J3vb/OwnCord
1
0
Fork 0
mirror of https://github.com/J3vb/OwnCord.git synced 2026-09-03 03:50:00 +03:00
Code Issues Packages Projects Releases Wiki Activity

test(client): compare auth-frame key sets order-independently

Browse Source 
Codex review on #1435: Object.keys preserves insertion order, so a harmless property reorder in ws.ts would fail the pin. Key order has no wire meaning; the Go fixtures already compare with sorted keys. Sort both sides.
This commit is contained in:
J3vb
2026-08-28 15:31:43 +02:00
parent 2cf628814a
commit 069412dbbf
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Client/tests/contract/ws-auth-frame.test.ts
+7 -7
View File
@@ -6,9 +6,9 @@
// extends this test's key sets. Extend this file, do not replace or delete // extends this test's key sets. Extend this file, do not replace or delete
// it. // it.
// //
// Assertions compare exact key sets (deep-equal on Object.keys), never // Assertions compare exact key sets (sorted Object.keys -- key order has no
// toHaveProperty, so an unexpected added key fails just as loudly as a // wire meaning), never toHaveProperty, so an unexpected added key fails just
// missing one. // as loudly as a missing one.
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest"; import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
@@ -74,9 +74,9 @@ describe("contract: auth frame key set (epoch 1)", () => {
// part of the auth-specific payload contract, but it IS part of what // part of the auth-specific payload contract, but it IS part of what
// actually goes over the wire, so the envelope pin has three keys, not // actually goes over the wire, so the envelope pin has three keys, not
// the two the auth message literal at ws.ts:446-453 has on its own. // the two the auth message literal at ws.ts:446-453 has on its own.
expect(Object.keys(frame)).toEqual(["type", "payload", "id"]); expect(Object.keys(frame).sort()).toEqual(["id", "payload", "type"]);
expect(frame.type).toBe("auth"); expect(frame.type).toBe("auth");
expect(Object.keys(frame.payload)).toEqual(["token", "last_seq"]); expect(Object.keys(frame.payload).sort()).toEqual(["last_seq", "token"]);
expect(frame.payload.token).toBe("t"); expect(frame.payload.token).toBe("t");
expect(frame.payload.last_seq).toBe(0); expect(frame.payload.last_seq).toBe(0);
}); });
@@ -107,7 +107,7 @@ describe("contract: auth frame key set (epoch 1)", () => {
emitTauriEvent("ws-state", "open"); emitTauriEvent("ws-state", "open");
const frame = getAuthFrame(); const frame = getAuthFrame();
expect(Object.keys(frame.payload)).toEqual(["token", "last_seq", "active_channel_id"]); expect(Object.keys(frame.payload).sort()).toEqual(["active_channel_id", "last_seq", "token"]);
expect(frame.payload.last_seq).toBe(7); expect(frame.payload.last_seq).toBe(7);
expect(frame.payload.active_channel_id).toBe(42); expect(frame.payload.active_channel_id).toBe(42);
}); });
@@ -137,7 +137,7 @@ describe("contract: auth frame key set (epoch 1)", () => {
emitTauriEvent("ws-state", "open"); emitTauriEvent("ws-state", "open");
const frame = getAuthFrame(); const frame = getAuthFrame();
expect(Object.keys(frame.payload)).toEqual(["token", "last_seq"]); expect(Object.keys(frame.payload).sort()).toEqual(["last_seq", "token"]);
expect(frame.payload.last_seq).toBe(3); expect(frame.payload.last_seq).toBe(3);
}); });
}); });