J3vb/OwnCord
1
0
Fork 0
mirror of https://github.com/J3vb/OwnCord.git synced 2026-09-03 03:50:00 +03:00
Code Issues Packages Projects Releases Wiki Activity

chore(lint): set complexity budgets to targets (intentionally red — backlog visible) (#1384)

Browse Source 
* chore(lint): add ratcheted complexity budgets

Enables funlen, cyclop, nestif and dupl. Each threshold sits just above today's
worst offender, so the tree is green now and the budgets only block regression
past the current extreme:

  funlen    320 lines / 135 statements  (worst: main.go run, 311/131)
  cyclop    60                          (worst: ws handleVoiceJoin, 59)
  nestif    18                          (worst: 17)
  dupl      250 tokens                  (green boundary; 150 flags 3 real pairs)

Measured over 1446 production functions with tests excluded. Verified tight
rather than slack: 320/135 is green and 310/130 is not.

The budgets apply to production code only. Table-driven tests are legitimately
long, and duplicated setup between cases is clearer than a helper that hides
what each case does.

These are a ratchet, not a standard. 94 functions exceed 60 lines and 22 exceed
120; none of them are touched. The settings block records what each budget is
waiting on, including the three duplicate pairs that must be collapsed before
dupl can drop to the conventional 150.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* chore(lint): set complexity budgets to targets, not to what passes

Replaces the ratchet (thresholds parked just above today's worst) with real
targets. Existing offenders are left failing rather than excluded: an exclusion
list goes stale and quietly becomes permanent, whereas a failing check is a
backlog you can see and work off.

  funlen    100 lines / 50 statements   (was 320/135)
  cyclop    20                          (was 60)
  nestif    8                           (was 18)
  dupl      150 tokens                  (was 250)

These are not the tool defaults (60/40, 10, 4). Those descend from 1976-era
cyclomatic-complexity work predating Go's explicit error handling, where every
`if err != nil` costs a branch and idiomatic code scores high for no real
complexity — which is why golangci-lint's other cyclomatic linter, gocyclo,
defaults to 30 rather than 10. The values above are chosen for a Go server.

Also disables three output limits that hide work. uniq-by-line is the sharp one:
it keeps one issue per line, and because cyclop and funlen both anchor at the
function declaration, enabling cyclop silently swallowed 16 of funlen's 21
findings. The visible backlog was 46; the real one is 62.

This leaves the lint gate RED by design. No other linter regressed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
J3vb
2026-08-16 17:30:12 +02:00
committed by GitHub
co-authored by Claude Opus 5
parent 36be31db43
commit 7f87be6306
1 changed files with 58 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Server/.golangci.yml
+58
View File
@@ -15,6 +15,16 @@ linters:
- staticcheck # advanced static analysis (correctness, performance, deprecation)
- modernize # flags outdated idioms (slices/maps/min/max, range-over-int, any, fmt.Appendf)
# Complexity budgets. These are a RATCHET, not a standard: each threshold sits
# just above today's worst offender, so the build is green now and the budget
# only blocks regression past the current extreme. Tighten them over time — each
# step is a one-line edit here plus the refactor it forces. Measured values and
# the work each budget is waiting on are in the settings block below.
- funlen # function length (lines and statements)
- cyclop # cyclomatic complexity per function
- nestif # deeply nested if-blocks
- dupl # verbatim duplicated blocks
settings:
staticcheck:
checks:
@@ -26,6 +36,38 @@ linters:
- performance
disabled-checks:
- hugeParam # too noisy for struct-heavy code
# Complexity budgets set to a TARGET, not to whatever passes today. Existing
# offenders are deliberately left failing rather than excluded: an exclusion
# list goes stale and quietly becomes permanent, whereas a failing check is a
# backlog you can see. Measured 2026-08-16 over 1446 production functions,
# tests excluded.
#
# These are not the tool defaults (60/40, 10, 4). The defaults descend from
# 1976-era cyclomatic-complexity work that predates Go's explicit error
# handling: every `if err != nil` costs a branch, so idiomatic Go scores high
# for no real complexity. That is why golangci-lint's other cyclomatic linter,
# gocyclo, defaults to 30 rather than 10. The values below are chosen for a Go
# server rather than copied from C-era literature.
funlen:
# funlen counts in its own units — it ignores blank lines and comments, so
# main.go run() is 311 here and 422 by raw line span. Worst today: 311 lines,
# 131 statements.
lines: 100
statements: 50
cyclop:
# Worst today: ws/voice_join.go handleVoiceJoin at 59, main.go run at 57,
# plugin/registry.go InstallFromZip at 44.
max-complexity: 20
nestif:
# Worst today: 17.
min-complexity: 8
dupl:
# The conventional value. Flags three real duplicate pairs, all adjacent
# near-identical siblings worth collapsing:
# db/mention_queries.go:322-357 vs :364-399
# ws/voice_controls.go:13-42 vs :45-73
# ws/voice_controls.go:76-121 vs :124-171
threshold: 150
gosec:
excludes:
- G104 # unhandled errors — errcheck covers this better
@@ -42,3 +84,19 @@ linters:
path: _test\.go
- linters: [errcheck]
path: _test\.go
# Complexity budgets apply to production code only. Table-driven tests are
# legitimately long, and duplicated setup between test cases is clearer than
# a shared helper that hides what each case is doing.
- linters: [funlen, cyclop, nestif, dupl]
path: _test\.go
# Report every finding. The defaults hide work three separate ways, which is fine
# when the list is meant to be empty and actively misleading when it is a backlog:
# "fixed everything shown" would leave more behind. uniq-by-line is the sharp one —
# it keeps a single issue per line, and since cyclop and funlen both anchor at the
# function declaration, enabling cyclop silently swallowed 16 of funlen's 21
# findings here.
issues:
max-issues-per-linter: 0
max-same-issues: 0
uniq-by-line: false