From d498e8fcce75ec39eee072f307d1b62f16be29d9 Mon Sep 17 00:00:00 2001
From: jevb <jevb@telenet.be>
Date: Sun, 22 Mar 2026 21:10:02 +0100
Subject: [PATCH] =?UTF-8?q?fix:=20resolve=20LiveKit=20voice=20issues=20?=
 =?UTF-8?q?=E2=80=94=20duplicate=20audio,=20tunnel=20effect=20with=205+=20?=
 =?UTF-8?q?users?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Detach existing audio elements before attaching to prevent double playback on reconnects
- Remove webAudioMix to eliminate Web Audio overhead compounding with multiple participants
- Use participant.setVolume() for full 0-200% per-user volume range
- Add pli_throttle and active_loopback_prevention to LiveKit server config
- Bump version to 1.3.0
---
 CLAUDE.md                                     |  2 +-
 Client/tauri-client/package.json              |  2 +-
 Client/tauri-client/src-tauri/Cargo.toml      |  2 +-
 Client/tauri-client/src-tauri/tauri.conf.json |  2 +-
 Client/tauri-client/src/lib/livekitSession.ts | 10 +++++-----
 Server/ws/livekit_process.go                  | 10 ++++++++++
 6 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/CLAUDE.md b/CLAUDE.md
index 2d084ceb..039bcc80 100644
--- a/CLAUDE.md
+++ b/CLAUDE.md
@@ -147,7 +147,7 @@ OwnCord/
 
 ```bash
 cd Server
-go build -o chatserver.exe -ldflags "-s -w -X main.version=1.0.0" .
+go build -o chatserver.exe -ldflags "-s -w -X main.version=1.3.0" .
 go test ./...                        # all tests
 go test ./... -cover                 # with coverage
 ```
diff --git a/Client/tauri-client/package.json b/Client/tauri-client/package.json
index 812dd9f8..ba98a7b3 100644
--- a/Client/tauri-client/package.json
+++ b/Client/tauri-client/package.json
@@ -1,7 +1,7 @@
 {
   "name": "owncord-client",
   "private": true,
-  "version": "1.2.0",
+  "version": "1.3.0",
   "type": "module",
   "scripts": {
     "dev": "vite",
diff --git a/Client/tauri-client/src-tauri/Cargo.toml b/Client/tauri-client/src-tauri/Cargo.toml
index bda73835..43ca4947 100644
--- a/Client/tauri-client/src-tauri/Cargo.toml
+++ b/Client/tauri-client/src-tauri/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "owncord-client"
-version = "1.2.0"
+version = "1.3.0"
 edition = "2021"
 description = "OwnCord Desktop Client"
 
diff --git a/Client/tauri-client/src-tauri/tauri.conf.json b/Client/tauri-client/src-tauri/tauri.conf.json
index 0f1962fa..95b3ec95 100644
--- a/Client/tauri-client/src-tauri/tauri.conf.json
+++ b/Client/tauri-client/src-tauri/tauri.conf.json
@@ -1,6 +1,6 @@
 {
   "productName": "OwnCord",
-  "version": "1.2.0",
+  "version": "1.3.0",
   "identifier": "com.owncord.client",
   "build": {
     "frontendDist": "../dist",
diff --git a/Client/tauri-client/src/lib/livekitSession.ts b/Client/tauri-client/src/lib/livekitSession.ts
index 13f8df7d..543eb030 100644
--- a/Client/tauri-client/src/lib/livekitSession.ts
+++ b/Client/tauri-client/src/lib/livekitSession.ts
@@ -88,7 +88,6 @@ export class LiveKitSession {
     const newRoom = new Room({
       adaptiveStream: true,
       dynacast: true,
-      webAudioMix: true,
       audioCaptureDefaults: {
         echoCancellation: loadPref("echoCancellation", true),
         noiseSuppression: loadPref("noiseSuppression", true),
@@ -111,13 +110,14 @@ export class LiveKitSession {
   ): void => {
     const userId = parseUserId(participant.identity);
     if (track.kind === Track.Kind.Audio) {
-      // Attach creates an <audio> element — required for playback
+      // Detach any previous <audio> elements to prevent duplicate playback
+      // on fast reconnects (new subscription fires before old unsubscription)
+      for (const el of track.detach()) el.remove();
       const audioEl = track.attach();
       audioEl.style.display = "none";
       document.body.appendChild(audioEl);
-      // Apply saved per-user volume scaled by master output volume
-      const savedVolume = userId > 0 ? getSavedUserVolume(userId) : 100;
-      audioEl.volume = Math.min(savedVolume, 100) / 100;
+      // Apply saved per-user volume via LiveKit's setVolume (supports 0-2.0 range)
+      participant.setVolume(this.getEffectiveVolume(userId));
       const savedOutput = loadPref<string>("audioOutputDevice", "");
       if (savedOutput !== "" && typeof audioEl.setSinkId === "function") {
         audioEl.setSinkId(savedOutput).catch((err) => {
diff --git a/Server/ws/livekit_process.go b/Server/ws/livekit_process.go
index 97f61ec9..d39957d5 100644
--- a/Server/ws/livekit_process.go
+++ b/Server/ws/livekit_process.go
@@ -58,14 +58,24 @@ func (p *LiveKitProcess) generateConfig() (string, error) {
 
 	content := fmt.Sprintf(`# Auto-generated by OwnCord — do not edit manually.
 port: 7880
+
 rtc:
   port_range_start: 50000
   port_range_end: 60000
   use_external_ip: true
+  pli_throttle:
+    low_quality: 500ms
+    mid_quality: 1s
+    high_quality: 1s
+
 keys:
   "%s": "%s"
+
 logging:
   level: info
+
+audio:
+  active_loopback_prevention: true
 `, p.cfg.LiveKitAPIKey, p.cfg.LiveKitAPISecret)
 
 	if err := os.MkdirAll(p.dataDir, 0o755); err != nil {