package ws_test // reconnect_db_test.go — buffer-miss → DB cold-tier replay integration test. // // The hub's ring buffer holds 1000 events. When a reconnecting client's // last_seq is older than the buffer's oldest entry, EventsSinceFiltered returns // nil and handleReconnect falls back to the EventStore. This file verifies that // code path end-to-end against a real httptest WebSocket server. import ( "context" "encoding/json" "fmt" "net/http/httptest" "strings" "testing" "time" "github.com/coder/websocket" "github.com/J3vb/OwnCord/Server/auth" "github.com/J3vb/OwnCord/Server/db" "github.com/J3vb/OwnCord/Server/ws" ) // openEventStoreDB opens an in-memory database with the full migration set so // the events table exists. *db.DB satisfies the hub's EventStore interface // (D3 removed the store abstraction and its MemStore fake). func openEventStoreDB(t *testing.T) *db.DB { t.Helper() database, err := db.Open(":memory:") if err != nil { t.Fatalf("db.Open: %v", err) } t.Cleanup(func() { _ = database.Close() }) if err := db.Migrate(database); err != nil { t.Fatalf("db.Migrate: %v", err) } return database } // TestReconnect_BufferMiss_FallsBackToDBTier verifies that when a client // reconnects with a last_seq that is older than the ring buffer's oldest entry, // the hub falls back to the EventStore (DB tier) and sends the missed events. // // Setup: // - Ring buffer size = 1000; push seqs 501..1500 → oldestSeq = 501. // - The DB event store contains 100 global events at seqs 501..600. // - Client reconnects with last_seq = 500. // - Buffer: 500 <= 501 → returns nil. // - DB: returns seqs > 500 with channelID = 0 (global, no permission filter). // // Asserts: // - auth_ok is received with replay_source = "db". // - hub.ReconnectTierStats() db counter = 1. func TestReconnect_BufferMiss_FallsBackToDBTier(t *testing.T) { database := openServeTestDB(t) limiter := auth.NewRateLimiter() // Create a user. role_id=1 intentionally does not exist in the test DB so // computeAllowedChannels returns an empty channel set — but events with // channelID=0 (global) bypass the per-channel filter in the DB event store // and in EventsSinceFiltered, so they are always returned. userID, err := database.CreateUser(context.Background(), "reconnect-db-user", "hash", 1) if err != nil { t.Fatalf("CreateUser: %v", err) } token, err := auth.GenerateToken() if err != nil { t.Fatalf("GenerateToken: %v", err) } if _, err := database.CreateSession(context.Background(), userID, auth.HashToken(token), "test", "127.0.0.1"); err != nil { t.Fatalf("CreateSession: %v", err) } // Pre-populate the event store with 100 global events (seqs 501..600). // channelID=0 means "global broadcast" — the DB event store's // GetEventsSinceForChannels returns them regardless of the allowed-channel // filter. eventStore := openEventStoreDB(t) bgCtx := context.Background() for seq := int64(501); seq <= 600; seq++ { payload := fmt.Appendf(nil, `{"seq":%d,"type":"broadcast"}`, seq) if err := eventStore.PersistEvent(bgCtx, seq, "broadcast", 0, payload); err != nil { t.Fatalf("PersistEvent seq=%d: %v", seq, err) } } // Build hub, attach the DB event store as the cold-tier read path. hub := ws.NewHub(database, limiter, nil) hub.SetEventStore(eventStore) go hub.Run() defer hub.Stop() // Fill the ring buffer with seqs 501..1500 (exactly 1000 entries). // After 1000 pushes into a 1000-slot buffer, oldestSeq = 501 (the first // entry pushed). A client with last_seq=500 satisfies 500 <= 501, so // EventsSinceFiltered returns nil and the DB tier is invoked. rb := hub.ReplayBuffer() dummyPayload := []byte(`{"type":"broadcast"}`) for seq := uint64(501); seq <= 1500; seq++ { rb.Push(seq, 0, dummyPayload) } if oldest := rb.OldestSeq(); oldest != 501 { t.Fatalf("pre-condition: expected oldestSeq=501, got %d", oldest) } // Spin up a real HTTP+WS server. handler := ws.ServeWS(hub, database, []string{"*"}, 0) srv := httptest.NewServer(handler) defer srv.Close() wsURL := "ws" + strings.TrimPrefix(srv.URL, "http") dialCtx, cancel := context.WithTimeout(bgCtx, 10*time.Second) defer cancel() // Dial and authenticate with last_seq=500 — this triggers the reconnect // path (handleReconnect) rather than the fresh-connect path. conn, dialResp, dialErr := websocket.Dial(dialCtx, wsURL, nil) if dialResp != nil && dialResp.Body != nil { _ = dialResp.Body.Close() } if dialErr != nil { t.Fatalf("websocket.Dial: %v", dialErr) } defer func() { _ = conn.Close(websocket.StatusNormalClosure, "") }() authMsg := map[string]any{ "type": "auth", "payload": map[string]any{ "token": token, "last_seq": uint64(500), }, } raw, _ := json.Marshal(authMsg) if err := conn.Write(dialCtx, websocket.MessageText, raw); err != nil { t.Fatalf("write auth: %v", err) } // The first message back must be auth_ok with replay_source="db". _, msg, err := conn.Read(dialCtx) if err != nil { t.Fatalf("read auth_ok: %v", err) } var resp map[string]any if err := json.Unmarshal(msg, &resp); err != nil { t.Fatalf("unmarshal response: %v; raw=%s", err, msg) } if resp["type"] != "auth_ok" { t.Fatalf("expected type=auth_ok, got %v; raw=%s", resp["type"], msg) } payloadField, _ := resp["payload"].(map[string]any) if payloadField["replay_source"] != "db" { t.Fatalf("expected replay_source=db, got %v", payloadField["replay_source"]) } // hub.reconnectTierDB is incremented before auth_ok is sent, so the // counter is stable by the time we read auth_ok. _, dbTier, _ := hub.ReconnectTierStats() if dbTier != 1 { t.Fatalf("expected db tier count=1, got %d", dbTier) } } // TestReconnect_ColdTierAtRowLimit_ForcesFullReady locks the truncation guard. // // GetEventsSinceForChannels is "ORDER BY seq ASC LIMIT n", so a gap larger than // the cap returns the OLDEST n rows and silently drops the newest. Replaying // that as a successful resume looks complete to the client — it tracks only // max(seq) and cannot detect the hole — so the dropped range is lost until some // later full resync. State events (channel/role/member changes) in that range // are never repaired by REST history fetches. // // Setup mirrors TestReconnect_BufferMiss_FallsBackToDBTier, but seeds 100 more // events than the cap so the query comes back exactly full. func TestReconnect_ColdTierAtRowLimit_ForcesFullReady(t *testing.T) { database := openServeTestDB(t) limiter := auth.NewRateLimiter() userID, err := database.CreateUser(context.Background(), "reconnect-overflow-user", "hash", 1) if err != nil { t.Fatalf("CreateUser: %v", err) } token, err := auth.GenerateToken() if err != nil { t.Fatalf("GenerateToken: %v", err) } if _, err := database.CreateSession(context.Background(), userID, auth.HashToken(token), "test", "127.0.0.1"); err != nil { t.Fatalf("CreateSession: %v", err) } // Seed seqs 501..(500+cap+100): the query caps at `cap` rows, so the newest // 100 are dropped — the exact overflow condition. eventStore := openEventStoreDB(t) bgCtx := context.Background() const overflow = 100 events := make([]db.PersistedEvent, 0, ws.MaxColdReplayForTest+overflow) for i := range ws.MaxColdReplayForTest + overflow { seq := int64(501 + i) events = append(events, db.PersistedEvent{ Seq: seq, EventType: "broadcast", ChannelID: 0, Payload: fmt.Appendf(nil, `{"seq":%d,"type":"broadcast"}`, seq), }) } if n, err := eventStore.PersistEvents(bgCtx, events); err != nil || n != len(events) { t.Fatalf("PersistEvents: persisted %d/%d, err=%v", n, len(events), err) } hub := ws.NewHub(database, limiter, nil) hub.SetEventStore(eventStore) go hub.Run() defer hub.Stop() // Ring buffer holds 501..1500, so last_seq=500 misses it and the cold tier // is consulted. rb := hub.ReplayBuffer() dummyPayload := []byte(`{"type":"broadcast"}`) for seq := uint64(501); seq <= 1500; seq++ { rb.Push(seq, 0, dummyPayload) } if oldest := rb.OldestSeq(); oldest != 501 { t.Fatalf("pre-condition: expected oldestSeq=501, got %d", oldest) } handler := ws.ServeWS(hub, database, []string{"*"}, 0) srv := httptest.NewServer(handler) defer srv.Close() wsURL := "ws" + strings.TrimPrefix(srv.URL, "http") dialCtx, cancel := context.WithTimeout(bgCtx, 30*time.Second) defer cancel() conn, dialResp, dialErr := websocket.Dial(dialCtx, wsURL, nil) if dialResp != nil && dialResp.Body != nil { _ = dialResp.Body.Close() } if dialErr != nil { t.Fatalf("websocket.Dial: %v", dialErr) } defer func() { _ = conn.Close(websocket.StatusNormalClosure, "") }() authMsg := map[string]any{ "type": "auth", "payload": map[string]any{ "token": token, "last_seq": uint64(500), }, } raw, _ := json.Marshal(authMsg) if err := conn.Write(dialCtx, websocket.MessageText, raw); err != nil { t.Fatalf("write auth: %v", err) } // Reading the first frame guarantees the handshake picked a tier. if _, _, err := conn.Read(dialCtx); err != nil { t.Fatalf("read handshake response: %v", err) } _, dbTier, fullTier := hub.ReconnectTierStats() if dbTier != 0 { t.Errorf("db tier count = %d, want 0: a truncated cold-tier replay was delivered as a complete resume", dbTier) } if fullTier != 1 { t.Errorf("full tier count = %d, want 1: an over-cap gap must force a full ready re-sync", fullTier) } } // TestReconnect_ColdTierMergesRingBufferTail locks the flush-lag hole: the // EventPersister flushes asynchronously (~100ms batches), so cold rows can lag // the live seq. Events broadcast after the last flush sit only in the ring // buffer — a cold replay built from persisted rows alone presents an // incomplete resume as complete (the client tracks only max(seq) and cannot // detect the hole), which the maxColdReplay cap in the same function exists // to prevent. // // Setup: cold rows 501..700; ring buffer holds 601..710 (so the buffer cannot // serve last_seq=500 itself, but can serve everything past the newest // persisted row). The replay must deliver 501..710 — the 200 cold rows plus // the 10-event buffer tail. func TestReconnect_ColdTierMergesRingBufferTail(t *testing.T) { database := openServeTestDB(t) limiter := auth.NewRateLimiter() userID, err := database.CreateUser(context.Background(), "reconnect-tail-user", "hash", 1) if err != nil { t.Fatalf("CreateUser: %v", err) } token, err := auth.GenerateToken() if err != nil { t.Fatalf("GenerateToken: %v", err) } if _, err := database.CreateSession(context.Background(), userID, auth.HashToken(token), "test", "127.0.0.1"); err != nil { t.Fatalf("CreateSession: %v", err) } eventStore := openEventStoreDB(t) bgCtx := context.Background() for seq := int64(501); seq <= 700; seq++ { payload := fmt.Appendf(nil, `{"seq":%d,"type":"broadcast"}`, seq) if err := eventStore.PersistEvent(bgCtx, seq, "broadcast", 0, payload); err != nil { t.Fatalf("PersistEvent seq=%d: %v", seq, err) } } hub := ws.NewHub(database, limiter, nil) hub.SetEventStore(eventStore) go hub.Run() defer hub.Stop() rb := hub.ReplayBuffer() for seq := uint64(601); seq <= 710; seq++ { rb.Push(seq, 0, fmt.Appendf(nil, `{"seq":%d,"type":"broadcast"}`, seq)) } handler := ws.ServeWS(hub, database, []string{"*"}, 0) srv := httptest.NewServer(handler) defer srv.Close() wsURL := "ws" + strings.TrimPrefix(srv.URL, "http") dialCtx, cancel := context.WithTimeout(bgCtx, 15*time.Second) defer cancel() conn, dialResp, dialErr := websocket.Dial(dialCtx, wsURL, nil) if dialResp != nil && dialResp.Body != nil { _ = dialResp.Body.Close() } if dialErr != nil { t.Fatalf("websocket.Dial: %v", dialErr) } defer func() { _ = conn.Close(websocket.StatusNormalClosure, "") }() authMsg := map[string]any{ "type": "auth", "payload": map[string]any{"token": token, "last_seq": uint64(500)}, } raw, _ := json.Marshal(authMsg) if err := conn.Write(dialCtx, websocket.MessageText, raw); err != nil { t.Fatalf("write auth: %v", err) } _, msg, err := conn.Read(dialCtx) if err != nil { t.Fatalf("read auth_ok: %v", err) } var resp map[string]any _ = json.Unmarshal(msg, &resp) if resp["type"] != "auth_ok" { t.Fatalf("expected auth_ok, got %s", msg) } // Count replayed frames; the highest seq seen must reach the buffer tail. var replayed int var maxSeq float64 for { readCtx, readCancel := context.WithTimeout(dialCtx, 500*time.Millisecond) _, evt, readErr := conn.Read(readCtx) readCancel() if readErr != nil { break } var frame map[string]any if json.Unmarshal(evt, &frame) == nil && frame["type"] == "broadcast" { replayed++ if s, ok := frame["seq"].(float64); ok && s > maxSeq { maxSeq = s } } } if replayed != 210 { t.Errorf("replayed %d events, want 210 (200 cold rows + 10 ring-buffer tail)", replayed) } if maxSeq != 710 { t.Errorf("max replayed seq = %.0f, want 710 — events after the last persister flush were silently dropped", maxSeq) } }