Files
J3vbandClaude Opus 5 2a37f386f9 B1-3: repository hygiene gates (RL-19 / L-13, S-05) (#1414)
* chore(format): one Prettier config at the repository root

Every formatting rule in this repository lived under Client/ and covered
exactly two globs: Client/src/**/*.ts and Client/tests/**/*.ts. Root Markdown,
all of docs/, every YAML and JSON, all CSS, the root scripts and
tools/mcp-introspect were formatted by nothing. There was no .editorconfig.

The obvious fix -- a second Prettier config at the root for "everything else"
-- gives two configs and two ignore files that can silently disagree about the
same file. So the root takes ownership instead: config, ignore file and gate
move up, and Client/ folds in. Client's inline "prettier" block, its
.prettierignore, its format/format:check scripts and its now-unused prettier
devDependency are all deleted; knip would have failed client-check on that last
one.

The .prettierrc.json values are lifted byte-for-byte from Client/package.json,
which is what keeps the reformat commit free of client TypeScript churn: 87
tracked files need reformatting and not one of them is under Client/src or
Client/tests.

.prettierignore carries only what .gitignore does not. Prettier 3 reads the
root .gitignore by default, so node_modules/, dist/, coverage/,
Client/src/generated/ and docs/security-findings/ need no entry. It does NOT
read nested .gitignore files, which is why .remember/ is listed explicitly --
38 untracked per-machine scratch files were otherwise able to turn a shared
gate red. graphify-out/ is listed because its seven files are tracked and
.graphify_labels.json is signed byte-for-byte by its .sig, so formatting it
would silently invalidate the signature.

check:hygiene is registered in scripts/run.mjs and folded into check and
release:preflight. It deliberately contains no `gofmt -l` step: gofmt -l prints
offenders and still exits 0, so it cannot fail a build. Go formatting is
enforced separately.

shellcheck and actionlint take their file lists from `git ls-files`, never a
filesystem glob -- .claude/worktrees/ holds a gitignored pre-flatten copy of
the tree with three .sh files a glob would happily lint.

This commit leaves the tree non-conformant on purpose. The reformat is the next
commit, so the 87-file diff is reviewable separately from the rule that caused
it.

Not included: editorconfig-checker. .editorconfig is the editor baseline the
audit asked for; Prettier, gofmt and rustfmt already fail CI on the same
indentation and newline rules, so a fourth tool checking them again is a gate
with no failure mode of its own.

Verified: `npx prettier --check .` names 87 tracked files and zero untracked
ones; the same command listed 38 .remember/ scratch files before the ignore
entry and none after. `node scripts/run.mjs --list` resolves check:hygiene to 8
shell targets and 4 workflow targets. Both package.json files parse.

Refs RL-19 / L-13, S-05.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* chore(format): reformat the tree to the repository Prettier rules

Mechanical. This commit is `npx prettier --write .` and nothing else -- the
rule that caused it landed in the previous commit so this diff can be reviewed
as a transformation rather than as 84 files of hunks.

84 tracked files: 54 Markdown, 7 .mjs, 7 JSON, 6 YAML, 4 .js, 3 CSS, 2
TypeScript (the two Playwright configs at Client's root, which the old
Client/src + Client/tests globs never covered). No file under Client/src or
Client/tests moves, because .prettierrc.json carries Client's former inline
values byte-for-byte.

Prettier rewrote 87 files, not 84. The three in .github/ISSUE_TEMPLATE/ had
CRLF on disk and differ only in line endings, which .gitattributes
(`* text=auto eol=lf`) already normalises, so their committed blobs are
unchanged. Worth knowing before someone reconciles the two numbers.

The largest single diff is .superpowers/findings-ledger.json at 7976 lines
rewritten. That is safe to format: nothing writes the ledger programmatically
-- render-ledger.mjs reads it and writes only FINDINGS.md -- so no tool will
fight Prettier over its style on the next hunt. FINDINGS.md itself is ignored
as generated.

Verified: `npx prettier --check .` reports "All matched files use Prettier code
style", so the pass is both complete and idempotent. All 7 reformatted JSON
files were parsed before and after and compared as values: semantically
identical, zero content changes. `node .superpowers/render-ledger.mjs --check`
still reports 348 valid findings and leaves FINDINGS.md untouched.
`node scripts/check-doc-counts.mjs` still passes its selftest and still agrees
on 27 claims across 9 watched documents -- table realignment did not break the
patterns it matches on. `node scripts/run.mjs --list` still parses.

Refs RL-19 / L-13, S-05.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* chore(lint): enforce Go formatting in the Server linter

S-05: repository-wide Go formatting was not a required gate. The only gofmt
enforcement anywhere was .githooks/pre-commit, which is opt-in per clone
(`npm run hooks:install`), only sees staged files, and warns-and-skips when
gofmt is off PATH.

The obvious fix -- a `gofmt -l` step in CI -- does not work: `gofmt -l` prints
its offenders and still exits 0, so the step passes no matter what it finds.
scripts/run.mjs has the same problem, which is why check:hygiene has no Go step
either.

So gofmt goes where it can actually fail something: Server/.golangci.yml. The
file was already `version: "2"` but had no `formatters:` block at all, so the
19 enabled linters ran with zero formatters. In v2 gofmt/gofumpt/goimports
moved out of `linters.enable` into their own section with its own exclusions.
Adding it there means the gate reports through the Lint step of "Server Build &
Test", which is already pinned as required on dev -- no new job and no new pin.
Every tracked .go file is under Server/ (551 of them, one go.mod), so
Server-scoped is repository-wide here.

One file was genuinely misformatted: a one-space struct field alignment in
Server/admin/handlers_users_broadcast_test.go, fixed in the same commit because
a single line does not need its own reformat commit.

Trap worth recording: `gofmt -l .` on a Windows working tree lists every file
that has CRLF on disk, because gofmt normalises line endings. That reported 18
offenders here, 17 of them ghosts. The blobs are all LF -- .gitattributes
forces `eol=lf` -- so CI never saw them, and the honest test is to run gofmt
over `git show HEAD:<file>` rather than the working copy. Doing that across all
551 tracked Go files found exactly the one real offender above.

Verified both directions with golangci-lint v2 locally: `golangci-lint run
./...` reports 0 issues on the formatted tree; appending a misformatted
function to Server/auth/constants.go produces 2 gofmt findings; appending the
same misformatted function to Server/db/dbgen/admin.sql.go produces 0, so the
exclusion holds. Both files restored and verified clean afterwards.

Refs RL-19 / L-13, S-05.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(scripts): escape the NUL separator instead of embedding one

The `tracked()` helper added earlier in this branch splits `git ls-files -z`
output on NUL. The separator was written as a literal NUL byte rather than the
two-character JavaScript escape, so scripts/run.mjs became a binary file: `git
diff` refused to show it, `grep` reported "Binary file matches" instead of the
line, and `* text=auto` in .gitattributes stops normalising line endings for a
blob it detects as binary.

The code worked -- splitting on a raw NUL and splitting on "\0" are the same
operation -- which is exactly why this is worth fixing before it is inherited.
A source file that tooling classifies as binary is a file nobody can review.

Verified: zero NUL bytes remain, `grep -n "split("` now prints line 50 instead
of "Binary file matches", `node scripts/run.mjs --list` still resolves the same
8 shell and 4 workflow targets, and prettier still reports the file clean.

* chore(lint): enforce Rust formatting

Rust had no formatting gate of any kind: no rustfmt.toml, no `cargo fmt`
anywhere in CI, in scripts/run.mjs, in the Makefile or in the git hooks. Clippy
was the only Rust gate, and clippy does not check layout.

`cargo fmt --all -- --check` now runs in the rust-tests job, ahead of clippy: a
formatting failure is cheap to produce and cheap to fix, and there is no reason
to spend a clippy pass to surface one. The stable toolchain in that job
requested `components: clippy` only, so rustfmt is added there.

Only that job. ci.yml has a second, byte-identical `Install Rust` block in
tauri-build; it stays clippy-only, because a full desktop build is the wrong
place to discover a misplaced brace.

No rustfmt.toml. The default profile is the point of a baseline -- a config
file here would be a second opinion about style with nothing to say.
Client/src-tauri is a single `[package]`, not a workspace, so `--all` is a
safeguard against a future member rather than a fan-out today.

Verified: `node scripts/run.mjs --list` resolves check:rust to three steps with
`cargo fmt --all -- --check` first, `npm run format` now also runs `cargo fmt
--all`, and prettier reports ci.yml, run.mjs and the ci-check skill clean.
`cargo fmt --all -- --check` currently fails on 13 files -- that is the
reformat, and it is the next commit.

Refs RL-19 / L-13.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* chore(format): reformat the Rust crate to rustfmt defaults

Mechanical. This commit is `cargo fmt --all` and nothing else; the gate that
demands it landed in the previous commit so this diff is reviewable on its own.

13 of the 17 tracked .rs files, +343/-164. The crate had never been formatted,
so the changes are the usual first-run set: aligned trailing comments collapsed
to single spaces, single-element slice literals folded onto one line, long
method chains broken across lines, closure bodies expanded into blocks.

Verified: `cargo fmt --all -- --check` is clean, so the pass is complete and
idempotent. `cargo clippy --all-targets -- -D warnings` finishes with no
warnings, and `cargo test --lib` reports 115 passed / 0 failed -- identical to
before the reformat, which is what "mechanical" has to mean for a commit that
touches this much of the crate.

Refs RL-19 / L-13.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(scripts): make the root facade actually run on Windows

Adding the first gate that a contributor would run from the repository root
exposed two bugs in the facade, both of which made it silently wrong on the
platform this project is developed on.

1. Every npm and npx step failed. bin() appends `.cmd` on Windows, but Node
   refuses to spawn a .cmd or .bat with shell:false -- the CVE-2024-27980
   mitigation -- and fails with EINVAL and a *null* exit status. run.mjs only
   special-cased ENOENT, so the result was `FAILED: npx prettier --check .
   exited null` with nothing to explain it. check:client has three npm steps and
   has never been able to run here.

   Fixed by spawning only the npm shims through a shell. They are concatenated
   into a single command string rather than passed as an args array, because
   shell:true plus a separate array is deprecated (DEP0190) and prints a warning
   on every invocation; no argument in this file contains a space.

2. Every optional() step was skipped, always. onPath() shelled out to
   `where` on Windows, but where.exe lives in C:\WINDOWS\System32, which a Git
   Bash PATH does not necessarily contain -- on this machine PATH carries
   System32\Wbem, System32\WindowsPowerShell\v1.0 and System32\OpenSSH but not
   System32 itself. The probe could not start, `probe.status === 0` was false,
   and golangci-lint and sqlc reported as "not installed" while installed.

   Fixed by resolving against PATH and PATHEXT directly. No subprocess, and no
   dependency on which directories happen to be on PATH.

A spawn error other than ENOENT now reports its code instead of surfacing as a
null exit status.

Verified: before, `node scripts/run.mjs check:hygiene` died with "exited null"
and both optional steps printed SKIP with the tools present on PATH. After, the
same command runs prettier, shellcheck and actionlint and prints
"check:hygiene: passed", with no deprecation warning. `golangci-lint` is
detected by the new onPath where the old one missed it.

Refs RL-20 / L-14.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* chore(format): ignore build output that nested gitignores hide

Prettier honours the root .gitignore and no other. Every build and scratch
directory in this repository is ignored by a *nested* one -- Client/.gitignore,
.serena/.gitignore, .superpowers/sdd/.gitignore -- so none of them were
excluded from the new repository-wide gate.

The effect is not subtle. Running `cargo test` once drops roughly 850
formattable files into Client/src-tauri/target/, and the hygiene gate goes from
clean to "Code style issues found in 939 files". CI never sees it, because a
fresh checkout has no build output; every contributor sees it on their second
command.

Mirrors the three nested files rather than inventing a list: dist, coverage,
playwright-report, test-results, .vite, src-tauri/target and src-tauri/gen from
Client/.gitignore, plus .serena/ and .superpowers/sdd/. node_modules needs no
entry -- Prettier ignores it by default.

Verified: `npx prettier --check .` reports "All matched files use Prettier code
style" with a fully populated Client/src-tauri/target/ present on disk, and
still names README.md when a misformatted table is appended to it.

Refs RL-19 / L-13.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* chore(ci): shellcheck, actionlint, and a repository hygiene job

The last two gates RL-19 asks for. Neither existed: the shell scripts were
never linted, the workflows were never syntax-checked, and .githooks/pre-commit
carried hand-written `# shellcheck disable=` directives that nothing had ever
read.

New `hygiene` job, ubuntu-only and root-scoped, modelled on docs-consistency
for the same reason: every gate in it is platform-independent text analysis,
and .gitattributes pins eol=lf so a second OS would only re-prove line endings.
It runs `npm run check:hygiene` -- the same entry point a contributor runs, not
a parallel copy of the commands.

shellcheck ships in the runner image. actionlint does not, so it is pinned by
version and verified by sha256: an installer script piped from a branch would
be the one unverified download in a workflow file that pins every action by
commit SHA.

Prettier's step moves here from client-check, where it no longer belongs.

Both linters found real defects.

shellcheck, 3 findings in 8 scripts. Two are SC1125 errors in
.githooks/pre-commit: `# shellcheck disable=SC2086 - repo paths contain no
spaces` is not a valid directive. Trailing prose makes shellcheck discard the
rest of the line, so neither suppression was ever in effect -- and one of the
two was written earlier in this same branch, which is a fair demonstration of
why the gate is worth having. The prose moves to its own line above. The third
is SC2015 in start-server.sh, rewritten as an explicit if.

actionlint, 5 findings, all inside `run:` blocks it shellchecks once shellcheck
is on PATH. Three SC2015 in load-baseline.yml, rewritten as explicit ifs. Two
SC2035 in release.yml, where `sha256sum *` should not become `sha256sum ./*`:
the comment four lines above records that ParseChecksumFile exact-matches the
last field, so a "./" prefix would strand every deployed server exactly as a
"windows/" prefix would. `sha256sum -- *` satisfies the linter and leaves the
output bytes identical.

Verified all three gates in both directions with shellcheck 0.10.0 and
actionlint 1.7.7 on PATH. Passing: `node scripts/run.mjs check:hygiene` prints
"check:hygiene: passed" with all three steps run, not skipped. Failing:
appending `bait_fn() { cat $1; }` to Server/scripts/voice-test.sh fails on
SC2086; changing a runs-on to `ubunt-latest` fails on runner-label; appending a
misformatted table to README.md fails prettier. All three files restored and
confirmed clean afterwards. actionlint validates the new job in ci.yml itself.

Refs RL-19 / L-13, S-05.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* docs(plans): record B1 progress through B1-3

The header still read "B1-0 is complete; B1-1 is the next step" three merged
phases later. A plan that misstates where it is costs a reader the same
confusion whether it is stale by one phase or three.

B1-0 (#1410), B1-1 (#1411), B1-2 (#1412) and B1-3 (this branch) are done; B1-4,
dependency automation, is next.

Verified: `node scripts/check-doc-counts.mjs` still agrees on 27 claims across
9 watched documents -- this file is one of them -- and prettier reports it
clean.

* chore(ci): pin Repository Hygiene as a required check on dev

The second half of S-05. Its acceptance criterion is "tree is formatted AND a
fast required gate fails future drift" -- a check that runs but is not pinned
lets a formatting regression merge, so the gate is not a gate until this lands.

The name was read off PR #1414 with `gh pr checks` after the job reported
`pass` in 26s, not copied out of ci.yml. That order matters: the B0 script
records that three pinned names exist in no workflow file at all, and that a
required check which never reports blocks every PR forever.

Extends the existing script rather than adding a second one, per the B1 plan.

Also records, in the "deliberately NOT pinned" list, that Docs & Ledger
Consistency reports and passes on a dev PR yet is unpinned. That reads as an
oversight from the 2026-08-25 pass rather than a decision, but it belongs to
G-04, so it is documented here and not changed.

NOT APPLIED YET. Running this script now would pin a check that PR #1413 cannot
report -- its branch predates the hygiene job, so the job does not exist in its
workflow file and the check would never arrive. Run it after #1414 merges;
#1413 needs a rebase onto dev regardless.

Verified: shellcheck clean, the embedded JSON parses, and `check:hygiene`
passes with prettier, shellcheck and actionlint all running.

Refs S-05, RL-14 / G-03.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-26 18:00:26 +00:00

17 KiB
Raw Permalink Blame History

Plan: Slash command dispatcher in WS

Status: design only, not implemented

Staleness notes (2026-08-04): this design predates several changes and needs a refresh before implementation: migration number 016 is now taken (016_announcement_channel_type.sql — the plan's 016_plugin_commands.sql must be renumbered, as must its checklist); Server/store/ no longer exists (deleted in D3 — the sqlite_plugin_commands.go file below would live in Server/db/ now); src/state/ does not exist in the client (state modules live in src/stores/). One slice of this plan did land separately: the manifest commands name-only ACL (see the inline note in §"Manifest"). Owner: TBD Tracks: deferred feature backlog (post-beta; see CHANGELOG "Deferred work") Estimated effort: 12 weeks of focused work

Why

Discord's command system is the primary surface every bot/app uses. OwnCord already ships:

  • A plugin runtime (Server/plugin/) with a commands capability,
  • plugin.Registry.RegisterCommand and plugin.Registry.DispatchCommand (Server/plugin/host_commands.go),
  • A V2 WS dispatcher (Server/ws/handlers_chat.go, Server/ws/command.go) that already routes typed Command structs to pure handlers,
  • A chat_send payload that flows through MessageService.SendMessage.

…but chat_send content beginning with / is currently treated as a literal message. There is no dispatcher that recognises /help, no autocomplete, no per-command argument schema, and the Registry.DispatchCommand plumbing is dead code.

This plan wires the existing pieces together and adds the surface that clients need to render slash commands the way Discord does.

Non-goals

  • Not an OAuth2/app directory (Tier 2 work — separate plan).
  • Not a hosted "verified bot" registry — local plugins only.
  • Not modal interactions or buttons/select menus (component v2). These are a follow-up; the v1 surface is text reply + ephemeral reply.
  • Not a re-implementation of MessageService — slash commands take a separate path so they don't pollute the message table.

Surface design

Wire format

Two new client→server messages:

// 1. Command invocation (from /chat input or autocomplete pick)
{
  "type": "command_invoke",
  "req_id": "c-42",
  "payload": {
    "channel_id": 17,
    "name": "kick",
    "args": [
      {"name": "user",   "value": "12345"},
      {"name": "reason", "value": "spam"}
    ]
  }
}

// 2. Autocomplete query (sent on every keystroke after `/`)
{
  "type": "command_autocomplete",
  "req_id": "c-43",
  "payload": {
    "channel_id": 17,
    "name": "kick",
    "focused": "user",
    "partial": "ali",
    "args": [{"name": "user", "value": "ali"}]
  }
}

Two new server→client messages:

// Successful invocation reply (ephemeral by default).
{
  "type": "command_reply",
  "req_id": "c-42",
  "payload": {
    "ephemeral": true,
    "content":   "Kicked alice for: spam.",
    "embeds":    [],
    "broadcast": null
  }
}

// Autocomplete suggestions.
{
  "type": "command_autocomplete_result",
  "req_id": "c-43",
  "payload": {
    "choices": [
      {"label": "alice (id 12345)", "value": "12345"},
      {"label": "alistair (id 67)", "value": "67"}
    ]
  }
}

The ephemeral reply is delivered only to the invoking client (it never hits MessageSentChannelEvent). The optional broadcast field, when non-null, becomes a real chat_message posted by a synthetic Bot:<plugin-name> identity so the channel timeline records it.

Manifest changes

Plugin manifests gain a commands block. The manifest is the source of truth for the per-command schema; the runtime never trusts what the plugin says at dispatch time. Example:

Partially landed 2026-07-20 (audit-2026-04-07 CRITICAL #3): the name-only slice of this block exists today — plugin.json accepts "commands": [{"name": "kick"}] and Registry.RegisterCommand refuses any command the manifest did not declare, so list_commands can no longer bind names behind the admin's back. description / options / default_member_permissions below are still design-only; unknown keys parse and are ignored, so manifests written against the full schema already load.

{
  "name": "moderation-tools",
  "version": "0.2.0",
  "entrypoint": "mod.wasm",
  "permissions": ["commands", "events"],
  "commands": [
    {
      "name": "kick",
      "description": "Remove a user from the server.",
      "default_member_permissions": ["kick_members"],
      "options": [
        {
          "name": "user",
          "type": "user",
          "description": "Who to kick.",
          "required": true,
          "autocomplete": true
        },
        {
          "name": "reason",
          "type": "string",
          "description": "Optional reason recorded in audit log.",
          "max_length": 256
        }
      ]
    }
  ]
}

Manifest.Validate (Server/plugin/manifest.go) gets a new validateCommands() step:

  • name: same regex as plugin names (^[a-z][a-z0-9_-]{0,31}$), forced lowercase, no spaces, no slashes, max 32 chars.
  • description: 1100 chars, no NUL/control bytes.
  • options: max 25, each name unique, recurses on nested groups.
  • option.type: closed enum (string, int, bool, user, channel, role, mention, attachment, subcommand, subcommand_group).
  • default_member_permissions: closed enum matched against permissions.Permission constants (so a typo fails at install, not at dispatch).

Same defense profile as the existing manifest validation: the closed-set checks live in manifest.go next to validCapabilities.

Schema additions

A new table to support server-installed plugin commands without duplicating the manifest — needed so the WS hub can answer command_autocomplete requests without doing a JSON walk on every keystroke:

-- migrations/016_plugin_commands.sql
CREATE TABLE plugin_commands (
    plugin_id    INTEGER NOT NULL REFERENCES plugins(id) ON DELETE CASCADE,
    name         TEXT    NOT NULL,
    schema_json  TEXT    NOT NULL,         -- the validated `commands[i]` blob
    permissions  INTEGER NOT NULL DEFAULT 0, -- packed permission bits
    PRIMARY KEY (plugin_id, name)
);
CREATE UNIQUE INDEX plugin_commands_name_uq ON plugin_commands(name);

The unique index on name enforces that two enabled plugins can't both own /ban — install of the second one fails. This is intentional: command namespace collisions are confusing for users.

Code surface

File Change
Server/ws/message_types.go Add MsgTypeCommandInvoke, MsgTypeCommandAutocomplete, MsgTypeCommandReply, MsgTypeCommandAutocompleteResult.
Server/ws/command.go Add CommandInvokeCmd, CommandAutocompleteCmd structs and constructors. Validate name regex + arg count cap (25) at parse time so the dispatcher trusts its input.
Server/ws/handlers_command.go New file. handleCommandInvokeV2, handleCommandAutocompleteV2. Pure handlers — return a Result like the existing chat handlers.
Server/ws/handlers.go Register the new handlers via r.RegisterV2(MsgTypeCommandInvoke, handleCommandInvokeV2, deps).
Server/ws/deps.go Add a CommandDeps carrying *plugin.Registry, service.PermissionService, and service.MessageService.
Server/plugin/host_commands.go Extend DispatchCommand to take a typed arg map (map[string]any) instead of []string. Add Autocomplete(ctx, name, focused, partial).
Server/plugin/manifest.go Add Commands []CommandSpec to Manifest, validateCommands(), and a Manifest.Command(name) lookup.
Server/store/sqlite_plugin_commands.go New file. CRUD over the plugin_commands table.
Server/migrations/016_plugin_commands.sql New migration.
Client/src/state/commands.ts New module. Caches per-server command list (fetched at auth_ok time via a new commands_list REST endpoint), feeds the autocomplete UI.
Client/src/components/Composer/SlashCommandPopup.tsx New component — autocomplete dropdown that opens when the message buffer starts with /.
docs/protocol.md Document the four new wire messages.

Permission model

default_member_permissions is enforced server-side in handleCommandInvokeV2 before the plugin is invoked, by calling PermissionService.HasChannelPerm for each declared permission. Plugins do not get to decide who can use their commands; the manifest declares, the host enforces.

Slash commands inherit the existing channel ACL: command_invoke for a channel the user can't view_channel in returns ErrCodeForbidden with no plugin invocation, no telemetry leak.

Built-in commands

Two slash commands ship in-tree (no plugin required), to validate the dispatcher and to give bare-metal deployments something useful:

Command Implementation Why in-tree
/me <text> Built-in handler in handlers_command.go Discord parity, IRC tradition.
/shrug Built-in handler Same. Trivial.

A future PR can add /poll, /remind, /nick etc. — all should follow the same handler shape so a plugin author can read the source as the canonical example.

Concurrency & lifecycle

  • Plugin command registration happens at Registry.activateAll time (already exists for the wazero build) and at installFromDisk for the default build.
  • plugin_commands rows are written inside the same transaction as plugins so a half-installed plugin can never have orphan rows.
  • DispatchCommand runs the plugin handler off the WS goroutine with a 3 s context deadline (configurable via config.yaml > plugins.command_deadline_ms). A slow command must not block chat_send for the same client.
  • The 3 s budget is enforced by passing context.WithTimeout into Registry.DispatchCommand; the wazero runtime already accepts a ctx on every host call.

Failure modes & UX

Failure Server response Client UX
No such command command_reply ephemeral: Unknown command: /foo Red banner under composer.
Plugin runtime not built (default build) Existing fallback in DispatchCommand returns the helpful error message Same banner, no crash.
Plugin handler timeout (>3s) command_reply ephemeral: /foo timed out + audit log entry Banner + telemetry tag.
Plugin handler panics Recovered in the runtime, ephemeral error, plugin auto-disabled after 3 panics in 60s Banner + plugin marked unhealthy in admin panel.
Permission denied command_invoke returns ErrCodeForbidden before invocation Banner: "You lack permission".
Argument validation fails command_invoke returns ErrCodeBadPayload with the field name Composer highlights the bad option.

Testing strategy

Unit:

  • manifest_test.go — extend with command validation (name regex, option type enum, max 25 options, max 100 char description).
  • host_commands_test.goDispatchCommand with a stub Instance, arg-map round trip, auto-disable after panics.
  • handlers_command_test.go — pure handler test using the existing V2 test pattern (stubMessageSvc, stubPermSvc).

Integration:

  • Add a new in-tree test plugin under Server/plugin/examples/echo (no wasm needed — installable via the default build) that registers /echo and is loaded inside ws_integration_test.go.

Contract:

  • docs/protocol.md round trip — JSON examples kept in sync with the parser via golden tests.

Telemetry

Three new counters under commands_*:

  • commands_invoked_total{name,plugin,result}
  • commands_autocomplete_total{name,plugin}
  • commands_duration_ms_bucket{name,plugin} (histogram)

Existing OTel skeleton (Server/telemetry/) gets a new tracer.Start(ctx, "command.invoke") span around DispatchCommand.

Rollout

  1. Land schema migration + manifest validation behind the existing default build. New plugins can declare commands but the WS dispatcher still treats / as plain text.
  2. Land WS dispatcher + /me / /shrug built-ins. Slash commands work for in-tree handlers, plugin commands still no-op.
  3. Land the autocomplete RPC + client UI. Composer learns to open the popup on /.
  4. Land Registry.DispatchCommand wiring so plugin commands route through. Gate behind -tags wazero for the actual invocation; the default build returns the existing helpful "runtime not built" message.

Each step is independently shippable.

Open questions

  1. Bot identity for broadcast replies. When a slash command produces a broadcast, who is the author? Options: (a) a virtual Bot:<name> user with a synthetic ID in a reserved namespace, (b) the invoking user (Discord style: "Used /poll"). I'm leaning (b) for simplicity — it avoids new identity rows — but it loses the visual distinction. TBD in review.
  2. Component v2 (buttons / selects). Out of scope for v1 but the wire-format reservations should leave room for a components array on command_reply. Worth adding the field as []any now even though nothing renders it, so v2 isn't a breaking change.
  3. Cross-plugin command imports. Discord allows one app to use another's commands. We don't, and shouldn't until there's a real reason — the namespace flatness is a feature for a self-hosted product.
  4. DM-context commands. Some commands make sense in DMs (/poll), some don't (/kick). Add a manifest field contexts: ["channel", "dm"] defaulting to ["channel"].

Files-to-touch checklist (for the implementing agent)

  • Server/migrations/016_plugin_commands.sql
  • Server/plugin/manifest.goCommandSpec, validateCommands
  • Server/plugin/manifest_test.go — command validation table
  • Server/plugin/host_commands.go — typed args, autocomplete
  • Server/store/sqlite_plugin_commands.go
  • Server/ws/message_types.go — four new constants
  • Server/ws/command.goCommandInvokeCmd, CommandAutocompleteCmd
  • Server/ws/handlers_command.go — V2 handlers + /me + /shrug
  • Server/ws/handlers.go — register new handlers
  • Server/ws/deps.goCommandDeps
  • Server/ws/handlers_command_test.go
  • Server/api/router.goGET /api/v1/commands (cached schema dump)
  • Client/src/state/commands.ts
  • Client/src/components/Composer/SlashCommandPopup.tsx
  • docs/protocol.md — four new wire messages
  • CHANGELOG.md — Phase D entry