mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
* refactor(ws): split handleVoiceJoin into cohesive join-stage helpers handleVoiceJoin was 130 statements / cyclomatic 59 / nestif 11, breaking all three complexity budgets at once. Split along the stage boundaries the doc comment already described: precheck, leave-current, persist, restore moderator flags, grant token, complete. The publish-permission derivation becomes its own helper because it is the one branch-heavy block inside the token grant. Pure move: every statement is preserved verbatim. The only edits are bare `return`s becoming the typed returns of their new helper, `c.userID` becoming the `userID` parameter inside voiceJoinPublishPerms, and voiceJoinComplete re-reading `ch.VoiceMaxUsers` instead of receiving it — `ch` is never mutated, so the value is identical. Verified by normalising both revisions of the region to sorted, comment- and whitespace-stripped statements and diffing: the only deltas are the ones listed above. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: collapse the three duplicated sibling pairs dupl flagged three pairs of adjacent near-identical functions. Each pair is now one parameterised implementation plus two thin, still-greppable wrappers. - ws/voice_controls.go: handleVoiceMuteV2 / handleVoiceDeafenV2 share voiceSelfToggleV2; handleVoiceCameraV2 / handleVoiceScreenshareV2 share voiceStreamToggleV2. Camera and screenshare drawing from one voice_max_video budget (OC-0023) was a bug caused by exactly this duplication drifting, so one body is the point, not a side effect. - db/mention_queries.go: ListMentionTargetsByRoles / ListMentionTargetsByUserIDs share listMentionTargets. The matched column is a closed named type (mentionTargetColumn) rather than a bare string, so the value interpolated into the SELECT cannot become caller-supplied. Behaviour is unchanged: every rate-limit key, error code, error string, slog message and slog key is preserved verbatim, including the two "failed to update <kind> state" messages, which are now assembled the same way enableVideoSlot already assembled them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(api): extract readEmojiUpload from handleCreateEmoji handleCreateEmoji was 101 lines against a 100-line budget. The upload-bytes stage — pull the file out of the parsed form, cap its size, sniff its MIME type and sniff its dimensions — is the one self-contained block in it, and it already wrote its own refusals, so it moves out whole as readEmojiUpload. The permission-before-parse ordering the doc comment calls out is unchanged; so is every error string. file.Close() now runs when the helper returns rather than when the handler does, which is strictly earlier and unobservable: the bytes are already copied into raw and nothing else touches the handle. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: extract one cohesive block from three single-budget offenders Each of these was over exactly one budget, so each gets exactly one extraction rather than a restructure: - api/totp_handler.go handleVerifyTOTP (102 lines / 100): the block that resolves the user behind the partial-auth challenge and decrypts their TOTP secret becomes totpChallengeSecret. The ban-inside-the-partial-window check moves with it. - service/message_reactions.go handleReaction (cyclop 21 / 20): the whole authorisation chain — channel lookup, archived gate, DM participant and block checks, non-DM permission check — becomes reactionAudience, which also returns the DM fan-out audience it already resolved. Check order is unchanged and load-bearing. - db/admin_queries.go BackupToSafe (cyclop 21 / 20): the character allowlist loop and the SQL-comment rejection become validateBackupPathChars. That loop alone was most of the branch count. No error string, no check and no ordering changed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(plugin): split InstallFromZip into staged install helpers 104 statements / cyclomatic 44 / nestif 12. Split along the stages the code already had: installZipExtract (the per-entry write loop, with installZipEntryDest holding the mode/symlink/zip-slip guard chain and installZipWriteEntry the size-capped copy), installZipStagedManifest, installZipPromote, and installZipReactivate for the :399 nested block. Every zip-slip, symlink, entry-mode and uncompressed-size check is preserved in the same order relative to the writes it guards. The 19 inline `cleanup(); return` sites collapse to 4 in the orchestrator, one per stage, because each helper now returns an error instead of unwinding itself — the staging directory is still removed on exactly the same set of failures. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(api): split newWAFMiddleware into engine build and per-phase helpers 184 lines / cyclomatic 38, and the request-body block at :382 was the worst nested site in the tree at nestif 17. Engine construction moves out of the closure (wafInlineEngine, wafCRSEngine — the Coraza directive string is lifted verbatim), and each request phase becomes its own helper: wafInlineRequestHeaders, wafCRSRequestHeaders (including the Host/Transfer-Encoding re-add for CRS 920280), wafFeedCRSBody and wafInspectRequestBody, which is the old :382 block. The three `handleWAFInterruption(w, it); return` sites inside the body block become one: the helper now returns the interruption and the orchestrator handles it. No statement runs between the two points on either side, so the verdict is honoured identically — in particular a CRS body interruption still returns without replacing r.Body. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(service): split SendMessage and lift EditMessage's access check SendMessage was 79 statements / cyclomatic 35 with an 11-deep nested attachment block at :101; EditMessage was one point over cyclop. SendMessage becomes sendMessagePrecheck (permission and DM-block gates, content sanitisation), sendMessageLinkAttachments (the :101 block: attachment ownership, claim and link) and sendMessageDMSideEffects. EditMessage gets editMessageCheckAccess and nothing else — one budget over earns one extraction. The sanitizeContent fixpoint and the attachment ownership check are unchanged, as is the order of every gate. The DM side effects run behind `isDM && !s.sendMessageDMSideEffects(...)`, so a non-DM never enters them; inside, only the GetDMParticipantIDs failure returns false, matching the one error the original early-returned on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(admin): split handlePatchUser into per-field apply helpers 106 lines / cyclomatic 29, with the ban block at :154 nested 9 deep. Each optional field of the partial edit becomes its own helper — patchUserPrecheck, patchUserAuthorizeRole, patchUserApplyBan (the :154 block, including the session disconnect and the broadcast) and patchUserApplyRole. Each returns a bool meaning "keep going"; none of them writes a success response, so the single response site in the orchestrator is unchanged. Field application order, the permission-cache invalidation on a role change and the disconnect-and-broadcast on a ban are all preserved, as are the three fail-closed `mod == nil` guards, which now sit at the top of their own helper and still fire on exactly the same conditions. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(admin): split handleSetup into first-run setup stages 143 lines / cyclomatic 30, with the optional-wizard block at :219 sitting exactly on the nestif threshold. Split into the stages the endpoint already had: request gating (rate limit and origin check, which run before any auth exists on a fresh server), owner account creation, and the wizard application that was the :219 block. Every gate in front of the handler is a security control on an unauthenticated endpoint; none moved relative to the work it protects. setup_wizard.go is untouched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: split run() into named bootstrap and shutdown steps 131 statements / cyclomatic 57, with the executable-path fallback at :126 nested 9 deep. The five anonymous `defer func(){...}()` blocks become named functions — telemetryStop, runClosePlugins, runStopEventPersistence, runStopAuditWriter, maintenanceStop — and the bootstrap stages move out likewise. Every defer is still registered in run() itself, at the same point in the sequence, so the LIFO teardown order is unchanged; that order is documented in the surrounding comments and is load-bearing (the audit-writer stop must follow database.Close's registration, the event-persistence stop must precede it). runStopEventPersistence is now registered unconditionally with a nil persister meaning "disabled", where the old code registered its defer inside the enabled branch — a no-op occupying that slot cannot change the relative order of the others. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(ws): split handleReconnect into resume stages 77 statements / cyclomatic 41, plus the replay block at :199 and, in handleFreshConnect, the voice-state restore at :622. handleReconnect becomes reconnectPrecheck, reconnectSelectReplay (with reconnectVetColdTail for the cold-tier gap check), reconnectRegister and reconnectWriteReplay. handleFreshConnect's stale-voice cleanup moves to its own helper, where the `if h.livekit != nil` wrapper becomes a guard clause — that block was the tail of its scope, so returning early and falling off the end are the same. The parts that carry the invariants are moved verbatim: reconnectRegister still takes h.seqMu, still calls registerNow inside that same critical section (BUG-123 / OC-0206), still unlocks on every exit, and still emits the "full" tier counter and telemetry on each of its three re-check failures. handleReconnect's two-boolean contract is unchanged — the collapsed `return false, false` sites are all fall-through-to-full-ready, and the single `return true, false` is still the handshake-write-failure path whose teardown already ran (OC-0051). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs(server): fold in the adversarial review of the complexity refactors Eleven skeptic passes over the refactor commits on this branch found no blocker and no major — behaviour is preserved throughout. They did find comment and accuracy defects worth correcting: - db/mention_queries.go: the mentionTargetColumn rationale claimed the named type made the interpolated column "only ever one of the two constants". A Go named type is not closed, so that is a convention the type makes visible, not one it enforces. Reworded, gosec justification included. - ws/voice_controls.go: the dupl collapse generalised away three specifics — that a server deafen is the moderator's to lift (now on the serverDeafen field), the concrete voice_states.camera / voice_states.screenshare column names, and the half of the OC-0023 rationale about neither stream kind hiding from the other's count. All three restored. - ws/voice_join.go: `maxUsers := ch.VoiceMaxUsers` had been hoisted to the top of voiceJoinComplete, moving a read across the tail supersession guard. The read is inert, but it was the one statement in that commit whose position relative to a security guard changed; it now sits at its use, as before. - ws/*_test.go: three test comments cited voice_join.go line numbers that the split invalidated. They now cite the helper by name instead. - service/message_reactions.go: reactionAudience's doc claimed to enforce "every gate on reacting"; it enforces the channel-scoped ones, and the doc now says which gates stay with the caller. - api/emoji_handler.go: the readEmojiUpload call reused the outer `ok` from the auth check by assignment; it gets its own readOK. - admin/setup_handler.go: a moved comment kept a "the response above" deictic that no longer had a response above it. No behaviour change. Build, vet, full tests and -race on five packages green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(ws): clear the remaining complexity budgets across the hub Eight files, thirteen findings. Each function is split at the stages it already had; no branch is reordered, merged or inverted. - handlers.go handleMessage (cyclop 28, 88 stmts): session re-check, frame decode and result application become handleMessageSessionRecheck, handleMessageDecode and handleMessageApply. The V2 constructor lookup -> DispatchV2 -> Result resolution order is untouched. - serve_ready.go buildReady (cyclop 26, 61 stmts): the per-section fetches split out, readyChannelPayloads among them. Every visibility predicate is preserved verbatim — this is the payload that decides what a client may see. - serve_pumps.go writePump (cyclop 31): writePumpWrite, writePumpDeliver, writePumpDrainChannel and writePumpDrainAndClose. Every channel receive stays in the same select statement, so scheduling is unchanged. - hub_sweep.go sweepStaleVoiceStates (cyclop 22, 56 stmts): the staleness predicate, the hub-lock ordering and the position of the race hook are all as they were — handleVoiceJoin's BUG-088 ordering depends on them. - hub_broadcast.go channelReadAudienceImpl and RefreshChannelVisibility (cyclop 22 each, 57 stmts): channelReadAudienceDM and refreshChannelVisibilityCanSend. The audience predicate is the OC-0090 group-DM leak surface, so it is extracted, never simplified. - livekit_webhook.go (nestif 13 and 14): webhookJoinedEnforceVoiceState, webhookLeftCleanupClient and webhookLeftFinishLeave. DB delete still precedes broadcast on every path. - livekit_download.go EnsureLiveKitBinary (52 stmts): one extraction, ensureLiveKitStageBinary, keeping every archive path check intact. - voice_moderation.go (nestif 8): voiceModDeafenRollback. The persisted server_muted flag remains the authority. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(api): clear the remaining complexity budgets across the HTTP layer - router.go NewRouter (cyclop 28, 84 stmts): split by wiring concern into routerTOTPKey, routerHealthDeps, routerMiddleware, routerUploadRoutes, routerPluginWiring, routerVoiceRoutes and routerMetricsRoutes. Middleware ORDER is a security property (auth before handler, WAF before body parse, rate limit before work) and is unchanged; the returned cleanup func still closes over and releases everything it did before. - auth_handler.go handleRegister (133 lines) and handleLogin (cyclop 21, 152 lines): registerPolicyGate, registerReadRequest, loginReadRequest and loginAuthenticate. The always-compare posture, every rate-limit key, every counter reset and the ban-check-versus-password-compare order are all preserved — including loginUserFailureThreshold staying unscaled by scaledAuthLimit, which is deliberate and commented. - upload_handler.go handleServeFile (cyclop 31, 128 lines): serveFileResolve and serveFileAuthorize. Every header this sets — Content-Disposition included, which is what stops a stored file being served as active content — is still set with the same value in the same circumstances. - profile_handler.go handleUploadAvatar (120 lines): avatarUploadReadImage, mirroring readEmojiUpload in shape but with the avatar caps and MIME set. The two deliberately do not share a helper. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: clear the last complexity budgets in db and admin - db/account.go DeleteAccount (cyclop 28, 55 stmts): grouped by subsystem into deleteAccountAdminGuard, deleteAccountDMChannels and deleteAccountCloseDMChannels, each taking the same transaction. The transaction boundary, the delete ORDER (which foreign keys depend on) and the rollback path are unchanged. - admin/logstream.go handleLogStream (cyclop 24): logStreamAuthorize. Flush cadence, heartbeat and disconnect detection untouched. - admin/setup_wizard.go validateWizard (cyclop 23): grouped by section into wizardValidateIdentity, wizardValidateNetwork and wizardValidateMedia. Every message and bound is unchanged — this is the first input-validation boundary on a fresh server, before any auth exists. With this the tree is at zero: golangci-lint run reports 0 issues against the budgets set in #1384 (funlen 100/50, cyclop 20, nestif 8, dupl 150), with no //nolint and no exclusion added anywhere. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
350 lines
11 KiB
Go
350 lines
11 KiB
Go
package ws
|
|
|
|
// Auto-download of the companion livekit-server binary.
|
|
//
|
|
// When voice.auto_download_livekit is enabled and no voice.livekit_binary is
|
|
// configured, the server fetches a pinned livekit-server release from the
|
|
// official LiveKit GitHub releases, verifies it against the release's
|
|
// checksums.txt, and stores it under <data_dir>/livekit/. The version is
|
|
// pinned (overridable via voice.livekit_version) so a boot never silently
|
|
// picks up a new upstream release.
|
|
|
|
import (
|
|
"archive/tar"
|
|
"archive/zip"
|
|
"bufio"
|
|
"compress/gzip"
|
|
"context"
|
|
"crypto/sha256"
|
|
"encoding/hex"
|
|
"fmt"
|
|
"io"
|
|
"log/slog"
|
|
"net/http"
|
|
"os"
|
|
"path/filepath"
|
|
"runtime"
|
|
"strings"
|
|
)
|
|
|
|
// DefaultLiveKitVersion is the livekit-server release the server downloads
|
|
// when voice.livekit_version is not set. Bump deliberately with releases.
|
|
const DefaultLiveKitVersion = "1.13.5"
|
|
|
|
// livekitDownloadBase is the release download URL prefix. Package variable so
|
|
// tests can point it at a local httptest server.
|
|
var livekitDownloadBase = "https://github.com/livekit/livekit/releases/download"
|
|
|
|
const (
|
|
// maxLiveKitArchiveSize caps the archive download (the real archive is
|
|
// ~40 MB compressed).
|
|
maxLiveKitArchiveSize = 200 * 1024 * 1024
|
|
// maxChecksumsSize caps the checksums.txt download.
|
|
maxChecksumsSize = 1 * 1024 * 1024
|
|
)
|
|
|
|
// livekitAssetName maps GOOS/GOARCH to the release asset file name, following
|
|
// LiveKit's goreleaser config (linux/windows on amd64/arm64/armv7; archives
|
|
// are tar.gz except zip on windows; checksum file is "checksums.txt").
|
|
func livekitAssetName(version, goos, goarch string) (string, error) {
|
|
var arch string
|
|
switch goarch {
|
|
case "amd64", "arm64":
|
|
arch = goarch
|
|
case "arm":
|
|
arch = "armv7"
|
|
default:
|
|
return "", fmt.Errorf("livekit auto-download does not support architecture %s — set voice.livekit_binary to a livekit-server binary you provide", goarch)
|
|
}
|
|
switch goos {
|
|
case "linux":
|
|
return fmt.Sprintf("livekit_%s_linux_%s.tar.gz", version, arch), nil
|
|
case "windows":
|
|
return fmt.Sprintf("livekit_%s_windows_%s.zip", version, arch), nil
|
|
default:
|
|
return "", fmt.Errorf("livekit auto-download does not support OS %s — set voice.livekit_binary to a livekit-server binary you provide", goos)
|
|
}
|
|
}
|
|
|
|
// livekitBinaryFilename is the versioned name the extracted binary is stored
|
|
// under. Embedding the version means a bumped pin downloads fresh instead of
|
|
// reusing a stale cached binary.
|
|
func livekitBinaryFilename(version string) string {
|
|
name := "livekit-server-" + version
|
|
if runtime.GOOS == "windows" {
|
|
name += ".exe"
|
|
}
|
|
return name
|
|
}
|
|
|
|
// EnsureLiveKitBinary returns the path to a verified livekit-server binary
|
|
// for the given release version (empty = DefaultLiveKitVersion), downloading
|
|
// and extracting it into <dataDir>/livekit/ if it is not already cached.
|
|
func EnsureLiveKitBinary(ctx context.Context, dataDir, version string) (string, error) {
|
|
version = strings.TrimPrefix(version, "v")
|
|
if version == "" {
|
|
version = DefaultLiveKitVersion
|
|
}
|
|
asset, err := livekitAssetName(version, runtime.GOOS, runtime.GOARCH)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
dir := filepath.Join(dataDir, "livekit")
|
|
dest := filepath.Join(dir, livekitBinaryFilename(version))
|
|
if info, statErr := os.Stat(dest); statErr == nil && info.Mode().IsRegular() && info.Size() > 0 {
|
|
return dest, nil
|
|
}
|
|
|
|
if err := os.MkdirAll(dir, 0o750); err != nil {
|
|
return "", fmt.Errorf("creating livekit dir: %w", err)
|
|
}
|
|
|
|
base := livekitDownloadBase + "/v" + version
|
|
slog.Info("livekit: downloading livekit-server (one-time)", "version", version, "asset", asset)
|
|
|
|
sums, err := fetchLimited(ctx, base+"/checksums.txt", maxChecksumsSize)
|
|
if err != nil {
|
|
return "", fmt.Errorf("fetching livekit checksums: %w", err)
|
|
}
|
|
expectedHash, err := parseChecksumLine(sums, asset)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
// Download the archive next to the destination so the final rename stays
|
|
// on one filesystem. O_EXCL via downloadTo refuses pre-planted files.
|
|
archivePath := dest + ".download"
|
|
_ = os.Remove(archivePath)
|
|
defer os.Remove(archivePath) //nolint:errcheck // best-effort cleanup
|
|
|
|
if err := downloadTo(ctx, base+"/"+asset, archivePath, maxLiveKitArchiveSize); err != nil {
|
|
return "", fmt.Errorf("downloading %s: %w", asset, err)
|
|
}
|
|
|
|
// Verify and extract through one open handle so the bytes verified are
|
|
// the bytes extracted even if the path is swapped in between (TOCTOU).
|
|
f, err := os.Open(archivePath) //nolint:gosec // G304: path constructed from trusted config
|
|
if err != nil {
|
|
return "", fmt.Errorf("opening archive: %w", err)
|
|
}
|
|
defer f.Close() //nolint:errcheck
|
|
|
|
h := sha256.New()
|
|
size, err := io.Copy(h, f)
|
|
if err != nil {
|
|
return "", fmt.Errorf("hashing archive: %w", err)
|
|
}
|
|
actual := hex.EncodeToString(h.Sum(nil))
|
|
if !strings.EqualFold(actual, expectedHash) {
|
|
return "", fmt.Errorf("livekit archive checksum mismatch for %s: expected %s, got %s", asset, expectedHash, actual)
|
|
}
|
|
|
|
if err := ensureLiveKitStageBinary(f, size, asset, dest); err != nil {
|
|
return "", err
|
|
}
|
|
|
|
cleanupOldLiveKitBinaries(dir, filepath.Base(dest))
|
|
slog.Info("livekit: download complete", "path", dest)
|
|
return dest, nil
|
|
}
|
|
|
|
// ensureLiveKitStageBinary extracts the already-verified archive f (asset's
|
|
// suffix picks zip vs tar.gz) into a temp file beside dest, makes it
|
|
// executable and renames it into place. Every failure removes the temp file.
|
|
func ensureLiveKitStageBinary(f *os.File, size int64, asset, dest string) error {
|
|
tmpBin := dest + ".tmp"
|
|
_ = os.Remove(tmpBin)
|
|
var err error
|
|
if strings.HasSuffix(asset, ".zip") {
|
|
err = extractLiveKitFromZip(f, size, tmpBin)
|
|
} else {
|
|
if _, seekErr := f.Seek(0, io.SeekStart); seekErr != nil {
|
|
return fmt.Errorf("rewinding archive: %w", seekErr)
|
|
}
|
|
err = extractLiveKitFromTarGz(f, tmpBin)
|
|
}
|
|
if err != nil {
|
|
_ = os.Remove(tmpBin)
|
|
return fmt.Errorf("extracting %s: %w", asset, err)
|
|
}
|
|
if err := os.Chmod(tmpBin, 0o755); err != nil { //nolint:gosec // G302: must be executable
|
|
_ = os.Remove(tmpBin)
|
|
return fmt.Errorf("chmod binary: %w", err)
|
|
}
|
|
if err := os.Rename(tmpBin, dest); err != nil {
|
|
_ = os.Remove(tmpBin)
|
|
return fmt.Errorf("staging binary: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// livekitBinaryEntry reports whether an archive entry name is the
|
|
// livekit-server binary (archives contain it at the top level plus LICENSE).
|
|
func livekitBinaryEntry(name string) bool {
|
|
base := filepath.Base(filepath.ToSlash(name))
|
|
return base == "livekit-server" || base == "livekit-server.exe"
|
|
}
|
|
|
|
// extractLiveKitFromTarGz extracts the livekit-server entry to destPath
|
|
// (created O_EXCL so a pre-planted file fails the extraction).
|
|
func extractLiveKitFromTarGz(r io.Reader, destPath string) error {
|
|
gr, err := gzip.NewReader(r)
|
|
if err != nil {
|
|
return fmt.Errorf("gzip: %w", err)
|
|
}
|
|
defer gr.Close() //nolint:errcheck
|
|
|
|
tr := tar.NewReader(gr)
|
|
for {
|
|
hdr, err := tr.Next()
|
|
if err == io.EOF {
|
|
return fmt.Errorf("archive contains no livekit-server binary")
|
|
}
|
|
if err != nil {
|
|
return fmt.Errorf("tar: %w", err)
|
|
}
|
|
if hdr.Typeflag != tar.TypeReg || strings.Contains(hdr.Name, "..") || !livekitBinaryEntry(hdr.Name) {
|
|
continue
|
|
}
|
|
return writeExact(destPath, io.LimitReader(tr, hdr.Size), hdr.Size)
|
|
}
|
|
}
|
|
|
|
// extractLiveKitFromZip extracts the livekit-server entry to destPath
|
|
// (created O_EXCL). r must be positioned over the verified archive bytes.
|
|
func extractLiveKitFromZip(r io.ReaderAt, size int64, destPath string) error {
|
|
zr, err := zip.NewReader(r, size)
|
|
if err != nil {
|
|
return fmt.Errorf("zip: %w", err)
|
|
}
|
|
for _, entry := range zr.File {
|
|
if entry.FileInfo().IsDir() || strings.Contains(entry.Name, "..") || !livekitBinaryEntry(entry.Name) {
|
|
continue
|
|
}
|
|
rc, err := entry.Open()
|
|
if err != nil {
|
|
return fmt.Errorf("opening zip entry: %w", err)
|
|
}
|
|
//nolint:gosec // G110: size is bounded by the verified archive's cap
|
|
writeErr := writeExact(destPath, rc, int64(entry.UncompressedSize64)) //nolint:gosec // G115: size fits int64
|
|
_ = rc.Close()
|
|
return writeErr
|
|
}
|
|
return fmt.Errorf("archive contains no livekit-server binary")
|
|
}
|
|
|
|
// writeExact writes exactly size bytes from r to destPath, O_EXCL.
|
|
func writeExact(destPath string, r io.Reader, size int64) error {
|
|
out, err := os.OpenFile(destPath, os.O_CREATE|os.O_WRONLY|os.O_EXCL, 0o600) //nolint:gosec // G304: trusted path
|
|
if err != nil {
|
|
return err
|
|
}
|
|
n, copyErr := io.Copy(out, r)
|
|
closeErr := out.Close()
|
|
if copyErr != nil {
|
|
return fmt.Errorf("writing binary: %w", copyErr)
|
|
}
|
|
if closeErr != nil {
|
|
return closeErr
|
|
}
|
|
if n != size {
|
|
return fmt.Errorf("incomplete archive entry (%d of %d bytes)", n, size)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// parseChecksumLine finds the sha256 for filename in a goreleaser-style
|
|
// checksums file ("<hex> <filename>" per line).
|
|
func parseChecksumLine(data []byte, filename string) (string, error) {
|
|
sc := bufio.NewScanner(strings.NewReader(string(data)))
|
|
for sc.Scan() {
|
|
fields := strings.Fields(sc.Text())
|
|
if len(fields) == 2 && fields[1] == filename && len(fields[0]) == 64 {
|
|
return fields[0], nil
|
|
}
|
|
}
|
|
return "", fmt.Errorf("no checksum entry for %s", filename)
|
|
}
|
|
|
|
// fetchLimited GETs url and returns at most limit bytes, erroring beyond it.
|
|
func fetchLimited(ctx context.Context, url string, limit int64) ([]byte, error) {
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
resp, err := http.DefaultClient.Do(req)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer resp.Body.Close() //nolint:errcheck
|
|
if resp.StatusCode != http.StatusOK {
|
|
return nil, fmt.Errorf("HTTP %d fetching %s", resp.StatusCode, url)
|
|
}
|
|
data, err := io.ReadAll(io.LimitReader(resp.Body, limit+1))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if int64(len(data)) > limit {
|
|
return nil, fmt.Errorf("response exceeds %d bytes", limit)
|
|
}
|
|
return data, nil
|
|
}
|
|
|
|
// downloadTo streams url to destPath (O_EXCL), capped at limit bytes.
|
|
func downloadTo(ctx context.Context, url, destPath string, limit int64) error {
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
resp, err := http.DefaultClient.Do(req)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer resp.Body.Close() //nolint:errcheck
|
|
if resp.StatusCode != http.StatusOK {
|
|
return fmt.Errorf("HTTP %d downloading %s", resp.StatusCode, url)
|
|
}
|
|
|
|
out, err := os.OpenFile(destPath, os.O_CREATE|os.O_WRONLY|os.O_EXCL, 0o600) //nolint:gosec // G304: trusted path
|
|
if err != nil {
|
|
return fmt.Errorf("creating download file: %w", err)
|
|
}
|
|
n, copyErr := io.Copy(out, io.LimitReader(resp.Body, limit))
|
|
if copyErr == nil && n == limit {
|
|
// Probe one more byte to distinguish exactly-at-limit from over-limit.
|
|
var probe [1]byte
|
|
if extra, _ := resp.Body.Read(probe[:]); extra > 0 {
|
|
copyErr = fmt.Errorf("download exceeds maximum size of %d bytes", limit)
|
|
}
|
|
}
|
|
closeErr := out.Close()
|
|
if copyErr != nil {
|
|
_ = os.Remove(destPath)
|
|
return copyErr
|
|
}
|
|
if closeErr != nil {
|
|
_ = os.Remove(destPath)
|
|
return fmt.Errorf("closing download: %w", closeErr)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// cleanupOldLiveKitBinaries best-effort removes previously downloaded
|
|
// livekit-server versions other than keep.
|
|
func cleanupOldLiveKitBinaries(dir, keep string) {
|
|
entries, err := os.ReadDir(dir)
|
|
if err != nil {
|
|
return
|
|
}
|
|
for _, e := range entries {
|
|
name := e.Name()
|
|
if e.Type().IsRegular() && strings.HasPrefix(name, "livekit-server-") && name != keep &&
|
|
!strings.HasSuffix(name, ".download") && !strings.HasSuffix(name, ".tmp") {
|
|
if rmErr := os.Remove(filepath.Join(dir, name)); rmErr == nil {
|
|
slog.Info("livekit: removed old downloaded binary", "name", name)
|
|
}
|
|
}
|
|
}
|
|
}
|