mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
* refactor(ws): split handleVoiceJoin into cohesive join-stage helpers handleVoiceJoin was 130 statements / cyclomatic 59 / nestif 11, breaking all three complexity budgets at once. Split along the stage boundaries the doc comment already described: precheck, leave-current, persist, restore moderator flags, grant token, complete. The publish-permission derivation becomes its own helper because it is the one branch-heavy block inside the token grant. Pure move: every statement is preserved verbatim. The only edits are bare `return`s becoming the typed returns of their new helper, `c.userID` becoming the `userID` parameter inside voiceJoinPublishPerms, and voiceJoinComplete re-reading `ch.VoiceMaxUsers` instead of receiving it — `ch` is never mutated, so the value is identical. Verified by normalising both revisions of the region to sorted, comment- and whitespace-stripped statements and diffing: the only deltas are the ones listed above. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: collapse the three duplicated sibling pairs dupl flagged three pairs of adjacent near-identical functions. Each pair is now one parameterised implementation plus two thin, still-greppable wrappers. - ws/voice_controls.go: handleVoiceMuteV2 / handleVoiceDeafenV2 share voiceSelfToggleV2; handleVoiceCameraV2 / handleVoiceScreenshareV2 share voiceStreamToggleV2. Camera and screenshare drawing from one voice_max_video budget (OC-0023) was a bug caused by exactly this duplication drifting, so one body is the point, not a side effect. - db/mention_queries.go: ListMentionTargetsByRoles / ListMentionTargetsByUserIDs share listMentionTargets. The matched column is a closed named type (mentionTargetColumn) rather than a bare string, so the value interpolated into the SELECT cannot become caller-supplied. Behaviour is unchanged: every rate-limit key, error code, error string, slog message and slog key is preserved verbatim, including the two "failed to update <kind> state" messages, which are now assembled the same way enableVideoSlot already assembled them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(api): extract readEmojiUpload from handleCreateEmoji handleCreateEmoji was 101 lines against a 100-line budget. The upload-bytes stage — pull the file out of the parsed form, cap its size, sniff its MIME type and sniff its dimensions — is the one self-contained block in it, and it already wrote its own refusals, so it moves out whole as readEmojiUpload. The permission-before-parse ordering the doc comment calls out is unchanged; so is every error string. file.Close() now runs when the helper returns rather than when the handler does, which is strictly earlier and unobservable: the bytes are already copied into raw and nothing else touches the handle. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: extract one cohesive block from three single-budget offenders Each of these was over exactly one budget, so each gets exactly one extraction rather than a restructure: - api/totp_handler.go handleVerifyTOTP (102 lines / 100): the block that resolves the user behind the partial-auth challenge and decrypts their TOTP secret becomes totpChallengeSecret. The ban-inside-the-partial-window check moves with it. - service/message_reactions.go handleReaction (cyclop 21 / 20): the whole authorisation chain — channel lookup, archived gate, DM participant and block checks, non-DM permission check — becomes reactionAudience, which also returns the DM fan-out audience it already resolved. Check order is unchanged and load-bearing. - db/admin_queries.go BackupToSafe (cyclop 21 / 20): the character allowlist loop and the SQL-comment rejection become validateBackupPathChars. That loop alone was most of the branch count. No error string, no check and no ordering changed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(plugin): split InstallFromZip into staged install helpers 104 statements / cyclomatic 44 / nestif 12. Split along the stages the code already had: installZipExtract (the per-entry write loop, with installZipEntryDest holding the mode/symlink/zip-slip guard chain and installZipWriteEntry the size-capped copy), installZipStagedManifest, installZipPromote, and installZipReactivate for the :399 nested block. Every zip-slip, symlink, entry-mode and uncompressed-size check is preserved in the same order relative to the writes it guards. The 19 inline `cleanup(); return` sites collapse to 4 in the orchestrator, one per stage, because each helper now returns an error instead of unwinding itself — the staging directory is still removed on exactly the same set of failures. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(api): split newWAFMiddleware into engine build and per-phase helpers 184 lines / cyclomatic 38, and the request-body block at :382 was the worst nested site in the tree at nestif 17. Engine construction moves out of the closure (wafInlineEngine, wafCRSEngine — the Coraza directive string is lifted verbatim), and each request phase becomes its own helper: wafInlineRequestHeaders, wafCRSRequestHeaders (including the Host/Transfer-Encoding re-add for CRS 920280), wafFeedCRSBody and wafInspectRequestBody, which is the old :382 block. The three `handleWAFInterruption(w, it); return` sites inside the body block become one: the helper now returns the interruption and the orchestrator handles it. No statement runs between the two points on either side, so the verdict is honoured identically — in particular a CRS body interruption still returns without replacing r.Body. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(service): split SendMessage and lift EditMessage's access check SendMessage was 79 statements / cyclomatic 35 with an 11-deep nested attachment block at :101; EditMessage was one point over cyclop. SendMessage becomes sendMessagePrecheck (permission and DM-block gates, content sanitisation), sendMessageLinkAttachments (the :101 block: attachment ownership, claim and link) and sendMessageDMSideEffects. EditMessage gets editMessageCheckAccess and nothing else — one budget over earns one extraction. The sanitizeContent fixpoint and the attachment ownership check are unchanged, as is the order of every gate. The DM side effects run behind `isDM && !s.sendMessageDMSideEffects(...)`, so a non-DM never enters them; inside, only the GetDMParticipantIDs failure returns false, matching the one error the original early-returned on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(admin): split handlePatchUser into per-field apply helpers 106 lines / cyclomatic 29, with the ban block at :154 nested 9 deep. Each optional field of the partial edit becomes its own helper — patchUserPrecheck, patchUserAuthorizeRole, patchUserApplyBan (the :154 block, including the session disconnect and the broadcast) and patchUserApplyRole. Each returns a bool meaning "keep going"; none of them writes a success response, so the single response site in the orchestrator is unchanged. Field application order, the permission-cache invalidation on a role change and the disconnect-and-broadcast on a ban are all preserved, as are the three fail-closed `mod == nil` guards, which now sit at the top of their own helper and still fire on exactly the same conditions. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(admin): split handleSetup into first-run setup stages 143 lines / cyclomatic 30, with the optional-wizard block at :219 sitting exactly on the nestif threshold. Split into the stages the endpoint already had: request gating (rate limit and origin check, which run before any auth exists on a fresh server), owner account creation, and the wizard application that was the :219 block. Every gate in front of the handler is a security control on an unauthenticated endpoint; none moved relative to the work it protects. setup_wizard.go is untouched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: split run() into named bootstrap and shutdown steps 131 statements / cyclomatic 57, with the executable-path fallback at :126 nested 9 deep. The five anonymous `defer func(){...}()` blocks become named functions — telemetryStop, runClosePlugins, runStopEventPersistence, runStopAuditWriter, maintenanceStop — and the bootstrap stages move out likewise. Every defer is still registered in run() itself, at the same point in the sequence, so the LIFO teardown order is unchanged; that order is documented in the surrounding comments and is load-bearing (the audit-writer stop must follow database.Close's registration, the event-persistence stop must precede it). runStopEventPersistence is now registered unconditionally with a nil persister meaning "disabled", where the old code registered its defer inside the enabled branch — a no-op occupying that slot cannot change the relative order of the others. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(ws): split handleReconnect into resume stages 77 statements / cyclomatic 41, plus the replay block at :199 and, in handleFreshConnect, the voice-state restore at :622. handleReconnect becomes reconnectPrecheck, reconnectSelectReplay (with reconnectVetColdTail for the cold-tier gap check), reconnectRegister and reconnectWriteReplay. handleFreshConnect's stale-voice cleanup moves to its own helper, where the `if h.livekit != nil` wrapper becomes a guard clause — that block was the tail of its scope, so returning early and falling off the end are the same. The parts that carry the invariants are moved verbatim: reconnectRegister still takes h.seqMu, still calls registerNow inside that same critical section (BUG-123 / OC-0206), still unlocks on every exit, and still emits the "full" tier counter and telemetry on each of its three re-check failures. handleReconnect's two-boolean contract is unchanged — the collapsed `return false, false` sites are all fall-through-to-full-ready, and the single `return true, false` is still the handshake-write-failure path whose teardown already ran (OC-0051). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs(server): fold in the adversarial review of the complexity refactors Eleven skeptic passes over the refactor commits on this branch found no blocker and no major — behaviour is preserved throughout. They did find comment and accuracy defects worth correcting: - db/mention_queries.go: the mentionTargetColumn rationale claimed the named type made the interpolated column "only ever one of the two constants". A Go named type is not closed, so that is a convention the type makes visible, not one it enforces. Reworded, gosec justification included. - ws/voice_controls.go: the dupl collapse generalised away three specifics — that a server deafen is the moderator's to lift (now on the serverDeafen field), the concrete voice_states.camera / voice_states.screenshare column names, and the half of the OC-0023 rationale about neither stream kind hiding from the other's count. All three restored. - ws/voice_join.go: `maxUsers := ch.VoiceMaxUsers` had been hoisted to the top of voiceJoinComplete, moving a read across the tail supersession guard. The read is inert, but it was the one statement in that commit whose position relative to a security guard changed; it now sits at its use, as before. - ws/*_test.go: three test comments cited voice_join.go line numbers that the split invalidated. They now cite the helper by name instead. - service/message_reactions.go: reactionAudience's doc claimed to enforce "every gate on reacting"; it enforces the channel-scoped ones, and the doc now says which gates stay with the caller. - api/emoji_handler.go: the readEmojiUpload call reused the outer `ok` from the auth check by assignment; it gets its own readOK. - admin/setup_handler.go: a moved comment kept a "the response above" deictic that no longer had a response above it. No behaviour change. Build, vet, full tests and -race on five packages green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(ws): clear the remaining complexity budgets across the hub Eight files, thirteen findings. Each function is split at the stages it already had; no branch is reordered, merged or inverted. - handlers.go handleMessage (cyclop 28, 88 stmts): session re-check, frame decode and result application become handleMessageSessionRecheck, handleMessageDecode and handleMessageApply. The V2 constructor lookup -> DispatchV2 -> Result resolution order is untouched. - serve_ready.go buildReady (cyclop 26, 61 stmts): the per-section fetches split out, readyChannelPayloads among them. Every visibility predicate is preserved verbatim — this is the payload that decides what a client may see. - serve_pumps.go writePump (cyclop 31): writePumpWrite, writePumpDeliver, writePumpDrainChannel and writePumpDrainAndClose. Every channel receive stays in the same select statement, so scheduling is unchanged. - hub_sweep.go sweepStaleVoiceStates (cyclop 22, 56 stmts): the staleness predicate, the hub-lock ordering and the position of the race hook are all as they were — handleVoiceJoin's BUG-088 ordering depends on them. - hub_broadcast.go channelReadAudienceImpl and RefreshChannelVisibility (cyclop 22 each, 57 stmts): channelReadAudienceDM and refreshChannelVisibilityCanSend. The audience predicate is the OC-0090 group-DM leak surface, so it is extracted, never simplified. - livekit_webhook.go (nestif 13 and 14): webhookJoinedEnforceVoiceState, webhookLeftCleanupClient and webhookLeftFinishLeave. DB delete still precedes broadcast on every path. - livekit_download.go EnsureLiveKitBinary (52 stmts): one extraction, ensureLiveKitStageBinary, keeping every archive path check intact. - voice_moderation.go (nestif 8): voiceModDeafenRollback. The persisted server_muted flag remains the authority. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(api): clear the remaining complexity budgets across the HTTP layer - router.go NewRouter (cyclop 28, 84 stmts): split by wiring concern into routerTOTPKey, routerHealthDeps, routerMiddleware, routerUploadRoutes, routerPluginWiring, routerVoiceRoutes and routerMetricsRoutes. Middleware ORDER is a security property (auth before handler, WAF before body parse, rate limit before work) and is unchanged; the returned cleanup func still closes over and releases everything it did before. - auth_handler.go handleRegister (133 lines) and handleLogin (cyclop 21, 152 lines): registerPolicyGate, registerReadRequest, loginReadRequest and loginAuthenticate. The always-compare posture, every rate-limit key, every counter reset and the ban-check-versus-password-compare order are all preserved — including loginUserFailureThreshold staying unscaled by scaledAuthLimit, which is deliberate and commented. - upload_handler.go handleServeFile (cyclop 31, 128 lines): serveFileResolve and serveFileAuthorize. Every header this sets — Content-Disposition included, which is what stops a stored file being served as active content — is still set with the same value in the same circumstances. - profile_handler.go handleUploadAvatar (120 lines): avatarUploadReadImage, mirroring readEmojiUpload in shape but with the avatar caps and MIME set. The two deliberately do not share a helper. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: clear the last complexity budgets in db and admin - db/account.go DeleteAccount (cyclop 28, 55 stmts): grouped by subsystem into deleteAccountAdminGuard, deleteAccountDMChannels and deleteAccountCloseDMChannels, each taking the same transaction. The transaction boundary, the delete ORDER (which foreign keys depend on) and the rollback path are unchanged. - admin/logstream.go handleLogStream (cyclop 24): logStreamAuthorize. Flush cadence, heartbeat and disconnect detection untouched. - admin/setup_wizard.go validateWizard (cyclop 23): grouped by section into wizardValidateIdentity, wizardValidateNetwork and wizardValidateMedia. Every message and bound is unchanged — this is the first input-validation boundary on a fresh server, before any auth exists. With this the tree is at zero: golangci-lint run reports 0 issues against the budgets set in #1384 (funlen 100/50, cyclop 20, nestif 8, dupl 150), with no //nolint and no exclusion added anywhere. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
311 lines
12 KiB
Go
311 lines
12 KiB
Go
package db
|
|
|
|
import (
|
|
"context"
|
|
"crypto/rand"
|
|
"database/sql"
|
|
"encoding/hex"
|
|
"errors"
|
|
"fmt"
|
|
"slices"
|
|
"strings"
|
|
|
|
"github.com/owncord/server/permissions"
|
|
)
|
|
|
|
// DeleteAccount anonymises and disables a user account within a single
|
|
// transaction. Because the messages, invites, and emoji tables
|
|
// reference users(id) with no ON DELETE CASCADE, we cannot simply DELETE
|
|
// the row. Instead we:
|
|
//
|
|
// 1. Verify the user is not the last admin/owner (return ErrLastAdmin).
|
|
// 2. Invalidate all sessions so existing tokens stop working.
|
|
// 3. Remove DM participation and open-state rows.
|
|
// 4. Remove reactions.
|
|
// 5. Remove read states.
|
|
// 6. Soft-delete all messages (mark deleted, clear content).
|
|
// 7. Anonymise the user row: clear password, avatar, TOTP, set
|
|
// username to "[deleted-{id}]", status to "offline", banned to 1.
|
|
//
|
|
// After this the account is completely unusable and all personal data is
|
|
// removed while preserving referential integrity for historical records.
|
|
func (d *DB) DeleteAccount(ctx context.Context, userID int64) error {
|
|
tx, err := d.writer.BeginTx(ctx, nil)
|
|
if err != nil {
|
|
return fmt.Errorf("DeleteAccount begin tx: %w", err)
|
|
}
|
|
defer tx.Rollback() //nolint:errcheck
|
|
|
|
if err := deleteAccountAdminGuard(ctx, tx, userID); err != nil {
|
|
return err
|
|
}
|
|
|
|
dmChannelIDs, err := deleteAccountDMChannels(ctx, tx, userID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// ── Purge related data ───────────────────────────────────────────────
|
|
stmts := []struct {
|
|
label string
|
|
query string
|
|
}{
|
|
{"sessions", `DELETE FROM sessions WHERE user_id = ?`},
|
|
// API tokens authenticate independently of sessions; leaving them
|
|
// active would keep the deleted account usable.
|
|
{"api_tokens", `UPDATE api_tokens SET revoked_at = datetime('now') WHERE user_id = ? AND revoked_at IS NULL`},
|
|
{"dm_participants", `DELETE FROM dm_participants WHERE user_id = ?`},
|
|
{"dm_open_state", `DELETE FROM dm_open_state WHERE user_id = ?`},
|
|
{"reactions", `DELETE FROM reactions WHERE user_id = ?`},
|
|
{"read_states", `DELETE FROM read_states WHERE user_id = ?`},
|
|
}
|
|
for _, s := range stmts {
|
|
if _, err := tx.ExecContext(ctx, s.query, userID); err != nil {
|
|
return fmt.Errorf("DeleteAccount %s: %w", s.label, err)
|
|
}
|
|
}
|
|
|
|
if err := deleteAccountCloseDMChannels(ctx, tx, userID, dmChannelIDs); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Soft-delete messages: mark as deleted and clear content so the rows
|
|
// remain for conversation continuity but contain no personal data.
|
|
if _, err := tx.ExecContext(ctx,
|
|
`UPDATE messages SET deleted = 1, content = '' WHERE user_id = ?`,
|
|
userID,
|
|
); err != nil {
|
|
return fmt.Errorf("DeleteAccount messages: %w", err)
|
|
}
|
|
|
|
// ── Anonymise user row ───────────────────────────────────────────────
|
|
// users.username is UNIQUE COLLATE NOCASE, so a third party holding
|
|
// "[deleted-<userID>]" would make this UPDATE fail, roll the whole
|
|
// transaction back, and deny the victim their own account deletion
|
|
// indefinitely. auth.ValidateUsername now reserves that namespace, but the
|
|
// erasure path must not depend on it: on a collision, fall back to a random
|
|
// suffix and retry. A SQLite constraint violation rolls back the statement,
|
|
// not the enclosing transaction, so retrying in place is safe.
|
|
if err := anonymiseUser(ctx, tx, userID); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := tx.Commit(); err != nil {
|
|
return fmt.Errorf("DeleteAccount commit: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// anonymiseUserAttempts is how many names anonymiseUser will try: the canonical
|
|
// "[deleted-<id>]" plus randomly suffixed variants. Exhausting it means the
|
|
// generator collided repeatedly, which is not something an attacker can force.
|
|
const anonymiseUserAttempts = 4
|
|
|
|
// anonymiseUser strips the user's credentials and personal fields and renames
|
|
// the row out of the way. The first candidate is the canonical
|
|
// "[deleted-<id>]"; if that name is taken, later candidates append a random
|
|
// suffix so no third party can pin the account in place by squatting a
|
|
// predictable string.
|
|
func anonymiseUser(ctx context.Context, tx *sql.Tx, userID int64) error {
|
|
// ban_expires must be cleared: a stale lapsed temp-ban timestamp would
|
|
// make banned=1 read as NOT banned (IsEffectivelyBanned), reviving the
|
|
// deleted account for any credential that survives.
|
|
const anonymise = `UPDATE users
|
|
SET username = ?,
|
|
password = '',
|
|
avatar = NULL,
|
|
totp_secret = NULL,
|
|
display_name = NULL,
|
|
about = NULL,
|
|
custom_status = NULL,
|
|
identity_public_key = NULL,
|
|
status = 'offline',
|
|
banned = 1,
|
|
ban_expires = NULL,
|
|
ban_reason = 'account deleted'
|
|
WHERE id = ?`
|
|
|
|
var lastErr error
|
|
for attempt := range anonymiseUserAttempts {
|
|
name := fmt.Sprintf("[deleted-%d]", userID)
|
|
if attempt > 0 {
|
|
suffix := make([]byte, 6)
|
|
if _, err := rand.Read(suffix); err != nil {
|
|
return fmt.Errorf("DeleteAccount anonymise suffix: %w", err)
|
|
}
|
|
name = fmt.Sprintf("[deleted-%d-%s]", userID, hex.EncodeToString(suffix))
|
|
}
|
|
_, lastErr = tx.ExecContext(ctx, anonymise, name, userID)
|
|
if lastErr == nil {
|
|
return nil
|
|
}
|
|
if !IsUniqueConstraintError(lastErr) {
|
|
return fmt.Errorf("DeleteAccount anonymise: %w", lastErr)
|
|
}
|
|
}
|
|
return fmt.Errorf("DeleteAccount anonymise: %w", lastErr)
|
|
}
|
|
|
|
// deleteAccountAdminGuard blocks the deletion when userID is the last
|
|
// remaining admin-class account, returning ErrLastAdmin.
|
|
func deleteAccountAdminGuard(ctx context.Context, tx *sql.Tx, userID int64) error {
|
|
// ── Guard: last admin/owner check ────────────────────────────────────
|
|
// Resolve admin-class roles by the canonical criteria — the seeded
|
|
// Owner/Admin role IDs plus any custom role holding the Administrator
|
|
// bypass bit. Names are user-editable (the Owner can rename the seeded
|
|
// Admin role), so a name lookup would silently disable the guard.
|
|
adminRows, err := tx.QueryContext(ctx,
|
|
`SELECT id FROM roles WHERE id IN (?, ?) OR (permissions & ?) != 0`,
|
|
permissions.OwnerRoleID, permissions.AdminRoleID, permissions.Administrator,
|
|
)
|
|
if err != nil {
|
|
return fmt.Errorf("DeleteAccount fetch admin roles: %w", err)
|
|
}
|
|
var adminRoleIDs []int64
|
|
for adminRows.Next() {
|
|
var rid int64
|
|
if scanErr := adminRows.Scan(&rid); scanErr != nil {
|
|
adminRows.Close() //nolint:errcheck
|
|
return fmt.Errorf("DeleteAccount scan admin role: %w", scanErr)
|
|
}
|
|
adminRoleIDs = append(adminRoleIDs, rid)
|
|
}
|
|
adminRows.Close() //nolint:errcheck
|
|
if adminRows.Err() != nil {
|
|
return fmt.Errorf("DeleteAccount admin roles rows: %w", adminRows.Err())
|
|
}
|
|
|
|
if len(adminRoleIDs) == 0 {
|
|
// No admin-class roles defined; skip the guard.
|
|
} else {
|
|
var userRoleID int64
|
|
if err := tx.QueryRowContext(ctx,
|
|
`SELECT role_id FROM users WHERE id = ?`, userID,
|
|
).Scan(&userRoleID); err != nil {
|
|
return fmt.Errorf("DeleteAccount fetch role: %w", err)
|
|
}
|
|
|
|
isAdminClass := slices.Contains(adminRoleIDs, userRoleID)
|
|
|
|
if isAdminClass {
|
|
// Build IN clause dynamically for the admin role IDs.
|
|
placeholders := make([]string, len(adminRoleIDs))
|
|
args := make([]any, 0, len(adminRoleIDs)+1)
|
|
for i, rid := range adminRoleIDs {
|
|
placeholders[i] = "?"
|
|
args = append(args, rid)
|
|
}
|
|
args = append(args, userID)
|
|
|
|
var adminCount int
|
|
if err := tx.QueryRowContext(ctx,
|
|
fmt.Sprintf(`SELECT COUNT(*) FROM users WHERE role_id IN (%s) AND id != ? AND banned = 0`,
|
|
strings.Join(placeholders, ",")),
|
|
args...,
|
|
).Scan(&adminCount); err != nil {
|
|
return fmt.Errorf("DeleteAccount count admins: %w", err)
|
|
}
|
|
if adminCount == 0 {
|
|
return ErrLastAdmin
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// deleteAccountDMChannels snapshots the DM channels the user takes part in,
|
|
// before the dm_participants purge removes the rows that name them.
|
|
func deleteAccountDMChannels(ctx context.Context, tx *sql.Tx, userID int64) ([]int64, error) {
|
|
// Snapshot the user's DM channels before the participant rows go away,
|
|
// so channels left with zero participants can be removed below —
|
|
// LeaveGroupDM's invariant: a participant-less DM channel is an
|
|
// unreachable, undeletable row.
|
|
var dmChannelIDs []int64
|
|
dmRows, err := tx.QueryContext(ctx,
|
|
`SELECT channel_id FROM dm_participants WHERE user_id = ?`, userID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("DeleteAccount list dm channels: %w", err)
|
|
}
|
|
for dmRows.Next() {
|
|
var chID int64
|
|
if scanErr := dmRows.Scan(&chID); scanErr != nil {
|
|
dmRows.Close() //nolint:errcheck
|
|
return nil, fmt.Errorf("DeleteAccount scan dm channel: %w", scanErr)
|
|
}
|
|
dmChannelIDs = append(dmChannelIDs, chID)
|
|
}
|
|
dmRows.Close() //nolint:errcheck
|
|
if dmRows.Err() != nil {
|
|
return nil, fmt.Errorf("DeleteAccount dm channels rows: %w", dmRows.Err())
|
|
}
|
|
return dmChannelIDs, nil
|
|
}
|
|
|
|
// deleteAccountCloseDMChannels closes, and where the purge emptied them,
|
|
// removes the DM channels snapshotted by deleteAccountDMChannels.
|
|
func deleteAccountCloseDMChannels(ctx context.Context, tx *sql.Tx, userID int64, dmChannelIDs []int64) error {
|
|
// Close and, where emptied, remove the deleted user's DM channels.
|
|
for _, chID := range dmChannelIDs {
|
|
var isGroup bool
|
|
if err := tx.QueryRowContext(ctx,
|
|
`SELECT is_group FROM channels WHERE id = ?`, chID,
|
|
).Scan(&isGroup); err != nil {
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
continue // channel already gone
|
|
}
|
|
return fmt.Errorf("DeleteAccount dm channel is_group: %w", err)
|
|
}
|
|
|
|
if !isGroup {
|
|
// The purge above removed only this user's dm_participants row, so
|
|
// a 1:1 DM with a live other side is untouched: its dm_participants
|
|
// row (and the channel) survive, but the survivor's own
|
|
// dm_open_state row does too. Left alone that renders as a
|
|
// sidebar entry with a blank, unnamed recipient (GetDMParticipantsForUser
|
|
// skips the viewer's own row and this user has none left to
|
|
// return) that the survivor can still open and send into. Closing
|
|
// it for them removes it from their sidebar, same as if they had
|
|
// closed it themselves.
|
|
if _, err := tx.ExecContext(ctx,
|
|
`DELETE FROM dm_open_state WHERE channel_id = ? AND user_id != ?`,
|
|
chID, userID,
|
|
); err != nil {
|
|
return fmt.Errorf("DeleteAccount close dm for survivor: %w", err)
|
|
}
|
|
}
|
|
|
|
// Hard-delete DM channels the deletion left with zero participants
|
|
// (always true for the last member of a group DM; true for a 1:1 DM
|
|
// only when the other side had already deleted their own account).
|
|
//
|
|
// Unlink attachments first: messages.channel_id and
|
|
// attachments.message_id both cascade ON DELETE (migrations/001), so
|
|
// deleting the channel row destroys the attachment rows too. Those
|
|
// rows are the only handle DeleteOrphanedAttachments (the periodic
|
|
// sweep in main.go) has on the uploaded files — once the cascade
|
|
// removes them the files are stranded on disk forever. Setting
|
|
// message_id to NULL first turns them into ordinary orphaned
|
|
// attachments the sweep already knows how to reclaim.
|
|
if _, err := tx.ExecContext(ctx,
|
|
`UPDATE attachments SET message_id = NULL
|
|
WHERE message_id IN (SELECT id FROM messages WHERE channel_id = ?)
|
|
AND EXISTS (
|
|
SELECT 1 FROM channels
|
|
WHERE channels.id = ? AND channels.type = 'dm'
|
|
AND NOT EXISTS (SELECT 1 FROM dm_participants WHERE channel_id = channels.id)
|
|
)`,
|
|
chID, chID,
|
|
); err != nil {
|
|
return fmt.Errorf("DeleteAccount unlink dm attachments: %w", err)
|
|
}
|
|
if _, err := tx.ExecContext(ctx,
|
|
`DELETE FROM channels WHERE id = ? AND type = 'dm'
|
|
AND NOT EXISTS (SELECT 1 FROM dm_participants WHERE channel_id = channels.id)`,
|
|
chID,
|
|
); err != nil {
|
|
return fmt.Errorf("DeleteAccount empty dm channel: %w", err)
|
|
}
|
|
}
|
|
return nil
|
|
}
|