mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
* refactor(ws): split handleVoiceJoin into cohesive join-stage helpers handleVoiceJoin was 130 statements / cyclomatic 59 / nestif 11, breaking all three complexity budgets at once. Split along the stage boundaries the doc comment already described: precheck, leave-current, persist, restore moderator flags, grant token, complete. The publish-permission derivation becomes its own helper because it is the one branch-heavy block inside the token grant. Pure move: every statement is preserved verbatim. The only edits are bare `return`s becoming the typed returns of their new helper, `c.userID` becoming the `userID` parameter inside voiceJoinPublishPerms, and voiceJoinComplete re-reading `ch.VoiceMaxUsers` instead of receiving it — `ch` is never mutated, so the value is identical. Verified by normalising both revisions of the region to sorted, comment- and whitespace-stripped statements and diffing: the only deltas are the ones listed above. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: collapse the three duplicated sibling pairs dupl flagged three pairs of adjacent near-identical functions. Each pair is now one parameterised implementation plus two thin, still-greppable wrappers. - ws/voice_controls.go: handleVoiceMuteV2 / handleVoiceDeafenV2 share voiceSelfToggleV2; handleVoiceCameraV2 / handleVoiceScreenshareV2 share voiceStreamToggleV2. Camera and screenshare drawing from one voice_max_video budget (OC-0023) was a bug caused by exactly this duplication drifting, so one body is the point, not a side effect. - db/mention_queries.go: ListMentionTargetsByRoles / ListMentionTargetsByUserIDs share listMentionTargets. The matched column is a closed named type (mentionTargetColumn) rather than a bare string, so the value interpolated into the SELECT cannot become caller-supplied. Behaviour is unchanged: every rate-limit key, error code, error string, slog message and slog key is preserved verbatim, including the two "failed to update <kind> state" messages, which are now assembled the same way enableVideoSlot already assembled them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(api): extract readEmojiUpload from handleCreateEmoji handleCreateEmoji was 101 lines against a 100-line budget. The upload-bytes stage — pull the file out of the parsed form, cap its size, sniff its MIME type and sniff its dimensions — is the one self-contained block in it, and it already wrote its own refusals, so it moves out whole as readEmojiUpload. The permission-before-parse ordering the doc comment calls out is unchanged; so is every error string. file.Close() now runs when the helper returns rather than when the handler does, which is strictly earlier and unobservable: the bytes are already copied into raw and nothing else touches the handle. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: extract one cohesive block from three single-budget offenders Each of these was over exactly one budget, so each gets exactly one extraction rather than a restructure: - api/totp_handler.go handleVerifyTOTP (102 lines / 100): the block that resolves the user behind the partial-auth challenge and decrypts their TOTP secret becomes totpChallengeSecret. The ban-inside-the-partial-window check moves with it. - service/message_reactions.go handleReaction (cyclop 21 / 20): the whole authorisation chain — channel lookup, archived gate, DM participant and block checks, non-DM permission check — becomes reactionAudience, which also returns the DM fan-out audience it already resolved. Check order is unchanged and load-bearing. - db/admin_queries.go BackupToSafe (cyclop 21 / 20): the character allowlist loop and the SQL-comment rejection become validateBackupPathChars. That loop alone was most of the branch count. No error string, no check and no ordering changed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(plugin): split InstallFromZip into staged install helpers 104 statements / cyclomatic 44 / nestif 12. Split along the stages the code already had: installZipExtract (the per-entry write loop, with installZipEntryDest holding the mode/symlink/zip-slip guard chain and installZipWriteEntry the size-capped copy), installZipStagedManifest, installZipPromote, and installZipReactivate for the :399 nested block. Every zip-slip, symlink, entry-mode and uncompressed-size check is preserved in the same order relative to the writes it guards. The 19 inline `cleanup(); return` sites collapse to 4 in the orchestrator, one per stage, because each helper now returns an error instead of unwinding itself — the staging directory is still removed on exactly the same set of failures. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(api): split newWAFMiddleware into engine build and per-phase helpers 184 lines / cyclomatic 38, and the request-body block at :382 was the worst nested site in the tree at nestif 17. Engine construction moves out of the closure (wafInlineEngine, wafCRSEngine — the Coraza directive string is lifted verbatim), and each request phase becomes its own helper: wafInlineRequestHeaders, wafCRSRequestHeaders (including the Host/Transfer-Encoding re-add for CRS 920280), wafFeedCRSBody and wafInspectRequestBody, which is the old :382 block. The three `handleWAFInterruption(w, it); return` sites inside the body block become one: the helper now returns the interruption and the orchestrator handles it. No statement runs between the two points on either side, so the verdict is honoured identically — in particular a CRS body interruption still returns without replacing r.Body. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(service): split SendMessage and lift EditMessage's access check SendMessage was 79 statements / cyclomatic 35 with an 11-deep nested attachment block at :101; EditMessage was one point over cyclop. SendMessage becomes sendMessagePrecheck (permission and DM-block gates, content sanitisation), sendMessageLinkAttachments (the :101 block: attachment ownership, claim and link) and sendMessageDMSideEffects. EditMessage gets editMessageCheckAccess and nothing else — one budget over earns one extraction. The sanitizeContent fixpoint and the attachment ownership check are unchanged, as is the order of every gate. The DM side effects run behind `isDM && !s.sendMessageDMSideEffects(...)`, so a non-DM never enters them; inside, only the GetDMParticipantIDs failure returns false, matching the one error the original early-returned on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(admin): split handlePatchUser into per-field apply helpers 106 lines / cyclomatic 29, with the ban block at :154 nested 9 deep. Each optional field of the partial edit becomes its own helper — patchUserPrecheck, patchUserAuthorizeRole, patchUserApplyBan (the :154 block, including the session disconnect and the broadcast) and patchUserApplyRole. Each returns a bool meaning "keep going"; none of them writes a success response, so the single response site in the orchestrator is unchanged. Field application order, the permission-cache invalidation on a role change and the disconnect-and-broadcast on a ban are all preserved, as are the three fail-closed `mod == nil` guards, which now sit at the top of their own helper and still fire on exactly the same conditions. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(admin): split handleSetup into first-run setup stages 143 lines / cyclomatic 30, with the optional-wizard block at :219 sitting exactly on the nestif threshold. Split into the stages the endpoint already had: request gating (rate limit and origin check, which run before any auth exists on a fresh server), owner account creation, and the wizard application that was the :219 block. Every gate in front of the handler is a security control on an unauthenticated endpoint; none moved relative to the work it protects. setup_wizard.go is untouched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: split run() into named bootstrap and shutdown steps 131 statements / cyclomatic 57, with the executable-path fallback at :126 nested 9 deep. The five anonymous `defer func(){...}()` blocks become named functions — telemetryStop, runClosePlugins, runStopEventPersistence, runStopAuditWriter, maintenanceStop — and the bootstrap stages move out likewise. Every defer is still registered in run() itself, at the same point in the sequence, so the LIFO teardown order is unchanged; that order is documented in the surrounding comments and is load-bearing (the audit-writer stop must follow database.Close's registration, the event-persistence stop must precede it). runStopEventPersistence is now registered unconditionally with a nil persister meaning "disabled", where the old code registered its defer inside the enabled branch — a no-op occupying that slot cannot change the relative order of the others. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(ws): split handleReconnect into resume stages 77 statements / cyclomatic 41, plus the replay block at :199 and, in handleFreshConnect, the voice-state restore at :622. handleReconnect becomes reconnectPrecheck, reconnectSelectReplay (with reconnectVetColdTail for the cold-tier gap check), reconnectRegister and reconnectWriteReplay. handleFreshConnect's stale-voice cleanup moves to its own helper, where the `if h.livekit != nil` wrapper becomes a guard clause — that block was the tail of its scope, so returning early and falling off the end are the same. The parts that carry the invariants are moved verbatim: reconnectRegister still takes h.seqMu, still calls registerNow inside that same critical section (BUG-123 / OC-0206), still unlocks on every exit, and still emits the "full" tier counter and telemetry on each of its three re-check failures. handleReconnect's two-boolean contract is unchanged — the collapsed `return false, false` sites are all fall-through-to-full-ready, and the single `return true, false` is still the handshake-write-failure path whose teardown already ran (OC-0051). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs(server): fold in the adversarial review of the complexity refactors Eleven skeptic passes over the refactor commits on this branch found no blocker and no major — behaviour is preserved throughout. They did find comment and accuracy defects worth correcting: - db/mention_queries.go: the mentionTargetColumn rationale claimed the named type made the interpolated column "only ever one of the two constants". A Go named type is not closed, so that is a convention the type makes visible, not one it enforces. Reworded, gosec justification included. - ws/voice_controls.go: the dupl collapse generalised away three specifics — that a server deafen is the moderator's to lift (now on the serverDeafen field), the concrete voice_states.camera / voice_states.screenshare column names, and the half of the OC-0023 rationale about neither stream kind hiding from the other's count. All three restored. - ws/voice_join.go: `maxUsers := ch.VoiceMaxUsers` had been hoisted to the top of voiceJoinComplete, moving a read across the tail supersession guard. The read is inert, but it was the one statement in that commit whose position relative to a security guard changed; it now sits at its use, as before. - ws/*_test.go: three test comments cited voice_join.go line numbers that the split invalidated. They now cite the helper by name instead. - service/message_reactions.go: reactionAudience's doc claimed to enforce "every gate on reacting"; it enforces the channel-scoped ones, and the doc now says which gates stay with the caller. - api/emoji_handler.go: the readEmojiUpload call reused the outer `ok` from the auth check by assignment; it gets its own readOK. - admin/setup_handler.go: a moved comment kept a "the response above" deictic that no longer had a response above it. No behaviour change. Build, vet, full tests and -race on five packages green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(ws): clear the remaining complexity budgets across the hub Eight files, thirteen findings. Each function is split at the stages it already had; no branch is reordered, merged or inverted. - handlers.go handleMessage (cyclop 28, 88 stmts): session re-check, frame decode and result application become handleMessageSessionRecheck, handleMessageDecode and handleMessageApply. The V2 constructor lookup -> DispatchV2 -> Result resolution order is untouched. - serve_ready.go buildReady (cyclop 26, 61 stmts): the per-section fetches split out, readyChannelPayloads among them. Every visibility predicate is preserved verbatim — this is the payload that decides what a client may see. - serve_pumps.go writePump (cyclop 31): writePumpWrite, writePumpDeliver, writePumpDrainChannel and writePumpDrainAndClose. Every channel receive stays in the same select statement, so scheduling is unchanged. - hub_sweep.go sweepStaleVoiceStates (cyclop 22, 56 stmts): the staleness predicate, the hub-lock ordering and the position of the race hook are all as they were — handleVoiceJoin's BUG-088 ordering depends on them. - hub_broadcast.go channelReadAudienceImpl and RefreshChannelVisibility (cyclop 22 each, 57 stmts): channelReadAudienceDM and refreshChannelVisibilityCanSend. The audience predicate is the OC-0090 group-DM leak surface, so it is extracted, never simplified. - livekit_webhook.go (nestif 13 and 14): webhookJoinedEnforceVoiceState, webhookLeftCleanupClient and webhookLeftFinishLeave. DB delete still precedes broadcast on every path. - livekit_download.go EnsureLiveKitBinary (52 stmts): one extraction, ensureLiveKitStageBinary, keeping every archive path check intact. - voice_moderation.go (nestif 8): voiceModDeafenRollback. The persisted server_muted flag remains the authority. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(api): clear the remaining complexity budgets across the HTTP layer - router.go NewRouter (cyclop 28, 84 stmts): split by wiring concern into routerTOTPKey, routerHealthDeps, routerMiddleware, routerUploadRoutes, routerPluginWiring, routerVoiceRoutes and routerMetricsRoutes. Middleware ORDER is a security property (auth before handler, WAF before body parse, rate limit before work) and is unchanged; the returned cleanup func still closes over and releases everything it did before. - auth_handler.go handleRegister (133 lines) and handleLogin (cyclop 21, 152 lines): registerPolicyGate, registerReadRequest, loginReadRequest and loginAuthenticate. The always-compare posture, every rate-limit key, every counter reset and the ban-check-versus-password-compare order are all preserved — including loginUserFailureThreshold staying unscaled by scaledAuthLimit, which is deliberate and commented. - upload_handler.go handleServeFile (cyclop 31, 128 lines): serveFileResolve and serveFileAuthorize. Every header this sets — Content-Disposition included, which is what stops a stored file being served as active content — is still set with the same value in the same circumstances. - profile_handler.go handleUploadAvatar (120 lines): avatarUploadReadImage, mirroring readEmojiUpload in shape but with the avatar caps and MIME set. The two deliberately do not share a helper. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: clear the last complexity budgets in db and admin - db/account.go DeleteAccount (cyclop 28, 55 stmts): grouped by subsystem into deleteAccountAdminGuard, deleteAccountDMChannels and deleteAccountCloseDMChannels, each taking the same transaction. The transaction boundary, the delete ORDER (which foreign keys depend on) and the rollback path are unchanged. - admin/logstream.go handleLogStream (cyclop 24): logStreamAuthorize. Flush cadence, heartbeat and disconnect detection untouched. - admin/setup_wizard.go validateWizard (cyclop 23): grouped by section into wizardValidateIdentity, wizardValidateNetwork and wizardValidateMedia. Every message and bound is unchanged — this is the first input-validation boundary on a fresh server, before any auth exists. With this the tree is at zero: golangci-lint run reports 0 issues against the budgets set in #1384 (funlen 100/50, cyclop 20, nestif 8, dupl 150), with no //nolint and no exclusion added anywhere. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
414 lines
17 KiB
Go
414 lines
17 KiB
Go
package db
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"fmt"
|
|
"strings"
|
|
)
|
|
|
|
// mentionExecer is the subset of *sql.Tx insertMentionRows needs, so the same
|
|
// row-writing loop serves both the insert and the edit transaction.
|
|
type mentionExecer interface {
|
|
ExecContext(ctx context.Context, query string, args ...any) (sql.Result, error)
|
|
}
|
|
|
|
// maxMentionsPerMessage bounds how many resolved mentions a single message may
|
|
// store. The service caps its resolution at the same number; this is the
|
|
// storage-side backstop so a caller cannot widen the fan-out.
|
|
const maxMentionsPerMessage = 20
|
|
|
|
// notBannedClause is the mention resolution's "is this user reachable" test.
|
|
// A raw `banned = 0` reads a temp-banned user as unreachable forever: nothing
|
|
// clears the column when ban_expires lapses (that happens lazily, at login,
|
|
// via auth.IsEffectivelyBanned — see db/account.go's anonymiseUser comment on
|
|
// the same split), so a reinstated user could log in and post yet never
|
|
// resolve as an @mention target or appear in an @everyone/@here fan-out. This
|
|
// mirrors IsEffectivelyBanned's own rule (permanent when ban_expires is NULL,
|
|
// lapsed once ban_expires is in the past) so the two never disagree.
|
|
//
|
|
// The comparison is lexical, so the two ban_expires spellings
|
|
// IsEffectivelyBanned accepts must both sort correctly against the reference
|
|
// string. BanUser writes ISO-8601 'Z' ("2006-01-02T15:04:05Z"), but the
|
|
// SQLite space form ("2006-01-02 15:04:05") is equally accepted there and
|
|
// test-locked (auth/helpers_test.go), and a bare ' ' sorts BELOW 'T' — so an
|
|
// unnormalised space-form expiry later on the same day would compare as
|
|
// already lapsed and fail OPEN, un-hiding a genuinely banned user. replace()
|
|
// normalises the separator first; the trailing 'Z' only ever makes the
|
|
// reference string longer at an equal instant, which the `<=` already treats
|
|
// as lapsed. Those two are the only spellings any writer produces.
|
|
const notBannedClause = `(banned = 0 OR (ban_expires IS NOT NULL AND replace(ban_expires, ' ', 'T') <= strftime('%Y-%m-%dT%H:%M:%SZ', 'now')))`
|
|
|
|
// MentionTarget is a candidate recipient of a mention fan-out: the user id, the
|
|
// presence status @here filters on, and the role the user holds (so the caller
|
|
// can apply the ADMINISTRATOR bypass when a per-user channel override would
|
|
// otherwise drop them).
|
|
type MentionTarget struct {
|
|
UserID int64
|
|
Status string
|
|
RoleID int64
|
|
}
|
|
|
|
// CreateMessageWithMentions inserts a message and its resolved mentions in one
|
|
// writer transaction, so a reader can never observe a message whose mention set
|
|
// is still half-written. mentionedUserIDs is truncated to
|
|
// maxMentionsPerMessage and duplicates are ignored.
|
|
func (d *DB) CreateMessageWithMentions(ctx context.Context, channelID, userID int64, content string, replyTo *int64, mentionedUserIDs []int64, mentionsEveryone bool) (*Message, error) {
|
|
tx, err := d.writer.BeginTx(ctx, nil)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("CreateMessageWithMentions begin tx: %w", err)
|
|
}
|
|
defer tx.Rollback() //nolint:errcheck
|
|
|
|
var m Message
|
|
var deleted, pinned, everyone int64
|
|
if scanErr := tx.QueryRowContext(ctx,
|
|
`INSERT INTO messages (channel_id, user_id, content, reply_to, mentions_everyone)
|
|
VALUES (?, ?, ?, ?, ?)
|
|
RETURNING id, channel_id, user_id, content, reply_to, edited_at, deleted, pinned,
|
|
timestamp, mentions_everyone`,
|
|
channelID, userID, content, replyTo, b2i64(mentionsEveryone),
|
|
).Scan(&m.ID, &m.ChannelID, &m.UserID, &m.Content, &m.ReplyTo, &m.EditedAt,
|
|
&deleted, &pinned, &m.Timestamp, &everyone); scanErr != nil {
|
|
return nil, fmt.Errorf("CreateMessageWithMentions insert: %w", scanErr)
|
|
}
|
|
m.Deleted = deleted != 0
|
|
m.Pinned = pinned != 0
|
|
m.MentionsEveryone = everyone != 0
|
|
|
|
if err := insertMentionRows(ctx, tx, m.ID, mentionedUserIDs); err != nil {
|
|
return nil, err
|
|
}
|
|
if err := tx.Commit(); err != nil {
|
|
return nil, fmt.Errorf("CreateMessageWithMentions commit: %w", err)
|
|
}
|
|
return &m, nil
|
|
}
|
|
|
|
// ReplaceMessageMentions rewrites a message's mention set and its
|
|
// mentions_everyone flag in one writer transaction. Used by edits, which
|
|
// re-resolve mentions from the new content.
|
|
func (d *DB) ReplaceMessageMentions(ctx context.Context, messageID int64, mentionedUserIDs []int64, mentionsEveryone bool) error {
|
|
tx, err := d.writer.BeginTx(ctx, nil)
|
|
if err != nil {
|
|
return fmt.Errorf("ReplaceMessageMentions begin tx: %w", err)
|
|
}
|
|
defer tx.Rollback() //nolint:errcheck
|
|
|
|
if _, err := tx.ExecContext(ctx, `DELETE FROM message_mentions WHERE message_id = ?`, messageID); err != nil {
|
|
return fmt.Errorf("ReplaceMessageMentions delete: %w", err)
|
|
}
|
|
// Guarded so an edit that does not change the flag skips the write — an
|
|
// UPDATE on messages re-indexes the row through the messages_fts triggers.
|
|
if _, err := tx.ExecContext(ctx,
|
|
`UPDATE messages SET mentions_everyone = ? WHERE id = ? AND mentions_everyone != ?`,
|
|
b2i64(mentionsEveryone), messageID, b2i64(mentionsEveryone),
|
|
); err != nil {
|
|
return fmt.Errorf("ReplaceMessageMentions flag: %w", err)
|
|
}
|
|
if err := insertMentionRows(ctx, tx, messageID, mentionedUserIDs); err != nil {
|
|
return err
|
|
}
|
|
if err := tx.Commit(); err != nil {
|
|
return fmt.Errorf("ReplaceMessageMentions commit: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// insertMentionRows writes the mention rows for one message inside tx.
|
|
// Self-mentions are stored like any other: the fan-out, not storage, is what
|
|
// excludes the author.
|
|
func insertMentionRows(ctx context.Context, tx mentionExecer, messageID int64, mentionedUserIDs []int64) error {
|
|
if len(mentionedUserIDs) > maxMentionsPerMessage {
|
|
mentionedUserIDs = mentionedUserIDs[:maxMentionsPerMessage]
|
|
}
|
|
for _, uid := range mentionedUserIDs {
|
|
if _, err := tx.ExecContext(ctx,
|
|
`INSERT OR IGNORE INTO message_mentions (message_id, mentioned_user_id) VALUES (?, ?)`,
|
|
messageID, uid,
|
|
); err != nil {
|
|
return fmt.Errorf("insertMentionRows: %w", err)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// GetMentionsByMessageIDs returns the mentioned user ids per message id.
|
|
// Messages with no mentions are absent from the map.
|
|
func (d *DB) GetMentionsByMessageIDs(ctx context.Context, msgIDs []int64) (map[int64][]int64, error) {
|
|
result := make(map[int64][]int64)
|
|
if len(msgIDs) == 0 {
|
|
return result, nil
|
|
}
|
|
|
|
placeholders := make([]string, len(msgIDs))
|
|
args := make([]any, len(msgIDs))
|
|
for i, id := range msgIDs {
|
|
placeholders[i] = "?"
|
|
args[i] = id
|
|
}
|
|
|
|
rows, err := d.reader.QueryContext(ctx,
|
|
fmt.Sprintf( //nolint:gosec // G201: placeholder interpolation, not user input
|
|
`SELECT message_id, mentioned_user_id FROM message_mentions
|
|
WHERE message_id IN (%s) ORDER BY message_id, mentioned_user_id`,
|
|
strings.Join(placeholders, ",")),
|
|
args...,
|
|
)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("GetMentionsByMessageIDs: %w", err)
|
|
}
|
|
defer rows.Close() //nolint:errcheck
|
|
|
|
for rows.Next() {
|
|
var msgID, userID int64
|
|
if scanErr := rows.Scan(&msgID, &userID); scanErr != nil {
|
|
return nil, fmt.Errorf("GetMentionsByMessageIDs scan: %w", scanErr)
|
|
}
|
|
result[msgID] = append(result[msgID], userID)
|
|
}
|
|
if rows.Err() != nil {
|
|
return nil, fmt.Errorf("GetMentionsByMessageIDs rows: %w", rows.Err())
|
|
}
|
|
return result, nil
|
|
}
|
|
|
|
// mentionCountChunkSize bounds how many recipients IncrementMentionCounts
|
|
// upserts in a single multi-row INSERT, keeping the per-exec bound-parameter
|
|
// count (2 per row) far below SQLite's limit. Mirrors the IN-list chunking in
|
|
// GetSessionsWithBanStatusBatch.
|
|
const mentionCountChunkSize = 500
|
|
|
|
// IncrementMentionCounts bumps read_states.mention_count by one for each user
|
|
// in a channel, creating the read-state row when the user has none yet.
|
|
// last_message_id stays 0 for a created row: the user has read nothing, and the
|
|
// mention they were just given is unread by definition.
|
|
//
|
|
// msgID is the id of the message that triggered this fan-out. The increment
|
|
// is skipped for a recipient whose read state already covers msgID
|
|
// (last_message_id >= msgID): a mark_read that lands between the message
|
|
// commit and this deferred call already zeroed their mention_count, and an
|
|
// unconditional increment would leave a permanent phantom badge on a channel
|
|
// with zero unread — nothing else ever zeroes it again. The guard is atomic
|
|
// with the increment itself (part of the same ON CONFLICT ... DO UPDATE ...
|
|
// WHERE), so there is no separate check-then-write race window.
|
|
//
|
|
// Batched into one multi-row INSERT per chunk of mentionCountChunkSize
|
|
// recipients instead of one exec per recipient: an @everyone mention fans out
|
|
// to every reader of a channel, and the writer txn used to pay one round trip
|
|
// per reader for that. The caller has already excluded the author, so
|
|
// semantics are unchanged — each listed user id still gets exactly one
|
|
// increment (or a fresh row seeded at 1), unless the guard above skips it.
|
|
func (d *DB) IncrementMentionCounts(ctx context.Context, channelID, msgID int64, userIDs []int64) error {
|
|
if len(userIDs) == 0 {
|
|
return nil
|
|
}
|
|
tx, err := d.writer.BeginTx(ctx, nil)
|
|
if err != nil {
|
|
return fmt.Errorf("IncrementMentionCounts begin tx: %w", err)
|
|
}
|
|
defer tx.Rollback() //nolint:errcheck
|
|
|
|
for start := 0; start < len(userIDs); start += mentionCountChunkSize {
|
|
chunk := userIDs[start:min(start+mentionCountChunkSize, len(userIDs))]
|
|
|
|
rowPlaceholders := make([]string, len(chunk))
|
|
args := make([]any, 0, len(chunk)*2)
|
|
for i, uid := range chunk {
|
|
rowPlaceholders[i] = "(?, ?, 0, 1)"
|
|
args = append(args, uid, channelID)
|
|
}
|
|
// msgID is a bound parameter of the WHERE clause, not a VALUES column:
|
|
// every conflicting row in this chunk shares the one message that
|
|
// triggered the fan-out, so one trailing arg covers the whole batch.
|
|
args = append(args, msgID)
|
|
|
|
query := fmt.Sprintf( //nolint:gosec // G201: placeholder interpolation, not user input
|
|
`INSERT INTO read_states (user_id, channel_id, last_message_id, mention_count)
|
|
VALUES %s
|
|
ON CONFLICT(user_id, channel_id) DO UPDATE SET
|
|
mention_count = mention_count + 1
|
|
WHERE read_states.last_message_id < ?`,
|
|
strings.Join(rowPlaceholders, ","),
|
|
)
|
|
if _, err := tx.ExecContext(ctx, query, args...); err != nil {
|
|
return fmt.Errorf("IncrementMentionCounts: %w", err)
|
|
}
|
|
}
|
|
if err := tx.Commit(); err != nil {
|
|
return fmt.Errorf("IncrementMentionCounts commit: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// GetMentionCount returns the unread mention count for a user in a channel.
|
|
func (d *DB) GetMentionCount(ctx context.Context, userID, channelID int64) (int, error) {
|
|
var count int
|
|
err := d.reader.QueryRowContext(ctx,
|
|
`SELECT COALESCE((SELECT mention_count FROM read_states
|
|
WHERE user_id = ? AND channel_id = ?), 0)`,
|
|
userID, channelID,
|
|
).Scan(&count)
|
|
if err != nil {
|
|
return 0, fmt.Errorf("GetMentionCount: %w", err)
|
|
}
|
|
return count, nil
|
|
}
|
|
|
|
// LowerASCII lowercases only ASCII letters ('A'-'Z'), matching the fold
|
|
// SQLite's COLLATE NOCASE applies to users.username (see notBannedClause's
|
|
// sibling comment above and the migration that declares the column). Go's
|
|
// strings.ToLower is Unicode-aware and would fold a non-ASCII uppercase
|
|
// letter (e.g. 'É' -> 'é') that NOCASE does not touch, desyncing a Go-side
|
|
// lookup key from a query bound against the same column. Every mention
|
|
// lookup that builds a key or a query argument from a username must fold
|
|
// through this instead of strings.ToLower, or the two folds silently
|
|
// disagree on any non-ASCII-uppercase username.
|
|
func LowerASCII(s string) string {
|
|
b := []byte(s)
|
|
for i, c := range b {
|
|
if c >= 'A' && c <= 'Z' {
|
|
b[i] = c + ('a' - 'A')
|
|
}
|
|
}
|
|
return string(b)
|
|
}
|
|
|
|
// GetUserIDsByUsernames resolves usernames to ids, keyed by the ASCII-lowered
|
|
// username (see LowerASCII). Matching is case-insensitive because
|
|
// users.username is UNIQUE COLLATE NOCASE, which makes the column's
|
|
// comparisons case-insensitive too -- but ASCII-only, which is why the map
|
|
// key folds no harder than that.
|
|
func (d *DB) GetUserIDsByUsernames(ctx context.Context, usernames []string) (map[string]int64, error) {
|
|
result := make(map[string]int64)
|
|
if len(usernames) == 0 {
|
|
return result, nil
|
|
}
|
|
|
|
placeholders := make([]string, len(usernames))
|
|
args := make([]any, len(usernames))
|
|
for i, name := range usernames {
|
|
placeholders[i] = "?"
|
|
args[i] = name
|
|
}
|
|
|
|
rows, err := d.reader.QueryContext(ctx,
|
|
fmt.Sprintf( //nolint:gosec // G201: placeholder interpolation, not user input
|
|
`SELECT id, username FROM users WHERE %s AND username IN (%s)`,
|
|
notBannedClause, strings.Join(placeholders, ",")),
|
|
args...,
|
|
)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("GetUserIDsByUsernames: %w", err)
|
|
}
|
|
defer rows.Close() //nolint:errcheck
|
|
|
|
for rows.Next() {
|
|
var id int64
|
|
var name string
|
|
if scanErr := rows.Scan(&id, &name); scanErr != nil {
|
|
return nil, fmt.Errorf("GetUserIDsByUsernames scan: %w", scanErr)
|
|
}
|
|
result[LowerASCII(name)] = id
|
|
}
|
|
if rows.Err() != nil {
|
|
return nil, fmt.Errorf("GetUserIDsByUsernames rows: %w", rows.Err())
|
|
}
|
|
return result, nil
|
|
}
|
|
|
|
// mentionTargetColumn is the users column a mention-target lookup matches its
|
|
// id list against. It is a named type rather than a bare string so that every
|
|
// call site has to name one of the two constants below instead of passing an
|
|
// arbitrary string into the SELECT. Go named types are not closed, so this is
|
|
// a convention the type makes visible, not one it enforces: do not introduce a
|
|
// mentionTargetColumn(x) conversion from a runtime value.
|
|
type mentionTargetColumn string
|
|
|
|
const (
|
|
mentionTargetsByRole mentionTargetColumn = "role_id"
|
|
mentionTargetsByUser mentionTargetColumn = "id"
|
|
)
|
|
|
|
// listMentionTargets returns non-banned users whose column is in ids, with the
|
|
// presence status @here filters on. It is the shared body of
|
|
// ListMentionTargetsByRoles and ListMentionTargetsByUserIDs, which differ only
|
|
// in the column they match and the name they report in errors.
|
|
func (d *DB) listMentionTargets(ctx context.Context, column mentionTargetColumn, caller string, ids []int64) ([]MentionTarget, error) {
|
|
if len(ids) == 0 {
|
|
return []MentionTarget{}, nil
|
|
}
|
|
|
|
placeholders := make([]string, len(ids))
|
|
args := make([]any, len(ids))
|
|
for i, id := range ids {
|
|
placeholders[i] = "?"
|
|
args[i] = id
|
|
}
|
|
|
|
rows, err := d.reader.QueryContext(ctx,
|
|
fmt.Sprintf( //nolint:gosec // G201: placeholders plus a named-type column constant, not user input
|
|
`SELECT id, status, role_id FROM users WHERE %s AND %s IN (%s)`,
|
|
notBannedClause, string(column), strings.Join(placeholders, ",")),
|
|
args...,
|
|
)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("%s: %w", caller, err)
|
|
}
|
|
defer rows.Close() //nolint:errcheck
|
|
|
|
targets := []MentionTarget{}
|
|
for rows.Next() {
|
|
var t MentionTarget
|
|
if scanErr := rows.Scan(&t.UserID, &t.Status, &t.RoleID); scanErr != nil {
|
|
return nil, fmt.Errorf("%s scan: %w", caller, scanErr)
|
|
}
|
|
targets = append(targets, t)
|
|
}
|
|
if rows.Err() != nil {
|
|
return nil, fmt.Errorf("%s rows: %w", caller, rows.Err())
|
|
}
|
|
return targets, nil
|
|
}
|
|
|
|
// ListMentionTargetsByRoles returns non-banned users holding any of the given
|
|
// roles, with the presence status @here filters on.
|
|
func (d *DB) ListMentionTargetsByRoles(ctx context.Context, roleIDs []int64) ([]MentionTarget, error) {
|
|
return d.listMentionTargets(ctx, mentionTargetsByRole, "ListMentionTargetsByRoles", roleIDs)
|
|
}
|
|
|
|
// ListMentionTargetsByUserIDs returns non-banned users by explicit id, with the
|
|
// same fields ListMentionTargetsByRoles returns. It backs the additive half of
|
|
// the per-user channel override layer: a member whose user override ALLOWs
|
|
// READ_MESSAGES can read a channel their role cannot, so the role walk alone
|
|
// would leave them out of an @everyone fan-out they are entitled to.
|
|
func (d *DB) ListMentionTargetsByUserIDs(ctx context.Context, userIDs []int64) ([]MentionTarget, error) {
|
|
return d.listMentionTargets(ctx, mentionTargetsByUser, "ListMentionTargetsByUserIDs", userIDs)
|
|
}
|
|
|
|
// ListBlockersOf returns the ids of users who have blocked the given user.
|
|
// A mention from a blocked user must not raise the blocker's mention badge.
|
|
func (d *DB) ListBlockersOf(ctx context.Context, blockedID int64) ([]int64, error) {
|
|
ids, err := d.q.ListBlockersOfUser(ctx, blockedID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("ListBlockersOf: %w", err)
|
|
}
|
|
return ids, nil
|
|
}
|
|
|
|
// GetChannelOverrides returns every role override on a channel, keyed by role
|
|
// id. The per-role reverse (GetAllChannelPermissionsForRole) backs the
|
|
// per-user permission cache; this direction backs the @everyone fan-out, which
|
|
// needs every role's verdict on one channel.
|
|
func (d *DB) GetChannelOverrides(ctx context.Context, channelID int64) (map[int64]ChannelOverride, error) {
|
|
rows, err := d.q.GetChannelOverrides(ctx, channelID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("GetChannelOverrides: %w", err)
|
|
}
|
|
result := make(map[int64]ChannelOverride, len(rows))
|
|
for _, r := range rows {
|
|
result[r.RoleID] = ChannelOverride{Allow: r.Allow, Deny: r.Deny}
|
|
}
|
|
return result, nil
|
|
}
|