Files
OwnCord/Server/admin/setup_handler_test.go
T
J3vbandClaude Fable 5 6afa9e974c refactor(server): thread context.Context through the db layer and all callers
Fixes all 109 golangci-lint findings (106 contextcheck, 1 gocritic,
2 gosec) that accumulated after D2 wired dbgen (whose queries take ctx)
under ctx-less db.DB wrappers while CI lint was quota-dead. No nolint
comments added; every finding fixed by genuinely threading context.

- db: all 138 hand-written db.DB methods take ctx first; the dbCtx()
  Background shim is deleted; raw Query/QueryRow/Exec/Begin use their
  Context variants; the four redundant ctx-less passthroughs removed.
  db.Auditor/WriteAudit gain ctx.
- Seams: permissions.Checker (DB iface, HasChannelPerm,
  RequireChannelAccess) and the service.Store interface mirror the new
  signatures (ws.EventStore and plugin.PluginStore already did).
- Callers: api/admin handlers use r.Context(); ws per-message paths use
  the connection ctx via DispatchV2; hub loops and startup wiring use
  context.Background(); service methods thread ctx where they have one
  and Background where no ctx exists. Public service surface reached by
  ctx-holding chains (PermissionService.HasChannelPerm/GetRoleForUser/
  RequireChannelAccess, message/dm/block/invite/profile methods) is now
  ctx-first.
- Detached (context.WithoutCancel) where cancellation would break an
  invariant, found by a 3-lens adversarial review of the diff:
  * voice-leave background retries (a dead webhook/connection ctx killed
    retry 2 before it ran, leaving ghost capacity-holding voice rows)
  * rollbackVoiceJoin's compensating delete (its trigger IS the cancel)
  * post-2FA-change DeleteOtherSessions and logout DeleteSession (the
    security tail of a committed change must not die with the request)
  * all api/ws audit writes (a banned user could suppress their own
    login_blocked_banned row by aborting the request mid-bcrypt)
  * admin backup VACUUM INTO (an interrupt left a truncated .db that
    the backup list presented as restorable)
  * post-commit message/edit refetches (a committed message must still
    fan out when the sender disconnects)
  * hub settings-cache refresh (one dead connection could pin stale
    values for the 30s TTL)
- gocritic rangeValCopy fixed (index iteration); gosec G306 excluded in
  config with justification (generated source must stay world-readable)
  instead of flipping genprotocol output to 0o600.

Verified: gofmt/vet, all four build-tag variants, full suite, deadlock
pass, full -race pass, golangci-lint 0 issues uncapped.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 17:03:52 +02:00

197 lines
5.4 KiB
Go

package admin_test
import (
"context"
"encoding/json"
"fmt"
"net/http"
"testing"
"github.com/owncord/server/admin"
)
func TestSetupStatus_NeedsSetup(t *testing.T) {
database := openAdminTestDB(t)
handler := admin.NewAdminAPI(database, "1.0.0", nil, nil, nil, nil, nil, newTestModService(database))
rr := doRequest(t, handler, "GET", "/setup/status", "", nil)
if rr.Code != http.StatusOK {
t.Fatalf("GET /setup/status = %d, want 200", rr.Code)
}
var resp struct {
NeedsSetup bool `json:"needs_setup"`
}
if err := json.Unmarshal(rr.Body.Bytes(), &resp); err != nil {
t.Fatalf("unmarshal: %v", err)
}
if !resp.NeedsSetup {
t.Error("needs_setup = false, want true (no users)")
}
}
func TestSetupStatus_NoSetupNeeded(t *testing.T) {
database := openAdminTestDB(t)
createAdminUser(t, database) // Create a user first
handler := admin.NewAdminAPI(database, "1.0.0", nil, nil, nil, nil, nil, newTestModService(database))
rr := doRequest(t, handler, "GET", "/setup/status", "", nil)
if rr.Code != http.StatusOK {
t.Fatalf("GET /setup/status = %d, want 200", rr.Code)
}
var resp struct {
NeedsSetup bool `json:"needs_setup"`
}
if err := json.Unmarshal(rr.Body.Bytes(), &resp); err != nil {
t.Fatalf("unmarshal: %v", err)
}
if resp.NeedsSetup {
t.Error("needs_setup = true, want false (user exists)")
}
}
func TestSetup_CreatesOwner(t *testing.T) {
database := openAdminTestDB(t)
handler := admin.NewAdminAPI(database, "1.0.0", nil, nil, nil, nil, nil, newTestModService(database))
rr := doRequest(t, handler, "POST", "/setup", "", map[string]string{
"username": "myadmin",
"password": "SecurePass123!",
})
if rr.Code != http.StatusCreated {
t.Fatalf("POST /setup = %d, want 201; body=%s", rr.Code, rr.Body.String())
}
var resp struct {
Token string `json:"token"`
UserID int64 `json:"user_id"`
Username string `json:"username"`
InviteCode string `json:"invite_code"`
}
if err := json.Unmarshal(rr.Body.Bytes(), &resp); err != nil {
t.Fatalf("unmarshal: %v", err)
}
if resp.Token == "" {
t.Error("token is empty")
}
if resp.Username != "myadmin" {
t.Errorf("username = %q, want %q", resp.Username, "myadmin")
}
if resp.InviteCode == "" {
t.Error("invite_code is empty")
}
if resp.UserID == 0 {
t.Error("user_id is 0")
}
// Verify user was created with Owner role.
user, err := database.GetUserByUsername(context.Background(), "myadmin")
if err != nil || user == nil {
t.Fatal("user not found in database after setup")
}
if user.RoleID != 1 {
t.Errorf("role_id = %d, want 1 (Owner)", user.RoleID)
}
}
func TestSetup_BlockedAfterFirstUser(t *testing.T) {
database := openAdminTestDB(t)
handler := admin.NewAdminAPI(database, "1.0.0", nil, nil, nil, nil, nil, newTestModService(database))
// First setup succeeds.
rr := doRequest(t, handler, "POST", "/setup", "", map[string]string{
"username": "owner1",
"password": "SecurePass123!",
})
if rr.Code != http.StatusCreated {
t.Fatalf("first setup = %d, want 201; body=%s", rr.Code, rr.Body.String())
}
// Second setup is blocked.
rr2 := doRequest(t, handler, "POST", "/setup", "", map[string]string{
"username": "hacker",
"password": "EvilPass456!",
})
if rr2.Code != http.StatusForbidden {
t.Errorf("second setup = %d, want 403", rr2.Code)
}
}
func TestSetup_WeakPassword(t *testing.T) {
database := openAdminTestDB(t)
handler := admin.NewAdminAPI(database, "1.0.0", nil, nil, nil, nil, nil, newTestModService(database))
rr := doRequest(t, handler, "POST", "/setup", "", map[string]string{
"username": "admin",
"password": "short",
})
if rr.Code != http.StatusBadRequest {
t.Errorf("weak password = %d, want 400; body=%s", rr.Code, rr.Body.String())
}
}
func TestSetup_MissingFields(t *testing.T) {
database := openAdminTestDB(t)
handler := admin.NewAdminAPI(database, "1.0.0", nil, nil, nil, nil, nil, newTestModService(database))
rr := doRequest(t, handler, "POST", "/setup", "", map[string]string{
"username": "",
"password": "",
})
if rr.Code != http.StatusBadRequest {
t.Errorf("missing fields = %d, want 400", rr.Code)
}
}
// TestSetup_ConcurrentRace fires many parallel setup requests at a fresh
// server and asserts that exactly one owner is created (BUG-119).
func TestSetup_ConcurrentRace(t *testing.T) {
database := openAdminTestDB(t)
handler := admin.NewAdminAPI(database, "1.0.0", nil, nil, nil, nil, nil, newTestModService(database))
const goroutines = 20
results := make(chan int, goroutines)
// Launch goroutines simultaneously.
start := make(chan struct{})
for i := 0; i < goroutines; i++ {
go func(n int) {
<-start // wait for the gate
rr := doRequest(t, handler, "POST", "/setup", "", map[string]string{
"username": fmt.Sprintf("owner%d", n),
"password": "SecurePass123!",
})
results <- rr.Code
}(i)
}
close(start) // release all goroutines at once
created := 0
for i := 0; i < goroutines; i++ {
code := <-results
switch code {
case http.StatusCreated:
created++
case http.StatusForbidden, http.StatusTooManyRequests:
// expected for losers (already set up or rate-limited)
default:
t.Errorf("unexpected status %d", code)
}
}
if created != 1 {
t.Errorf("expected exactly 1 owner created, got %d", created)
}
// Verify only one user exists in the database.
count, err := database.UserCount(context.Background())
if err != nil {
t.Fatalf("UserCount: %v", err)
}
if count != 1 {
t.Errorf("user count = %d, want 1", count)
}
}