Files
OwnCord/Server/admin/handlers_channel_perms.go
T
J3vbandClaude 5202e3fe1e fix: correctness fixes from the 2026-08-20 bug hunt (#1398)
* fix(identity): 2 defect(s) (OC-0192, OC-0197)

OC-0192: bound raw display_name/about/avatar bytes before the quadratic
fixpoint sanitizer runs, in both the REST handler and UserService.UpdateProfile.

OC-0197: sanitize display_name before validateDisplayName so an
HTML-entity-encoded bidi override (e.g. "‮") can no longer pass
validation as ASCII and be decoded into the real character on the way to
storage.

* fix(ws): 1 defect(s) (OC-0196)

A transient DB error during WebSocket auth (session or user lookup) was
collapsed into the terminal auth_error frame, which the client treats as
non-recoverable: it stops reconnecting and clears stored credentials. A
sub-second SQLite hiccup therefore force-logged-out every reconnecting
client with a perfectly valid session. Send a non-terminal INTERNAL error
frame instead so normal backoff/reconnect retries.

* fix(api): 1 defect(s) (OC-0198)

* fix(ws): 1 defect(s) (OC-0200)

normalizeHostForCertCompare now unwraps a bracketed IPv6 literal after the
trailing-":443" strip and before lowercasing, matching tofu::cert_store_key's
normalization order. Without the unwrap, every cert-tofu host equality guard
took the "unrelated host" branch for bracketed-IPv6 servers.

* fix(api): 1 defect(s) (OC-0202)

* fix(admin): 1 defect(s) (OC-0203)

Channel permission override handlers applied requireGrantableOverride only
to the bits being written, so an all-zero PUT or a DELETE could clear a
deny bit the actor's own role does not hold — EffectivePerms =
(rolePerm &^ deny) | allow makes removing a deny an escalation. Both the
role-layer and per-user handlers now check the guard against the bits
already on the row.

* fix(client): 1 defect(s) (OC-0205)

* fix(client): 3 defect(s) (OC-0207, OC-0227, OC-0235)

* fix(client): 1 defect(s) (OC-0208)

* fix(voice): 3 defect(s) (OC-0209, OC-0212, OC-0213)

OC-0209: reject a replayed retired-key announce before verifyPeerAnnounce
runs, so the replay cannot overwrite the peer's displayed verification
status/session fingerprint with the retired key's before being rejected.

OC-0212: buffer an announce blocked as a TOFU pin mismatch and replay it
after a successful rePinPeerIdentity, so re-pinning actually restores the
peer for the live call instead of clearing the badge and leaving them
un-keyed (a mid-call peer never re-announces on its own).

OC-0213: skip retiring a departing peer's key when the local voice roster
still lists them as present — a rejoin announce published straight into
the send queue can overtake the buffered, stale voice_leave, and retiring
a still-live key would reject every later genuine re-announce as a replay.

* fix(ws): 1 defect(s) (OC-0211)

* fix(identity): 1 defect(s) (OC-0214)

The delete-account admin guard counted remaining admins with a raw
`banned = 0` filter, so an admin whose temporary ban had already lapsed
was treated as unusable. Use the shared notBannedClause, appended outside
the Sprintf format string because its strftime verbs (%Y, %H) would
otherwise be parsed as fmt directives.

* fix(client): 1 defect(s) (OC-0215)

* fix(voice): 1 defect(s) (OC-0216)

* fix(client): 1 defect(s) (OC-0217)

* fix(voice): 1 defect(s) (OC-0219)

rollbackVoiceJoin cleared the client's in-memory voiceChID but left its
VoiceTopic subscription in place, so a socket whose join failed after
voiceJoinComplete's Subscribe kept receiving that room's E2EE relays for
the rest of the connection. Use clearVoiceAndUnsubscribe instead, matching
every other path that takes a client out of voice while its WS stays up.

* fix(client): 2 defect(s) (OC-0220, OC-0224)

dmDisplayName: a group DM whose other members have all left keeps a live
is_group row, but the server leaves `recipient` zero-valued, so the empty
username fell through as a blank label. Fall back to a non-empty placeholder.

updateDmLastMessage: a queued chat_message redelivered for an id already
reflected in the `ready` snapshot double-counted the unread badge. Only
increment when the message id advances past lastMessageId.

* fix(client): 1 defect(s) (OC-0221)

Cap queued attachments at the server's 10-attachment limit in the message
composer. Past that the server rejects the whole chat_send frame as a
generic parse error, orphaning already-uploaded attachments; refusing
before the upload starts keeps composer state and the send in sync.

* fix(ws): 1 defect(s) (OC-0222)

handleReconnect built the resume auth_ok before applyConnectStatus settled
c.user.Status, so a resumed client was told its disconnect-time status
(routinely "offline") instead of the status it was coming online as.
Move applyConnectStatus ahead of reconnectWriteReplay, matching
handleFreshConnect's ordering.

* fix(mentions): 1 defect(s) (OC-0223)

* fix(admin): 1 defect(s) (OC-0225)

* fix(client): 1 defect(s) (OC-0226)

* fix(client): 1 defect(s) (OC-0228)

* fix(client): 1 defect(s) (OC-0230)

Route the Logs tab entry counter through renderLogEntries so every render path (filter change, Clear, Refresh, live entry) keeps the count in sync with the list.

* fix(voice): 1 defect(s) (OC-0231)

* fix(client): 1 defect(s) (OC-0232)

Reduce Motion toggle wrote the reduced-motion class directly, fighting the
OS-sync media-query listener that owns it when Sync with OS is on. Route the
side effect through syncOsMotionListener so whichever source owns the class
re-derives it.

* fix(client): 1 defect(s) (OC-0233)

notifyIncomingMessage titled the desktop notification with the raw
payload username, so the popup named the sender differently from the
message row it points at. Resolve the author the same way the message
list does (resolveAuthor over the live membersStore, then
resolveDisplayName).

* fix(client): 1 defect(s) (OC-0234)

* fix(client): 1 defect(s) (OC-0236)

* fix(ws): 1 defect(s) (OC-0237)

* fix(client): 4 defect(s) (OC-0193, OC-0201, OC-0204, OC-0218)

* fix(identity): 1 defect(s) (OC-0195)

Bound free-text profile fields by raw byte length before cleanText's
quadratic sanitizeToFixpoint pass runs, generalizing OC-0192's guard into
cleanTextBounded and applying it to HandlePresenceUpdate's custom_status,
SetCustomStatus, and group DM names.

* fix(dm): 1 defect(s) (OC-0199)

handleCreateDM now broadcasts dm_channel_open to the recipient when a 1:1 DM is newly created, matching handleCreateGroupDM. GetOrCreateDMChannel pre-seeds dm_open_state for both users, so the recipient's later OpenDM reported opened=false and nothing ever told them the DM existed.

* fix(voice): 1 defect(s) (OC-0206)

vad-worklet.js gate timing constants were copied from the setTimeout
fallback's ~16ms poll cadence, but AudioWorkletProcessor.process() runs
once per 128-sample render quantum (~2.667ms at the 48kHz AudioContext).
The mic gate therefore closed ~6x faster than intended (~32ms of silence
instead of ~200ms), with the startup grace and RMS post interval off by
the same factor. Scale the frame counts to render quanta.

* fix(client): 1 defect(s) (OC-0229)

* test(client): assert the real TOFU re-pin outcome and make the pin mock faithful

The e2e journey test asserted that "Trust New Key" makes the peer's verify
badge disappear. That is the behaviour OC-0212 identifies as the defect: a
mid-call peer never re-announces, so clearing the badge left the peer
un-keyed for the rest of the call with nothing on screen. Re-pinning now
replays the announce that was blocked as a mismatch and re-verifies it
against the pin just stored, so assert the peer actually lands verified.

The mock's store_identity_pin was a no-op recorder while get_identity_pin
served a static seed map, so the replayed announce re-read the stale pin and
re-failed — a mismatch the real keyring never produces. Back the pins with a
mutable map so a write is visible to the next read. The unreadable-store
(DC-08) and reject-keeps-blocked paths are unchanged and still pass.

* fix(dm): 1 defect(s) (OC-0194)

Add regression tests pinning the raw-byte bound on group DM names, for
both CreateGroupDM and RenameGroupDM.

The Server/service/dm.go source fix for OC-0194 already landed in
bdbd5ac (fix(identity): 1 defect(s) (OC-0195)), which generalized the
guard into cleanTextBounded and applied it to the group DM name paths
alongside the profile fields. This commit therefore carries the OC-0194
tests only; dm.go is unchanged.

Revert-proof: with dm.go restored to bdbd5ac^ (cleanText before the
rune-count check) both new tests fail — CreateGroupDM returns "recipient
not found" after 222ms and RenameGroupDM accepts the name after 251ms,
against a 150ms budget. With the fix in place both pass in 0.03s.

* fix(ws): 1 defect(s) (OC-0210)

* chore(findings): record the 2026-08-20 hunt's 46 findings as fixed

Appends OC-0192..OC-0237 from the 2026-08-20 converging hunt and marks each
fixed with its commit and the test that pins it. Pre-existing records are
byte-identical; nextId moves 192 -> 238 so the next hunt cannot collide with
these ids.

Every fix was independently revert-proofed: the commit's own source diff is
reverse-applied, its test must go red, and must return green once restored.
43 of 46 carry revertProof "pass" from that mechanical run. Three could not be
checked at file level and were proved by hand at hunk level instead, recorded
as "pass (hand-proved)": OC-0200, whose ws.ts edit no longer reverse-applies
because the merge kept main's equivalent implementation; OC-0215, whose Rust
tests live in-file under #[cfg(test)]; and OC-0194, which stacks on a helper
introduced by an earlier commit. No fix was found to rest on a vacuous test.

OC-0200 additionally carries a note: main fixed that same normalizer
independently while this branch was in flight, so the branch is no longer the
only thing closing it.

* docs: record the dm_channel_open emission on 1:1 DM creation

POST /api/v1/dms now emits dm_channel_open to the recipient when it creates a
channel (it previously emitted nothing on that path), so api.md states it the
way the sibling DM endpoints already state theirs.

The channels/members/DMs UX spec claimed the server broadcast the event "to
both parties" on this flow. That was never true — nothing was broadcast before,
and now only the recipient is sent it; the creator learns the channel from the
response body. This doc lists dispatcher.ts, dm.store.ts, ChannelSidebar.ts,
service/channel.go and dm.go among its sources of truth, all touched here, so
it is corrected in the same change per its maintenance rule.

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-08-20 20:45:30 +02:00

468 lines
18 KiB
Go

package admin
import (
"context"
"encoding/json"
"fmt"
"log/slog"
"net/http"
"github.com/owncord/server/db"
"github.com/owncord/server/permissions"
)
// ─── Channel Permission Override Handlers ────────────────────────────────────
//
// These endpoints manage per-role allow/deny permission overrides on a
// channel (the channel_overrides table). Denying ReadMessages hides the
// channel from a role entirely ("private channel"); the read side is already
// enforced by ListVisibleChannels, the WS ready payload, and the per-message
// permission checks.
// getPermChannel loads the channel for an override request and writes the
// appropriate error response when it is missing or a DM. Returns nil when a
// response has already been written.
func getPermChannel(database *db.DB, w http.ResponseWriter, r *http.Request) *db.Channel {
id, err := pathInt64(r, "id")
if err != nil {
writeErr(w, http.StatusBadRequest, "BAD_REQUEST", "invalid channel id")
return nil
}
ch, err := database.GetChannel(r.Context(), id)
if err != nil {
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to fetch channel")
return nil
}
if ch == nil {
writeErr(w, http.StatusNotFound, "NOT_FOUND", "channel not found")
return nil
}
if ch.Type == "dm" {
writeErr(w, http.StatusBadRequest, "INVALID_INPUT", "DM channels do not support permission overrides")
return nil
}
return ch
}
// channelPermissionsResponse is the JSON shape for GET .../permissions.
// Roles lists EVERY role (zero allow/deny when it carries no override), while
// Users lists only the members who actually have a per-user override row —
// every member of a server is not a sensible list to ship, and the matrix
// editor adds a member by writing one.
type channelPermissionsResponse struct {
ChannelID int64 `json:"channel_id"`
Roles []db.ChannelRoleOverride `json:"roles"`
Users []db.ChannelUserOverride `json:"users"`
}
func handleGetChannelPermissions(database *db.DB) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
ch := getPermChannel(database, w, r)
if ch == nil {
return
}
overrides, err := database.ListChannelRoleOverrides(r.Context(), ch.ID)
if err != nil {
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to list channel permissions")
return
}
userOverrides, err := database.ListChannelUserOverrides(r.Context(), ch.ID)
if err != nil {
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to list channel user permissions")
return
}
writeJSON(w, http.StatusOK, channelPermissionsResponse{
ChannelID: ch.ID,
Roles: overrides,
Users: userOverrides,
})
}
}
// putChannelPermissionRequest is the JSON body for PUT .../permissions/{roleId}.
type putChannelPermissionRequest struct {
Allow int64 `json:"allow"`
Deny int64 `json:"deny"`
}
// requireGrantableOverride refuses to write a channel override whose allow or
// deny mask contains a bit the actor's own role does not hold. Without this,
// any MANAGE_CHANNELS holder could grant themselves or another user a
// permission (e.g. MANAGE_SERVER) they were never assigned by writing a
// channel-scoped override. ADMINISTRATOR bypasses, mirroring
// service.requireGrantable's escalation rule for role permission masks.
func requireGrantableOverride(actorRole *db.Role, allow, deny int64) error {
if permissions.HasAdmin(actorRole.Permissions) {
return nil
}
if escalated := (allow | deny) &^ actorRole.Permissions; escalated != 0 {
return fmt.Errorf("cannot grant a permission your own role lacks (%s)", permissions.Name(escalated&-escalated))
}
return nil
}
func handlePutChannelPermission(database *db.DB, hub HubBroadcaster, permInvalidator PermissionInvalidator) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
ch := getPermChannel(database, w, r)
if ch == nil {
return
}
roleID, err := pathInt64(r, "roleId")
if err != nil {
writeErr(w, http.StatusBadRequest, "BAD_REQUEST", "invalid role id")
return
}
role, err := database.GetRoleByID(r.Context(), roleID)
if err != nil {
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to fetch role")
return
}
if role == nil {
writeErr(w, http.StatusNotFound, "NOT_FOUND", "role not found")
return
}
var req putChannelPermissionRequest
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
writeErr(w, http.StatusBadRequest, "BAD_REQUEST", "invalid request body")
return
}
// Drop unknown bits so garbage input cannot persist undefined perms.
allow := req.Allow & permissions.AllPerms
deny := req.Deny & permissions.AllPerms
actorRole := actorRoleFromContext(r)
if actorRole == nil {
writeErr(w, http.StatusUnauthorized, "UNAUTHORIZED", "not authenticated")
return
}
// Escalation guard: a MANAGE_CHANNELS holder without ADMINISTRATOR
// cannot grant bits their own role lacks via a channel override.
// Checked against the union of the bits being written and the bits
// already present on the row: clearing an existing deny is also a
// grant (EffectivePerms = (rolePerm &^ deny) | allow), so writing an
// all-zero mask over a deny the actor's own role lacks must not slip
// past this guard just because the NEW mask alone is empty.
curAllow, curDeny, err := database.GetChannelPermissions(r.Context(), ch.ID, roleID)
if err != nil {
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to fetch channel permission")
return
}
if err := requireGrantableOverride(actorRole, curAllow|allow, curDeny|deny); err != nil {
writeErr(w, http.StatusForbidden, "FORBIDDEN", err.Error())
return
}
// Hierarchy guard: a role override can only target a role strictly
// below the actor's own position, mirroring service.requireBelowActor.
if role.Position >= actorRole.Position {
writeErr(w, http.StatusForbidden, "FORBIDDEN", "cannot manage a role at or above your own rank")
return
}
if err := database.UpsertChannelOverride(r.Context(), ch.ID, roleID, allow, deny); err != nil {
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to save channel permission")
return
}
actor := actorFromContext(r)
slog.Info("channel permissions updated", "actor_id", actor, "channel_id", ch.ID,
"role_id", roleID, "allow", allow, "deny", deny)
db.WriteAudit(context.WithoutCancel(r.Context()), database, actor, "channel_perms_update", "channel", ch.ID,
fmt.Sprintf("set overrides for role %s on #%s (allow=%#x deny=%#x)", role.Name, ch.Name, allow, deny))
// Narrow the eviction to users actually holding this role: a
// role-scoped override cannot change any other user's verdict, and
// InvalidateAll here made every connected user repopulate (2 reads
// each) synchronously inside RefreshChannelVisibility below — a
// whole-cache stampede that grows with total population, not with the
// role's size. Same rationale (and same fail-safe) as the role-perms
// handler: an unreadable member list falls back to the full flush,
// because a missed eviction is a stale grant.
if permInvalidator != nil {
if affected, listErr := database.ListUserIDsByRole(r.Context(), roleID); listErr == nil {
invalidateUsers(permInvalidator, affected)
} else {
permInvalidator.InvalidateAll()
}
}
if hub != nil {
hub.RefreshChannelVisibility(ch)
}
writeJSON(w, http.StatusOK, db.ChannelRoleOverride{
RoleID: role.ID,
RoleName: role.Name,
Position: role.Position,
Permissions: role.Permissions,
Allow: allow,
Deny: deny,
})
}
}
func handleDeleteChannelPermission(database *db.DB, hub HubBroadcaster, permInvalidator PermissionInvalidator) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
ch := getPermChannel(database, w, r)
if ch == nil {
return
}
roleID, err := pathInt64(r, "roleId")
if err != nil {
writeErr(w, http.StatusBadRequest, "BAD_REQUEST", "invalid role id")
return
}
role, err := database.GetRoleByID(r.Context(), roleID)
if err != nil {
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to fetch role")
return
}
if role == nil {
writeErr(w, http.StatusNotFound, "NOT_FOUND", "role not found")
return
}
actorRole := actorRoleFromContext(r)
if actorRole == nil {
writeErr(w, http.StatusUnauthorized, "UNAUTHORIZED", "not authenticated")
return
}
// Escalation guard: deleting an override is a permission mutation with
// the same authority as writing one — removing a deny row restores
// exactly the access the PUT path refuses to grant (EffectivePerms =
// (rolePerm &^ deny) | allow) — so gate it identically to
// handlePutChannelPermission, checked against the bits the deleted row
// actually carries.
curAllow, curDeny, err := database.GetChannelPermissions(r.Context(), ch.ID, roleID)
if err != nil {
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to fetch channel permission")
return
}
if err := requireGrantableOverride(actorRole, curAllow, curDeny); err != nil {
writeErr(w, http.StatusForbidden, "FORBIDDEN", err.Error())
return
}
// Hierarchy guard: deleting an override is a permission mutation with the
// same authority as writing one (removing a deny row restores exactly the
// access the PUT path refuses to grant), so gate it identically to
// handlePutChannelPermission.
if role.Position >= actorRole.Position {
writeErr(w, http.StatusForbidden, "FORBIDDEN", "cannot manage a role at or above your own rank")
return
}
if err := database.DeleteChannelOverride(r.Context(), ch.ID, roleID); err != nil {
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to delete channel permission")
return
}
actor := actorFromContext(r)
slog.Info("channel permissions cleared", "actor_id", actor, "channel_id", ch.ID, "role_id", roleID)
db.WriteAudit(context.WithoutCancel(r.Context()), database, actor, "channel_perms_clear", "channel", ch.ID,
fmt.Sprintf("cleared overrides for role %s on #%s", role.Name, ch.Name))
// Narrow the eviction to users actually holding this role: a
// role-scoped override cannot change any other user's verdict, and
// InvalidateAll here made every connected user repopulate (2 reads
// each) synchronously inside RefreshChannelVisibility below — a
// whole-cache stampede that grows with total population, not with the
// role's size. Same rationale (and same fail-safe) as the role-perms
// handler: an unreadable member list falls back to the full flush,
// because a missed eviction is a stale grant.
if permInvalidator != nil {
if affected, listErr := database.ListUserIDsByRole(r.Context(), roleID); listErr == nil {
invalidateUsers(permInvalidator, affected)
} else {
permInvalidator.InvalidateAll()
}
}
if hub != nil {
hub.RefreshChannelVisibility(ch)
}
w.WriteHeader(http.StatusNoContent)
}
}
// ─── Per-user overrides ──────────────────────────────────────────────────────
//
// channel_user_overrides is the last layer of the resolution order (base role
// perms -> role override -> user override), so these two endpoints can grant a
// single member access to a channel their role is denied, or take it away
// without minting a role for them.
//
// Unlike the role endpoints they invalidate only the target user's cached
// permissions (InvalidateUser): a per-user override cannot change anyone else's
// verdict, and blowing the whole cache away for one member would cost every
// connected client a repopulate.
// getPermUser resolves the {userId} path parameter for a per-user override
// request, writing the error response itself. Returns nil when a response has
// already been written.
func getPermUser(database *db.DB, w http.ResponseWriter, r *http.Request) *db.User {
userID, err := pathInt64(r, "userId")
if err != nil {
writeErr(w, http.StatusBadRequest, "BAD_REQUEST", "invalid user id")
return nil
}
user, err := database.GetUserByID(r.Context(), userID)
if err != nil {
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to fetch user")
return nil
}
if user == nil {
writeErr(w, http.StatusNotFound, "NOT_FOUND", "user not found")
return nil
}
return user
}
// requireManageableUser refuses a per-user channel override that targets a
// member whose role sits at or above the actor's own rank, mirroring the
// hierarchy guard the role-layer handler applies (handlePutChannelPermission).
// Without it a MANAGE_CHANNELS holder could deny a higher-ranked member access
// to a channel via the per-user layer, which is last in the resolution order
// and therefore beats that member's role allow. ADMINISTRATOR bypasses. Writes
// the error response and returns false when the action must be refused.
func requireManageableUser(database *db.DB, w http.ResponseWriter, r *http.Request, target *db.User, actorRole *db.Role) bool {
if permissions.HasAdmin(actorRole.Permissions) {
return true
}
targetRole, err := database.GetRoleByID(r.Context(), target.RoleID)
if err != nil {
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to fetch target role")
return false
}
if targetRole != nil && targetRole.Position >= actorRole.Position {
writeErr(w, http.StatusForbidden, "FORBIDDEN", "cannot manage a user ranked at or above your own")
return false
}
return true
}
func handlePutChannelUserPermission(database *db.DB, hub HubBroadcaster, permInvalidator PermissionInvalidator) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
ch := getPermChannel(database, w, r)
if ch == nil {
return
}
user := getPermUser(database, w, r)
if user == nil {
return
}
var req putChannelPermissionRequest
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
writeErr(w, http.StatusBadRequest, "BAD_REQUEST", "invalid request body")
return
}
// Drop unknown bits so garbage input cannot persist undefined perms.
allow := req.Allow & permissions.AllPerms
deny := req.Deny & permissions.AllPerms
actorRole := actorRoleFromContext(r)
if actorRole == nil {
writeErr(w, http.StatusUnauthorized, "UNAUTHORIZED", "not authenticated")
return
}
// Escalation guard: a MANAGE_CHANNELS holder without ADMINISTRATOR
// cannot grant bits their own role lacks via a per-user override.
// Checked against the union of the bits being written and the bits
// already present on the row, same rationale as
// handlePutChannelPermission: clearing an existing deny is a grant, so
// an all-zero write must not bypass this guard.
curAllow, curDeny, err := database.GetUserChannelPermissions(r.Context(), ch.ID, user.ID)
if err != nil {
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to fetch channel user permission")
return
}
if err := requireGrantableOverride(actorRole, curAllow|allow, curDeny|deny); err != nil {
writeErr(w, http.StatusForbidden, "FORBIDDEN", err.Error())
return
}
// Hierarchy guard: cannot override a member ranked at or above you.
if !requireManageableUser(database, w, r, user, actorRole) {
return
}
if err := database.UpsertChannelUserOverride(r.Context(), ch.ID, user.ID, allow, deny); err != nil {
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to save channel user permission")
return
}
actor := actorFromContext(r)
slog.Info("channel user permissions updated", "actor_id", actor, "channel_id", ch.ID,
"user_id", user.ID, "allow", allow, "deny", deny)
db.WriteAudit(context.WithoutCancel(r.Context()), database, actor, "channel_user_perms_update", "channel", ch.ID,
fmt.Sprintf("set overrides for user %s on #%s (allow=%#x deny=%#x)", user.Username, ch.Name, allow, deny))
// Invalidate BEFORE the hub call: RefreshChannelVisibility resolves the
// target's visibility through the same cache (see handlePutChannelPermission).
if permInvalidator != nil {
permInvalidator.InvalidateUser(user.ID)
}
if hub != nil {
hub.RefreshChannelVisibility(ch)
}
writeJSON(w, http.StatusOK, db.ChannelUserOverride{
UserID: user.ID,
Username: user.Username,
RoleID: user.RoleID,
Allow: allow,
Deny: deny,
})
}
}
func handleDeleteChannelUserPermission(database *db.DB, hub HubBroadcaster, permInvalidator PermissionInvalidator) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
ch := getPermChannel(database, w, r)
if ch == nil {
return
}
user := getPermUser(database, w, r)
if user == nil {
return
}
actorRole := actorRoleFromContext(r)
if actorRole == nil {
writeErr(w, http.StatusUnauthorized, "UNAUTHORIZED", "not authenticated")
return
}
// Escalation guard: clearing a per-user override restores exactly the
// access the PUT path refuses to grant (EffectivePerms = (rolePerm &^
// deny) | allow), so gate it identically to
// handlePutChannelUserPermission, checked against the bits the
// deleted row actually carries.
curAllow, curDeny, err := database.GetUserChannelPermissions(r.Context(), ch.ID, user.ID)
if err != nil {
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to fetch channel user permission")
return
}
if err := requireGrantableOverride(actorRole, curAllow, curDeny); err != nil {
writeErr(w, http.StatusForbidden, "FORBIDDEN", err.Error())
return
}
// Hierarchy guard: clearing a higher-ranked member's override is the
// same authority as writing one, so gate it identically.
if !requireManageableUser(database, w, r, user, actorRole) {
return
}
if err := database.DeleteChannelUserOverride(r.Context(), ch.ID, user.ID); err != nil {
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to delete channel user permission")
return
}
actor := actorFromContext(r)
slog.Info("channel user permissions cleared", "actor_id", actor, "channel_id", ch.ID, "user_id", user.ID)
db.WriteAudit(context.WithoutCancel(r.Context()), database, actor, "channel_user_perms_clear", "channel", ch.ID,
fmt.Sprintf("cleared overrides for user %s on #%s", user.Username, ch.Name))
if permInvalidator != nil {
permInvalidator.InvalidateUser(user.ID)
}
if hub != nil {
hub.RefreshChannelVisibility(ch)
}
w.WriteHeader(http.StatusNoContent)
}
}