mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
* feat(auth): add revocable API tokens (bot/service auth) Add long-lived, revocable API tokens so headless clients (the introspection MCP tool, bots, CI) can authenticate without a password. Presented as "Authorization: Bearer <token>", a token authenticates as a specific user, inheriting that user's role and permissions. - migration 018 + dedicated api_tokens table (kept separate from sessions so bulk logout and the per-user session cap never touch these); only the SHA-256 hash is stored, raw token shown once at creation - auth.ResolveTokenHash: one shared bearer resolver that both AuthMiddleware and adminAuthMiddleware now call. Sessions are matched first so existing login behavior is unchanged; API tokens are a fallback only on session miss. A DB outage is returned wrapped, never mistaken for a bad token. - `server token create|list|revoke` CLI: mints directly against the DB with no HTTP and no login — the password-free bootstrap path - tests: resolver (8 cases incl. outage-not-fallthrough), db queries (6), api middleware integration (valid + revoked token) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(tools): add owncord-introspect MCP server A local MCP dev tool that lets Claude Code introspect a running OwnCord instance: read its logs, query any REST endpoint, and tail the desktop client's log file. It is a thin wrapper over the existing API plus the client log — no new product surface. - tools/mcp-introspect/index.mjs (Node/ESM, one dep: @modelcontextprotocol/sdk) exposes api_request (full read-write passthrough), server_logs (admin SSE ring-buffer stream), client_logs (reads the desktop log file) - authenticates with an API token (OWNCORD_API_TOKEN); pins the self-signed cert and skips hostname checks (the cert has no SAN) - registered in .mcp.json (secret-free ${OWNCORD_API_TOKEN}) - un-ignore tools/mcp-introspect/ so this shared dev tool is committed, while tools/livekit-server.exe and node_modules stay ignored - docs/mcp-introspect.md: how it works, tool reference, setup, troubleshooting Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(dependencies): update and add various crate versions in Cargo.lock * feat(admin): manage API tokens from the admin panel Add Owner-gated HTTP endpoints and a UI card to create, list, and revoke API tokens from the web admin panel. Previously only the `server token` CLI could manage them, which requires shell access to the host. - POST|GET|DELETE /admin/api/tokens in admin/handlers_tokens.go, wired in admin/api.go. All three are Owner-only (ownerOnlyMiddleware, like backups/updates): an HTTP token-mint endpoint is a network-reachable credential-minting surface, and API tokens deliberately survive password change + bulk logout, so a hijacked admin session must not mint one. - Reuses the same db.*APIToken calls as the CLI; create sources the actor from request context (audits who clicked, not the bound user); the raw token is returned once in the 201 body, never stored. - Add json tags to db.APITokenListItem for snake_case wire consistency. - Admin panel: "API Tokens" nav item + create modal, show-once reveal, revoke confirm in admin/static/index.html. - Tests: 7 in admin/api_test.go (+api_tokens table in the in-memory schema). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor: modernize to Go 1.26 idioms + enable modernize linter Apply `golangci-lint modernize` autofixes across the server and enable the linter in .golangci.yml so these stop re-accumulating (they built up only because modernize was never in the config). Production code: slices.Contains for hand-rolled membership loops (api router, ws origin, db/account, plugin manifest); strings.SplitSeq for allocation-free line/segment iteration (db/migrate, updater, livekit_proxy); strings.Cut (config); fmt.Appendf (dm_handler); min() (event_pruner); any (ws client). Tests: range-over-int, t.Context(), WaitGroup.Go, slices.Sort, maps.Copy, new(expr), interface{}->any. - plugin/manifest.go parent-traversal check applied by hand: modernize skipped it (two conflicting rewrites); used the slices.Contains form. - Removed the now-dead ptr() test helper after newexpr inlined its callers. - Dropped dangling sort imports left by the sort.Slice->slices.Sort rewrite. No behavior change. All four tag variants build, full test suite is green, and golangci-lint (with modernize enabled) reports 0 issues. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
197 lines
5.4 KiB
Go
197 lines
5.4 KiB
Go
package admin_test
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/owncord/server/admin"
|
|
)
|
|
|
|
func TestSetupStatus_NeedsSetup(t *testing.T) {
|
|
database := openAdminTestDB(t)
|
|
handler := admin.NewAdminAPI(database, "1.0.0", nil, nil, nil, nil, nil, newTestModService(database))
|
|
|
|
rr := doRequest(t, handler, "GET", "/setup/status", "", nil)
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("GET /setup/status = %d, want 200", rr.Code)
|
|
}
|
|
|
|
var resp struct {
|
|
NeedsSetup bool `json:"needs_setup"`
|
|
}
|
|
if err := json.Unmarshal(rr.Body.Bytes(), &resp); err != nil {
|
|
t.Fatalf("unmarshal: %v", err)
|
|
}
|
|
if !resp.NeedsSetup {
|
|
t.Error("needs_setup = false, want true (no users)")
|
|
}
|
|
}
|
|
|
|
func TestSetupStatus_NoSetupNeeded(t *testing.T) {
|
|
database := openAdminTestDB(t)
|
|
createAdminUser(t, database) // Create a user first
|
|
handler := admin.NewAdminAPI(database, "1.0.0", nil, nil, nil, nil, nil, newTestModService(database))
|
|
|
|
rr := doRequest(t, handler, "GET", "/setup/status", "", nil)
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("GET /setup/status = %d, want 200", rr.Code)
|
|
}
|
|
|
|
var resp struct {
|
|
NeedsSetup bool `json:"needs_setup"`
|
|
}
|
|
if err := json.Unmarshal(rr.Body.Bytes(), &resp); err != nil {
|
|
t.Fatalf("unmarshal: %v", err)
|
|
}
|
|
if resp.NeedsSetup {
|
|
t.Error("needs_setup = true, want false (user exists)")
|
|
}
|
|
}
|
|
|
|
func TestSetup_CreatesOwner(t *testing.T) {
|
|
database := openAdminTestDB(t)
|
|
handler := admin.NewAdminAPI(database, "1.0.0", nil, nil, nil, nil, nil, newTestModService(database))
|
|
|
|
rr := doRequest(t, handler, "POST", "/setup", "", map[string]string{
|
|
"username": "myadmin",
|
|
"password": "SecurePass123!",
|
|
})
|
|
|
|
if rr.Code != http.StatusCreated {
|
|
t.Fatalf("POST /setup = %d, want 201; body=%s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
var resp struct {
|
|
Token string `json:"token"`
|
|
UserID int64 `json:"user_id"`
|
|
Username string `json:"username"`
|
|
InviteCode string `json:"invite_code"`
|
|
}
|
|
if err := json.Unmarshal(rr.Body.Bytes(), &resp); err != nil {
|
|
t.Fatalf("unmarshal: %v", err)
|
|
}
|
|
if resp.Token == "" {
|
|
t.Error("token is empty")
|
|
}
|
|
if resp.Username != "myadmin" {
|
|
t.Errorf("username = %q, want %q", resp.Username, "myadmin")
|
|
}
|
|
if resp.InviteCode == "" {
|
|
t.Error("invite_code is empty")
|
|
}
|
|
if resp.UserID == 0 {
|
|
t.Error("user_id is 0")
|
|
}
|
|
|
|
// Verify user was created with Owner role.
|
|
user, err := database.GetUserByUsername(context.Background(), "myadmin")
|
|
if err != nil || user == nil {
|
|
t.Fatal("user not found in database after setup")
|
|
}
|
|
if user.RoleID != 1 {
|
|
t.Errorf("role_id = %d, want 1 (Owner)", user.RoleID)
|
|
}
|
|
}
|
|
|
|
func TestSetup_BlockedAfterFirstUser(t *testing.T) {
|
|
database := openAdminTestDB(t)
|
|
handler := admin.NewAdminAPI(database, "1.0.0", nil, nil, nil, nil, nil, newTestModService(database))
|
|
|
|
// First setup succeeds.
|
|
rr := doRequest(t, handler, "POST", "/setup", "", map[string]string{
|
|
"username": "owner1",
|
|
"password": "SecurePass123!",
|
|
})
|
|
if rr.Code != http.StatusCreated {
|
|
t.Fatalf("first setup = %d, want 201; body=%s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
// Second setup is blocked.
|
|
rr2 := doRequest(t, handler, "POST", "/setup", "", map[string]string{
|
|
"username": "hacker",
|
|
"password": "EvilPass456!",
|
|
})
|
|
if rr2.Code != http.StatusForbidden {
|
|
t.Errorf("second setup = %d, want 403", rr2.Code)
|
|
}
|
|
}
|
|
|
|
func TestSetup_WeakPassword(t *testing.T) {
|
|
database := openAdminTestDB(t)
|
|
handler := admin.NewAdminAPI(database, "1.0.0", nil, nil, nil, nil, nil, newTestModService(database))
|
|
|
|
rr := doRequest(t, handler, "POST", "/setup", "", map[string]string{
|
|
"username": "admin",
|
|
"password": "short",
|
|
})
|
|
if rr.Code != http.StatusBadRequest {
|
|
t.Errorf("weak password = %d, want 400; body=%s", rr.Code, rr.Body.String())
|
|
}
|
|
}
|
|
|
|
func TestSetup_MissingFields(t *testing.T) {
|
|
database := openAdminTestDB(t)
|
|
handler := admin.NewAdminAPI(database, "1.0.0", nil, nil, nil, nil, nil, newTestModService(database))
|
|
|
|
rr := doRequest(t, handler, "POST", "/setup", "", map[string]string{
|
|
"username": "",
|
|
"password": "",
|
|
})
|
|
if rr.Code != http.StatusBadRequest {
|
|
t.Errorf("missing fields = %d, want 400", rr.Code)
|
|
}
|
|
}
|
|
|
|
// TestSetup_ConcurrentRace fires many parallel setup requests at a fresh
|
|
// server and asserts that exactly one owner is created (BUG-119).
|
|
func TestSetup_ConcurrentRace(t *testing.T) {
|
|
database := openAdminTestDB(t)
|
|
handler := admin.NewAdminAPI(database, "1.0.0", nil, nil, nil, nil, nil, newTestModService(database))
|
|
|
|
const goroutines = 20
|
|
results := make(chan int, goroutines)
|
|
|
|
// Launch goroutines simultaneously.
|
|
start := make(chan struct{})
|
|
for i := range goroutines {
|
|
go func(n int) {
|
|
<-start // wait for the gate
|
|
rr := doRequest(t, handler, "POST", "/setup", "", map[string]string{
|
|
"username": fmt.Sprintf("owner%d", n),
|
|
"password": "SecurePass123!",
|
|
})
|
|
results <- rr.Code
|
|
}(i)
|
|
}
|
|
close(start) // release all goroutines at once
|
|
|
|
created := 0
|
|
for range goroutines {
|
|
code := <-results
|
|
switch code {
|
|
case http.StatusCreated:
|
|
created++
|
|
case http.StatusForbidden, http.StatusTooManyRequests:
|
|
// expected for losers (already set up or rate-limited)
|
|
default:
|
|
t.Errorf("unexpected status %d", code)
|
|
}
|
|
}
|
|
|
|
if created != 1 {
|
|
t.Errorf("expected exactly 1 owner created, got %d", created)
|
|
}
|
|
|
|
// Verify only one user exists in the database.
|
|
count, err := database.UserCount(context.Background())
|
|
if err != nil {
|
|
t.Fatalf("UserCount: %v", err)
|
|
}
|
|
if count != 1 {
|
|
t.Errorf("user count = %d, want 1", count)
|
|
}
|
|
}
|