mirror of https://github.com/J3vb/OwnCord.git synced 2026-09-03 03:50:00 +03:00

Files

T

jevb 5d0af7c03e feat: sidebar stream preview + screenshare focus fix

- Add hover/focus preview for remote voice users' camera/screenshare
  streams in the voice channel sidebar. Preview reuses already-subscribed
  LiveKit tracks (zero bandwidth cost). Full-width 16:9 preview with
  neon border-glow treatment matching DESIGN.md.

- Fix screenshare focus bug: clicking a screensharing user now correctly
  focuses the screenshare tile (userId + SCREENSHARE_TILE_ID_OFFSET)
  instead of the camera tile.

- Extract SCREENSHARE_TILE_ID_OFFSET to shared lib/constants.ts (was
  duplicated in VideoModeController.ts and MainPage.ts).

- New lib/streamPreview.ts module: attachStreamPreview() with 300ms
  debounce, track renegotiation detection, autoplay failure handling,
  scroll collapse, keyboard accessibility (focusin/focusout), ARIA
  labels, and full AbortSignal cleanup.

- Placeholder shows "Join to preview" with click-to-join behavior.
  Live video preview is also clickable to watch the stream.

- 22 new tests (16 stream-preview + 6 channel-sidebar).

2026-03-30 19:12:36 +02:00

3.2 KiB

Raw Blame History

TODOS

Deferred work items from engineering reviews.

Completed (2026-03-29 voice/video polish pass)

~~Voice E2E Test Infrastructure~~ -- tests/e2e/voice-lifecycle.spec.ts (11 tests)
~~Voice Session Metrics~~ -- voice_sessions counter on /api/v1/metrics
~~Create DESIGN.md~~ -- full design system documentation at repo root
~~Extract AudioPipeline Class~~ -- audioPipeline.ts, audioElements.ts, deviceManager.ts (facade pattern)
~~Audio Pipeline + Event Handler Tests~~ -- audio-pipeline.test.ts (30 tests), audio-elements.test.ts (25 tests)
~~HTTPS Proxy Unit Tests~~ -- livekit_proxy_test.go (22 tests)
~~Migrate VAD to AudioWorklet~~ -- public/vad-worklet.js with setTimeout fallback

Already Implemented (discovered 2026-03-29 — code analysis was stale)

~~Simulcast on Camera Video~~ -- simulcast: quality !== "source" in publishTrack options (livekitSession.ts:852)
~~Adaptive Bitrate on Screenshare~~ -- dynacast: !isSource + adaptiveStream: !isSource in Room options (livekitSession.ts:187-188)
~~LiveKit Proxy Port Exhaustion~~ -- already handles reuse (same host) + cleanup via shutdown channel (different host) in livekit_proxy.rs:196-208

Deferred (from 2026-03-30 eng review)

Remote Video Stream Reuse (getRemoteVideoStream)

What: The getRemoteVideoStream(userId, type) accessor added for sidebar preview can be reused for PiP, mini-player, or notification previews. Why: Currently only used by stream preview hover. Future features (PiP mode, floating mini-player, notification thumbnails) would benefit from the same API. Pros: Zero additional work — the export already exists in livekitSession.ts. This TODO just tracks the reuse opportunity. Cons: None — purely informational. No code change needed. Context: Added during sidebar stream preview eng review (2026-03-30). The method is exported as a bound module-level function, consistent with getLocalCameraStream/getLocalScreenshareStream. Any future consumer can import it directly. Depends on: Sidebar stream preview feature (this PR). Added: 2026-03-30 (eng review of sidebar stream preview)

Deferred (from 2026-03-29 CEO review)

Voice E2E CI Integration (narrowed scope)

What: Set up LiveKit binary in CI for WebRTC-specific regression testing only. Why: Mocked E2E tests (24 tests in voice-lifecycle.spec.ts) cover 90%+ of voice UI regressions. Real LiveKit CI is only needed for audio pipeline bugs, LiveKit SDK regressions, or WebRTC transport issues that mocks can't catch. Pros: Catches WebRTC-specific regressions (codec negotiation, ICE failures, audio pipeline). Cons: Requires Docker-in-CI setup with LiveKit binary. High maintenance for low-frequency bugs. Context: Mocked voice E2E covers: join/leave flow, speaker indicators, permission recovery, device hot-swap, quality warnings, timer, token refresh, channel switching. Only pursue real LiveKit CI if evidence emerges of WebRTC-specific regressions that mocked tests miss. Depends on: Voice E2E test infrastructure (done), mocked voice E2E expansion (done). Added: 2026-03-29 (eng review of voice/video polish), updated: 2026-03-29 (scope narrowed after mocked E2E expansion) Added: 2026-03-29 (eng review of voice/video polish)

3.2 KiB Raw Blame History