mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
* refactor(ws): split handleVoiceJoin into cohesive join-stage helpers handleVoiceJoin was 130 statements / cyclomatic 59 / nestif 11, breaking all three complexity budgets at once. Split along the stage boundaries the doc comment already described: precheck, leave-current, persist, restore moderator flags, grant token, complete. The publish-permission derivation becomes its own helper because it is the one branch-heavy block inside the token grant. Pure move: every statement is preserved verbatim. The only edits are bare `return`s becoming the typed returns of their new helper, `c.userID` becoming the `userID` parameter inside voiceJoinPublishPerms, and voiceJoinComplete re-reading `ch.VoiceMaxUsers` instead of receiving it — `ch` is never mutated, so the value is identical. Verified by normalising both revisions of the region to sorted, comment- and whitespace-stripped statements and diffing: the only deltas are the ones listed above. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: collapse the three duplicated sibling pairs dupl flagged three pairs of adjacent near-identical functions. Each pair is now one parameterised implementation plus two thin, still-greppable wrappers. - ws/voice_controls.go: handleVoiceMuteV2 / handleVoiceDeafenV2 share voiceSelfToggleV2; handleVoiceCameraV2 / handleVoiceScreenshareV2 share voiceStreamToggleV2. Camera and screenshare drawing from one voice_max_video budget (OC-0023) was a bug caused by exactly this duplication drifting, so one body is the point, not a side effect. - db/mention_queries.go: ListMentionTargetsByRoles / ListMentionTargetsByUserIDs share listMentionTargets. The matched column is a closed named type (mentionTargetColumn) rather than a bare string, so the value interpolated into the SELECT cannot become caller-supplied. Behaviour is unchanged: every rate-limit key, error code, error string, slog message and slog key is preserved verbatim, including the two "failed to update <kind> state" messages, which are now assembled the same way enableVideoSlot already assembled them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(api): extract readEmojiUpload from handleCreateEmoji handleCreateEmoji was 101 lines against a 100-line budget. The upload-bytes stage — pull the file out of the parsed form, cap its size, sniff its MIME type and sniff its dimensions — is the one self-contained block in it, and it already wrote its own refusals, so it moves out whole as readEmojiUpload. The permission-before-parse ordering the doc comment calls out is unchanged; so is every error string. file.Close() now runs when the helper returns rather than when the handler does, which is strictly earlier and unobservable: the bytes are already copied into raw and nothing else touches the handle. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: extract one cohesive block from three single-budget offenders Each of these was over exactly one budget, so each gets exactly one extraction rather than a restructure: - api/totp_handler.go handleVerifyTOTP (102 lines / 100): the block that resolves the user behind the partial-auth challenge and decrypts their TOTP secret becomes totpChallengeSecret. The ban-inside-the-partial-window check moves with it. - service/message_reactions.go handleReaction (cyclop 21 / 20): the whole authorisation chain — channel lookup, archived gate, DM participant and block checks, non-DM permission check — becomes reactionAudience, which also returns the DM fan-out audience it already resolved. Check order is unchanged and load-bearing. - db/admin_queries.go BackupToSafe (cyclop 21 / 20): the character allowlist loop and the SQL-comment rejection become validateBackupPathChars. That loop alone was most of the branch count. No error string, no check and no ordering changed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(plugin): split InstallFromZip into staged install helpers 104 statements / cyclomatic 44 / nestif 12. Split along the stages the code already had: installZipExtract (the per-entry write loop, with installZipEntryDest holding the mode/symlink/zip-slip guard chain and installZipWriteEntry the size-capped copy), installZipStagedManifest, installZipPromote, and installZipReactivate for the :399 nested block. Every zip-slip, symlink, entry-mode and uncompressed-size check is preserved in the same order relative to the writes it guards. The 19 inline `cleanup(); return` sites collapse to 4 in the orchestrator, one per stage, because each helper now returns an error instead of unwinding itself — the staging directory is still removed on exactly the same set of failures. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(api): split newWAFMiddleware into engine build and per-phase helpers 184 lines / cyclomatic 38, and the request-body block at :382 was the worst nested site in the tree at nestif 17. Engine construction moves out of the closure (wafInlineEngine, wafCRSEngine — the Coraza directive string is lifted verbatim), and each request phase becomes its own helper: wafInlineRequestHeaders, wafCRSRequestHeaders (including the Host/Transfer-Encoding re-add for CRS 920280), wafFeedCRSBody and wafInspectRequestBody, which is the old :382 block. The three `handleWAFInterruption(w, it); return` sites inside the body block become one: the helper now returns the interruption and the orchestrator handles it. No statement runs between the two points on either side, so the verdict is honoured identically — in particular a CRS body interruption still returns without replacing r.Body. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(service): split SendMessage and lift EditMessage's access check SendMessage was 79 statements / cyclomatic 35 with an 11-deep nested attachment block at :101; EditMessage was one point over cyclop. SendMessage becomes sendMessagePrecheck (permission and DM-block gates, content sanitisation), sendMessageLinkAttachments (the :101 block: attachment ownership, claim and link) and sendMessageDMSideEffects. EditMessage gets editMessageCheckAccess and nothing else — one budget over earns one extraction. The sanitizeContent fixpoint and the attachment ownership check are unchanged, as is the order of every gate. The DM side effects run behind `isDM && !s.sendMessageDMSideEffects(...)`, so a non-DM never enters them; inside, only the GetDMParticipantIDs failure returns false, matching the one error the original early-returned on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(admin): split handlePatchUser into per-field apply helpers 106 lines / cyclomatic 29, with the ban block at :154 nested 9 deep. Each optional field of the partial edit becomes its own helper — patchUserPrecheck, patchUserAuthorizeRole, patchUserApplyBan (the :154 block, including the session disconnect and the broadcast) and patchUserApplyRole. Each returns a bool meaning "keep going"; none of them writes a success response, so the single response site in the orchestrator is unchanged. Field application order, the permission-cache invalidation on a role change and the disconnect-and-broadcast on a ban are all preserved, as are the three fail-closed `mod == nil` guards, which now sit at the top of their own helper and still fire on exactly the same conditions. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(admin): split handleSetup into first-run setup stages 143 lines / cyclomatic 30, with the optional-wizard block at :219 sitting exactly on the nestif threshold. Split into the stages the endpoint already had: request gating (rate limit and origin check, which run before any auth exists on a fresh server), owner account creation, and the wizard application that was the :219 block. Every gate in front of the handler is a security control on an unauthenticated endpoint; none moved relative to the work it protects. setup_wizard.go is untouched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: split run() into named bootstrap and shutdown steps 131 statements / cyclomatic 57, with the executable-path fallback at :126 nested 9 deep. The five anonymous `defer func(){...}()` blocks become named functions — telemetryStop, runClosePlugins, runStopEventPersistence, runStopAuditWriter, maintenanceStop — and the bootstrap stages move out likewise. Every defer is still registered in run() itself, at the same point in the sequence, so the LIFO teardown order is unchanged; that order is documented in the surrounding comments and is load-bearing (the audit-writer stop must follow database.Close's registration, the event-persistence stop must precede it). runStopEventPersistence is now registered unconditionally with a nil persister meaning "disabled", where the old code registered its defer inside the enabled branch — a no-op occupying that slot cannot change the relative order of the others. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(ws): split handleReconnect into resume stages 77 statements / cyclomatic 41, plus the replay block at :199 and, in handleFreshConnect, the voice-state restore at :622. handleReconnect becomes reconnectPrecheck, reconnectSelectReplay (with reconnectVetColdTail for the cold-tier gap check), reconnectRegister and reconnectWriteReplay. handleFreshConnect's stale-voice cleanup moves to its own helper, where the `if h.livekit != nil` wrapper becomes a guard clause — that block was the tail of its scope, so returning early and falling off the end are the same. The parts that carry the invariants are moved verbatim: reconnectRegister still takes h.seqMu, still calls registerNow inside that same critical section (BUG-123 / OC-0206), still unlocks on every exit, and still emits the "full" tier counter and telemetry on each of its three re-check failures. handleReconnect's two-boolean contract is unchanged — the collapsed `return false, false` sites are all fall-through-to-full-ready, and the single `return true, false` is still the handshake-write-failure path whose teardown already ran (OC-0051). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs(server): fold in the adversarial review of the complexity refactors Eleven skeptic passes over the refactor commits on this branch found no blocker and no major — behaviour is preserved throughout. They did find comment and accuracy defects worth correcting: - db/mention_queries.go: the mentionTargetColumn rationale claimed the named type made the interpolated column "only ever one of the two constants". A Go named type is not closed, so that is a convention the type makes visible, not one it enforces. Reworded, gosec justification included. - ws/voice_controls.go: the dupl collapse generalised away three specifics — that a server deafen is the moderator's to lift (now on the serverDeafen field), the concrete voice_states.camera / voice_states.screenshare column names, and the half of the OC-0023 rationale about neither stream kind hiding from the other's count. All three restored. - ws/voice_join.go: `maxUsers := ch.VoiceMaxUsers` had been hoisted to the top of voiceJoinComplete, moving a read across the tail supersession guard. The read is inert, but it was the one statement in that commit whose position relative to a security guard changed; it now sits at its use, as before. - ws/*_test.go: three test comments cited voice_join.go line numbers that the split invalidated. They now cite the helper by name instead. - service/message_reactions.go: reactionAudience's doc claimed to enforce "every gate on reacting"; it enforces the channel-scoped ones, and the doc now says which gates stay with the caller. - api/emoji_handler.go: the readEmojiUpload call reused the outer `ok` from the auth check by assignment; it gets its own readOK. - admin/setup_handler.go: a moved comment kept a "the response above" deictic that no longer had a response above it. No behaviour change. Build, vet, full tests and -race on five packages green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(ws): clear the remaining complexity budgets across the hub Eight files, thirteen findings. Each function is split at the stages it already had; no branch is reordered, merged or inverted. - handlers.go handleMessage (cyclop 28, 88 stmts): session re-check, frame decode and result application become handleMessageSessionRecheck, handleMessageDecode and handleMessageApply. The V2 constructor lookup -> DispatchV2 -> Result resolution order is untouched. - serve_ready.go buildReady (cyclop 26, 61 stmts): the per-section fetches split out, readyChannelPayloads among them. Every visibility predicate is preserved verbatim — this is the payload that decides what a client may see. - serve_pumps.go writePump (cyclop 31): writePumpWrite, writePumpDeliver, writePumpDrainChannel and writePumpDrainAndClose. Every channel receive stays in the same select statement, so scheduling is unchanged. - hub_sweep.go sweepStaleVoiceStates (cyclop 22, 56 stmts): the staleness predicate, the hub-lock ordering and the position of the race hook are all as they were — handleVoiceJoin's BUG-088 ordering depends on them. - hub_broadcast.go channelReadAudienceImpl and RefreshChannelVisibility (cyclop 22 each, 57 stmts): channelReadAudienceDM and refreshChannelVisibilityCanSend. The audience predicate is the OC-0090 group-DM leak surface, so it is extracted, never simplified. - livekit_webhook.go (nestif 13 and 14): webhookJoinedEnforceVoiceState, webhookLeftCleanupClient and webhookLeftFinishLeave. DB delete still precedes broadcast on every path. - livekit_download.go EnsureLiveKitBinary (52 stmts): one extraction, ensureLiveKitStageBinary, keeping every archive path check intact. - voice_moderation.go (nestif 8): voiceModDeafenRollback. The persisted server_muted flag remains the authority. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(api): clear the remaining complexity budgets across the HTTP layer - router.go NewRouter (cyclop 28, 84 stmts): split by wiring concern into routerTOTPKey, routerHealthDeps, routerMiddleware, routerUploadRoutes, routerPluginWiring, routerVoiceRoutes and routerMetricsRoutes. Middleware ORDER is a security property (auth before handler, WAF before body parse, rate limit before work) and is unchanged; the returned cleanup func still closes over and releases everything it did before. - auth_handler.go handleRegister (133 lines) and handleLogin (cyclop 21, 152 lines): registerPolicyGate, registerReadRequest, loginReadRequest and loginAuthenticate. The always-compare posture, every rate-limit key, every counter reset and the ban-check-versus-password-compare order are all preserved — including loginUserFailureThreshold staying unscaled by scaledAuthLimit, which is deliberate and commented. - upload_handler.go handleServeFile (cyclop 31, 128 lines): serveFileResolve and serveFileAuthorize. Every header this sets — Content-Disposition included, which is what stops a stored file being served as active content — is still set with the same value in the same circumstances. - profile_handler.go handleUploadAvatar (120 lines): avatarUploadReadImage, mirroring readEmojiUpload in shape but with the avatar caps and MIME set. The two deliberately do not share a helper. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor: clear the last complexity budgets in db and admin - db/account.go DeleteAccount (cyclop 28, 55 stmts): grouped by subsystem into deleteAccountAdminGuard, deleteAccountDMChannels and deleteAccountCloseDMChannels, each taking the same transaction. The transaction boundary, the delete ORDER (which foreign keys depend on) and the rollback path are unchanged. - admin/logstream.go handleLogStream (cyclop 24): logStreamAuthorize. Flush cadence, heartbeat and disconnect detection untouched. - admin/setup_wizard.go validateWizard (cyclop 23): grouped by section into wizardValidateIdentity, wizardValidateNetwork and wizardValidateMedia. Every message and bound is unchanged — this is the first input-validation boundary on a fresh server, before any auth exists. With this the tree is at zero: golangci-lint run reports 0 issues against the budgets set in #1384 (funlen 100/50, cyclop 20, nestif 8, dupl 150), with no //nolint and no exclusion added anywhere. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
352 lines
12 KiB
Go
352 lines
12 KiB
Go
package admin
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/owncord/server/config"
|
|
"github.com/owncord/server/db"
|
|
)
|
|
|
|
// ─── SetupOptions ────────────────────────────────────────────────────────────
|
|
|
|
// SetupOptions wires the first-run setup wizard to the running server. The
|
|
// zero value disables everything beyond legacy owner-account creation, which
|
|
// keeps every existing NewAdminAPI/NewHandler call site behaving as before.
|
|
type SetupOptions struct {
|
|
// ConfigPath is the config.yaml path the wizard patches. Empty disables
|
|
// config writing entirely.
|
|
ConfigPath string
|
|
// RunningCfg is the configuration the server booted with. It provides the
|
|
// wizard's prefill defaults, the values compared against to decide whether
|
|
// a restart is needed, and the generated LiveKit credentials to persist.
|
|
// Nil disables prefill and restarting.
|
|
RunningCfg *config.Config
|
|
// Restart replaces the process-restart hook (tests). Nil = requestRestart.
|
|
Restart func(reason string)
|
|
}
|
|
|
|
// ─── Wizard payload ──────────────────────────────────────────────────────────
|
|
|
|
// setupWizardRequest is the optional "wizard" object on POST /api/setup.
|
|
// Every field is a pointer: absent means "keep the current/default value".
|
|
type setupWizardRequest struct {
|
|
// Stored in the settings table (read live, no restart needed).
|
|
ServerName *string `json:"server_name"`
|
|
Motd *string `json:"motd"`
|
|
RegistrationOpen *bool `json:"registration_open"`
|
|
|
|
// Stored in config.yaml (consumed at startup — changes need a restart).
|
|
Port *int `json:"port"`
|
|
TLSMode *string `json:"tls_mode"`
|
|
TLSDomain *string `json:"tls_domain"`
|
|
UploadMaxSizeMB *int `json:"upload_max_size_mb"`
|
|
VoiceQuality *string `json:"voice_quality"`
|
|
// VoiceAutoDownload toggles voice.auto_download_livekit — download and
|
|
// run livekit-server automatically so voice works with zero setup.
|
|
VoiceAutoDownload *bool `json:"voice_auto_download"`
|
|
}
|
|
|
|
// setupDefaults is the prefill data the wizard shows. Exposed only while
|
|
// needs_setup is true, and deliberately free of secrets, filesystem paths and
|
|
// network ACLs.
|
|
type setupDefaults struct {
|
|
ServerName string `json:"server_name"`
|
|
Motd string `json:"motd"`
|
|
RegistrationOpen bool `json:"registration_open"`
|
|
Port int `json:"port"`
|
|
TLSMode string `json:"tls_mode"`
|
|
TLSDomain string `json:"tls_domain"`
|
|
UploadMaxSizeMB int `json:"upload_max_size_mb"`
|
|
VoiceQuality string `json:"voice_quality"`
|
|
VoiceAutoDownload bool `json:"voice_auto_download"`
|
|
}
|
|
|
|
// ─── Validation ──────────────────────────────────────────────────────────────
|
|
|
|
const (
|
|
maxServerNameLen = 100
|
|
maxMotdLen = 500
|
|
maxUploadSizeMB = 10240 // 10 GiB
|
|
)
|
|
|
|
var validTLSModes = map[string]struct{}{
|
|
"self_signed": {}, "acme": {}, "manual": {}, "off": {},
|
|
}
|
|
|
|
var validVoiceQualities = map[string]struct{}{
|
|
"low": {}, "medium": {}, "high": {},
|
|
}
|
|
|
|
// validateWizard checks and normalises the wizard payload in place. It must
|
|
// be called BEFORE the owner account is created so a bad payload rejects the
|
|
// whole request instead of leaving a half-configured server.
|
|
func validateWizard(wr *setupWizardRequest) error {
|
|
if err := wizardValidateIdentity(wr); err != nil {
|
|
return err
|
|
}
|
|
if err := wizardValidateNetwork(wr); err != nil {
|
|
return err
|
|
}
|
|
if err := wizardValidateMedia(wr); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// wizardValidateIdentity checks and normalises the settings-table fields the
|
|
// server reads live: the display name and the message of the day.
|
|
func wizardValidateIdentity(wr *setupWizardRequest) error {
|
|
if wr.ServerName != nil {
|
|
name := strings.TrimSpace(setupSanitizer.Sanitize(*wr.ServerName))
|
|
if name == "" {
|
|
return fmt.Errorf("server_name cannot be empty")
|
|
}
|
|
if len(name) > maxServerNameLen {
|
|
return fmt.Errorf("server_name must be at most %d characters", maxServerNameLen)
|
|
}
|
|
*wr.ServerName = name
|
|
}
|
|
if wr.Motd != nil {
|
|
motd := strings.TrimSpace(setupSanitizer.Sanitize(*wr.Motd))
|
|
if len(motd) > maxMotdLen {
|
|
return fmt.Errorf("motd must be at most %d characters", maxMotdLen)
|
|
}
|
|
*wr.Motd = motd
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// wizardValidateNetwork checks and normalises the listener and TLS fields,
|
|
// including the cross-field rule that ACME issuance needs a domain.
|
|
func wizardValidateNetwork(wr *setupWizardRequest) error {
|
|
if wr.Port != nil && (*wr.Port < 1 || *wr.Port > 65535) {
|
|
return fmt.Errorf("port must be between 1 and 65535")
|
|
}
|
|
if wr.TLSMode != nil {
|
|
mode := strings.ToLower(strings.TrimSpace(*wr.TLSMode))
|
|
if _, ok := validTLSModes[mode]; !ok {
|
|
return fmt.Errorf("tls_mode must be one of: self_signed, acme, manual, off")
|
|
}
|
|
*wr.TLSMode = mode
|
|
}
|
|
if wr.TLSDomain != nil {
|
|
domain := strings.ToLower(strings.TrimSpace(*wr.TLSDomain))
|
|
if domain != "" {
|
|
if err := validateHostname(domain); err != nil {
|
|
return fmt.Errorf("tls_domain: %w", err)
|
|
}
|
|
}
|
|
*wr.TLSDomain = domain
|
|
}
|
|
if wr.TLSMode != nil && *wr.TLSMode == "acme" &&
|
|
(wr.TLSDomain == nil || *wr.TLSDomain == "") {
|
|
return fmt.Errorf("tls_domain is required when tls_mode is acme")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// wizardValidateMedia checks and normalises the upload-size cap and the voice
|
|
// quality preset.
|
|
func wizardValidateMedia(wr *setupWizardRequest) error {
|
|
if wr.UploadMaxSizeMB != nil && (*wr.UploadMaxSizeMB < 1 || *wr.UploadMaxSizeMB > maxUploadSizeMB) {
|
|
return fmt.Errorf("upload_max_size_mb must be between 1 and %d", maxUploadSizeMB)
|
|
}
|
|
if wr.VoiceQuality != nil {
|
|
q := strings.ToLower(strings.TrimSpace(*wr.VoiceQuality))
|
|
if _, ok := validVoiceQualities[q]; !ok {
|
|
return fmt.Errorf("voice_quality must be one of: low, medium, high")
|
|
}
|
|
*wr.VoiceQuality = q
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// validateHostname checks an LDH (letters-digits-hyphen) DNS name suitable
|
|
// for ACME issuance: dotted, each label 1-63 chars, no leading/trailing
|
|
// hyphen, 253 chars max. Input is expected lowercase.
|
|
func validateHostname(h string) error {
|
|
if len(h) > 253 {
|
|
return fmt.Errorf("hostname too long")
|
|
}
|
|
labels := strings.Split(h, ".")
|
|
if len(labels) < 2 {
|
|
return fmt.Errorf("must be a fully qualified domain name (e.g. chat.example.com)")
|
|
}
|
|
for _, label := range labels {
|
|
if label == "" || len(label) > 63 {
|
|
return fmt.Errorf("invalid hostname label")
|
|
}
|
|
if label[0] == '-' || label[len(label)-1] == '-' {
|
|
return fmt.Errorf("hostname labels cannot start or end with a hyphen")
|
|
}
|
|
for _, c := range label {
|
|
if (c < 'a' || c > 'z') && (c < '0' || c > '9') && c != '-' {
|
|
return fmt.Errorf("hostname contains invalid characters")
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ─── Applying the wizard ─────────────────────────────────────────────────────
|
|
|
|
// applyWizardSettings persists the wizard's DB-backed settings atomically.
|
|
// server_name, motd and registration_open are read live by the server;
|
|
// max_upload_bytes and voice_quality are written so the Settings page shows
|
|
// values consistent with what the wizard put in config.yaml.
|
|
func applyWizardSettings(ctx context.Context, database *db.DB, wr *setupWizardRequest) error {
|
|
updates := map[string]string{}
|
|
if wr.ServerName != nil {
|
|
updates["server_name"] = *wr.ServerName
|
|
}
|
|
if wr.Motd != nil {
|
|
updates["motd"] = *wr.Motd
|
|
}
|
|
if wr.RegistrationOpen != nil {
|
|
if *wr.RegistrationOpen {
|
|
updates["registration_open"] = "1"
|
|
} else {
|
|
updates["registration_open"] = "0"
|
|
}
|
|
}
|
|
if wr.UploadMaxSizeMB != nil {
|
|
updates["max_upload_bytes"] = strconv.Itoa(*wr.UploadMaxSizeMB * 1024 * 1024)
|
|
}
|
|
if wr.VoiceQuality != nil {
|
|
updates["voice_quality"] = *wr.VoiceQuality
|
|
}
|
|
if len(updates) == 0 {
|
|
return nil
|
|
}
|
|
|
|
tx, err := database.BeginTx(ctx, nil)
|
|
if err != nil {
|
|
return fmt.Errorf("starting transaction: %w", err)
|
|
}
|
|
for key, value := range updates {
|
|
if _, txErr := tx.ExecContext(ctx,
|
|
`INSERT INTO settings (key, value) VALUES (?, ?)
|
|
ON CONFLICT(key) DO UPDATE SET value = excluded.value`,
|
|
key, value,
|
|
); txErr != nil {
|
|
_ = tx.Rollback()
|
|
return fmt.Errorf("writing setting %s: %w", key, txErr)
|
|
}
|
|
}
|
|
return tx.Commit()
|
|
}
|
|
|
|
// buildConfigPatch maps the wizard payload onto config.yaml keys. When the
|
|
// running config is known, the LiveKit credentials it booted with are included
|
|
// so config.Save can persist them if the file has none — stabilising voice
|
|
// tokens across restarts (they are otherwise regenerated randomly each boot).
|
|
func buildConfigPatch(wr *setupWizardRequest, running *config.Config) config.Patch {
|
|
p := config.Patch{
|
|
ServerPort: wr.Port,
|
|
ServerName: wr.ServerName,
|
|
TLSMode: wr.TLSMode,
|
|
TLSDomain: wr.TLSDomain,
|
|
UploadMaxSizeMB: wr.UploadMaxSizeMB,
|
|
VoiceQuality: wr.VoiceQuality,
|
|
VoiceAutoDownload: wr.VoiceAutoDownload,
|
|
}
|
|
if running != nil {
|
|
if key := running.Voice.LiveKitAPIKey; key != "" {
|
|
p.VoiceAPIKey = &key
|
|
}
|
|
if secret := running.Voice.LiveKitAPISecret; secret != "" {
|
|
p.VoiceAPISecret = &secret
|
|
}
|
|
}
|
|
return p
|
|
}
|
|
|
|
// patchedConfigKeys summarises which config.yaml keys a patch touches, for
|
|
// the audit log. Secrets are named, never valued.
|
|
func patchedConfigKeys(wr *setupWizardRequest) string {
|
|
var keys []string
|
|
if wr.Port != nil {
|
|
keys = append(keys, "server.port")
|
|
}
|
|
if wr.ServerName != nil {
|
|
keys = append(keys, "server.name")
|
|
}
|
|
if wr.TLSMode != nil {
|
|
keys = append(keys, "tls.mode")
|
|
}
|
|
if wr.TLSDomain != nil {
|
|
keys = append(keys, "tls.domain")
|
|
}
|
|
if wr.UploadMaxSizeMB != nil {
|
|
keys = append(keys, "upload.max_size_mb")
|
|
}
|
|
if wr.VoiceQuality != nil {
|
|
keys = append(keys, "voice.quality")
|
|
}
|
|
if wr.VoiceAutoDownload != nil {
|
|
keys = append(keys, "voice.auto_download_livekit")
|
|
}
|
|
keys = append(keys, "voice credentials (persisted if unset)")
|
|
return strings.Join(keys, ", ")
|
|
}
|
|
|
|
// ─── Restart decision ────────────────────────────────────────────────────────
|
|
|
|
// wizardChangesRunningConfig reports whether the wizard set any startup-only
|
|
// value to something different from what this process booted with. Only those
|
|
// changes justify a restart; server.name and the persisted voice credentials
|
|
// match the running state by construction.
|
|
func wizardChangesRunningConfig(wr *setupWizardRequest, running *config.Config) bool {
|
|
if wr.Port != nil && *wr.Port != running.Server.Port {
|
|
return true
|
|
}
|
|
if wr.TLSMode != nil && *wr.TLSMode != running.TLS.Mode {
|
|
return true
|
|
}
|
|
if wr.UploadMaxSizeMB != nil && *wr.UploadMaxSizeMB != running.Upload.MaxSizeMB {
|
|
return true
|
|
}
|
|
if wr.VoiceQuality != nil && *wr.VoiceQuality != running.Voice.Quality {
|
|
return true
|
|
}
|
|
if wr.VoiceAutoDownload != nil && *wr.VoiceAutoDownload != running.Voice.AutoDownloadLiveKit {
|
|
return true
|
|
}
|
|
// A domain change only matters when certificates come from ACME.
|
|
effMode := running.TLS.Mode
|
|
if wr.TLSMode != nil {
|
|
effMode = *wr.TLSMode
|
|
}
|
|
if effMode == "acme" && wr.TLSDomain != nil && *wr.TLSDomain != running.TLS.Domain {
|
|
return true
|
|
}
|
|
return false
|
|
}
|
|
|
|
// computeRestartURL builds the admin-panel URL the server will be reachable
|
|
// at after restarting with the wizard's values. host is the request's Host
|
|
// header (the address the user's browser is already using).
|
|
func computeRestartURL(host string, wr *setupWizardRequest, running *config.Config) string {
|
|
h := host
|
|
if hh, _, err := net.SplitHostPort(host); err == nil {
|
|
h = hh
|
|
}
|
|
effPort := running.Server.Port
|
|
if wr.Port != nil {
|
|
effPort = *wr.Port
|
|
}
|
|
effMode := running.TLS.Mode
|
|
if wr.TLSMode != nil {
|
|
effMode = *wr.TLSMode
|
|
}
|
|
scheme := "https"
|
|
if effMode == "off" {
|
|
scheme = "http"
|
|
}
|
|
return scheme + "://" + net.JoinHostPort(h, strconv.Itoa(effPort)) + "/admin"
|
|
}
|