mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
`Server/go.mod` declared `github.com/owncord/server` while the public repository is `github.com/J3vb/OwnCord`. Nothing resolves that path — there is no `owncord` GitHub org and no vanity-import host serving go-import metadata for it — so every import line in the tree named a location that does not exist. It compiles because a main module's own path is never fetched, which is exactly why it went unnoticed. The obvious fix — an AST-aware import rewriter (`gomvpkg`, `go mod edit`) — is wrong here, and provably so. Six of the 722 occurrences are not imports at all: `api/main_test.go:20` (a goleak `IgnoreTopFunction` pattern), `telemetry/metrics.go:17-19` (three OTel instrumentation-scope names), `invariants/syncutil_locks.go:73` (a diagnostic message), and `invariants/syncutil_locks_test.go:56` (an import line inside a raw-string Go fixture). An import rewriter touches none of them, and the compiler cannot see any of them either. Done as one scripted substitution over `git ls-files`, anchored on the full `github.com/owncord/server` string. The anchor matters: `owncord-server` is a different identifier — the OTel `service.name` (`config/config.go`, `telemetry/telemetry_otel.go`) and the GHCR image name (`.github/workflows/release.yml`, `docker-compose.yml`) — and a looser pattern would have moved it. It is untouched: 10 occurrences across 9 files, before and after. 350 files, 728 insertions, 728 deletions. 722 occurrences in 344 Go files, plus `go.mod:1`, the `sed` at `Makefile:67`, `Server/CLAUDE.md:3`, `docs/architecture/server.md:5`, and the ledger pair (`findings-ledger.json:3758` plus a `render-ledger.mjs` re-render of `FINDINGS.md`). Zero in any workflow, zero in the Dockerfile, zero in `Server/.golangci.yml` (no `local-prefixes`, `gci`, `importas` or `depguard` rule keys on the module path, so import grouping is not configured anywhere). The plan's blast-radius estimate missed one thing, and it is the one that would have gone red: **gofmt**. `J` (0x4A) sorts before every lowercase letter, so in the 36 files where a module-local import shares a contiguous group with a third-party one, the module's imports must move above `github.com/go-chi/...`. `gofmt -l` was clean before the substitution and listed exactly 36 files after it; `gofmt -w` on those 36 restores it to clean. `gofmt` is an enforced gate — the `formatters` block in `Server/.golangci.yml`, which is S-05 — so a substitution-only commit fails Lint. Verified: both directions, and the line accounting is exact. Every added line in this diff contains the new module path (728) and every removed line contains the old one (728); the count of changed lines containing neither is **zero**, so the gofmt re-sort moved module-path lines only and touched no third-party import. The residual check (`git ls-files -z | xargs -0 grep -n 'github\.com/owncord/server'`) returns exactly two hits, both deliberately out of scope: the RL-13 row in `docs/audit-2026-08-23-repository-layout.md` and the measurement row in this phase's own plan. The compiler-invisible half was proven by reverting *only* `api/main_test.go:20` to the old path on the otherwise-renamed tree: `go build ./...` and `go vet ./api/` both still pass — they see nothing wrong — while `go test ./api/` FAILS, because the runtime function name now carries the new path and goleak stops ignoring `ws.(*Hub).Run.func1`. Restoring the line makes it pass. `go.sum` is byte-identical (no `go mod tidy` was run and none was needed). All four build-tag variants compile; `go vet ./...`, `go vet -tags otel,wazero ./...` and `go vet -tags deadlock ./...` pass; `go test -race ./...` is 16/16 packages green; `go test -tags deadlock ./...` passes; the tag-gated `./plugin/...` (wazero) and `./telemetry/...` (otel) runs pass. `golangci-lint` v2.11.3 — the pinned CI version, rebuilt locally against Go 1.26 because the packaged binary cannot load a 1.26 config — reports **0 issues**. `go run ./cmd/genprotocol` leaves `git diff --exit-code ws/message_types.go ../Client/src/lib/protocolTypes.ts` clean, so the rename does not reach the generated protocol constants. `npx prettier --check .` and `node .superpowers/render-ledger.mjs --check` pass. Not included: `docs/audit-2026-08-23-repository-layout.md` and `docs/plans/b1-repository-foundation-2026-08-25.md` keep the old path — they are the audit row and the measurement that motivated this change, and rewriting them would erase the record of what was measured. They are why the residual check needs a two-path allowance rather than being empty; that allowance is stated above rather than hidden in a pathspec. `telemetry/metrics.go:19` declares `scopeVoice` for a `Server/voice` package that does not exist; the substitution carried the dead path forward verbatim as `github.com/J3vb/OwnCord/Server/voice` rather than fixing it, because correcting a real observability bug inside a mechanical rename would hide it in a 350-file diff. It needs its own item. No `go.work`, no second module, and no vanity-import host was set up — the new path resolves against the real repository, but nothing imports this module as a library, so `go get` reachability was not exercised either way. Refs RL-13, L-12
156 lines
5.4 KiB
Go
156 lines
5.4 KiB
Go
package api_test
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/J3vb/OwnCord/Server/api"
|
|
"github.com/go-chi/chi/v5"
|
|
)
|
|
|
|
// buildMetricsRouter creates a chi router with the metrics endpoint behind AdminIPRestrict.
|
|
func buildMetricsRouter(allowedCIDRs []string) http.Handler {
|
|
r := chi.NewRouter()
|
|
r.With(api.AdminIPRestrict(allowedCIDRs, nil)).
|
|
Get("/api/v1/metrics", api.HandleMetricsForTest(api.MetricsSources{
|
|
ConnectedUsers: func() int { return 5 },
|
|
VoiceSessions: func() int { return 2 },
|
|
BroadcastDrops: func() uint64 { return 0 },
|
|
LiveKitHealth: func(_ context.Context) (bool, error) { return true, nil },
|
|
ReconnectTiers: func() (uint64, uint64, uint64) { return 7, 3, 1 },
|
|
Backpressure: func() (uint64, uint64, uint64) { return 4, 9, 11 },
|
|
PersisterStats: func() (uint64, uint64, uint64, uint64, bool) { return 100, 2, 10, 1, true },
|
|
DBStats: func() sql.DBStats { return sql.DBStats{WaitCount: 6, WaitDuration: 1500 * time.Millisecond} },
|
|
PermCache: func() (uint64, uint64) { return 42, 8 },
|
|
}))
|
|
return r
|
|
}
|
|
|
|
func TestHandleMetrics_ReturnsExpectedFields(t *testing.T) {
|
|
router := buildMetricsRouter(nil) // no IP restriction
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/metrics", nil)
|
|
req.RemoteAddr = "127.0.0.1:9999"
|
|
rr := httptest.NewRecorder()
|
|
router.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("status = %d, want 200; body: %s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
var resp map[string]any
|
|
if err := json.NewDecoder(rr.Body).Decode(&resp); err != nil {
|
|
t.Fatalf("decode: %v", err)
|
|
}
|
|
|
|
requiredFields := []string{
|
|
"uptime", "uptime_seconds", "goroutines",
|
|
"heap_alloc_mb", "heap_sys_mb", "num_gc",
|
|
"connected_users", "voice_sessions", "broadcast_drops", "livekit_healthy",
|
|
"reconnect_tier_buffer", "reconnect_tier_db", "reconnect_tier_full",
|
|
"backpressure_queue_disconnects", "backpressure_high_fallbacks", "backpressure_low_drops",
|
|
"db_writer_wait_count", "db_writer_wait_seconds",
|
|
"perm_cache_hits", "perm_cache_misses",
|
|
"event_persister",
|
|
}
|
|
for _, f := range requiredFields {
|
|
if _, ok := resp[f]; !ok {
|
|
t.Errorf("missing field %q in metrics response", f)
|
|
}
|
|
}
|
|
|
|
// Verify the callback values are reflected.
|
|
if int(resp["connected_users"].(float64)) != 5 {
|
|
t.Errorf("connected_users = %v, want 5", resp["connected_users"])
|
|
}
|
|
if int(resp["voice_sessions"].(float64)) != 2 {
|
|
t.Errorf("voice_sessions = %v, want 2", resp["voice_sessions"])
|
|
}
|
|
if resp["livekit_healthy"] != true {
|
|
t.Errorf("livekit_healthy = %v, want true", resp["livekit_healthy"])
|
|
}
|
|
if int(resp["reconnect_tier_buffer"].(float64)) != 7 {
|
|
t.Errorf("reconnect_tier_buffer = %v, want 7", resp["reconnect_tier_buffer"])
|
|
}
|
|
if int(resp["backpressure_low_drops"].(float64)) != 11 {
|
|
t.Errorf("backpressure_low_drops = %v, want 11", resp["backpressure_low_drops"])
|
|
}
|
|
if got := resp["db_writer_wait_seconds"].(float64); got != 1.5 {
|
|
t.Errorf("db_writer_wait_seconds = %v, want 1.5", got)
|
|
}
|
|
if int(resp["perm_cache_hits"].(float64)) != 42 {
|
|
t.Errorf("perm_cache_hits = %v, want 42", resp["perm_cache_hits"])
|
|
}
|
|
ep, ok := resp["event_persister"].(map[string]any)
|
|
if !ok {
|
|
t.Fatalf("event_persister = %v, want object", resp["event_persister"])
|
|
}
|
|
if int(ep["persisted"].(float64)) != 100 {
|
|
t.Errorf("event_persister.persisted = %v, want 100", ep["persisted"])
|
|
}
|
|
}
|
|
|
|
func TestHandleMetrics_AdminIPRestrict_BlocksNonAdmin(t *testing.T) {
|
|
router := buildMetricsRouter([]string{"10.0.0.0/8"}) // only 10.x allowed
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/metrics", nil)
|
|
req.RemoteAddr = "192.168.1.1:9999" // not in allowed CIDR
|
|
rr := httptest.NewRecorder()
|
|
router.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusForbidden {
|
|
t.Errorf("status = %d, want 403; body: %s", rr.Code, rr.Body.String())
|
|
}
|
|
}
|
|
|
|
func TestHandleMetrics_AdminIPRestrict_AllowsAdmin(t *testing.T) {
|
|
router := buildMetricsRouter([]string{"127.0.0.0/8"})
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/metrics", nil)
|
|
req.RemoteAddr = "127.0.0.1:9999"
|
|
rr := httptest.NewRecorder()
|
|
router.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Errorf("status = %d, want 200; body: %s", rr.Code, rr.Body.String())
|
|
}
|
|
}
|
|
|
|
func TestHandleMetrics_WithoutLiveKitHealthCheck(t *testing.T) {
|
|
r := chi.NewRouter()
|
|
r.Get("/api/v1/metrics", api.HandleMetricsForTest(api.MetricsSources{
|
|
ConnectedUsers: func() int { return 0 },
|
|
VoiceSessions: func() int { return 0 },
|
|
BroadcastDrops: func() uint64 { return 0 },
|
|
// LiveKitHealth nil — no livekit wired.
|
|
// PersisterStats returning ok=false must omit event_persister.
|
|
PersisterStats: func() (uint64, uint64, uint64, uint64, bool) { return 0, 0, 0, 0, false },
|
|
}))
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/metrics", nil)
|
|
req.RemoteAddr = "127.0.0.1:9999"
|
|
rr := httptest.NewRecorder()
|
|
r.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("status = %d, want 200; body: %s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
var resp map[string]any
|
|
_ = json.NewDecoder(rr.Body).Decode(&resp)
|
|
|
|
// livekit_healthy should be absent when no health check is provided.
|
|
if _, ok := resp["livekit_healthy"]; ok {
|
|
t.Errorf("livekit_healthy should be omitted when health check is nil, got %v", resp["livekit_healthy"])
|
|
}
|
|
// event_persister should be absent when the persister reports ok=false.
|
|
if _, ok := resp["event_persister"]; ok {
|
|
t.Errorf("event_persister should be omitted when persistence is disabled, got %v", resp["event_persister"])
|
|
}
|
|
}
|