Files
OwnCord/Client/tauri-client/tests/unit/sidebar-dm-section.test.ts
T
J3vbandClaude Opus 5 8cf019c03f fix: 40 correctness fixes from the 2026-08-19 bug hunt (#1392)
* fix(identity): 1 defect(s) (OC-0151)

* fix(ws): 1 defect(s) (OC-0152)

* fix(admin): 1 defect(s) (OC-0153)

* fix(admin): 1 defect(s) (OC-0154)

* fix(voice): 2 defect(s) (OC-0155, OC-0167)

Replace distributeRoomKey's per-call offer counter with an instance-level
sliding-window budget shared by every voice_e2ee_offer send path.

- OC-0155: back-to-back rotations (the second run immediately by
  drainPendingRotationOrArmTimer) each got a fresh pacing budget, so their
  combined sends could exceed the server's single per-second cap.
- OC-0167: handleAnnounceInner's drain-time offer send bypassed pacing
  entirely, letting a key holder joining a large ongoing call burst every
  queued announce's offer unpaced.

The shared budget is reset in clearState() since the server's limit is
scoped per (sender, channel).

* fix(client): 1 defect(s) (OC-0156)

createPresenceSender dropped a queued custom_status when a later plain
status change superseded the pending retry. The retry now carries the
last committed custom_status forward.

* fix(client): 2 defect(s) (OC-0160, OC-0163)

OC-0160: exempt the handshake frames (ready, auth_ok) from the ws message
size limit and run the guard after parsing. A 'ready' frame grows unbounded
with member/channel/DM counts and carries no seq, so dropping it left the
client on empty stores with no error and no recovery path.

OC-0163: bracket a bare IPv6 host when building the wss:// URL so the
authority parses, and collapse bracketed/bare IPv6 literals to the same
cert_store_key so one server is not pinned (and user-confirmed) twice.

* fix(voice): 1 defect(s) (OC-0162)

updatePttKey armed the Rust poller when a PTT key was bound mid-call but
never applied the gate. The poller only emits 'ptt-state' on a press/release
transition, so an idle key produced no event and the already-published mic
stayed hot until the user's first physical press+release. Mirror the join-time
gate computation in updatePttKey, guarded on being in a call, polling actually
being live, and the mic not already being gated.

* fix(client): 1 defect(s) (OC-0164)

* fix(plugin): 1 defect(s) (OC-0165)

scanPluginDirectory now skips a malformed plugin subdirectory and joins its
error instead of aborting the whole scan, and LoadAll logs-and-continues so
one bad plugin directory cannot disable every other plugin.

* fix(ws): 1 defect(s) (OC-0166)

Route PresenceSelfEvent onto the owner's normal-priority queue instead of
letting it fall through to the UserTargetedEvent high-priority case, so a
user's own presence frames all share one FIFO and cannot be delivered out
of order relative to the visible presence_update path.

* fix(db): 1 defect(s) (OC-0168)

* fix(client): 1 defect(s) (OC-0169)

* fix(client): 1 defect(s) (OC-0171)

addMessage appended a broadcast at the tail even when trailing optimistic
rows were still unreconciled, so a message that committed while our own
send was in flight ended up ordered behind the row confirmSend later
stamped with a higher server id/timestamp. Insert before the trailing
unreconciled run instead.

* fix(voice): 1 defect(s) (OC-0172)

* fix(client): 1 defect(s) (OC-0174)

* fix(ws): 1 defect(s) (OC-0175)

* fix(client): 1 defect(s) (OC-0177)

* fix(client): 1 defect(s) (OC-0178)

* fix(voice): 1 defect(s) (OC-0179)

Undeafening no longer sends a voice_mute{muted:false} the server will
refuse while a moderator-imposed mute stands, matching the localServerMuted
guard already present in onMuteToggle.

* fix(client): 1 defect(s) (OC-0182)

* fix(plugin): 1 defect(s) (OC-0183)

* fix(client): 1 defect(s) (OC-0184)

Treat a trailing underscore as an emphasis delimiter, not part of the URL,
when scanning for the end of an autolinked URL.

* fix(client): 1 defect(s) (OC-0185)

Reveal .msg-actions-bar on .message:focus-within, not only on hover, so
keyboard users can see the per-message action buttons they Tab into
instead of activating them at opacity: 0.

Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK

* fix(client): 1 defect(s) (OC-0186)

* fix(client): 1 defect(s) (OC-0187)

The Add Server modal validated addresses with its own narrower regex that
never gained IPv6 support when api.ts's validator did, so an IPv6 server
could be logged into but never saved as a profile. Extract the validator
into src/lib/hostValidation.ts and use it from both call sites.

* fix(client): 1 defect(s) (OC-0189)

DM sidebar rows dropped mention counts entirely and the header total
excluded muted conversations outright, so a direct mention in a muted DM
was invisible. Render a mention badge that outranks the plain unread
badge, and count a muted channel's mentionCount toward the header total.

* fix(client): 1 defect(s) (OC-0190)

* fix(client): 1 defect(s) (OC-0191)

* fix(client): 2 defect(s) (OC-0157, OC-0176)

* fix(client): 1 defect(s) (OC-0161)

confirmTotp answers 401 for a wrong enrollment code while the session is still valid; firing the global onUnauthorized sink signed the user out and deleted their stored credential. Opt that one call out via a skipUnauthorized flag on doFetch.

* fix(admin): 1 defect(s) (OC-0173)

* fix(identity): 1 defect(s) (OC-0180)

* fix(admin): archived channel PATCH skips voice eviction and fan-out (OC-0158)

handlePatchChannel commits the AdminUpdateChannel write, then re-reads the
channel to drive voice eviction and the visibility fan-out. When that
post-commit re-read failed, the handler returned early: the archive was
durable but connected clients were never told and voice members were never
evicted, leaving users talking in a channel that no longer exists for them.

Drive the post-commit work off the values already in hand rather than
abandoning it when the re-read fails.

Adds SetPatchChannelPostCommitHook so the test can land a cancellation in
that exact window deterministically instead of racing wall-clock timing.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK

* fix(admin): role changes commit with no client ever notified (OC-0170)

broadcastRoles derived its context from the inbound *http.Request, so the
roles_update fan-out was tied to the request lifetime. A role create,
update, or delete could commit to the database and then broadcast nothing
once that request context was done, leaving every connected client on a
stale role list until the next full resync.

Decouple the fan-out from the request context so the broadcast follows the
commit rather than the caller.

Adds BroadcastRolesForTest to reach broadcastRoles from the external test
package.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK

* fix(client): username rename stomps the profile card header (OC-0188)

The account profile card's header is a resolveDisplayName() slot, but the
username-rename save path wrote the raw username straight into it. A user
with a display name set would see the header switch from their display
name to their new username after a rename, disagreeing with every other
surface that renders the same identity.

Resolve the header through the same display-name path the initial render
uses, so a rename updates the username field without touching the header.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK

* fix(client): settings overlay never focuses when mounted already-open (OC-0181)

mount() synced initial state — including the show() that calls
focusDialog() — before appending root to the container. .focus() on a
still-detached subtree is a silent no-op, so a caller that mounts while
uiStore.settingsOpen is already true (ConnectPage's lazy first-open path)
got a visible overlay whose focus trap never captured focus: keyboard
users landed outside the dialog with Tab escaping to the page behind it.

Attach root before syncing initial state so focusDialog() runs against a
connected subtree.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK

* chore: satisfy the CI gates for this fix batch

The fix batch's own commits left three CI gates red. Nothing here changes
behaviour; every edit is a lint, type, or formatting correction to code
this batch introduced.

golangci-lint:
- OC-0153 and OC-0173 replaced the last two uses of admin's setupSanitizer,
  and OC-0151 the last use of api's sanitizer, leaving both package-level
  bluemonday vars unused. Remove them along with the now-unused imports,
  and reword the comments that named them so they still explain why the
  fixpoint sanitizer is the right one without pointing at deleted symbols.
- Modernize the new handshake-deadline test's loop to range-over-int.

tsc --noEmit:
- jsdom ships no types and @types/jsdom is not a dependency, so declare the
  surface the new admin-panel test uses, following src/types/jitsi-rnnoise.d.ts.
- Narrow the last-call lookup instead of indexing under
  noUncheckedIndexedAccess, with an explicit failure message.
- membersStore.setState replaces whole state, so the presence-sender mocks
  must supply typingUsers.

prettier: reformat the five files this batch touched.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK

* chore(ledger): record the 2026-08-19 hunt and its fixes

Adds the 41 findings confirmed by the 2026-08-19 hunt and marks the 40
fixed on this branch, each with its commit, the test that pins it, and
revertProof "pass".

"pass" means an independent check, not the fixing agent's self-report:
every commit had its source diff reverted against the working tree, its
own test re-run and required to FAIL, then the source restored and the
test required to PASS. Commits whose tests live inline in Rust
#[cfg(test)] blocks were proven the same way at hunk level, splicing the
pre-fix source onto the post-fix test module.

OC-0159 is recorded as a duplicate of OC-0152: the flow-reconnect and
flow-message lenses independently found the same unbounded handshake
write and proposed the same helper over the same call sites.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK

* test(e2e): make the voice-roster join fixture self-consistent

The voice-widget join test emitted a voice_state for user_id 4 claiming
username "newvoiceuser", but id 4 is "member2" in MOCK_MEMBERS_MULTI_ROLE.
A real server never sends a voice_state whose username disagrees with the
member record for that id, and the same file's VOICE_STATE_EVENT already
pairs id 1 with "testuser" correctly — this one event was the outlier.

The contradiction was invisible while the roster rendered the payload's
raw username. OC-0177 makes it resolve identity through membersStore so a
nickname shows the same in voice as everywhere else, at which point the
fixture's own inconsistency surfaced as a failure.

Send id 4's real username and assert on it. The test still covers what it
did before — a genuine join by a user not previously in voice, asserted by
name and by roster count.

Verified against the app unchanged: with the old fixture the spec fails
1/5 (matching CI), with this one it passes 5/5.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-08-19 16:32:07 +02:00

636 lines
20 KiB
TypeScript

import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
import {
createSidebarDmSection,
type SidebarDmSectionOptions,
} from "../../src/pages/main-page/SidebarDmSection";
import { dmStore, addDmChannel } from "../../src/stores/dm.store";
import { uiStore } from "../../src/stores/ui.store";
import type { DmChannel } from "../../src/stores/dm.store";
import { muteChannel, invalidateMuteCache } from "../../src/lib/channel-mutes";
// ---------------------------------------------------------------------------
// Store reset
// ---------------------------------------------------------------------------
function resetStores(): void {
dmStore.setState(() => ({ channels: [] }));
uiStore.setState(() => ({
sidebarCollapsed: false,
memberListVisible: true,
settingsOpen: false,
activeModal: null,
theme: "dark" as const,
connectionStatus: "disconnected" as const,
transientError: null,
persistentError: null,
collapsedCategories: new Set<string>(),
sidebarMode: "channels" as const,
activeDmUserId: null,
}));
}
// ---------------------------------------------------------------------------
// Fixtures
// ---------------------------------------------------------------------------
function makeDm(overrides: Partial<DmChannel> = {}): DmChannel {
return {
channelId: 100,
recipient: { id: 10, username: "Alice", avatar: "", status: "online" },
participants: [],
name: "",
isGroup: false,
lastMessageId: null,
lastMessage: "",
lastMessageAt: "",
unreadCount: 0,
mentionCount: 0,
...overrides,
};
}
function defaultOpts(overrides: Partial<SidebarDmSectionOptions> = {}): SidebarDmSectionOptions {
return {
onSelectDm: vi.fn(),
onNewDm: vi.fn(),
...overrides,
};
}
// ---------------------------------------------------------------------------
// Tests
// ---------------------------------------------------------------------------
describe("SidebarDmSection", () => {
let container: HTMLDivElement;
beforeEach(() => {
resetStores();
localStorage.clear();
invalidateMuteCache();
container = document.createElement("div");
document.body.appendChild(container);
});
afterEach(() => {
container.remove();
});
// -------------------------------------------------------------------------
// Rendering
// -------------------------------------------------------------------------
describe("rendering", () => {
it("renders the DM section root element", () => {
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
expect(container.querySelector(".sidebar-dm-section")).not.toBeNull();
section.destroy();
});
it("renders the DM header with label and arrow", () => {
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const header = container.querySelector(".category");
expect(header).not.toBeNull();
const label = container.querySelector(".category-name");
expect(label!.textContent).toBe("DIRECT MESSAGES");
const arrow = container.querySelector(".category-arrow");
expect(arrow!.textContent).toBe("\u25BC");
section.destroy();
});
it("renders the + (add DM) button", () => {
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const addBtn = container.querySelector(".category-add-btn");
expect(addBtn).not.toBeNull();
expect(addBtn!.textContent).toBe("+");
expect(addBtn!.getAttribute("title")).toBe("New DM");
section.destroy();
});
it("renders the unread badge element (hidden when 0)", () => {
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const badge = container.querySelector(".dm-header-unread-badge") as HTMLElement;
expect(badge).not.toBeNull();
expect(badge.style.display).toBe("none");
section.destroy();
});
});
// -------------------------------------------------------------------------
// DM list items
// -------------------------------------------------------------------------
describe("DM list items", () => {
it("renders DM entries from store", () => {
addDmChannel(
makeDm({
channelId: 100,
recipient: { id: 10, username: "Alice", avatar: "", status: "online" },
}),
);
addDmChannel(
makeDm({
channelId: 101,
recipient: { id: 11, username: "Bob", avatar: "", status: "idle" },
}),
);
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const entries = container.querySelectorAll("[data-testid='dm-entry']");
expect(entries.length).toBe(2);
section.destroy();
});
it("displays up to 3 DM entries (truncates if more)", () => {
for (let i = 0; i < 5; i++) {
addDmChannel(
makeDm({
channelId: 100 + i,
recipient: { id: 10 + i, username: `User${i}`, avatar: "", status: "online" },
}),
);
}
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const entries = container.querySelectorAll("[data-testid='dm-entry']");
expect(entries.length).toBe(3);
section.destroy();
});
it("displays the recipient username in each entry", () => {
addDmChannel(
makeDm({
channelId: 100,
recipient: { id: 10, username: "Alice", avatar: "", status: "online" },
}),
);
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const name = container.querySelector(".ch-name");
expect(name!.textContent).toBe("Alice");
section.destroy();
});
it("shows unread badge on DM entries with unread messages", () => {
addDmChannel(makeDm({ channelId: 100, unreadCount: 5 }));
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const badge = container.querySelector(".dm-unread-badge");
expect(badge).not.toBeNull();
expect(badge!.textContent).toBe("5");
section.destroy();
});
it("does not show unread badge when unreadCount is 0", () => {
addDmChannel(makeDm({ channelId: 100, unreadCount: 0 }));
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const badge = container.querySelector(".dm-unread-badge");
expect(badge).toBeNull();
section.destroy();
});
it("calls onSelectDm when a DM entry is clicked", () => {
const dm = makeDm({ channelId: 100 });
addDmChannel(dm);
const onSelectDm = vi.fn();
const section = createSidebarDmSection(defaultOpts({ onSelectDm }));
container.appendChild(section.element);
const entry = container.querySelector("[data-testid='dm-entry']") as HTMLElement;
entry.click();
expect(onSelectDm).toHaveBeenCalledOnce();
// Called with the DM channel object from the store
expect(onSelectDm.mock.calls[0]![0].channelId).toBe(100);
section.destroy();
});
});
// -------------------------------------------------------------------------
// Status colors
// -------------------------------------------------------------------------
describe("status dot colors", () => {
it("shows green dot for online status", () => {
addDmChannel(
makeDm({ recipient: { id: 10, username: "Alice", avatar: "", status: "online" } }),
);
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const entry = container.querySelector("[data-testid='dm-entry']");
const dot = entry!.querySelector("span") as HTMLElement;
expect(dot.style.background).toBe("var(--green)");
section.destroy();
});
it("shows yellow dot for idle status", () => {
addDmChannel(
makeDm({ recipient: { id: 10, username: "Alice", avatar: "", status: "idle" } }),
);
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const entry = container.querySelector("[data-testid='dm-entry']");
const dot = entry!.querySelector("span") as HTMLElement;
expect(dot.style.background).toBe("var(--yellow)");
section.destroy();
});
it("shows red dot for dnd status", () => {
addDmChannel(makeDm({ recipient: { id: 10, username: "Alice", avatar: "", status: "dnd" } }));
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const entry = container.querySelector("[data-testid='dm-entry']");
const dot = entry!.querySelector("span") as HTMLElement;
expect(dot.style.background).toBe("var(--red)");
section.destroy();
});
it("shows text-micro dot for offline status", () => {
addDmChannel(
makeDm({ recipient: { id: 10, username: "Alice", avatar: "", status: "offline" } }),
);
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const entry = container.querySelector("[data-testid='dm-entry']");
const dot = entry!.querySelector("span") as HTMLElement;
expect(dot.style.background).toBe("var(--text-micro)");
section.destroy();
});
});
// -------------------------------------------------------------------------
// Total unread badge
// -------------------------------------------------------------------------
describe("total unread badge", () => {
it("shows total unread count in header badge when there are unreads", () => {
addDmChannel(makeDm({ channelId: 100, unreadCount: 3 }));
addDmChannel(
makeDm({
channelId: 101,
recipient: { id: 11, username: "Bob", avatar: "", status: "online" },
unreadCount: 2,
}),
);
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const badge = container.querySelector(".dm-header-unread-badge") as HTMLElement;
expect(badge.textContent).toBe("5");
expect(badge.style.display).not.toBe("none");
section.destroy();
});
it("hides total unread badge when all channels have 0 unreads", () => {
addDmChannel(makeDm({ channelId: 100, unreadCount: 0 }));
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const badge = container.querySelector(".dm-header-unread-badge") as HTMLElement;
expect(badge.style.display).toBe("none");
section.destroy();
});
});
// -------------------------------------------------------------------------
// Mention badge (OC-0189)
// -------------------------------------------------------------------------
describe("mention badge", () => {
it("shows a mention badge instead of the unread badge when mentionCount > 0", () => {
addDmChannel(makeDm({ channelId: 100, unreadCount: 5, mentionCount: 2 }));
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const mentionBadge = container.querySelector(".dm-mention-badge");
expect(mentionBadge).not.toBeNull();
expect(mentionBadge!.textContent).toBe("2");
// The plain unread badge must not also render alongside it.
const unreadBadge = container.querySelector(".dm-unread-badge");
expect(unreadBadge).toBeNull();
section.destroy();
});
it("still shows the mention badge on a muted DM (a mute must never hide a mention)", () => {
addDmChannel(makeDm({ channelId: 100, unreadCount: 5, mentionCount: 2 }));
muteChannel(100);
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const mentionBadge = container.querySelector(".dm-mention-badge");
expect(mentionBadge).not.toBeNull();
expect(mentionBadge!.textContent).toBe("2");
section.destroy();
});
it("counts a muted DM's mentions (not its raw unreads) toward the header badge", () => {
// Muted DM with a mention: the header must still surface the mention.
addDmChannel(makeDm({ channelId: 100, unreadCount: 5, mentionCount: 2 }));
muteChannel(100);
// Muted DM with no mention: contributes nothing, same as before.
addDmChannel(
makeDm({
channelId: 101,
recipient: { id: 11, username: "Bob", avatar: "", status: "online" },
unreadCount: 3,
mentionCount: 0,
}),
);
muteChannel(101);
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const badge = container.querySelector(".dm-header-unread-badge") as HTMLElement;
expect(badge.textContent).toBe("2");
expect(badge.style.display).not.toBe("none");
section.destroy();
});
});
// -------------------------------------------------------------------------
// View All button
// -------------------------------------------------------------------------
describe("View All button", () => {
it("is hidden when 3 or fewer DMs exist", () => {
addDmChannel(makeDm({ channelId: 100 }));
addDmChannel(
makeDm({
channelId: 101,
recipient: { id: 11, username: "Bob", avatar: "", status: "online" },
}),
);
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const viewAll = container.querySelector(".sidebar-dm-view-all") as HTMLElement;
expect(viewAll.style.display).toBe("none");
section.destroy();
});
it("is visible when more than 3 DMs exist and shows count", () => {
for (let i = 0; i < 5; i++) {
addDmChannel(
makeDm({
channelId: 100 + i,
recipient: { id: 10 + i, username: `User${i}`, avatar: "", status: "online" },
}),
);
}
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const viewAll = container.querySelector(".sidebar-dm-view-all") as HTMLElement;
expect(viewAll.style.display).not.toBe("none");
expect(viewAll.textContent).toContain("5");
section.destroy();
});
it("switches sidebar mode to dms when clicked", () => {
for (let i = 0; i < 5; i++) {
addDmChannel(
makeDm({
channelId: 100 + i,
recipient: { id: 10 + i, username: `User${i}`, avatar: "", status: "online" },
}),
);
}
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const viewAll = container.querySelector(".sidebar-dm-view-all") as HTMLElement;
viewAll.click();
expect(uiStore.getState().sidebarMode).toBe("dms");
section.destroy();
});
});
// -------------------------------------------------------------------------
// Collapse toggle
// -------------------------------------------------------------------------
describe("collapse toggle", () => {
it("collapses the DM list when header is clicked", () => {
addDmChannel(makeDm({ channelId: 100 }));
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const header = container.querySelector(".category") as HTMLElement;
header.click();
// Arrow should change to right-pointing
const arrow = container.querySelector(".category-arrow");
expect(arrow!.textContent).toBe("\u25B6");
// DM list should be hidden
const dmList = container.querySelector(".sidebar-dm-list") as HTMLElement;
expect(dmList.style.display).toBe("none");
// Header should have collapsed class
expect(header.classList.contains("collapsed")).toBe(true);
section.destroy();
});
it("expands the DM list when header is clicked again", () => {
addDmChannel(makeDm({ channelId: 100 }));
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const header = container.querySelector(".category") as HTMLElement;
// Collapse
header.click();
// Expand
header.click();
const arrow = container.querySelector(".category-arrow");
expect(arrow!.textContent).toBe("\u25BC");
const dmList = container.querySelector(".sidebar-dm-list") as HTMLElement;
expect(dmList.style.display).not.toBe("none");
expect(header.classList.contains("collapsed")).toBe(false);
section.destroy();
});
it("hides View All button when collapsed even if more than 3 DMs", () => {
for (let i = 0; i < 5; i++) {
addDmChannel(
makeDm({
channelId: 100 + i,
recipient: { id: 10 + i, username: `User${i}`, avatar: "", status: "online" },
}),
);
}
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
const header = container.querySelector(".category") as HTMLElement;
header.click();
const viewAll = container.querySelector(".sidebar-dm-view-all") as HTMLElement;
expect(viewAll.style.display).toBe("none");
section.destroy();
});
});
// -------------------------------------------------------------------------
// Add DM button
// -------------------------------------------------------------------------
describe("add DM button", () => {
it("calls onNewDm when add button is clicked", () => {
const onNewDm = vi.fn();
const section = createSidebarDmSection(defaultOpts({ onNewDm }));
container.appendChild(section.element);
const addBtn = container.querySelector(".category-add-btn") as HTMLElement;
addBtn.click();
expect(onNewDm).toHaveBeenCalledOnce();
section.destroy();
});
it("stops click propagation so header click handler is not triggered", () => {
const onNewDm = vi.fn();
const section = createSidebarDmSection(defaultOpts({ onNewDm }));
container.appendChild(section.element);
// The add button is inside the header. Clicking it should not collapse.
const addBtn = container.querySelector(".category-add-btn") as HTMLElement;
addBtn.click();
// Arrow should remain down (not collapsed)
const arrow = container.querySelector(".category-arrow");
expect(arrow!.textContent).toBe("\u25BC");
section.destroy();
});
});
// -------------------------------------------------------------------------
// Store subscription / update
// -------------------------------------------------------------------------
describe("store subscription", () => {
it("re-renders when DM store changes", () => {
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
// Initially no DM entries
expect(container.querySelectorAll("[data-testid='dm-entry']").length).toBe(0);
// Add a DM channel
addDmChannel(makeDm({ channelId: 100 }));
dmStore.flush();
// Should now have 1 entry
expect(container.querySelectorAll("[data-testid='dm-entry']").length).toBe(1);
section.destroy();
});
it("update() manually triggers a re-render", () => {
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
// Add a DM directly to store without flushing
dmStore.setState((prev) => ({
channels: [...prev.channels, makeDm({ channelId: 100 })],
}));
// Manual update
section.update();
expect(container.querySelectorAll("[data-testid='dm-entry']").length).toBe(1);
section.destroy();
});
});
// -------------------------------------------------------------------------
// Cleanup
// -------------------------------------------------------------------------
describe("cleanup", () => {
it("destroy() unsubscribes from store", () => {
const section = createSidebarDmSection(defaultOpts());
container.appendChild(section.element);
section.destroy();
// After destroy, adding DMs should not trigger re-renders
addDmChannel(makeDm({ channelId: 100 }));
dmStore.flush();
// The section element is still in the DOM (we just unsubscribed)
// but no new entries should have been rendered
expect(container.querySelectorAll("[data-testid='dm-entry']").length).toBe(0);
});
});
});