mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
J3vbandClaude Fable 5
6afa9e974c
Fixes all 109 golangci-lint findings (106 contextcheck, 1 gocritic,
2 gosec) that accumulated after D2 wired dbgen (whose queries take ctx)
under ctx-less db.DB wrappers while CI lint was quota-dead. No nolint
comments added; every finding fixed by genuinely threading context.
- db: all 138 hand-written db.DB methods take ctx first; the dbCtx()
Background shim is deleted; raw Query/QueryRow/Exec/Begin use their
Context variants; the four redundant ctx-less passthroughs removed.
db.Auditor/WriteAudit gain ctx.
- Seams: permissions.Checker (DB iface, HasChannelPerm,
RequireChannelAccess) and the service.Store interface mirror the new
signatures (ws.EventStore and plugin.PluginStore already did).
- Callers: api/admin handlers use r.Context(); ws per-message paths use
the connection ctx via DispatchV2; hub loops and startup wiring use
context.Background(); service methods thread ctx where they have one
and Background where no ctx exists. Public service surface reached by
ctx-holding chains (PermissionService.HasChannelPerm/GetRoleForUser/
RequireChannelAccess, message/dm/block/invite/profile methods) is now
ctx-first.
- Detached (context.WithoutCancel) where cancellation would break an
invariant, found by a 3-lens adversarial review of the diff:
* voice-leave background retries (a dead webhook/connection ctx killed
retry 2 before it ran, leaving ghost capacity-holding voice rows)
* rollbackVoiceJoin's compensating delete (its trigger IS the cancel)
* post-2FA-change DeleteOtherSessions and logout DeleteSession (the
security tail of a committed change must not die with the request)
* all api/ws audit writes (a banned user could suppress their own
login_blocked_banned row by aborting the request mid-bcrypt)
* admin backup VACUUM INTO (an interrupt left a truncated .db that
the backup list presented as restorable)
* post-commit message/edit refetches (a committed message must still
fan out when the sender disconnects)
* hub settings-cache refresh (one dead connection could pin stale
values for the 30s TTL)
- gocritic rangeValCopy fixed (index iteration); gosec G306 excluded in
config with justification (generated source must stay world-readable)
instead of flipping genprotocol output to 0o600.
Verified: gofmt/vet, all four build-tag variants, full suite, deadlock
pass, full -race pass, golangci-lint 0 issues uncapped.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
36 lines
1.4 KiB
Go
36 lines
1.4 KiB
Go
//go:build !wazero
|
|
|
|
// Default plugin runtime: no Wazero. Plugin manifests are still discovered,
|
|
// persisted, and surfaced through the admin API, but `.wasm` modules are not
|
|
// executed. To enable real WASM execution build with `-tags wazero`.
|
|
|
|
package plugin
|
|
|
|
import (
|
|
"context"
|
|
)
|
|
|
|
// platformInit is a no-op in the default build — there is no Wazero runtime
|
|
// to stand up, and NewRegistry leaves runtimePlatform nil so the lifecycle
|
|
// methods fall through to ErrRuntimeUnavailable.
|
|
func platformInit(_ Config) (any, func(context.Context) error, error) {
|
|
return nil, nil, nil
|
|
}
|
|
|
|
// activateWithRuntime is a no-op in the default build. It is only called from
|
|
// Registry.activate when runtimePlatform is non-nil, which never happens here.
|
|
func (r *Registry) activateWithRuntime(_ context.Context, _ any, _ *Instance) error {
|
|
return ErrRuntimeUnavailable
|
|
}
|
|
|
|
// platformDeactivate is called from Close on each plugin; a no-op here.
|
|
func (r *Registry) platformDeactivate(_ context.Context, _ *Instance) {}
|
|
|
|
// invokeCommand returns an error result instructing the operator to enable
|
|
// the wazero build tag. Default build only.
|
|
func (r *Registry) invokeCommand(_ context.Context, _ *Instance, _, _ int64, _ string, _ []string) (*CommandResult, bool) {
|
|
return &CommandResult{
|
|
Reply: "plugin runtime disabled — rebuild server with -tags wazero to execute plugin commands",
|
|
}, true
|
|
}
|