mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
* fix(identity): 1 defect(s) (OC-0151)
* fix(ws): 1 defect(s) (OC-0152)
* fix(admin): 1 defect(s) (OC-0153)
* fix(admin): 1 defect(s) (OC-0154)
* fix(voice): 2 defect(s) (OC-0155, OC-0167)
Replace distributeRoomKey's per-call offer counter with an instance-level
sliding-window budget shared by every voice_e2ee_offer send path.
- OC-0155: back-to-back rotations (the second run immediately by
drainPendingRotationOrArmTimer) each got a fresh pacing budget, so their
combined sends could exceed the server's single per-second cap.
- OC-0167: handleAnnounceInner's drain-time offer send bypassed pacing
entirely, letting a key holder joining a large ongoing call burst every
queued announce's offer unpaced.
The shared budget is reset in clearState() since the server's limit is
scoped per (sender, channel).
* fix(client): 1 defect(s) (OC-0156)
createPresenceSender dropped a queued custom_status when a later plain
status change superseded the pending retry. The retry now carries the
last committed custom_status forward.
* fix(client): 2 defect(s) (OC-0160, OC-0163)
OC-0160: exempt the handshake frames (ready, auth_ok) from the ws message
size limit and run the guard after parsing. A 'ready' frame grows unbounded
with member/channel/DM counts and carries no seq, so dropping it left the
client on empty stores with no error and no recovery path.
OC-0163: bracket a bare IPv6 host when building the wss:// URL so the
authority parses, and collapse bracketed/bare IPv6 literals to the same
cert_store_key so one server is not pinned (and user-confirmed) twice.
* fix(voice): 1 defect(s) (OC-0162)
updatePttKey armed the Rust poller when a PTT key was bound mid-call but
never applied the gate. The poller only emits 'ptt-state' on a press/release
transition, so an idle key produced no event and the already-published mic
stayed hot until the user's first physical press+release. Mirror the join-time
gate computation in updatePttKey, guarded on being in a call, polling actually
being live, and the mic not already being gated.
* fix(client): 1 defect(s) (OC-0164)
* fix(plugin): 1 defect(s) (OC-0165)
scanPluginDirectory now skips a malformed plugin subdirectory and joins its
error instead of aborting the whole scan, and LoadAll logs-and-continues so
one bad plugin directory cannot disable every other plugin.
* fix(ws): 1 defect(s) (OC-0166)
Route PresenceSelfEvent onto the owner's normal-priority queue instead of
letting it fall through to the UserTargetedEvent high-priority case, so a
user's own presence frames all share one FIFO and cannot be delivered out
of order relative to the visible presence_update path.
* fix(db): 1 defect(s) (OC-0168)
* fix(client): 1 defect(s) (OC-0169)
* fix(client): 1 defect(s) (OC-0171)
addMessage appended a broadcast at the tail even when trailing optimistic
rows were still unreconciled, so a message that committed while our own
send was in flight ended up ordered behind the row confirmSend later
stamped with a higher server id/timestamp. Insert before the trailing
unreconciled run instead.
* fix(voice): 1 defect(s) (OC-0172)
* fix(client): 1 defect(s) (OC-0174)
* fix(ws): 1 defect(s) (OC-0175)
* fix(client): 1 defect(s) (OC-0177)
* fix(client): 1 defect(s) (OC-0178)
* fix(voice): 1 defect(s) (OC-0179)
Undeafening no longer sends a voice_mute{muted:false} the server will
refuse while a moderator-imposed mute stands, matching the localServerMuted
guard already present in onMuteToggle.
* fix(client): 1 defect(s) (OC-0182)
* fix(plugin): 1 defect(s) (OC-0183)
* fix(client): 1 defect(s) (OC-0184)
Treat a trailing underscore as an emphasis delimiter, not part of the URL,
when scanning for the end of an autolinked URL.
* fix(client): 1 defect(s) (OC-0185)
Reveal .msg-actions-bar on .message:focus-within, not only on hover, so
keyboard users can see the per-message action buttons they Tab into
instead of activating them at opacity: 0.
Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK
* fix(client): 1 defect(s) (OC-0186)
* fix(client): 1 defect(s) (OC-0187)
The Add Server modal validated addresses with its own narrower regex that
never gained IPv6 support when api.ts's validator did, so an IPv6 server
could be logged into but never saved as a profile. Extract the validator
into src/lib/hostValidation.ts and use it from both call sites.
* fix(client): 1 defect(s) (OC-0189)
DM sidebar rows dropped mention counts entirely and the header total
excluded muted conversations outright, so a direct mention in a muted DM
was invisible. Render a mention badge that outranks the plain unread
badge, and count a muted channel's mentionCount toward the header total.
* fix(client): 1 defect(s) (OC-0190)
* fix(client): 1 defect(s) (OC-0191)
* fix(client): 2 defect(s) (OC-0157, OC-0176)
* fix(client): 1 defect(s) (OC-0161)
confirmTotp answers 401 for a wrong enrollment code while the session is still valid; firing the global onUnauthorized sink signed the user out and deleted their stored credential. Opt that one call out via a skipUnauthorized flag on doFetch.
* fix(admin): 1 defect(s) (OC-0173)
* fix(identity): 1 defect(s) (OC-0180)
* fix(admin): archived channel PATCH skips voice eviction and fan-out (OC-0158)
handlePatchChannel commits the AdminUpdateChannel write, then re-reads the
channel to drive voice eviction and the visibility fan-out. When that
post-commit re-read failed, the handler returned early: the archive was
durable but connected clients were never told and voice members were never
evicted, leaving users talking in a channel that no longer exists for them.
Drive the post-commit work off the values already in hand rather than
abandoning it when the re-read fails.
Adds SetPatchChannelPostCommitHook so the test can land a cancellation in
that exact window deterministically instead of racing wall-clock timing.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK
* fix(admin): role changes commit with no client ever notified (OC-0170)
broadcastRoles derived its context from the inbound *http.Request, so the
roles_update fan-out was tied to the request lifetime. A role create,
update, or delete could commit to the database and then broadcast nothing
once that request context was done, leaving every connected client on a
stale role list until the next full resync.
Decouple the fan-out from the request context so the broadcast follows the
commit rather than the caller.
Adds BroadcastRolesForTest to reach broadcastRoles from the external test
package.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK
* fix(client): username rename stomps the profile card header (OC-0188)
The account profile card's header is a resolveDisplayName() slot, but the
username-rename save path wrote the raw username straight into it. A user
with a display name set would see the header switch from their display
name to their new username after a rename, disagreeing with every other
surface that renders the same identity.
Resolve the header through the same display-name path the initial render
uses, so a rename updates the username field without touching the header.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK
* fix(client): settings overlay never focuses when mounted already-open (OC-0181)
mount() synced initial state — including the show() that calls
focusDialog() — before appending root to the container. .focus() on a
still-detached subtree is a silent no-op, so a caller that mounts while
uiStore.settingsOpen is already true (ConnectPage's lazy first-open path)
got a visible overlay whose focus trap never captured focus: keyboard
users landed outside the dialog with Tab escaping to the page behind it.
Attach root before syncing initial state so focusDialog() runs against a
connected subtree.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK
* chore: satisfy the CI gates for this fix batch
The fix batch's own commits left three CI gates red. Nothing here changes
behaviour; every edit is a lint, type, or formatting correction to code
this batch introduced.
golangci-lint:
- OC-0153 and OC-0173 replaced the last two uses of admin's setupSanitizer,
and OC-0151 the last use of api's sanitizer, leaving both package-level
bluemonday vars unused. Remove them along with the now-unused imports,
and reword the comments that named them so they still explain why the
fixpoint sanitizer is the right one without pointing at deleted symbols.
- Modernize the new handshake-deadline test's loop to range-over-int.
tsc --noEmit:
- jsdom ships no types and @types/jsdom is not a dependency, so declare the
surface the new admin-panel test uses, following src/types/jitsi-rnnoise.d.ts.
- Narrow the last-call lookup instead of indexing under
noUncheckedIndexedAccess, with an explicit failure message.
- membersStore.setState replaces whole state, so the presence-sender mocks
must supply typingUsers.
prettier: reformat the five files this batch touched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK
* chore(ledger): record the 2026-08-19 hunt and its fixes
Adds the 41 findings confirmed by the 2026-08-19 hunt and marks the 40
fixed on this branch, each with its commit, the test that pins it, and
revertProof "pass".
"pass" means an independent check, not the fixing agent's self-report:
every commit had its source diff reverted against the working tree, its
own test re-run and required to FAIL, then the source restored and the
test required to PASS. Commits whose tests live inline in Rust
#[cfg(test)] blocks were proven the same way at hunk level, splicing the
pre-fix source onto the post-fix test module.
OC-0159 is recorded as a duplicate of OC-0152: the flow-reconnect and
flow-message lenses independently found the same unbounded handshake
write and proposed the same helper over the same call sites.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK
* test(e2e): make the voice-roster join fixture self-consistent
The voice-widget join test emitted a voice_state for user_id 4 claiming
username "newvoiceuser", but id 4 is "member2" in MOCK_MEMBERS_MULTI_ROLE.
A real server never sends a voice_state whose username disagrees with the
member record for that id, and the same file's VOICE_STATE_EVENT already
pairs id 1 with "testuser" correctly — this one event was the outlier.
The contradiction was invisible while the roster rendered the payload's
raw username. OC-0177 makes it resolve identity through membersStore so a
nickname shows the same in voice as everywhere else, at which point the
fixture's own inconsistency surfaced as a failure.
Send id 4's real username and assert on it. The test still covers what it
did before — a genuine join by a user not previously in voice, asserted by
name and by roster count.
Verified against the app unchanged: with the old fixture the spec fails
1/5 (matching CI), with this one it passes 5/5.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M6gVN2JM5wrduhkNaFCxdK
---------
Co-authored-by: Claude <noreply@anthropic.com>
329 lines
12 KiB
Go
329 lines
12 KiB
Go
package ws
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"log/slog"
|
|
|
|
"github.com/owncord/server/auth"
|
|
"github.com/owncord/server/db"
|
|
"github.com/owncord/server/permissions"
|
|
)
|
|
|
|
// HandleMessageForTest dispatches a raw WebSocket message from client c.
|
|
// Exported so ws_test package can invoke it directly without a real connection.
|
|
func (h *Hub) HandleMessageForTest(c *Client, raw []byte) {
|
|
h.handleMessage(c, raw)
|
|
}
|
|
|
|
// HandleVoiceLeaveForTest calls handleVoiceLeave directly, simulating a
|
|
// disconnect-triggered cleanup without an explicit voice_leave message.
|
|
// Exported for ws_test package use only.
|
|
func (h *Hub) HandleVoiceLeaveForTest(c *Client) {
|
|
h.handleVoiceLeave(context.Background(), c)
|
|
}
|
|
|
|
// handleMessage parses the envelope and dispatches to the appropriate handler.
|
|
func (h *Hub) handleMessage(c *Client, raw []byte) {
|
|
if h.handleMessageSessionRecheck(c) {
|
|
return
|
|
}
|
|
|
|
env, msgType, reqID, ok := h.handleMessageDecode(c, raw)
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
// ── Typed command dispatch ───────────────────────────────────────────
|
|
// Every message type parses through its constructor into a typed Command,
|
|
// then dispatches to its V2 handler, which returns a Result the applier
|
|
// below acts on. There is no second (V1) generation — the strangler-fig
|
|
// migration is complete.
|
|
ctor, ok := getCommandConstructor(env.Type)
|
|
if !ok {
|
|
slog.Warn("ws handleMessage unknown type", "user_id", c.userID, "msg_type", msgType, "req_id", reqID)
|
|
c.sendMsg(buildErrorMsg(ErrCodeUnknownType, fmt.Sprintf("unknown message type: %s", msgType)))
|
|
return
|
|
}
|
|
|
|
cmd, parseErr := ctor(c.userID, env.ID, env.Payload)
|
|
if parseErr != nil {
|
|
slog.Warn("ws command parse error", "user_id", c.userID, "msg_type", msgType, "req_id", reqID, "err", parseErr)
|
|
c.sendMsg(buildErrorMsgWithID(ErrCodeBadRequest, "invalid payload", env.ID))
|
|
return
|
|
}
|
|
|
|
var username string
|
|
var avatar, displayName *string
|
|
if c.user != nil {
|
|
username = c.user.Username
|
|
avatar = c.user.Avatar
|
|
displayName = c.user.DisplayName
|
|
}
|
|
voiceChID, voiceJoinTok := c.getVoiceState()
|
|
info := ClientInfo{
|
|
UserID: c.userID,
|
|
Username: username,
|
|
Avatar: avatar,
|
|
DisplayName: displayName,
|
|
RoleName: c.roleName,
|
|
ReqID: env.ID,
|
|
VoiceChannelID: voiceChID,
|
|
VoiceJoinToken: voiceJoinTok,
|
|
}
|
|
|
|
result, dispatched := h.registry.DispatchV2(c.ctx, cmd, info)
|
|
if !dispatched {
|
|
// A registered constructor with no V2 handler is a wiring bug — the
|
|
// guard test (TestEveryConstructorHasV2Handler) locks this shut.
|
|
slog.Error("ws no V2 handler for constructed command",
|
|
"user_id", c.userID, "msg_type", msgType, "req_id", reqID, "type", env.Type)
|
|
c.sendMsg(buildErrorMsgWithID(ErrCodeInternal, "internal error", env.ID))
|
|
return
|
|
}
|
|
if result.Error != nil {
|
|
if ce, ok := result.Error.(ClientError); ok {
|
|
c.sendMsg(buildErrorMsgWithID(ce.Code, ce.Message, env.ID))
|
|
} else {
|
|
slog.Error("ws handler internal error",
|
|
"user_id", c.userID, "msg_type", msgType, "req_id", reqID, "err", result.Error)
|
|
c.sendMsg(buildErrorMsgWithID(ErrCodeInternal, "internal error", env.ID))
|
|
}
|
|
// A rejection may still need to evict: voice_token_refresh returns
|
|
// LeaveVoice alongside its error when CONNECT_VOICE was revoked, so the
|
|
// user is removed from the SFU rather than merely denied a new token.
|
|
if result.LeaveVoice {
|
|
h.handleVoiceLeave(c.ctx, c)
|
|
}
|
|
return
|
|
}
|
|
|
|
h.handleMessageApply(c, env, result)
|
|
}
|
|
|
|
// handleMessageSessionRecheck performs handleMessage's periodic session
|
|
// revalidation. It reports whether the connection was closed, in which case
|
|
// the caller must stop processing the frame.
|
|
func (h *Hub) handleMessageSessionRecheck(c *Client) bool {
|
|
// Periodic session expiry check: every SessionCheckInterval messages,
|
|
// re-validate the session token. This catches sessions that are revoked or
|
|
// expire while the WebSocket connection is still open.
|
|
c.mu.Lock()
|
|
c.msgCount++
|
|
shouldCheck := c.msgCount >= SessionCheckInterval
|
|
if shouldCheck {
|
|
c.msgCount = 0
|
|
}
|
|
c.mu.Unlock()
|
|
|
|
if shouldCheck && c.tokenHash != "" {
|
|
result, dbErr := h.db.GetSessionWithBanStatus(c.ctx, c.tokenHash)
|
|
if dbErr != nil || result == nil || auth.IsSessionExpired(result.ExpiresAt) {
|
|
slog.Info("ws session expired, closing connection", "user_id", c.userID)
|
|
h.kickClient(c)
|
|
return true
|
|
}
|
|
tempUser := &db.User{Banned: result.Banned, BanExpires: result.BanExpires}
|
|
if auth.IsEffectivelyBanned(tempUser) {
|
|
slog.Info("ws user banned, closing connection", "user_id", c.userID)
|
|
c.sendMsg(buildErrorMsg(ErrCodeBanned, "you are banned"))
|
|
h.kickClient(c)
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// handleMessageDecode parses handleMessage's inbound frame into an envelope,
|
|
// maintaining the consecutive-invalid-JSON counter, and returns the capped
|
|
// msg_type / req_id used for logging. It reports false when the frame was
|
|
// rejected and the caller must stop.
|
|
func (h *Hub) handleMessageDecode(c *Client, raw []byte) (envelope, string, string, bool) {
|
|
var env envelope
|
|
if err := json.Unmarshal(raw, &env); err != nil {
|
|
c.mu.Lock()
|
|
c.invalidCount++
|
|
count := c.invalidCount
|
|
c.mu.Unlock()
|
|
|
|
slog.Warn("ws handleMessage invalid JSON", "user_id", c.userID, "err", err, "invalid_count", count)
|
|
c.sendMsg(buildErrorMsg(ErrCodeInvalidJSON, "message must be valid JSON"))
|
|
|
|
if count >= 10 {
|
|
slog.Warn("ws too many invalid messages, closing connection", "user_id", c.userID, "invalid_count", count)
|
|
h.kickClient(c)
|
|
}
|
|
return env, "", "", false
|
|
}
|
|
|
|
// Valid parse — reset consecutive invalid counter.
|
|
c.mu.Lock()
|
|
c.invalidCount = 0
|
|
c.mu.Unlock()
|
|
|
|
// Cap client-controlled fields before logging to prevent log injection
|
|
// and unbounded log entries.
|
|
msgType := env.Type
|
|
if len(msgType) > 64 {
|
|
msgType = msgType[:64]
|
|
}
|
|
reqID := env.ID
|
|
if len(reqID) > 64 {
|
|
reqID = reqID[:64]
|
|
}
|
|
|
|
// Correlation attrs (user_id/msg_type/req_id) are inlined at each log site
|
|
// below rather than bound via slog.With — the With clone allocated a new
|
|
// handler chain per message even when nothing ended up being logged.
|
|
slog.Debug("ws ← client message", "user_id", c.userID, "msg_type", msgType, "req_id", reqID)
|
|
|
|
return env, msgType, reqID, true
|
|
}
|
|
|
|
// handleMessageApply applies the client state mutations and side effects that a
|
|
// successful V2 Result asks for.
|
|
func (h *Hub) handleMessageApply(c *Client, env envelope, result Result) {
|
|
// Apply client state mutations and side effects.
|
|
if result.SetChannelID != nil {
|
|
h.applySetChannelID(c, *result.SetChannelID)
|
|
}
|
|
if result.SetE2EEPubKey != nil {
|
|
sig := ""
|
|
if result.SetE2EESignature != nil {
|
|
sig = *result.SetE2EESignature
|
|
}
|
|
c.setE2EEPubKey(*result.SetE2EEPubKey, sig)
|
|
}
|
|
if result.SetVoiceJoinToken != nil {
|
|
chID := c.getVoiceChID()
|
|
if chID != 0 {
|
|
c.setVoiceState(chID, *result.SetVoiceJoinToken)
|
|
}
|
|
}
|
|
if result.Reply != nil {
|
|
c.sendMsg(result.Reply)
|
|
}
|
|
if len(result.Events) > 0 {
|
|
h.EmitEvents(c.ctx, result.Events)
|
|
}
|
|
// Voice join/leave hand off to the hub-internal routines (also called
|
|
// un-throttled on disconnect/switch). handleVoiceJoin re-reads channel_id
|
|
// from the already-validated envelope payload.
|
|
if result.LeaveVoice {
|
|
h.handleVoiceLeave(c.ctx, c)
|
|
}
|
|
if result.JoinVoice {
|
|
h.handleVoiceJoin(c.ctx, c, env.Payload)
|
|
}
|
|
}
|
|
|
|
// applySetChannelID moves c's focused channel to newChID and updates its
|
|
// pub/sub topic subscription to match.
|
|
//
|
|
// OC-0024: channel_focus's handler (service/channel.go) checks READ_MESSAGES
|
|
// before returning, but that check and the Subscribe below are separated by
|
|
// two SQLite round trips (GetLatestMessageID/UpdateReadState), and the hub's
|
|
// visibility-revoke sweeps (RefreshChannelVisibility, revokeUnreadableChannels)
|
|
// only ever Unsubscribe a topic the socket already holds at the instant they
|
|
// run — a revoke that commits inside that window finds nothing to undo, and
|
|
// the Subscribe that lands once the window closes is never revisited. Once
|
|
// Subscribe is called we re-validate READ_MESSAGES live and unwind it on
|
|
// failure, which closes the race from both directions: a revoke that already
|
|
// committed is caught right here, and a revoke that commits afterward still
|
|
// finds the subscription the sweeps have always expected to see.
|
|
func (h *Hub) applySetChannelID(c *Client, newChID int64) {
|
|
oldChID := c.getChannelID()
|
|
c.mu.Lock()
|
|
c.channelID = newChID
|
|
c.mu.Unlock()
|
|
if oldChID == newChID {
|
|
return
|
|
}
|
|
if oldChID > 0 {
|
|
h.pubsub.Unsubscribe(c, ChannelTopic(oldChID))
|
|
}
|
|
if newChID <= 0 {
|
|
return
|
|
}
|
|
h.pubsub.Subscribe(c, ChannelTopic(newChID))
|
|
// The re-validation mirrors HandleChannelFocus's admission gate: DMs are
|
|
// participant-gated (the READ role bit is deliberately waived), non-DMs
|
|
// need READ_MESSAGES, and a deleted channel is a denial. A transient
|
|
// lookup error is NOT a denial — the recheck exists to catch a concrete
|
|
// revoke in the Subscribe race window, the sweeps stay authoritative, and
|
|
// unwinding on error would turn any DB hiccup into a silently dead
|
|
// message stream with no error frame sent to the client.
|
|
ch, chErr := h.db.GetChannel(c.ctx, newChID)
|
|
if chErr != nil {
|
|
return
|
|
}
|
|
if ch != nil && ch.Type == "dm" {
|
|
if ok, dmErr := h.db.IsDMParticipant(c.ctx, c.userID, newChID); dmErr != nil || ok {
|
|
return
|
|
}
|
|
} else if ch != nil && !ch.Archived && hasChannelAccess(c.ctx, h.db, h.permChecker, h.perms, c.userID, newChID, permissions.ReadMessages) {
|
|
return
|
|
}
|
|
h.pubsub.Unsubscribe(c, ChannelTopic(newChID))
|
|
c.mu.Lock()
|
|
if c.channelID == newChID {
|
|
c.channelID = 0
|
|
}
|
|
c.mu.Unlock()
|
|
}
|
|
|
|
// hasChannelPerm reports whether the client's role has all the given permission bits.
|
|
// Delegates to the unified permissions.Checker.
|
|
//
|
|
// F5: resolve the user's CURRENT role via GetRoleForUser(c.userID) rather than the
|
|
// role snapshotted onto c.user at connect time. A mid-session role reassignment
|
|
// (e.g. stripping CONNECT_VOICE) must take effect immediately for the live
|
|
// connection — including the SPEAK/VIDEO grants baked into a freshly minted
|
|
// LiveKit token — instead of persisting until the user reconnects. This mirrors
|
|
// the V2 handlers, which already resolve the live role (deps.go).
|
|
//
|
|
// Deliberately NOT routed through the cached PermissionService: the only
|
|
// production caller is sweepStaleVoiceStates, the last-line revocation backstop
|
|
// that evicts live voice participants. Reading the DB live keeps that backstop
|
|
// authoritative even for a permission change that somehow bypassed the
|
|
// invalidation hooks, and the sweep runs once a minute for only the clients
|
|
// currently in voice, so the uncached cost is negligible.
|
|
func (h *Hub) hasChannelPerm(ctx context.Context, c *Client, channelID int64, perm int64) bool {
|
|
role, err := h.db.GetRoleForUser(ctx, c.userID)
|
|
if err != nil || role == nil {
|
|
return false
|
|
}
|
|
return h.permChecker.HasChannelPerm(ctx, role.Permissions, role.ID, c.userID, channelID, perm)
|
|
}
|
|
|
|
// requireChannelAccess checks whether the client may act on the channel with the
|
|
// given permission. If not, it sends a FORBIDDEN error to the client and returns
|
|
// false. The permLabel should be the human-readable permission name (e.g.
|
|
// "SEND_MESSAGES").
|
|
//
|
|
// Unlike hasChannelPerm it is channel-type aware (see hasChannelAccess), which
|
|
// is what a channel id taken straight from a client frame requires: role bits
|
|
// alone let any member through to a DM they are not a participant of.
|
|
func (h *Hub) requireChannelAccess(ctx context.Context, c *Client, channelID int64, perm int64, permLabel string) bool {
|
|
if hasChannelAccess(ctx, h.db, h.permChecker, h.perms, c.userID, channelID, perm) {
|
|
return true
|
|
}
|
|
slog.Warn("ws permission denied", "user_id", c.userID, "channel_id", channelID, "perm", permLabel)
|
|
c.sendMsg(buildErrorMsg(ErrCodeForbidden, "missing "+permLabel+" permission"))
|
|
return false
|
|
}
|
|
|
|
// broadcastExcludeLow sends a message at low priority to all clients in the
|
|
// sender's channel EXCEPT the sender. Messages sent via this function are NOT
|
|
// stored in the replay ring buffer — they are ephemeral. This is correct for
|
|
// typing indicators (dropped on overflow instead of disconnecting) but would
|
|
// be incorrect for messages that should survive reconnection replay.
|
|
func (h *Hub) broadcastExcludeLow(channelID, excludeUserID int64, msg []byte) {
|
|
if channelID == 0 {
|
|
h.pubsub.PublishLow(TopicGlobal, msg, excludeUserID)
|
|
return
|
|
}
|
|
h.pubsub.PublishLow(ChannelTopic(channelID), msg, excludeUserID)
|
|
}
|