Files
OwnCord/Client/tauri-client/tests/unit/create-channel-modal.test.ts
T
J3vbandClaude 9df0e63b5f build: toolchain and dependency upgrades (TypeScript 6, Node 24 CI, Vite 8, Vitest 4, Go/Rust deps) (#1401)
* build(client): upgrade TypeScript to 6.0.3

Staging step toward TypeScript 7 (the native compiler), which needs its
7.1 stable API before typescript-eslint and Stryker's typescript-checker
can run on it. TS 6 is the JS-based bridge release that aligns config
defaults with 7.

Two fallout fixes:
- tsconfig.e2e.json: TS 6 defaults "types" to [] instead of every
  installed @types package, so the Playwright layer's Node globals
  (process, Buffer) need an explicit "types": ["node"].
- media-visibility.test.ts: TS 6's DOM lib adds scrollMargin to
  IntersectionObserver, so the mock grows the property.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lw5KEz6gdD816Wxmm4A3Bn

* build(server): bump chi to 5.3.2, modernc.org/sqlite to 1.57.0, toolchain to go1.26.7

Go 1.27 deliberately deferred until 1.27.1 lands.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lw5KEz6gdD816Wxmm4A3Bn

* build(tauri): bump tokio-tungstenite to 0.30, refresh Cargo.lock

In-range lockfile refresh via cargo update; tungstenite 0.29/0.30 changes
are client-API-neutral (header handling, server-side handshake hardening).

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lw5KEz6gdD816Wxmm4A3Bn

* build(client): upgrade vite 8, vitest 4, jsdom 30, stryker 10 + minors

- vite 6 -> 8: Rolldown requires the function form of manualChunks;
  __dirname -> import.meta.dirname in configs
- vitest 3 -> 4: browser provider moved to @vitest/browser-playwright;
  vi.fn() mocks now need explicit signatures (typed throughout tests);
  constructor mocks use function impls; restoreAllMocks no longer resets
  vi.fn state; matchMedia spies replaced with vi.stubGlobal
- jsdom 29 -> 30: one internal bookkeeping abort listener per signal,
  listener-count regression tests adjusted (leak detection retained)
- stryker 9 -> 10, @types/node 20 -> 24, eslint/oxlint/livekit-client minors
- tsconfigs: explicit "types" now that TS6/vitest4 stop injecting
  @types/node ambiently; build config keeps Node globals out of src/

Validated: tsc (main/build/e2e), eslint, oxlint, knip, prettier,
unit+integration (5196 tests), browser suite, vite build, stryker dry run.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lw5KEz6gdD816Wxmm4A3Bn

* ci: move Node 20 (EOL 2026-04-30) to Node 24 LTS

The jsdom suite runs on modern Node without --no-experimental-webstorage:
tests/setup.ts already replaces the shadowed localStorage with an
in-memory shim. Client CLAUDE.md gotcha updated accordingly.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lw5KEz6gdD816Wxmm4A3Bn

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-08-22 06:48:58 +02:00

390 lines
13 KiB
TypeScript

import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
import {
CHANNEL_TYPES,
defaultTypeForCategory,
createCreateChannelModal,
} from "@components/CreateChannelModal";
import type { CreateChannelModalOptions } from "@components/CreateChannelModal";
import { setChannels, UNCATEGORIZED_VOICE_CATEGORY } from "@stores/channels.store";
// ---------------------------------------------------------------------------
// Pure function tests
// ---------------------------------------------------------------------------
describe("defaultTypeForCategory", () => {
it("defaults to voice only in the synthetic uncategorized-voice group", () => {
expect(defaultTypeForCategory(UNCATEGORIZED_VOICE_CATEGORY)).toBe("voice");
});
it("defaults to text everywhere else, voice-sounding names included", () => {
for (const category of ["Voice Channels", "VOICE CHANNELS", "Text Channels", "Chat", ""]) {
expect(defaultTypeForCategory(category)).toBe("text");
}
});
});
describe("CHANNEL_TYPES", () => {
it("offers every channel type, regardless of category", () => {
expect([...CHANNEL_TYPES]).toEqual(["text", "voice", "announcement"]);
});
});
// ---------------------------------------------------------------------------
// Component tests
// ---------------------------------------------------------------------------
describe("CreateChannelModal", () => {
let container: HTMLDivElement;
beforeEach(() => {
container = document.createElement("div");
document.body.appendChild(container);
});
afterEach(() => {
container.remove();
// Clean up any modals attached to document.body
document.querySelectorAll("[data-testid='create-channel-modal']").forEach((el) => el.remove());
});
function makeModal(category: string, overrides?: Partial<CreateChannelModalOptions>) {
const options: CreateChannelModalOptions = {
category,
onCreate: overrides?.onCreate ?? vi.fn(async () => {}),
onClose: overrides?.onClose ?? vi.fn(),
};
const modal = createCreateChannelModal(options);
modal.mount(container);
return { modal, options };
}
it("renders the modal overlay", () => {
const { modal } = makeModal("Text Channels");
const overlay = container.querySelector("[data-testid='create-channel-modal']");
expect(overlay).not.toBeNull();
modal.destroy?.();
});
it("offers every channel type under a text-sounding category", () => {
const { modal } = makeModal("Text Channels");
const select = container.querySelector(
"[data-testid='channel-type-select']",
) as HTMLSelectElement;
expect(Array.from(select.options).map((o) => o.value)).toEqual([
"text",
"voice",
"announcement",
]);
modal.destroy?.();
});
it("offers every channel type under a voice-sounding category too", () => {
const { modal } = makeModal("Voice Channels");
const select = container.querySelector(
"[data-testid='channel-type-select']",
) as HTMLSelectElement;
expect(Array.from(select.options).map((o) => o.value)).toEqual([
"text",
"voice",
"announcement",
]);
modal.destroy?.();
});
it("pre-fills the category as editable text", () => {
const { modal } = makeModal("Gaming");
const input = container.querySelector(
"[data-testid='channel-category-input']",
) as HTMLInputElement;
expect(input.value).toBe("Gaming");
expect(input.hasAttribute("disabled")).toBe(false);
modal.destroy?.();
});
it("suggests the categories already in use via a datalist", () => {
setChannels([
{ id: 1, name: "general", type: "text", category: "Chat", position: 0 },
{ id: 2, name: "lounge", type: "voice", category: "Gaming", position: 1 },
{ id: 3, name: "loose", type: "text", category: null, position: 2 },
]);
const { modal } = makeModal("Chat");
const list = container.querySelector("#create-channel-categories");
const values = Array.from(list?.querySelectorAll("option") ?? []).map((o) =>
o.getAttribute("value"),
);
expect(values).toEqual(["Chat", "Gaming"]);
modal.destroy?.();
});
it("submits an edited category rather than the one it opened on", async () => {
const onCreate = vi.fn(async () => {});
const { modal } = makeModal("Chat", { onCreate });
(container.querySelector("[data-testid='channel-name-input']") as HTMLInputElement).value =
"lounge";
(container.querySelector("[data-testid='channel-category-input']") as HTMLInputElement).value =
" Gaming ";
(container.querySelector("[data-testid='channel-type-select']") as HTMLSelectElement).value =
"voice";
(container.querySelector("[data-testid='channel-create-submit']") as HTMLButtonElement).click();
await vi.waitFor(() => {
expect(onCreate).toHaveBeenCalledWith({
name: "lounge",
type: "voice",
category: "Gaming",
});
});
modal.destroy?.();
});
it("shows error when submitting with empty name", () => {
const onCreate = vi.fn(async () => {});
const { modal } = makeModal("Text Channels", { onCreate });
const submitBtn = container.querySelector(
"[data-testid='channel-create-submit']",
) as HTMLButtonElement;
submitBtn.click();
const error = container.querySelector("[data-testid='channel-create-error']");
expect(error?.textContent).toContain("required");
expect(onCreate).not.toHaveBeenCalled();
modal.destroy?.();
});
it("calls onCreate with correct data when name is provided", async () => {
const onCreate = vi.fn(async () => {});
const { modal } = makeModal("Text Channels", { onCreate });
const nameInput = container.querySelector(
"[data-testid='channel-name-input']",
) as HTMLInputElement;
nameInput.value = "test-channel";
const submitBtn = container.querySelector(
"[data-testid='channel-create-submit']",
) as HTMLButtonElement;
submitBtn.click();
// Wait for async handler
await vi.waitFor(() => {
expect(onCreate).toHaveBeenCalledWith({
name: "test-channel",
type: "text",
category: "Text Channels",
});
});
modal.destroy?.();
});
it("calls onClose when close button is clicked", () => {
const onClose = vi.fn();
const { modal } = makeModal("Text Channels", { onClose });
const closeBtn = container.querySelector(".modal-close") as HTMLButtonElement;
closeBtn.click();
expect(onClose).toHaveBeenCalled();
modal.destroy?.();
});
it("removes overlay on destroy", () => {
const { modal } = makeModal("Text Channels");
expect(container.querySelector("[data-testid='create-channel-modal']")).not.toBeNull();
modal.destroy?.();
expect(container.querySelector("[data-testid='create-channel-modal']")).toBeNull();
});
it("shows error message when onCreate rejects with Error", async () => {
const onCreate = vi.fn().mockRejectedValue(new Error("Name already exists"));
const { modal } = makeModal("Text Channels", { onCreate });
const nameInput = container.querySelector(
"[data-testid='channel-name-input']",
) as HTMLInputElement;
nameInput.value = "duplicate";
const submitBtn = container.querySelector(
"[data-testid='channel-create-submit']",
) as HTMLButtonElement;
submitBtn.click();
await vi.waitFor(() => {
const error = container.querySelector("[data-testid='channel-create-error']");
expect(error?.textContent).toBe("Name already exists");
});
// Button should be re-enabled
expect(submitBtn.hasAttribute("disabled")).toBe(false);
expect(submitBtn.textContent).toBe("Create Channel");
modal.destroy?.();
});
it("shows generic error when onCreate rejects with non-Error", async () => {
const onCreate = vi.fn().mockRejectedValue("string error");
const { modal } = makeModal("Text Channels", { onCreate });
const nameInput = container.querySelector(
"[data-testid='channel-name-input']",
) as HTMLInputElement;
nameInput.value = "test";
const submitBtn = container.querySelector(
"[data-testid='channel-create-submit']",
) as HTMLButtonElement;
submitBtn.click();
await vi.waitFor(() => {
const error = container.querySelector("[data-testid='channel-create-error']");
expect(error?.textContent).toBe("Failed to create channel");
});
modal.destroy?.();
});
it("disables submit button and shows 'Creating...' while creating", async () => {
let resolveCreate: (() => void) | undefined;
const onCreate = vi.fn<NonNullable<CreateChannelModalOptions["onCreate"]>>(
() =>
new Promise<void>((resolve) => {
resolveCreate = resolve;
}),
);
const { modal } = makeModal("Text Channels", { onCreate });
const nameInput = container.querySelector(
"[data-testid='channel-name-input']",
) as HTMLInputElement;
nameInput.value = "new-channel";
const submitBtn = container.querySelector(
"[data-testid='channel-create-submit']",
) as HTMLButtonElement;
submitBtn.click();
expect(submitBtn.hasAttribute("disabled")).toBe(true);
expect(submitBtn.textContent).toBe("Creating...");
resolveCreate?.();
modal.destroy?.();
});
it("calls onClose when cancel button is clicked", () => {
const onClose = vi.fn();
const { modal } = makeModal("Text Channels", { onClose });
const cancelBtn = container.querySelector(".btn-modal-cancel") as HTMLButtonElement;
cancelBtn.click();
expect(onClose).toHaveBeenCalled();
modal.destroy?.();
});
it("calls onClose on backdrop click", () => {
const onClose = vi.fn();
const { modal } = makeModal("Text Channels", { onClose });
const overlay = container.querySelector(
"[data-testid='create-channel-modal']",
) as HTMLDivElement;
// Simulate clicking the overlay backdrop directly
overlay.dispatchEvent(new MouseEvent("click", { bubbles: true }));
expect(onClose).toHaveBeenCalled();
modal.destroy?.();
});
it("clears previous error when submitting valid data after error", async () => {
const onCreate = vi
.fn()
.mockRejectedValueOnce(new Error("First error"))
.mockResolvedValueOnce(undefined);
const { modal } = makeModal("Text Channels", { onCreate });
const nameInput = container.querySelector(
"[data-testid='channel-name-input']",
) as HTMLInputElement;
nameInput.value = "test";
const submitBtn = container.querySelector(
"[data-testid='channel-create-submit']",
) as HTMLButtonElement;
submitBtn.click();
await vi.waitFor(() => {
expect(container.querySelector("[data-testid='channel-create-error']")?.textContent).toBe(
"First error",
);
});
// Try again with a valid name
nameInput.value = "valid-name";
submitBtn.click();
// Error should be hidden
const error = container.querySelector("[data-testid='channel-create-error']") as HTMLElement;
expect(error.style.display).toBe("none");
modal.destroy?.();
});
// ── dialog accessibility contract (DC-13) ──────────────────────────────────
it("stamps dialog semantics named by the header title", () => {
const { modal } = makeModal("Text Channels");
const dialog = container.querySelector(".modal") as HTMLElement;
expect(dialog.getAttribute("role")).toBe("dialog");
expect(dialog.getAttribute("aria-modal")).toBe("true");
expect(dialog.getAttribute("aria-labelledby")).toBe("create-channel-title");
expect(container.querySelector("#create-channel-title")?.textContent).toBe("Create Channel");
modal.destroy?.();
});
it("labels the icon-only close button", () => {
const { modal } = makeModal("Text Channels");
const closeBtn = container.querySelector(".modal-close") as HTMLButtonElement;
expect(closeBtn.getAttribute("aria-label")).toBe("Close");
modal.destroy?.();
});
it("Escape calls onClose without creating", () => {
const onCreate = vi.fn(async () => {});
const onClose = vi.fn();
const { modal } = makeModal("Text Channels", { onCreate, onClose });
document.dispatchEvent(new KeyboardEvent("keydown", { key: "Escape" }));
expect(onClose).toHaveBeenCalledTimes(1);
expect(onCreate).not.toHaveBeenCalled();
modal.destroy?.();
});
it("ignores Escape after destroy", () => {
const onClose = vi.fn();
const { modal } = makeModal("Text Channels", { onClose });
modal.destroy?.();
document.dispatchEvent(new KeyboardEvent("keydown", { key: "Escape" }));
expect(onClose).not.toHaveBeenCalled();
});
it("focuses the name input on open and restores focus on destroy", () => {
const trigger = document.createElement("button");
container.appendChild(trigger);
trigger.focus();
const { modal } = makeModal("Text Channels");
const nameInput = container.querySelector(
"[data-testid='channel-name-input']",
) as HTMLInputElement;
expect(document.activeElement).toBe(nameInput);
modal.destroy?.();
expect(document.activeElement).toBe(trigger);
});
});