J3vbandClaude Fable 5 a3459e5f80 fix(admin): route admin-panel bans through ModerationService (W1-4) ...

requireBanAuthority (BAN_MEMBERS + role hierarchy) was wired only into
ModerationService.BanUser/UnbanUser — which had zero production callers.
The live path, handlePatchUser, ran a raw UPDATE with no hierarchy check,
so any admin-panel actor could ban an equal- or higher-ranked user,
including the owner. The ban/unban branch now calls the service (dead code
becomes THE code — ban path 1 of 3 consolidated), which also audits as
user_ban/user_unban, keeping the historical audit vocabulary.

Authorization now runs in permission → existence → hierarchy order: an
actor without ban authority sees Forbidden, never NotFound, so the ban
path cannot enumerate user ids. The role+ban transaction is gone — the
ban leg lives in the service, runs first, and a refusal returns before
the role change executes, so a rejected ban never half-applies a PATCH.
MemStore gains honest BanUser/UnbanUser so the matrix is testable.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

2026-07-19 08:41:12 +02:00

..

block.go

fix(server): resolve golangci-lint contextcheck, errcheck, gocritic findings

2026-04-07 09:10:14 +02:00

channel.go

fix(ci): resolve all golangci-lint and ESLint failures on PR #1132

2026-04-07 10:10:38 +02:00

dm.go

fix(server): resolve golangci-lint contextcheck, errcheck, gocritic findings

2026-04-07 09:10:14 +02:00

invite.go

fix(server): resolve golangci-lint contextcheck, errcheck, gocritic findings

2026-04-07 09:10:14 +02:00

message_test.go

test(service): cover atomic attachment-ownership link semantics (W1-3)

2026-07-19 08:29:26 +02:00

message.go

fix(service): enforce attachment ownership atomically in the link UPDATE (W1-3)

2026-07-19 08:29:26 +02:00

moderation.go

fix(admin): route admin-panel bans through ModerationService (W1-4)

2026-07-19 08:41:12 +02:00

permission_test.go

add ModerationService, VoiceService, MemStore, permission tests

2026-04-05 21:35:20 +00:00

permission.go

feat: scaffold Phase B + C (events, telemetry, plugins, Solid.js)

2026-04-06 09:00:47 +00:00

service.go

fix(security): harden server against verified code-review findings

2026-07-17 21:08:54 +02:00

user.go

fix(security): harden server against verified code-review findings

2026-07-17 21:08:54 +02:00

voice.go

fix(review): address 11 Copilot review findings on PR #1132

2026-04-06 13:48:41 +00:00