J3vbandClaude Fable 5 b60bc8d04b feat(audit): route every LogAudit call through a best-effort WriteAudit helper ...

Audit writes stay best-effort — a LogAudit failure must never fail or abort
the request — but a failed write must no longer be silently discarded. Add
db.WriteAudit(auditor, actor, action, targetType, targetID, detail), which
logs a failed write with actor/action/target context (never the detail
string, which may be sensitive) and never propagates the error.

The Auditor interface is satisfied structurally by both *db.DB and the
service-layer Store, so api/admin/ws/service all reach the helper without an
import cycle. Converts all ~26 call sites from `_ = LogAudit(...)` (and the
two backup handlers' inline `if err` blocks) to db.WriteAudit. Pinned by
db/audit_test.go: failure logged and not propagated, success logs nothing,
detail never leaks.

Resolves the repo-wide LogAudit policy question flagged by the D8 note.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

2026-07-20 10:48:05 +02:00

..

auth_handler_test.go

fix: update tests and fix pending-join drain regression for CI

2026-04-04 21:50:57 +02:00

auth_handler.go

feat(audit): route every LogAudit call through a best-effort WriteAudit helper

2026-07-20 10:48:05 +02:00

channel_authz_test.go

fix: exclude DM channels from guild channel listings (BUG-093)

2026-04-02 11:24:43 +02:00

channel_handler_test.go

refactor(server): remove the store abstraction layer (D3)

2026-07-19 16:33:58 +00:00

channel_handler.go

fix(server): resolve golangci-lint contextcheck, errcheck, gocritic findings

2026-04-07 09:10:14 +02:00

client_update_test.go

test: add channel pins, metrics, diagnostics, client-update, middleware tests

2026-03-31 16:27:21 +02:00

client_update.go

fix(security): harden server against verified code-review findings

2026-07-17 21:08:54 +02:00

clientip_test.go

test(api): lock distinct client keys under broad trusted CIDRs (W2-5)

2026-07-19 08:56:34 +02:00

constants_test.go

fix: Go E2EE security hardening — key holder tracking, base64 loose validation, rate limits, test schema

2026-04-04 23:16:31 +02:00

constants.go

feat(server,client): protocol codegen + audit quick-wins batch

2026-07-19 13:32:58 +00:00

contract_test.go

fix: address PR review findings (issues #9-#14)

2026-03-17 04:11:04 +01:00

coverage_push_test.go

refactor(server): remove the store abstraction layer (D3)

2026-07-19 16:33:58 +00:00

diagnostics_handler_test.go

fix(phase-bc): address review findings — auth, SSRF, seq alignment

2026-04-06 09:29:29 +00:00

diagnostics_handler.go

fix: resolve 20 code review bugs across Rust, TypeScript, and Go

2026-04-03 23:18:06 +02:00

dm_handler_test.go

refactor(server): remove the store abstraction layer (D3)

2026-07-19 16:33:58 +00:00

dm_handler.go

fix(server): resolve golangci-lint contextcheck, errcheck, gocritic findings

2026-04-07 09:10:14 +02:00

export_test.go

fix: resolve 20 code review bugs across Rust, TypeScript, and Go

2026-04-03 23:18:06 +02:00

invite_handler_test.go

refactor(server): remove the store abstraction layer (D3)

2026-07-19 16:33:58 +00:00

invite_handler.go

fix(server): resolve golangci-lint contextcheck, errcheck, gocritic findings

2026-04-07 09:10:14 +02:00

livekit_proxy_test.go

feat: voice/video polish — refactor, AudioWorklet VAD, bug fixes, UX improvements

2026-03-29 00:51:54 +01:00

livekit_proxy.go

fix(security): harden server against verified code-review findings

2026-07-17 21:08:54 +02:00

livekit_ratelimit_test.go

test(api): lock client-update bucket isolation (W2-1)

2026-07-19 08:50:34 +02:00

main_test.go

feat: add syncutil mutex, test scaffolding, and server hardening

2026-04-01 12:04:15 +02:00

metrics_handler_test.go

fix: resolve 20 code review bugs across Rust, TypeScript, and Go

2026-04-03 23:18:06 +02:00

metrics_handler.go

fix: resolve 20 code review bugs across Rust, TypeScript, and Go

2026-04-03 23:18:06 +02:00

middleware_test.go

fix: resolve 20 code review bugs across Rust, TypeScript, and Go

2026-04-03 23:18:06 +02:00

middleware.go

fix(api): keep per-client keys distinct under broad trusted_proxies (W2-5)

2026-07-19 08:56:34 +02:00

plugins_handler_test.go

refactor(server): remove the store abstraction layer (D3)

2026-07-19 16:33:58 +00:00

plugins_handler.go

refactor(server): remove the store abstraction layer (D3)

2026-07-19 16:33:58 +00:00

profile_handler_test.go

refactor(server): remove the store abstraction layer (D3)

2026-07-19 16:33:58 +00:00

profile_handler.go

fix(service): report password change as partial success when revocation fails (W2-2)

2026-07-19 08:50:35 +02:00

router_test.go

fix(phase-bc): address review findings — auth, SSRF, seq alignment

2026-04-06 09:29:29 +00:00

router.go

refactor(server): remove the store abstraction layer (D3)

2026-07-19 16:33:58 +00:00

totp_handler_test.go

style: apply linter fixes to new test files

2026-04-01 08:48:41 +02:00

totp_handler.go

feat(audit): route every LogAudit call through a best-effort WriteAudit helper

2026-07-20 10:48:05 +02:00

upload_handler_test.go

refactor(server): remove the store abstraction layer (D3)

2026-07-19 16:33:58 +00:00

upload_handler.go

feat(server,client): protocol codegen + audit quick-wins batch

2026-07-19 13:32:58 +00:00

waf_test.go

fix: update tests and fix pending-join drain regression for CI

2026-04-04 21:50:57 +02:00

waf.go

fix(security): harden server against verified code-review findings

2026-07-17 21:08:54 +02:00