mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
J3vbandClaude Fable 5
b60bc8d04b
Audit writes stay best-effort — a LogAudit failure must never fail or abort the request — but a failed write must no longer be silently discarded. Add db.WriteAudit(auditor, actor, action, targetType, targetID, detail), which logs a failed write with actor/action/target context (never the detail string, which may be sensitive) and never propagates the error. The Auditor interface is satisfied structurally by both *db.DB and the service-layer Store, so api/admin/ws/service all reach the helper without an import cycle. Converts all ~26 call sites from `_ = LogAudit(...)` (and the two backup handlers' inline `if err` blocks) to db.WriteAudit. Pinned by db/audit_test.go: failure logged and not propagated, success logs nothing, detail never leaks. Resolves the repo-wide LogAudit policy question flagged by the D8 note. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
33 lines
1.3 KiB
Go
33 lines
1.3 KiB
Go
package db
|
|
|
|
import "log/slog"
|
|
|
|
// Auditor is the minimal audit-write surface WriteAudit needs. *DB satisfies
|
|
// it directly, and the service layer's Store interface does too, so every
|
|
// caller — api, admin, ws, service — can route its audit writes through this
|
|
// one helper regardless of whether it holds a *DB or a narrower interface.
|
|
type Auditor interface {
|
|
LogAudit(actorID int64, action, targetType string, targetID int64, detail string) error
|
|
}
|
|
|
|
// WriteAudit records an audit entry best-effort.
|
|
//
|
|
// Per the D8 policy decision (docs/plans/audit-2026-07-19-decisions.md), audit
|
|
// writes stay best-effort: a LogAudit failure must never fail or abort the
|
|
// caller's request. But a failed write must never be silently discarded
|
|
// either — this helper logs it with the actor/action/target context so the
|
|
// gap is visible in the logs. The detail string is intentionally not logged;
|
|
// it can carry request-specific or sensitive text and the structured fields
|
|
// already identify what was attempted.
|
|
func WriteAudit(a Auditor, actorID int64, action, targetType string, targetID int64, detail string) {
|
|
if err := a.LogAudit(actorID, action, targetType, targetID, detail); err != nil {
|
|
slog.Error("audit log write failed",
|
|
"action", action,
|
|
"actor_id", actorID,
|
|
"target_type", targetType,
|
|
"target_id", targetID,
|
|
"error", err,
|
|
)
|
|
}
|
|
}
|