mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
jevb
8e33be3c1d
- Remove Client/.gitignore (WPF-specific, no longer needed) - Add playwright-report/, test-results/, coverage/ to client .gitignore - Track CLIENT-REVIEW.md, playwright.config.prod.ts, and design specs - Delete empty WPF directories and debug screenshots
1.7 KiB
1.7 KiB
Client Code Review Findings
Date: 2026-03-16
Scope: Client/tauri-client/src
High
- Auth token is never set in
authStoreafter login. Theauth_okhandler callssetAuth(authStore.getState().token ?? "", ...), so the store token becomes an empty string. Any future logic that relies onauthStore.token(re-auth, API helpers, telemetry) will be wrong. File:Client/tauri-client/src/lib/dispatcher.ts. - If Tauri APIs are unavailable,
ws.connectlogs an error and returns early but leaves the connection state asconnectingand never schedules a retry or notifies the UI. This can hang the client in a pseudo-connecting state in browser/test contexts. File:Client/tauri-client/src/lib/ws.ts.
Medium
- Server-driven voice disconnects do not clear
currentChannelId. The dispatcher handlesvoice_leaveby removing users only; it does not callleaveVoiceChannel()when the current user is removed, so the voice widget can stay visible after kicks/disconnects. Files:Client/tauri-client/src/lib/dispatcher.ts,Client/tauri-client/src/stores/voice.store.ts,Client/tauri-client/src/components/VoiceWidget.ts. - Theme/font-size/compact-mode preferences are applied only when the Settings overlay is opened. On app start, stored preferences are not applied, causing UI to render in default theme until the user opens Settings. File:
Client/tauri-client/src/components/SettingsOverlay.ts.
Low
- Infinite scroll throttling in the message list uses a fixed
500mstimeout to resetloadingOlder, independent of the fetch completion. On slow responses this can trigger overlapping loads or repeated requests. File:Client/tauri-client/src/components/MessageList.ts.