mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
Claude
bf508c9e6b
The Solid.js migration was abandoned (per CHANGELOG); the 154-LOC beachhead and its scaffolding remained in-tree, leaving two UI paradigms for contributors. Removed: - src/components/solid/ (Badge, ChannelListItem, PluginContainer — none imported by production code) - src/lib/solidMount.ts and src/lib/solidAdapter.ts - tests/setup-solid.ts and tests/setup-solid.test.tsx - vite-plugin-solid from vite.config.ts and vitest.config.ts (and the now-unneeded tsx test include + setupFiles) - jsx/jsxImportSource from tsconfig.json - solid-js, @solidjs/testing-library, vite-plugin-solid from package.json docs/client-architecture.md (which described the SolidJS design) is retired to a pointer at docs/architecture/client.md; README links updated. Audit A-2026-07-12 and decision D6 marked closed. Verified: tsc --noEmit clean (previous 3 test-file errors were caused by the Solid jsx config and are gone); oxlint/eslint error counts identical to HEAD (pre-existing); vitest runner healthy on a sample suite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UA17KPvqGBX3XbXYnMf1rA
5.5 KiB
5.5 KiB
Audit 2026-07-19 — Maintainer Decisions
Date decided: 2026-07-19 Decided by: J3vb Status: decisions recorded; greenlit items (D4, D7, D8) implemented 2026-07-19 — see per-row Status Source: decision points raised by docs/audit-2026-07-19.md
This document records the maintainer's answers to the open decision points from the 2026-07-19 architectural audit, so follow-up PRs can implement against a settled direction instead of re-litigating it. Update the Status column here (and the audit's closure table) as items land.
Decisions
| # | Decision point | Audit ID | Decision | Status |
|---|---|---|---|---|
| D1 | announcement channel type (documented + offered by admin API, rejected by DB triggers) |
A-2026-07-01 | Implement end-to-end: migration to allow the type, posting-permission semantics, admin support, client rendering, spec updates. Not a doc-strip — this becomes a real feature. | Planned (not yet greenlit to start) |
| D2 | Data-layer direction (raw SQL vs dead sqlc db/dbgen vs store.Store) |
A-2026-07-05 / A-2026-07-06 | Adopt sqlc for real: wire db.DB method bodies to the generated dbgen queries so sqlc becomes the actual, type-checked query layer. The sqlc-verify CI job stays and starts earning its keep. |
Planned |
| D3 | Fate of Server/store/ (untested abstraction seam) |
prior audit #6 | Remove store/: execute the prior audit's P4 "single data layer" direction. Services call the (sqlc-backed) db package directly; tests use in-memory SQLite instead of MemStore. |
Planned (sequence with/after D2) |
| D4 | Protocol constants sync (message_types.go / protocolTypes.ts claim a nonexistent docs/protocol-schema.json) |
A-2026-07-08 | Create real codegen: commit an actual protocol-schema.json plus a generator that emits the Go and TS constant files (and, ideally, protocol.md's message table), making the "single source of truth" comment true. |
Implemented 2026-07-19: docs/protocol-schema.json + Server/scripts/genprotocol + make protocol-generate/protocol-verify + CI gate. protocol.md table generation deferred to D7. |
| D5 | Client HTTP TLS gap (allowSelfSigned: true, no TOFU pinning on the REST path) |
A-2026-07-02 | Next security work: build the TOFU HTTP proxy in Rust (mirroring ws_proxy.rs) as the next security task — highest-priority security item. |
Planned |
| D6 | Abandoned SolidJS beachhead + stale docs/client-architecture.md |
A-2026-07-12 | Delete it all: remove src/components/solid/, solidMount/solidAdapter, vite-plugin-solid, and Solid test deps; retire client-architecture.md in favor of docs/architecture/client.md. |
Implemented 2026-07-19 — solid/ dir, solidMount/solidAdapter, setup-solid tests, vite-plugin-solid, jsx tsconfig settings, and solid-js/@solidjs deps all removed; client-architecture.md is now a pointer. |
| D7 | Spec refresh strategy for api.md / protocol.md / schema.md | A-2026-07-03 | One refresh PR first, using the audit's §2 conformance matrix as the checklist; afterwards specs are kept current per-PR (see the maintenance rule in docs/architecture/README.md). Announcement channels (D1) later update the fresh specs. | Implemented 2026-07-19 — all three specs refreshed against the code (incl. E2EE protocol section, migrations 001–015, profile/blocks/plugin-admin endpoints); reference tables now point at protocol-schema.json. |
| D8 | What to implement first | backlog §6 | Greenlit now: Protocol codegen (D4) + the quick-wins batch — LogAudit error handling (admin/handlers_backup.go), contradictory upload Cache-Control (upload_handler.go), hub inline settings SQL through the data layer (ws/hub.go), Hub constructor cleanup (required collaborators into NewHub). |
Implemented 2026-07-19 (all four quick wins + D4). Hub cleanup shipped as: race fix — eventPersister/eventStore/pluginSink are now atomic (they were plain fields written by main.go after NewRouter had already started Run); remaining pre-Run setters now reject late calls with an error log instead of racing silently. Note discovered during the work: the discarded-LogAudit pattern is repo-wide (23 call sites) — the two tracker-flagged backup handlers are fixed; whether best-effort audit writes stay the convention elsewhere needs a policy decision. |
Suggested sequencing
- Now (greenlit):
- Quick-wins batch (small, independent, low-risk).
- Protocol codegen (D4) — also unblocks the protocol.md portion of D7.
- Next:
- Spec refresh PR (D7) — after D4 so protocol.md tables can be generated.
- Client HTTP TOFU proxy (D5) — next security work.
- Solid cleanup (D6) — small, can slot in anywhere.
- Then (larger, sequenced together):
- sqlc adoption (D2), followed by
store/removal (D3) once queries are type-checked — doing D3 after D2 avoids rewiring services twice. - Announcement channels (D1) — after the spec refresh so it patches fresh specs; needs its own small design note (permission semantics: who can post vs read).
- sqlc adoption (D2), followed by
Explicitly not decided here
- Channel-visibility unification (audit backlog 3) and finishing the V2 dispatch migration (backlog 11) were not greenlit yet — they remain open backlog items, not rejected.
- Client unit suite triage to green/blocking (A-2026-07-04) remains tracked in the audit; no scheduling decision was taken.