mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
J3vbandClaude Fable 5
6afa9e974c
Fixes all 109 golangci-lint findings (106 contextcheck, 1 gocritic,
2 gosec) that accumulated after D2 wired dbgen (whose queries take ctx)
under ctx-less db.DB wrappers while CI lint was quota-dead. No nolint
comments added; every finding fixed by genuinely threading context.
- db: all 138 hand-written db.DB methods take ctx first; the dbCtx()
Background shim is deleted; raw Query/QueryRow/Exec/Begin use their
Context variants; the four redundant ctx-less passthroughs removed.
db.Auditor/WriteAudit gain ctx.
- Seams: permissions.Checker (DB iface, HasChannelPerm,
RequireChannelAccess) and the service.Store interface mirror the new
signatures (ws.EventStore and plugin.PluginStore already did).
- Callers: api/admin handlers use r.Context(); ws per-message paths use
the connection ctx via DispatchV2; hub loops and startup wiring use
context.Background(); service methods thread ctx where they have one
and Background where no ctx exists. Public service surface reached by
ctx-holding chains (PermissionService.HasChannelPerm/GetRoleForUser/
RequireChannelAccess, message/dm/block/invite/profile methods) is now
ctx-first.
- Detached (context.WithoutCancel) where cancellation would break an
invariant, found by a 3-lens adversarial review of the diff:
* voice-leave background retries (a dead webhook/connection ctx killed
retry 2 before it ran, leaving ghost capacity-holding voice rows)
* rollbackVoiceJoin's compensating delete (its trigger IS the cancel)
* post-2FA-change DeleteOtherSessions and logout DeleteSession (the
security tail of a committed change must not die with the request)
* all api/ws audit writes (a banned user could suppress their own
login_blocked_banned row by aborting the request mid-bcrypt)
* admin backup VACUUM INTO (an interrupt left a truncated .db that
the backup list presented as restorable)
* post-commit message/edit refetches (a committed message must still
fan out when the sender disconnects)
* hub settings-cache refresh (one dead connection could pin stale
values for the 30s TTL)
- gocritic rangeValCopy fixed (index iteration); gosec G306 excluded in
config with justification (generated source must stay world-readable)
instead of flipping genprotocol output to 0o600.
Verified: gofmt/vet, all four build-tag variants, full suite, deadlock
pass, full -race pass, golangci-lint 0 issues uncapped.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
77 lines
2.3 KiB
Go
77 lines
2.3 KiB
Go
package db
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/owncord/server/db/dbgen"
|
|
)
|
|
|
|
// UpdateUserProfile updates the username and avatar for the given user.
|
|
// Returns ErrNotFound if the user does not exist. Returns an error wrapping
|
|
// a UNIQUE constraint violation if the username is already taken.
|
|
func (d *DB) UpdateUserProfile(ctx context.Context, userID int64, username string, avatar *string) error {
|
|
result, err := d.q.UpdateUserProfile(ctx, dbgen.UpdateUserProfileParams{
|
|
Username: username,
|
|
Avatar: avatar,
|
|
ID: userID,
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("UpdateUserProfile: %w", err)
|
|
}
|
|
rows, err := result.RowsAffected()
|
|
if err != nil {
|
|
return fmt.Errorf("UpdateUserProfile rows: %w", err)
|
|
}
|
|
if rows == 0 {
|
|
return fmt.Errorf("UpdateUserProfile: %w", ErrNotFound)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// UpdateUserPassword sets a new password hash for the given user.
|
|
func (d *DB) UpdateUserPassword(ctx context.Context, userID int64, newPasswordHash string) error {
|
|
if err := d.q.UpdateUserPassword(ctx, dbgen.UpdateUserPasswordParams{
|
|
Password: newPasswordHash,
|
|
ID: userID,
|
|
}); err != nil {
|
|
return fmt.Errorf("UpdateUserPassword: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ListUserSessions returns all sessions for the given user in a single query.
|
|
// Results are ordered by created_at descending (newest first).
|
|
func (d *DB) ListUserSessions(ctx context.Context, userID int64) ([]Session, error) {
|
|
rows, err := d.q.ListUserSessions(ctx, userID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("ListUserSessions: %w", err)
|
|
}
|
|
sessions := make([]Session, 0, len(rows))
|
|
for _, s := range rows {
|
|
sessions = append(sessions, sessionFromGen(s))
|
|
}
|
|
return sessions, nil
|
|
}
|
|
|
|
// DeleteSessionByID removes a session by its ID, but only if it belongs to
|
|
// the specified user. Returns ErrNotFound if the session does not exist or
|
|
// does not belong to the user.
|
|
func (d *DB) DeleteSessionByID(ctx context.Context, sessionID, userID int64) error {
|
|
result, err := d.q.DeleteSessionByID(ctx, dbgen.DeleteSessionByIDParams{
|
|
ID: sessionID,
|
|
UserID: userID,
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("DeleteSessionByID: %w", err)
|
|
}
|
|
rows, err := result.RowsAffected()
|
|
if err != nil {
|
|
return fmt.Errorf("DeleteSessionByID rows: %w", err)
|
|
}
|
|
if rows == 0 {
|
|
return fmt.Errorf("DeleteSessionByID: %w", ErrNotFound)
|
|
}
|
|
return nil
|
|
}
|