mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
Make server failures debuggable without leaking secrets: - configurable stdout log level (config.yaml logging.level + OWNCORD_LOGGING_LEVEL) - preserve the DB cause in ErrInternal wraps; log auth-DB failures distinctly from bad tokens; log the previously-silent expired-session cleanup goroutine - route HTTP handler panics through slog (was chi stderr-only, invisible to the admin log stream) - stackutil: argument-free panic stacks so key/token bytes never reach the admin ring buffer / SSE; slog.LogValuer redaction on VoiceConfig/GitHubConfig/ GIFConfig/Config and db.User/db.Session - logctx: req_id/trace_id correlation on ...Context log calls Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
135 lines
5.4 KiB
Go
135 lines
5.4 KiB
Go
package service
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"log/slog"
|
|
"time"
|
|
|
|
"github.com/owncord/server/db"
|
|
"github.com/owncord/server/telemetry"
|
|
)
|
|
|
|
// UserService handles user profile and session operations.
|
|
type UserService struct {
|
|
st Store
|
|
}
|
|
|
|
// NewUserService creates a UserService.
|
|
func NewUserService(st Store) *UserService {
|
|
return &UserService{st: st}
|
|
}
|
|
|
|
// UpdateProfile updates a user's username and/or avatar.
|
|
// Returns the updated user for response building.
|
|
func (s *UserService) UpdateProfile(ctx context.Context, userID int64, username string, avatar *string) (*db.User, error) {
|
|
ctx, span := telemetry.GlobalTracer("service/user").Start(ctx, "UserService.UpdateProfile",
|
|
telemetry.Int64("user_id", userID),
|
|
)
|
|
start := time.Now()
|
|
defer func() {
|
|
telemetry.TimeSince(ctx, telemetry.NewAppMetrics().ServiceCallDurationSec, start,
|
|
telemetry.String("method", "UpdateProfile"))
|
|
span.End()
|
|
}()
|
|
|
|
if err := s.st.UpdateUserProfile(ctx, userID, username, avatar); err != nil {
|
|
if db.IsUniqueConstraintError(err) {
|
|
return nil, fmt.Errorf("%w: username is already taken", ErrConflict)
|
|
}
|
|
return nil, fmt.Errorf("%w: failed to update profile: %v", ErrInternal, err)
|
|
}
|
|
user, err := s.st.GetUserByID(ctx, userID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("%w: failed to fetch updated user: %v", ErrInternal, err)
|
|
}
|
|
// Audit rows must survive a request canceled after the write committed.
|
|
db.WriteAudit(context.WithoutCancel(ctx), s.st, userID, "profile_update", "user", userID,
|
|
fmt.Sprintf("username=%s", username))
|
|
slog.Info("profile updated", "user_id", userID, "username", username)
|
|
return user, nil
|
|
}
|
|
|
|
// UpdateIdentityKey publishes the user's long-term E2EE identity public key
|
|
// (F3 voice E2EE TOFU). Last write wins; every write is audited so a key
|
|
// rotation — which peers surface as a TOFU mismatch — leaves a trail.
|
|
// Returns the updated user for response building.
|
|
func (s *UserService) UpdateIdentityKey(ctx context.Context, userID int64, key string) (*db.User, error) {
|
|
if err := s.st.UpdateUserIdentityKey(ctx, userID, &key); err != nil {
|
|
return nil, fmt.Errorf("%w: failed to update identity key", ErrInternal)
|
|
}
|
|
user, err := s.st.GetUserByID(ctx, userID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("%w: failed to fetch updated user", ErrInternal)
|
|
}
|
|
db.WriteAudit(context.WithoutCancel(ctx), s.st, userID, "identity_key_update", "user", userID, "")
|
|
slog.Info("identity key published", "user_id", userID)
|
|
return user, nil
|
|
}
|
|
|
|
// ChangePasswordResult reports a completed password change. RevokeFailed is
|
|
// set when the password committed but other sessions could not be revoked —
|
|
// a partial success the caller must surface as a warning, never as a 5xx:
|
|
// the old password is already unusable, so telling the user the change
|
|
// "failed" walks them into retrying with a dead password and tripping the
|
|
// password-confirm lockout.
|
|
type ChangePasswordResult struct {
|
|
SessionsRevoked int64
|
|
RevokeFailed bool
|
|
}
|
|
|
|
// ChangePassword updates the user's password and revokes other sessions.
|
|
func (s *UserService) ChangePassword(ctx context.Context, userID int64, newPasswordHash string, keepSessionID int64) (ChangePasswordResult, error) {
|
|
if err := s.st.UpdateUserPassword(ctx, userID, newPasswordHash); err != nil {
|
|
return ChangePasswordResult{}, fmt.Errorf("%w: failed to update password: %v", ErrInternal, err)
|
|
}
|
|
|
|
// The password is committed from here on: every path below reports
|
|
// success and writes the audit row — even if the request ctx has been
|
|
// canceled, revocation and audit are the security tail of the change.
|
|
tailCtx := context.WithoutCancel(ctx)
|
|
|
|
var res ChangePasswordResult
|
|
revoked, err := s.st.DeleteOtherSessions(tailCtx, userID, keepSessionID)
|
|
res.SessionsRevoked = revoked
|
|
if err != nil {
|
|
slog.Error("UserService.ChangePassword DeleteOtherSessions", "err", err, "user_id", userID)
|
|
// One bounded compensating retry: revocation is the security tail of
|
|
// the change and a single immediate retry covers transient write-lock
|
|
// contention. ponytail: one retry, add backoff only if logs show it.
|
|
if revokedRetry, retryErr := s.st.DeleteOtherSessions(tailCtx, userID, keepSessionID); retryErr == nil {
|
|
res.SessionsRevoked += revokedRetry
|
|
} else {
|
|
res.RevokeFailed = true
|
|
}
|
|
}
|
|
db.WriteAudit(tailCtx, s.st, userID, "password_change", "user", userID, "password changed")
|
|
slog.Info("password changed", "user_id", userID,
|
|
"sessions_revoked", res.SessionsRevoked, "revoke_failed", res.RevokeFailed)
|
|
return res, nil
|
|
}
|
|
|
|
// ListSessions returns all active sessions for a user.
|
|
func (s *UserService) ListSessions(ctx context.Context, userID int64) ([]db.Session, error) {
|
|
sessions, err := s.st.ListUserSessions(ctx, userID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("%w: failed to list sessions: %v", ErrInternal, err)
|
|
}
|
|
return sessions, nil
|
|
}
|
|
|
|
// RevokeSession deletes a specific session owned by the user.
|
|
func (s *UserService) RevokeSession(ctx context.Context, userID, sessionID int64) error {
|
|
if err := s.st.DeleteSessionByID(ctx, sessionID, userID); err != nil {
|
|
if errors.Is(err, db.ErrNotFound) {
|
|
return fmt.Errorf("%w: session not found", ErrNotFound)
|
|
}
|
|
return fmt.Errorf("%w: failed to revoke session: %v", ErrInternal, err)
|
|
}
|
|
// Audit rows must survive a request canceled after the delete committed.
|
|
db.WriteAudit(context.WithoutCancel(ctx), s.st, userID, "session_revoke", "session", sessionID, "session revoked")
|
|
slog.Info("session revoked", "user_id", userID, "session_id", sessionID)
|
|
return nil
|
|
}
|