Files
OwnCord/Server/ws/livekit.go
T
J3vbandClaude Fable 5 6afa9e974c refactor(server): thread context.Context through the db layer and all callers
Fixes all 109 golangci-lint findings (106 contextcheck, 1 gocritic,
2 gosec) that accumulated after D2 wired dbgen (whose queries take ctx)
under ctx-less db.DB wrappers while CI lint was quota-dead. No nolint
comments added; every finding fixed by genuinely threading context.

- db: all 138 hand-written db.DB methods take ctx first; the dbCtx()
  Background shim is deleted; raw Query/QueryRow/Exec/Begin use their
  Context variants; the four redundant ctx-less passthroughs removed.
  db.Auditor/WriteAudit gain ctx.
- Seams: permissions.Checker (DB iface, HasChannelPerm,
  RequireChannelAccess) and the service.Store interface mirror the new
  signatures (ws.EventStore and plugin.PluginStore already did).
- Callers: api/admin handlers use r.Context(); ws per-message paths use
  the connection ctx via DispatchV2; hub loops and startup wiring use
  context.Background(); service methods thread ctx where they have one
  and Background where no ctx exists. Public service surface reached by
  ctx-holding chains (PermissionService.HasChannelPerm/GetRoleForUser/
  RequireChannelAccess, message/dm/block/invite/profile methods) is now
  ctx-first.
- Detached (context.WithoutCancel) where cancellation would break an
  invariant, found by a 3-lens adversarial review of the diff:
  * voice-leave background retries (a dead webhook/connection ctx killed
    retry 2 before it ran, leaving ghost capacity-holding voice rows)
  * rollbackVoiceJoin's compensating delete (its trigger IS the cancel)
  * post-2FA-change DeleteOtherSessions and logout DeleteSession (the
    security tail of a committed change must not die with the request)
  * all api/ws audit writes (a banned user could suppress their own
    login_blocked_banned row by aborting the request mid-bcrypt)
  * admin backup VACUUM INTO (an interrupt left a truncated .db that
    the backup list presented as restorable)
  * post-commit message/edit refetches (a committed message must still
    fan out when the sender disconnects)
  * hub settings-cache refresh (one dead connection could pin stale
    values for the 30s TTL)
- gocritic rangeValCopy fixed (index iteration); gosec G306 excluded in
  config with justification (generated source must stay world-readable)
  instead of flipping genprotocol output to 0o600.

Verified: gofmt/vet, all four build-tag variants, full suite, deadlock
pass, full -race pass, golangci-lint 0 issues uncapped.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 17:03:52 +02:00

236 lines
7.0 KiB
Go

// Package ws provides the LiveKit integration client.
//
// LiveKitClient wraps the LiveKit server SDK for token generation and
// room management. It is the primary interface between OwnCord's WS
// handlers and the LiveKit server.
package ws
import (
"context"
"fmt"
"log/slog"
"time"
"github.com/livekit/protocol/auth"
"github.com/livekit/protocol/livekit"
lksdk "github.com/livekit/server-sdk-go/v2"
"github.com/owncord/server/config"
)
// tokenTTL is the validity duration for generated LiveKit access tokens.
// Short-lived (5 min) to limit replay window (BUG-127). The client requests
// a refresh via voice_token_refresh before expiry. Security mitigations:
// - Tokens are scoped to a single room
// - Server can revoke room access via LiveKit API on ban/kick
// - Webhook participant_joined validates voice_states membership
// - CanPublishSources restricts track types per permission (BUG-128)
const tokenTTL = 5 * time.Minute
// LiveKitClient provides token generation and room management via
// the LiveKit server SDK.
type LiveKitClient struct {
apiKey string
apiSecret string
url string
roomSvc *lksdk.RoomServiceClient
}
// NewLiveKitClient creates a new LiveKit client from the voice config.
// Returns an error if the credentials are missing or still set to the
// well-known default dev values (which are public in the source code).
func NewLiveKitClient(cfg *config.VoiceConfig) (*LiveKitClient, error) {
if cfg.LiveKitAPIKey == "" || cfg.LiveKitAPISecret == "" {
return nil, fmt.Errorf("livekit: api_key and api_secret are required")
}
if cfg.LiveKitURL == "" {
return nil, fmt.Errorf("livekit: url is required")
}
if config.IsDefaultVoiceCredentials(cfg) {
return nil, fmt.Errorf("livekit: refusing to start with default dev credentials — set voice.livekit_api_key and voice.livekit_api_secret in config.yaml")
}
// LiveKit room service client uses the HTTP URL (not WS).
// Convert ws:// to http:// and wss:// to https:// for the REST API.
httpURL := wsToHTTP(cfg.LiveKitURL)
roomSvc := lksdk.NewRoomServiceClient(httpURL, cfg.LiveKitAPIKey, cfg.LiveKitAPISecret)
slog.Info("livekit: client initialized",
"url", cfg.LiveKitURL,
"http_url", httpURL)
return &LiveKitClient{
apiKey: cfg.LiveKitAPIKey,
apiSecret: cfg.LiveKitAPISecret,
url: cfg.LiveKitURL,
roomSvc: roomSvc,
}, nil
}
// RoomName returns the LiveKit room name for an OwnCord channel.
func RoomName(channelID int64) string {
return fmt.Sprintf("channel-%d", channelID)
}
func participantIdentity(userID int64, voiceJoinToken string) string {
if voiceJoinToken == "" {
return fmt.Sprintf("user-%d", userID)
}
return fmt.Sprintf("user-%d:%s", userID, voiceJoinToken)
}
// GenerateToken creates a LiveKit access token for the given user
// to join the specified channel's voice room.
//
// canPublish controls audio publishing (SpeakVoice permission).
// canVideo and canScreenShare control which additional track sources are
// allowed at the SFU level via CanPublishSources, preventing users from
// bypassing OwnCord's USE_VIDEO/SHARE_SCREEN checks via raw LiveKit (BUG-128).
func (c *LiveKitClient) GenerateToken(
userID int64,
username string,
channelID int64,
voiceJoinToken string,
canPublish bool,
canSubscribe bool,
canVideo bool,
canScreenShare bool,
) (string, error) {
roomName := RoomName(channelID)
identity := participantIdentity(userID, voiceJoinToken)
at := auth.NewAccessToken(c.apiKey, c.apiSecret)
grant := &auth.VideoGrant{
RoomJoin: true,
Room: roomName,
CanSubscribe: &canSubscribe,
}
if canPublish {
// Use CanPublishSources to restrict which track types the user may
// publish. This supersedes CanPublish and prevents SFU-level bypass.
sources := []string{"microphone"}
if canVideo {
sources = append(sources, "camera")
}
if canScreenShare {
sources = append(sources, "screen_share", "screen_share_audio")
}
grant.CanPublishSources = sources
grant.CanPublishData = &canPublish
} else {
grant.CanPublish = &canPublish
grant.CanPublishData = &canPublish
}
at.SetVideoGrant(grant).
SetIdentity(identity).
SetName(username).
SetValidFor(tokenTTL)
token, err := at.ToJWT()
if err != nil {
return "", fmt.Errorf("livekit: generating token: %w", err)
}
slog.Debug("livekit: generated token",
"identity", identity,
"room", roomName,
"can_publish", canPublish,
"can_video", canVideo,
"can_screen_share", canScreenShare)
return token, nil
}
// URL returns the LiveKit WebSocket URL for client connections.
func (c *LiveKitClient) URL() string {
return c.url
}
// lkTimeout is the maximum duration for LiveKit SDK calls (remove, list, etc.).
const lkTimeout = 5 * time.Second
// RemoveParticipant forcefully disconnects a participant from a room.
func (c *LiveKitClient) RemoveParticipant(ctx context.Context, channelID int64, userID int64, voiceJoinToken string) error {
roomName := RoomName(channelID)
identity := participantIdentity(userID, voiceJoinToken)
ctx, cancel := context.WithTimeout(ctx, lkTimeout)
defer cancel()
_, err := c.roomSvc.RemoveParticipant(ctx, &livekit.RoomParticipantIdentity{
Room: roomName,
Identity: identity,
})
if err != nil {
return fmt.Errorf("livekit: removing participant %s from %s: %w", identity, roomName, err)
}
slog.Info("livekit: removed participant",
"identity", identity,
"room", roomName)
return nil
}
// ListParticipants returns all participants in a channel's voice room.
func (c *LiveKitClient) ListParticipants(channelID int64) ([]*livekit.ParticipantInfo, error) {
roomName := RoomName(channelID)
ctx, cancel := context.WithTimeout(context.Background(), lkTimeout)
defer cancel()
resp, err := c.roomSvc.ListParticipants(ctx, &livekit.ListParticipantsRequest{
Room: roomName,
})
if err != nil {
return nil, fmt.Errorf("livekit: listing participants in %s: %w", roomName, err)
}
return resp.Participants, nil
}
// CountVideoTracks returns the number of video tracks published in a room.
// Used for MaxVideo enforcement.
func (c *LiveKitClient) CountVideoTracks(channelID int64) (int, error) {
participants, err := c.ListParticipants(channelID)
if err != nil {
return 0, err
}
count := 0
for _, p := range participants {
for _, t := range p.Tracks {
if t.Type == livekit.TrackType_VIDEO {
count++
}
}
}
return count, nil
}
// HealthCheck verifies connectivity to the LiveKit server by listing rooms.
// Returns true if the server responds successfully.
func (c *LiveKitClient) HealthCheck(ctx context.Context) (bool, error) {
ctx, cancel := context.WithTimeout(ctx, 3*time.Second)
defer cancel()
_, err := c.roomSvc.ListRooms(ctx, &livekit.ListRoomsRequest{})
if err != nil {
return false, fmt.Errorf("livekit health check failed: %w", err)
}
return true, nil
}
// wsToHTTP converts a WebSocket URL to an HTTP URL.
func wsToHTTP(wsURL string) string {
switch {
case len(wsURL) >= 6 && wsURL[:6] == "wss://":
return "https://" + wsURL[6:]
case len(wsURL) >= 5 && wsURL[:5] == "ws://":
return "http://" + wsURL[5:]
default:
return wsURL
}
}