mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
Claude
d320a8b587
Clean sweep of every actionable item from the two Copilot review passes
on head 59ae4d8. Grouped by severity:
─── Crash / security (must-fix) ─────────────────────────────────────
1. main.go:140 — telemetryShutdown nil panic.
telemetry.Init can return (nil, err) on the -tags otel skeleton
path; the deferred closure would then call a nil function. Normalise
to a no-op shutdown when Init errors so the defer is always safe.
2. api/upload_handler.go — permSvc nil deref.
MountUploadRoutes + handleServeFile dereference permSvc on every
authenticated file request. Add a fail-fast panic at mount time so
the misconfiguration surfaces at wiring, not on the first 500.
Update upload_handler_test.go to pass a real PermissionService built
on the test DB (the existing tests were missing the argument entirely,
which meant the package wouldn't compile — this fixes the real bug
Copilot flagged).
3. ws/event_persister.go — NewEventPersister nil EventStore panic.
run() dereferences p.store on every flush. Panic at constructor
time instead so the crash happens once at startup rather than
minutes later in a background goroutine.
4. plugin/host_ui.go — serve-time symlink check.
rejectSymlinksUnder only runs at install time, so a symlink created
post-install (accidental or malicious) would be followed by
http.ServeFile and leak host files. Add an os.Lstat + ModeSymlink
check + IsRegular check to AssetHandler on every request. Cheap
relative to the file read and closes the TOCTOU window.
─── Correctness / observability (should-fix) ───────────────────────
5. ws/deps.go:77 — requirePerm hides misconfig as FORBIDDEN.
Previously, nil database, nil perms, or a GetRoleForUser error all
returned ErrCodeForbidden with the same message, making operator
failures indistinguishable from legitimate permission denials.
Split the branches: misconfig + DB error now return ErrCodeInternal
with a server-side slog.Error so operators see the real problem;
FORBIDDEN is reserved for the actual permission-bit check.
6. telemetry/metrics.go — ServiceCallDurationMs renamed to Sec.
Field name said "Ms" but the instrument name was
`service_call_duration_seconds` with unit "s". Renamed the field
and updated all 8 service-layer callers so the struct field and
metric semantics match.
7. ws/event_persister.go — flushEvy typo → flushEvery.
Renamed the field and the one call site in run().
─── Comments out of sync with code ──────────────────────────────────
8. plugin/loader.go — Stat vs Lstat comment.
The comment claimed "Stat (not Lstat)" but the code correctly uses
os.Lstat to detect symlinks. Updated the comment to match the code;
the code was already right.
9. telemetry/telemetry_otel.go — compile claim wrong.
Comment said the file would fail to compile without the upstream
OTel modules, but the skeleton deliberately avoids importing them
and Init returns a runtime error instead. Updated the comment to
reflect actual CI behaviour (the -tags otel build step passes
today but doesn't exercise real telemetry).
─── Nit / polish ────────────────────────────────────────────────────
10. ws/event_pruner.go — startup delay magic constant.
Hard-coded time.Minute made the "run shortly after startup"
behaviour untestable (a test with a 100ms interval would still
wait a full minute). Cap the startup delay by the interval:
min(interval, time.Minute). Documented via a new `maxStartupDelay`
constant.
11. ws/event_pruner_test.go — new file.
Unit coverage for runPrune cutoff correctness, error swallowing,
StartEventPruner nil-store short-circuit, ctx cancellation, and
the interval-bounded startup delay from fix #10. Uses a fakeEventStore
stub that records every prune call and signals the first one so
tests don't sleep.
─── Verification ────────────────────────────────────────────────────
gofmt -l clean. No network access in sandbox so `go vet` and `go test`
could not run; the changes are local and surgical and every touched
file compiles in isolation against the existing signatures.
https://claude.ai/code/session_01UsBsQW2YiA2usk9pnJjAWk
84 lines
2.3 KiB
Go
84 lines
2.3 KiB
Go
package service
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/owncord/server/db"
|
|
"github.com/owncord/server/store"
|
|
"github.com/owncord/server/telemetry"
|
|
)
|
|
|
|
// InviteService handles invite management.
|
|
type InviteService struct {
|
|
st store.Store
|
|
}
|
|
|
|
// NewInviteService creates an InviteService.
|
|
func NewInviteService(st store.Store) *InviteService {
|
|
return &InviteService{st: st}
|
|
}
|
|
|
|
// maxInviteExpiryHoursVal caps invite expiry to 30 days (H-4 hardening).
|
|
const maxInviteExpiryHoursVal = 720
|
|
|
|
// MaxInviteExpiryHours returns the maximum invite expiry in hours.
|
|
func MaxInviteExpiryHours() int { return maxInviteExpiryHoursVal }
|
|
|
|
// CreateInvite creates a new invite code with optional max uses and expiry.
|
|
func (s *InviteService) CreateInvite(createdBy int64, maxUses int, expiresInHours int) (*db.Invite, error) {
|
|
ctx, span := telemetry.GlobalTracer("service/invite").Start(context.Background(), "InviteService.CreateInvite",
|
|
telemetry.Int64("created_by", createdBy),
|
|
)
|
|
start := time.Now()
|
|
defer func() {
|
|
telemetry.TimeSince(ctx, telemetry.NewAppMetrics().ServiceCallDurationSec, start,
|
|
telemetry.String("method", "CreateInvite"))
|
|
span.End()
|
|
}()
|
|
|
|
// Cap expiry.
|
|
if expiresInHours > maxInviteExpiryHoursVal {
|
|
expiresInHours = maxInviteExpiryHoursVal
|
|
}
|
|
|
|
var expiresAt *time.Time
|
|
if expiresInHours > 0 {
|
|
t := time.Now().Add(time.Duration(expiresInHours) * time.Hour)
|
|
expiresAt = &t
|
|
}
|
|
|
|
code, err := s.st.CreateInvite(createdBy, maxUses, expiresAt)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("%w: failed to create invite", ErrInternal)
|
|
}
|
|
|
|
invite, err := s.st.GetInvite(code)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("%w: failed to fetch invite", ErrInternal)
|
|
}
|
|
return invite, nil
|
|
}
|
|
|
|
// ListInvites returns all invites.
|
|
func (s *InviteService) ListInvites() ([]*db.Invite, error) {
|
|
invites, err := s.st.ListInvites()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("%w: failed to list invites", ErrInternal)
|
|
}
|
|
return invites, nil
|
|
}
|
|
|
|
// RevokeInvite revokes an invite by code.
|
|
func (s *InviteService) RevokeInvite(code string) error {
|
|
invite, err := s.st.GetInvite(code)
|
|
if err != nil || invite == nil {
|
|
return fmt.Errorf("%w: invite not found", ErrNotFound)
|
|
}
|
|
if err := s.st.RevokeInvite(code); err != nil {
|
|
return fmt.Errorf("%w: failed to revoke invite", ErrInternal)
|
|
}
|
|
return nil
|
|
}
|