mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
* fix(ws): 2 defect(s) (OC-0013, OC-0140) * fix(voice): 1 defect(s) (OC-0044) * fix(ws): 1 defect(s) (OC-0024) * fix(server): 1 defect(s) (OC-0027) * fix(ws): 1 defect(s) (OC-0028) * fix(server): 7 defect(s) (OC-0033, OC-0066, OC-0067, OC-0068, OC-0074, OC-0077, OC-0106) * fix(ws): 1 defect(s) (OC-0051) * fix(client): 1 defect(s) (OC-0053) * fix(client): 1 defect(s) (OC-0055) * fix(service): 1 defect(s) (OC-0069) * fix(voice): 1 defect(s) (OC-0072) * fix(service): 1 defect(s) (OC-0082) * fix(client): 1 defect(s) (OC-0083) * fix(plugin): 1 defect(s) (OC-0088) * fix(plugin): 4 defect(s) (OC-0104, OC-0126, OC-0127, OC-0133) * fix(admin): 1 defect(s) (OC-0110) * fix(client): 1 defect(s) (OC-0114) * fix(api): 1 defect(s) (OC-0139) * fix(client): 1 defect(s) (OC-0149) * test(server): adapt existing tests to updated OpenDM and IncrementMentionCounts signatures * style(plugin): modernize loops and goroutine spawns in race test * fix(ws): mirror the focus admission gate in the post-subscribe revalidation * fix(service): detach DM post-commit side effects from the request ctx, fail delete closed, add empty-fan-out fallback * fix(plugin): preserve enabled intent when upgrade reactivation hits a runtime-less build * chore(skills): harden bughunt-fix workflow and fold review lessons into bughunt-run/db-change * Add comprehensive documentation for task-observer skill - Introduced environments.md to outline activation setup, compaction behavior, and handoff-doc mode. - Created skill-authoring.md detailing taxonomy, licensing, confidentiality, and editing rules for skill creation. - Added weekly-review.md for a structured review process of OPEN observations, including scheduled and in-session fallback modes. * chore(go): pin toolchain go1.26.6 (stdlib CVE fixes flagged by govulncheck)
49 lines
2.0 KiB
Go
49 lines
2.0 KiB
Go
package main
|
|
|
|
import (
|
|
"io"
|
|
"log/slog"
|
|
"testing"
|
|
|
|
"go.uber.org/goleak"
|
|
|
|
"github.com/owncord/server/admin"
|
|
)
|
|
|
|
// TestRun_ServeErrorReturn_StopsHubDispatchGoroutine pins OC-0027:
|
|
// hub.GracefulStop() (the only caller of LiveKitProcess.Stop(), and what
|
|
// closes the hub's dispatch goroutine) is a plain statement reached only on
|
|
// the graceful-shutdown path. The serve-error branch — `case err :=
|
|
// <-serveErr: ... return fmt.Errorf(...)` — returns from run() before ever
|
|
// reaching it, so the hub's `go hub.Run()` dispatch goroutine (started by
|
|
// api.NewRouter) is left running, and in production the companion
|
|
// livekit-server process it owns is left running with it.
|
|
//
|
|
// An out-of-range port fails the first listen attempt with an error that
|
|
// isAddrInUse does not recognize, so run() takes the servErr branch
|
|
// immediately instead of retrying for ~10s.
|
|
func TestRun_ServeErrorReturn_StopsHubDispatchGoroutine(t *testing.T) {
|
|
t.Chdir(t.TempDir())
|
|
|
|
t.Setenv("OWNCORD_SERVER_PORT", "99999") // out of range: immediate, non-retryable listen error
|
|
t.Setenv("OWNCORD_TLS_MODE", "off") // skip self-signed cert generation
|
|
t.Setenv("OWNCORD_VOICE_AUTO_DOWNLOAD_LIVEKIT", "false") // the generated default config.yaml turns this on; keep the test offline
|
|
|
|
logBuf := admin.NewRingBuffer(64)
|
|
levelVar := new(slog.LevelVar)
|
|
log := slog.New(slog.NewTextHandler(io.Discard, &slog.HandlerOptions{Level: levelVar}))
|
|
|
|
leakOpt := goleak.IgnoreCurrent()
|
|
|
|
if err := run(log, logBuf, levelVar); err == nil {
|
|
t.Fatal("expected run() to return an error for an out-of-range port")
|
|
}
|
|
|
|
// hub.Run's dispatch goroutine only exits once hub.stop is closed, which
|
|
// only happens inside hub.GracefulStop(). If run() returned without
|
|
// calling it, this goroutine is still alive here.
|
|
if err := goleak.Find(leakOpt); err != nil {
|
|
t.Fatalf("hub dispatch goroutine (and, in production, its LiveKit process) leaked after run() returned early: %v", err)
|
|
}
|
|
}
|