Files
OwnCord/Server/api/emoji_handler.go
T
J3vbandClaude Opus 5 39551de4a6 refactor(server): work off the complexity backlog — 62 findings to 0 (#1389)
* refactor(ws): split handleVoiceJoin into cohesive join-stage helpers

handleVoiceJoin was 130 statements / cyclomatic 59 / nestif 11, breaking all
three complexity budgets at once. Split along the stage boundaries the doc
comment already described: precheck, leave-current, persist, restore
moderator flags, grant token, complete. The publish-permission derivation
becomes its own helper because it is the one branch-heavy block inside the
token grant.

Pure move: every statement is preserved verbatim. The only edits are bare
`return`s becoming the typed returns of their new helper, `c.userID` becoming
the `userID` parameter inside voiceJoinPublishPerms, and voiceJoinComplete
re-reading `ch.VoiceMaxUsers` instead of receiving it — `ch` is never mutated,
so the value is identical.

Verified by normalising both revisions of the region to sorted, comment- and
whitespace-stripped statements and diffing: the only deltas are the ones
listed above.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor: collapse the three duplicated sibling pairs

dupl flagged three pairs of adjacent near-identical functions. Each pair is
now one parameterised implementation plus two thin, still-greppable wrappers.

- ws/voice_controls.go: handleVoiceMuteV2 / handleVoiceDeafenV2 share
  voiceSelfToggleV2; handleVoiceCameraV2 / handleVoiceScreenshareV2 share
  voiceStreamToggleV2. Camera and screenshare drawing from one
  voice_max_video budget (OC-0023) was a bug caused by exactly this
  duplication drifting, so one body is the point, not a side effect.
- db/mention_queries.go: ListMentionTargetsByRoles / ListMentionTargetsByUserIDs
  share listMentionTargets. The matched column is a closed named type
  (mentionTargetColumn) rather than a bare string, so the value interpolated
  into the SELECT cannot become caller-supplied.

Behaviour is unchanged: every rate-limit key, error code, error string, slog
message and slog key is preserved verbatim, including the two "failed to
update <kind> state" messages, which are now assembled the same way
enableVideoSlot already assembled them.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(api): extract readEmojiUpload from handleCreateEmoji

handleCreateEmoji was 101 lines against a 100-line budget. The upload-bytes
stage — pull the file out of the parsed form, cap its size, sniff its MIME
type and sniff its dimensions — is the one self-contained block in it, and it
already wrote its own refusals, so it moves out whole as readEmojiUpload.

The permission-before-parse ordering the doc comment calls out is unchanged;
so is every error string. file.Close() now runs when the helper returns
rather than when the handler does, which is strictly earlier and unobservable:
the bytes are already copied into raw and nothing else touches the handle.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor: extract one cohesive block from three single-budget offenders

Each of these was over exactly one budget, so each gets exactly one extraction
rather than a restructure:

- api/totp_handler.go handleVerifyTOTP (102 lines / 100): the block that
  resolves the user behind the partial-auth challenge and decrypts their TOTP
  secret becomes totpChallengeSecret. The ban-inside-the-partial-window check
  moves with it.
- service/message_reactions.go handleReaction (cyclop 21 / 20): the whole
  authorisation chain — channel lookup, archived gate, DM participant and
  block checks, non-DM permission check — becomes reactionAudience, which
  also returns the DM fan-out audience it already resolved. Check order is
  unchanged and load-bearing.
- db/admin_queries.go BackupToSafe (cyclop 21 / 20): the character allowlist
  loop and the SQL-comment rejection become validateBackupPathChars. That
  loop alone was most of the branch count.

No error string, no check and no ordering changed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(plugin): split InstallFromZip into staged install helpers

104 statements / cyclomatic 44 / nestif 12. Split along the stages the code
already had: installZipExtract (the per-entry write loop, with
installZipEntryDest holding the mode/symlink/zip-slip guard chain and
installZipWriteEntry the size-capped copy), installZipStagedManifest,
installZipPromote, and installZipReactivate for the :399 nested block.

Every zip-slip, symlink, entry-mode and uncompressed-size check is preserved
in the same order relative to the writes it guards. The 19 inline
`cleanup(); return` sites collapse to 4 in the orchestrator, one per stage,
because each helper now returns an error instead of unwinding itself — the
staging directory is still removed on exactly the same set of failures.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(api): split newWAFMiddleware into engine build and per-phase helpers

184 lines / cyclomatic 38, and the request-body block at :382 was the worst
nested site in the tree at nestif 17.

Engine construction moves out of the closure (wafInlineEngine, wafCRSEngine —
the Coraza directive string is lifted verbatim), and each request phase
becomes its own helper: wafInlineRequestHeaders, wafCRSRequestHeaders
(including the Host/Transfer-Encoding re-add for CRS 920280), wafFeedCRSBody
and wafInspectRequestBody, which is the old :382 block.

The three `handleWAFInterruption(w, it); return` sites inside the body block
become one: the helper now returns the interruption and the orchestrator
handles it. No statement runs between the two points on either side, so the
verdict is honoured identically — in particular a CRS body interruption still
returns without replacing r.Body.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(service): split SendMessage and lift EditMessage's access check

SendMessage was 79 statements / cyclomatic 35 with an 11-deep nested
attachment block at :101; EditMessage was one point over cyclop.

SendMessage becomes sendMessagePrecheck (permission and DM-block gates,
content sanitisation), sendMessageLinkAttachments (the :101 block: attachment
ownership, claim and link) and sendMessageDMSideEffects. EditMessage gets
editMessageCheckAccess and nothing else — one budget over earns one
extraction.

The sanitizeContent fixpoint and the attachment ownership check are unchanged,
as is the order of every gate. The DM side effects run behind
`isDM && !s.sendMessageDMSideEffects(...)`, so a non-DM never enters them;
inside, only the GetDMParticipantIDs failure returns false, matching the one
error the original early-returned on.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(admin): split handlePatchUser into per-field apply helpers

106 lines / cyclomatic 29, with the ban block at :154 nested 9 deep.

Each optional field of the partial edit becomes its own helper —
patchUserPrecheck, patchUserAuthorizeRole, patchUserApplyBan (the :154 block,
including the session disconnect and the broadcast) and patchUserApplyRole.
Each returns a bool meaning "keep going"; none of them writes a success
response, so the single response site in the orchestrator is unchanged.

Field application order, the permission-cache invalidation on a role change
and the disconnect-and-broadcast on a ban are all preserved, as are the three
fail-closed `mod == nil` guards, which now sit at the top of their own helper
and still fire on exactly the same conditions.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(admin): split handleSetup into first-run setup stages

143 lines / cyclomatic 30, with the optional-wizard block at :219 sitting
exactly on the nestif threshold.

Split into the stages the endpoint already had: request gating (rate limit and
origin check, which run before any auth exists on a fresh server), owner
account creation, and the wizard application that was the :219 block.

Every gate in front of the handler is a security control on an unauthenticated
endpoint; none moved relative to the work it protects. setup_wizard.go is
untouched.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor: split run() into named bootstrap and shutdown steps

131 statements / cyclomatic 57, with the executable-path fallback at :126
nested 9 deep.

The five anonymous `defer func(){...}()` blocks become named functions —
telemetryStop, runClosePlugins, runStopEventPersistence, runStopAuditWriter,
maintenanceStop — and the bootstrap stages move out likewise.

Every defer is still registered in run() itself, at the same point in the
sequence, so the LIFO teardown order is unchanged; that order is documented
in the surrounding comments and is load-bearing (the audit-writer stop must
follow database.Close's registration, the event-persistence stop must precede
it). runStopEventPersistence is now registered unconditionally with a nil
persister meaning "disabled", where the old code registered its defer inside
the enabled branch — a no-op occupying that slot cannot change the relative
order of the others.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(ws): split handleReconnect into resume stages

77 statements / cyclomatic 41, plus the replay block at :199 and, in
handleFreshConnect, the voice-state restore at :622.

handleReconnect becomes reconnectPrecheck, reconnectSelectReplay (with
reconnectVetColdTail for the cold-tier gap check), reconnectRegister and
reconnectWriteReplay. handleFreshConnect's stale-voice cleanup moves to its
own helper, where the `if h.livekit != nil` wrapper becomes a guard clause —
that block was the tail of its scope, so returning early and falling off the
end are the same.

The parts that carry the invariants are moved verbatim: reconnectRegister
still takes h.seqMu, still calls registerNow inside that same critical
section (BUG-123 / OC-0206), still unlocks on every exit, and still emits the
"full" tier counter and telemetry on each of its three re-check failures.
handleReconnect's two-boolean contract is unchanged — the collapsed
`return false, false` sites are all fall-through-to-full-ready, and the
single `return true, false` is still the handshake-write-failure path whose
teardown already ran (OC-0051).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* docs(server): fold in the adversarial review of the complexity refactors

Eleven skeptic passes over the refactor commits on this branch found no
blocker and no major — behaviour is preserved throughout. They did find
comment and accuracy defects worth correcting:

- db/mention_queries.go: the mentionTargetColumn rationale claimed the named
  type made the interpolated column "only ever one of the two constants". A
  Go named type is not closed, so that is a convention the type makes visible,
  not one it enforces. Reworded, gosec justification included.
- ws/voice_controls.go: the dupl collapse generalised away three specifics —
  that a server deafen is the moderator's to lift (now on the serverDeafen
  field), the concrete voice_states.camera / voice_states.screenshare column
  names, and the half of the OC-0023 rationale about neither stream kind
  hiding from the other's count. All three restored.
- ws/voice_join.go: `maxUsers := ch.VoiceMaxUsers` had been hoisted to the top
  of voiceJoinComplete, moving a read across the tail supersession guard. The
  read is inert, but it was the one statement in that commit whose position
  relative to a security guard changed; it now sits at its use, as before.
- ws/*_test.go: three test comments cited voice_join.go line numbers that the
  split invalidated. They now cite the helper by name instead.
- service/message_reactions.go: reactionAudience's doc claimed to enforce
  "every gate on reacting"; it enforces the channel-scoped ones, and the doc
  now says which gates stay with the caller.
- api/emoji_handler.go: the readEmojiUpload call reused the outer `ok` from
  the auth check by assignment; it gets its own readOK.
- admin/setup_handler.go: a moved comment kept a "the response above" deictic
  that no longer had a response above it.

No behaviour change. Build, vet, full tests and -race on five packages green.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(ws): clear the remaining complexity budgets across the hub

Eight files, thirteen findings. Each function is split at the stages it
already had; no branch is reordered, merged or inverted.

- handlers.go handleMessage (cyclop 28, 88 stmts): session re-check, frame
  decode and result application become handleMessageSessionRecheck,
  handleMessageDecode and handleMessageApply. The V2 constructor lookup ->
  DispatchV2 -> Result resolution order is untouched.
- serve_ready.go buildReady (cyclop 26, 61 stmts): the per-section fetches
  split out, readyChannelPayloads among them. Every visibility predicate is
  preserved verbatim — this is the payload that decides what a client may see.
- serve_pumps.go writePump (cyclop 31): writePumpWrite, writePumpDeliver,
  writePumpDrainChannel and writePumpDrainAndClose. Every channel receive
  stays in the same select statement, so scheduling is unchanged.
- hub_sweep.go sweepStaleVoiceStates (cyclop 22, 56 stmts): the staleness
  predicate, the hub-lock ordering and the position of the race hook are all
  as they were — handleVoiceJoin's BUG-088 ordering depends on them.
- hub_broadcast.go channelReadAudienceImpl and RefreshChannelVisibility
  (cyclop 22 each, 57 stmts): channelReadAudienceDM and
  refreshChannelVisibilityCanSend. The audience predicate is the OC-0090
  group-DM leak surface, so it is extracted, never simplified.
- livekit_webhook.go (nestif 13 and 14): webhookJoinedEnforceVoiceState,
  webhookLeftCleanupClient and webhookLeftFinishLeave. DB delete still
  precedes broadcast on every path.
- livekit_download.go EnsureLiveKitBinary (52 stmts): one extraction,
  ensureLiveKitStageBinary, keeping every archive path check intact.
- voice_moderation.go (nestif 8): voiceModDeafenRollback. The persisted
  server_muted flag remains the authority.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(api): clear the remaining complexity budgets across the HTTP layer

- router.go NewRouter (cyclop 28, 84 stmts): split by wiring concern into
  routerTOTPKey, routerHealthDeps, routerMiddleware, routerUploadRoutes,
  routerPluginWiring, routerVoiceRoutes and routerMetricsRoutes. Middleware
  ORDER is a security property (auth before handler, WAF before body parse,
  rate limit before work) and is unchanged; the returned cleanup func still
  closes over and releases everything it did before.
- auth_handler.go handleRegister (133 lines) and handleLogin (cyclop 21,
  152 lines): registerPolicyGate, registerReadRequest, loginReadRequest and
  loginAuthenticate. The always-compare posture, every rate-limit key, every
  counter reset and the ban-check-versus-password-compare order are all
  preserved — including loginUserFailureThreshold staying unscaled by
  scaledAuthLimit, which is deliberate and commented.
- upload_handler.go handleServeFile (cyclop 31, 128 lines): serveFileResolve
  and serveFileAuthorize. Every header this sets — Content-Disposition
  included, which is what stops a stored file being served as active content —
  is still set with the same value in the same circumstances.
- profile_handler.go handleUploadAvatar (120 lines): avatarUploadReadImage,
  mirroring readEmojiUpload in shape but with the avatar caps and MIME set.
  The two deliberately do not share a helper.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor: clear the last complexity budgets in db and admin

- db/account.go DeleteAccount (cyclop 28, 55 stmts): grouped by subsystem into
  deleteAccountAdminGuard, deleteAccountDMChannels and
  deleteAccountCloseDMChannels, each taking the same transaction. The
  transaction boundary, the delete ORDER (which foreign keys depend on) and
  the rollback path are unchanged.
- admin/logstream.go handleLogStream (cyclop 24): logStreamAuthorize. Flush
  cadence, heartbeat and disconnect detection untouched.
- admin/setup_wizard.go validateWizard (cyclop 23): grouped by section into
  wizardValidateIdentity, wizardValidateNetwork and wizardValidateMedia. Every
  message and bound is unchanged — this is the first input-validation boundary
  on a fresh server, before any auth exists.

With this the tree is at zero: golangci-lint run reports 0 issues against the
budgets set in #1384 (funlen 100/50, cyclop 20, nestif 8, dupl 150), with no
//nolint and no exclusion added anywhere.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-18 20:39:45 +02:00

424 lines
15 KiB
Go

package api
import (
"bytes"
"context"
"encoding/binary"
"errors"
"fmt"
"image"
_ "image/gif" // register the GIF decoder for image.DecodeConfig
_ "image/jpeg" // register the JPEG decoder for image.DecodeConfig
_ "image/png" // register the PNG decoder for image.DecodeConfig
"io"
"log/slog"
"net/http"
"strconv"
"time"
"github.com/go-chi/chi/v5"
"github.com/google/uuid"
"github.com/owncord/server/auth"
"github.com/owncord/server/db"
"github.com/owncord/server/service"
)
// EmojiBroadcaster is the slice of the hub the emoji routes need: after every
// mutation the full set is pushed to every connected client so pickers,
// message rendering and reaction pills converge without a reconnect.
type EmojiBroadcaster interface {
BroadcastEmojiUpdate(list []*db.Emoji)
}
// emojiResponse is the JSON shape of one emoji in GET/POST /api/v1/emoji.
// Deliberately not db.Emoji: the storage id and sniffed mime type are
// server-side details, and `url` is what a client actually needs.
type emojiResponse struct {
ID int64 `json:"id"`
Shortcode string `json:"shortcode"`
URL string `json:"url"`
}
func toEmojiResponse(e *db.Emoji) emojiResponse {
return emojiResponse{ID: e.ID, Shortcode: e.Shortcode, URL: service.EmojiImageURL(e.ID)}
}
func toEmojiResponses(list []*db.Emoji) []emojiResponse {
out := make([]emojiResponse, 0, len(list))
for _, e := range list {
if e == nil {
continue
}
out = append(out, toEmojiResponse(e))
}
return out
}
// allowedEmojiMIME is the set of image types an emoji may be, matched against
// the type sniffed from the file's own bytes. SVG is absent on purpose: it is
// markup with script and external-fetch capability, which is exactly what
// isUnsafeInlineMIME forces to a download on the attachment route -- an emoji
// is by definition rendered inline, so the format simply cannot be allowed.
var allowedEmojiMIME = map[string]bool{
"image/png": true,
"image/jpeg": true,
"image/gif": true,
"image/webp": true,
}
// MountEmojiRoutes registers the custom-emoji endpoints.
//
// Every route requires authentication: reading the set is ungated beyond that
// (emoji are server-wide and every member renders them), while POST and DELETE
// are gated on MANAGE_SERVER inside EmojiService. The image route is
// authenticated rather than public so an emoji cannot be used as an
// unauthenticated tracking pixel hosted on someone else's server.
func MountEmojiRoutes(r chi.Router, database *db.DB, svc *service.Services, store FileStore, limiter *auth.RateLimiter, broadcaster EmojiBroadcaster) {
r.Route("/api/v1/emoji", func(r chi.Router) {
r.Use(AuthMiddleware(database))
r.Get("/", handleListEmoji(svc))
r.Get("/{id}/image", handleServeEmojiImage(svc, store))
r.With(MaxBodySize(emojiMaxBodySize)).
Post("/", handleCreateEmoji(svc, store, limiter, broadcaster))
r.Delete("/{id}", handleDeleteEmoji(svc, store, broadcaster))
})
}
func handleListEmoji(svc *service.Services) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
list, err := svc.Emoji.List(r.Context())
if err != nil {
writeServiceError(r.Context(), w, err)
return
}
writeJSON(w, http.StatusOK, toEmojiResponses(list))
}
}
// handleCreateEmoji processes POST /api/v1/emoji (multipart: `file` + `shortcode`).
//
// Order matters here. The permission gate runs BEFORE the multipart parse, so a
// member without MANAGE_SERVER cannot make the server spool a body to disk; the
// shortcode is validated next, so a malformed name costs nothing either; only
// then are the bytes read, sniffed, measured and stored.
func handleCreateEmoji(svc *service.Services, store FileStore, limiter *auth.RateLimiter, broadcaster EmojiBroadcaster) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
user, ok := r.Context().Value(UserKey).(*db.User)
if !ok || user == nil {
writeJSON(w, http.StatusUnauthorized, errorResponse{
Error: "UNAUTHORIZED", Message: "not authenticated",
})
return
}
if err := svc.Emoji.RequireManage(r.Context(), user.ID); err != nil {
writeServiceError(r.Context(), w, err)
return
}
if limiter != nil && !limiter.Allow(auth.Key("emoji_upload", user.ID), emojiUploadRateLimitPerMinute, time.Minute) {
writeJSON(w, http.StatusTooManyRequests, errorResponse{
Error: "RATE_LIMITED", Message: "emoji upload rate limit exceeded, try again later",
})
return
}
// Bound the body before the multipart parser touches it. The route also
// carries MaxBodySize, but a handler that parses a form has to state
// its own limit — the parser is what turns an unbounded body into heap.
r.Body = http.MaxBytesReader(w, r.Body, emojiMaxBodySize)
if err := r.ParseMultipartForm(emojiMultipartMemoryLimit); err != nil {
writeJSON(w, http.StatusBadRequest, errorResponse{
Error: "BAD_REQUEST", Message: "invalid multipart form",
})
return
}
shortcode, err := service.ValidateShortcode(r.FormValue("shortcode"))
if err != nil {
writeServiceError(r.Context(), w, err)
return
}
raw, mimeType, readOK := readEmojiUpload(w, r)
if !readOK {
return
}
storedAs := uuid.New().String()
if _, saveErr := store.Save(storedAs, bytes.NewReader(raw)); saveErr != nil {
// writeStorageSaveError also stops echoing raw storage errors
// (which embed absolute paths) into the response body.
writeStorageSaveError(w, saveErr, "emoji upload")
return
}
created, err := svc.Emoji.Create(r.Context(), user.ID, shortcode, storedAs, mimeType)
if err != nil {
// The row never landed, so the file is an orphan — unlink it.
if delErr := store.Delete(storedAs); delErr != nil {
slog.Error("failed to clean up orphaned emoji file", "stored_as", storedAs, "error", delErr)
}
writeServiceError(r.Context(), w, err)
return
}
broadcastEmojiSet(r.Context(), svc, broadcaster)
writeJSON(w, http.StatusCreated, toEmojiResponse(created))
}
}
// readEmojiUpload pulls the uploaded file out of the already-parsed multipart
// form and enforces every property of the bytes themselves: the size cap, the
// sniffed MIME type and the sniffed pixel dimensions. It writes the refusal
// itself, so a false third result means the response is already complete.
func readEmojiUpload(w http.ResponseWriter, r *http.Request) ([]byte, string, bool) {
file, _, err := r.FormFile("file")
if err != nil {
writeJSON(w, http.StatusBadRequest, errorResponse{
Error: "BAD_REQUEST", Message: "missing file field",
})
return nil, "", false
}
defer file.Close() //nolint:errcheck
// Read at most one byte past the cap so "exactly at the limit" passes
// and "one byte over" is caught, without buffering an unbounded body.
raw, err := io.ReadAll(io.LimitReader(file, maxEmojiFileBytes+1))
if err != nil {
writeJSON(w, http.StatusBadRequest, errorResponse{
Error: "BAD_REQUEST", Message: "failed to read uploaded file",
})
return nil, "", false
}
if int64(len(raw)) > maxEmojiFileBytes {
writeJSON(w, http.StatusBadRequest, errorResponse{
Error: "BAD_REQUEST",
Message: fmt.Sprintf("emoji must be at most %d KB", maxEmojiFileBytes>>10),
})
return nil, "", false
}
mimeType := http.DetectContentType(raw)
if !allowedEmojiMIME[mimeType] {
writeJSON(w, http.StatusBadRequest, errorResponse{
Error: "BAD_REQUEST",
Message: "emoji must be a PNG, JPEG, GIF or WebP image",
})
return nil, "", false
}
width, height, err := imageDimensions(raw, mimeType)
if err != nil {
writeJSON(w, http.StatusBadRequest, errorResponse{
Error: "BAD_REQUEST", Message: "could not read image dimensions",
})
return nil, "", false
}
// Re-check the sniffed dimensions rather than trusting anything the
// client said about the image: the cap is what keeps an "emoji" from
// being a full-size picture inlined into every message that names it.
if width <= 0 || height <= 0 || width > maxEmojiDimension || height > maxEmojiDimension {
writeJSON(w, http.StatusBadRequest, errorResponse{
Error: "BAD_REQUEST",
Message: fmt.Sprintf("emoji must be at most %dx%d pixels (got %dx%d)", maxEmojiDimension, maxEmojiDimension, width, height),
})
return nil, "", false
}
return raw, mimeType, true
}
func handleDeleteEmoji(svc *service.Services, store FileStore, broadcaster EmojiBroadcaster) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
user, ok := r.Context().Value(UserKey).(*db.User)
if !ok || user == nil {
writeJSON(w, http.StatusUnauthorized, errorResponse{
Error: "UNAUTHORIZED", Message: "not authenticated",
})
return
}
id, err := strconv.ParseInt(chi.URLParam(r, "id"), 10, 64)
if err != nil || id <= 0 {
writeJSON(w, http.StatusBadRequest, errorResponse{
Error: "BAD_REQUEST", Message: "invalid emoji id",
})
return
}
removed, err := svc.Emoji.Delete(r.Context(), user.ID, id)
if err != nil {
writeServiceError(r.Context(), w, err)
return
}
// The row is already gone, so a failed unlink leaves an orphaned blob,
// not a broken emoji — log it rather than failing a successful delete.
if delErr := store.Delete(removed.StoredAs); delErr != nil {
slog.Warn("failed to remove emoji file", "stored_as", removed.StoredAs, "error", delErr)
}
broadcastEmojiSet(r.Context(), svc, broadcaster)
w.WriteHeader(http.StatusNoContent)
}
}
// broadcastEmojiSet re-reads the set and pushes it to every client. A failure
// here is logged and swallowed: the mutation itself already succeeded, and the
// caller's own response carries the change.
//
// Called after the mutation has already committed, so the caller's request
// context may be canceled by the time this runs (client aborted, deadline
// fired) -- context.WithoutCancel detaches the re-read from that, matching
// the pattern service/emoji.go already uses for its post-commit audit write.
func broadcastEmojiSet(ctx context.Context, svc *service.Services, broadcaster EmojiBroadcaster) {
if broadcaster == nil {
return
}
list, err := svc.Emoji.List(context.WithoutCancel(ctx))
if err != nil {
slog.Error("failed to load emoji for broadcast", "error", err)
return
}
broadcaster.BroadcastEmojiUpdate(list)
}
// handleServeEmojiImage serves the stored bytes of one emoji.
//
// Unlike /api/v1/files/{id} there is no per-channel ACL to apply: an emoji is
// server-wide by construction, so authentication is the whole check. The
// response is immutable for the id's lifetime (an emoji's bytes never change
// — a replacement is a new row), which is what lets it be cached hard.
func handleServeEmojiImage(svc *service.Services, store FileStore) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
id, err := strconv.ParseInt(chi.URLParam(r, "id"), 10, 64)
if err != nil || id <= 0 {
http.NotFound(w, r)
return
}
e, err := svc.Emoji.Get(r.Context(), id)
if err != nil {
if errors.Is(err, service.ErrNotFound) {
http.NotFound(w, r)
return
}
writeServiceError(r.Context(), w, err)
return
}
f, err := store.Open(e.StoredAs)
if err != nil {
http.NotFound(w, r)
return
}
defer f.Close() //nolint:errcheck
w.Header().Set("Content-Type", e.MimeType)
w.Header().Set("X-Content-Type-Options", "nosniff")
w.Header().Set("Content-Disposition", "inline")
// Private (it needed a session to fetch) but immutable, so a client may
// keep it for a day rather than re-fetching it for every message.
w.Header().Set("Cache-Control", "private, max-age=86400, immutable")
var modTime time.Time
if info, statErr := f.Stat(); statErr == nil {
modTime = info.ModTime()
}
http.ServeContent(w, r, e.Shortcode, modTime, f)
}
}
// ─── Dimension extraction ────────────────────────────────────────────────────
// imageDimensions returns the pixel size of an image already known to be one of
// the allowed types. PNG/JPEG/GIF go through image.DecodeConfig; WebP has no
// decoder in the standard library and none is vendored, so its header is read
// directly — which is all that is wanted here anyway, since decoding a whole
// frame just to learn its size is work the cap exists to avoid.
//
// Shared by the emoji and avatar upload routes: both refuse an image too big
// for the surface it renders on, and both have to answer the same question
// about the same four formats.
func imageDimensions(raw []byte, mimeType string) (width, height int, err error) {
if mimeType == "image/webp" {
width, height, err = webpDimensions(raw)
} else {
var cfg image.Config
cfg, _, err = image.DecodeConfig(bytes.NewReader(raw))
if err != nil {
return 0, 0, fmt.Errorf("decoding image config: %w", err)
}
width, height = cfg.Width, cfg.Height
}
if err != nil {
return 0, 0, err
}
// Both callers treat a non-error return as trustworthy enough to compare
// straight against their pixel cap. A width or height of zero is not a
// "small" image, it is a decoder -- Go's own GIF DecodeConfig happily
// reports height=0 for a malformed logical screen descriptor -- accepting
// a degenerate header as valid. Rejecting it here means the invariant
// holds even for a caller that forgets to re-check, instead of relying on
// every call site getting its own bounds check right.
if width <= 0 || height <= 0 {
return 0, 0, fmt.Errorf("decoding image config: non-positive dimensions %dx%d", width, height)
}
return width, height, nil
}
// errBadWebP is returned for any WebP whose header does not parse; the caller
// turns it into the same 400 a corrupt PNG gets.
var errBadWebP = errors.New("malformed WebP header")
// webpDimensions reads the canvas size out of a RIFF/WEBP container. All three
// chunk flavours are handled: VP8 (lossy), VP8L (lossless) and VP8X (extended,
// which is what an animated or alpha WebP uses).
func webpDimensions(raw []byte) (width, height int, err error) {
// 12-byte RIFF header + at least a 4-byte chunk fourcc.
if len(raw) < 16 || string(raw[0:4]) != "RIFF" || string(raw[8:12]) != "WEBP" {
return 0, 0, errBadWebP
}
switch string(raw[12:16]) {
case "VP8 ":
// Chunk payload starts at 20; the keyframe start code sits 3 bytes in,
// followed by two 14-bit dimensions (the top 2 bits are a scale field).
if len(raw) < 30 {
return 0, 0, errBadWebP
}
if raw[23] != 0x9d || raw[24] != 0x01 || raw[25] != 0x2a {
return 0, 0, errBadWebP
}
w := int(binary.LittleEndian.Uint16(raw[26:28]) & 0x3FFF)
h := int(binary.LittleEndian.Uint16(raw[28:30]) & 0x3FFF)
// Unlike VP8L/VP8X (which store size-1, so they can never encode
// zero), the VP8 keyframe stores the size directly: an all-zero
// dimension field is a validly-shaped but degenerate header, not a
// real 0x0 canvas. Reject it here rather than reporting "success"
// with a size no image actually has.
if w == 0 || h == 0 {
return 0, 0, errBadWebP
}
return w, h, nil
case "VP8L":
// Payload starts at 20 with a 0x2F signature byte, then a packed
// 14+14-bit (width-1, height-1) pair.
if len(raw) < 25 || raw[20] != 0x2F {
return 0, 0, errBadWebP
}
bits := binary.LittleEndian.Uint32(raw[21:25])
w := int(bits&0x3FFF) + 1
h := int((bits>>14)&0x3FFF) + 1
return w, h, nil
case "VP8X":
// Payload starts at 20: flags byte, 3 reserved bytes, then canvas
// width-1 and height-1 as 24-bit little-endian values.
if len(raw) < 30 {
return 0, 0, errBadWebP
}
w := int(uint32(raw[24]) | uint32(raw[25])<<8 | uint32(raw[26])<<16)
h := int(uint32(raw[27]) | uint32(raw[28])<<8 | uint32(raw[29])<<16)
return w + 1, h + 1, nil
default:
return 0, 0, errBadWebP
}
}