mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
* fix(ws): 2 defect(s) (OC-0013, OC-0140) * fix(voice): 1 defect(s) (OC-0044) * fix(ws): 1 defect(s) (OC-0024) * fix(server): 1 defect(s) (OC-0027) * fix(ws): 1 defect(s) (OC-0028) * fix(server): 7 defect(s) (OC-0033, OC-0066, OC-0067, OC-0068, OC-0074, OC-0077, OC-0106) * fix(ws): 1 defect(s) (OC-0051) * fix(client): 1 defect(s) (OC-0053) * fix(client): 1 defect(s) (OC-0055) * fix(service): 1 defect(s) (OC-0069) * fix(voice): 1 defect(s) (OC-0072) * fix(service): 1 defect(s) (OC-0082) * fix(client): 1 defect(s) (OC-0083) * fix(plugin): 1 defect(s) (OC-0088) * fix(plugin): 4 defect(s) (OC-0104, OC-0126, OC-0127, OC-0133) * fix(admin): 1 defect(s) (OC-0110) * fix(client): 1 defect(s) (OC-0114) * fix(api): 1 defect(s) (OC-0139) * fix(client): 1 defect(s) (OC-0149) * test(server): adapt existing tests to updated OpenDM and IncrementMentionCounts signatures * style(plugin): modernize loops and goroutine spawns in race test * fix(ws): mirror the focus admission gate in the post-subscribe revalidation * fix(service): detach DM post-commit side effects from the request ctx, fail delete closed, add empty-fan-out fallback * fix(plugin): preserve enabled intent when upgrade reactivation hits a runtime-less build * chore(skills): harden bughunt-fix workflow and fold review lessons into bughunt-run/db-change * Add comprehensive documentation for task-observer skill - Introduced environments.md to outline activation setup, compaction behavior, and handoff-doc mode. - Created skill-authoring.md detailing taxonomy, licensing, confidentiality, and editing rules for skill creation. - Added weekly-review.md for a structured review process of OPEN observations, including scheduled and in-session fallback modes. * chore(go): pin toolchain go1.26.6 (stdlib CVE fixes flagged by govulncheck)
630 lines
19 KiB
Go
630 lines
19 KiB
Go
package db_test
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
)
|
|
|
|
// ─── GetOrCreateDMChannel ───────────────────────────────────────────────────
|
|
|
|
func TestGetOrCreateDMChannel_CreatesNew(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
|
|
ch, created, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel: %v", err)
|
|
}
|
|
if !created {
|
|
t.Error("expected created=true for new DM channel")
|
|
}
|
|
if ch == nil {
|
|
t.Fatal("expected channel, got nil")
|
|
}
|
|
if ch.Type != "dm" {
|
|
t.Errorf("Type = %q, want 'dm'", ch.Type)
|
|
}
|
|
if ch.ID <= 0 {
|
|
t.Errorf("expected positive channel ID, got %d", ch.ID)
|
|
}
|
|
}
|
|
|
|
func TestGetOrCreateDMChannel_Idempotent(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
|
|
ch1, created1, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("first GetOrCreateDMChannel: %v", err)
|
|
}
|
|
if !created1 {
|
|
t.Error("expected created=true on first call")
|
|
}
|
|
|
|
ch2, created2, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("second GetOrCreateDMChannel: %v", err)
|
|
}
|
|
if created2 {
|
|
t.Error("expected created=false on second call")
|
|
}
|
|
if ch1.ID != ch2.ID {
|
|
t.Errorf("channel IDs differ: %d vs %d", ch1.ID, ch2.ID)
|
|
}
|
|
}
|
|
|
|
func TestGetOrCreateDMChannel_IdempotentReversedOrder(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
|
|
ch1, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel(u1,u2): %v", err)
|
|
}
|
|
|
|
// Reversed argument order should find the same channel.
|
|
ch2, created, err := database.GetOrCreateDMChannel(context.Background(), user2, user1)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel(u2,u1): %v", err)
|
|
}
|
|
if created {
|
|
t.Error("expected created=false when called with reversed user order")
|
|
}
|
|
if ch1.ID != ch2.ID {
|
|
t.Errorf("channel IDs differ: %d vs %d", ch1.ID, ch2.ID)
|
|
}
|
|
}
|
|
|
|
// ─── GetUserDMChannelIDs ────────────────────────────────────────────────────
|
|
|
|
// The ID-only lookup backs access computation (ws replay filtering, search
|
|
// scoping) — it must track dm_open_state exactly: present while open, gone
|
|
// after close, per user.
|
|
func TestGetUserDMChannelIDs(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
user3 := seedUser(t, database, "carol")
|
|
|
|
ch12, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel(u1,u2): %v", err)
|
|
}
|
|
ch13, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user3)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel(u1,u3): %v", err)
|
|
}
|
|
|
|
ids, err := database.GetUserDMChannelIDs(context.Background(), user1)
|
|
if err != nil {
|
|
t.Fatalf("GetUserDMChannelIDs: %v", err)
|
|
}
|
|
got := make(map[int64]bool, len(ids))
|
|
for _, id := range ids {
|
|
got[id] = true
|
|
}
|
|
if len(ids) != 2 || !got[ch12.ID] || !got[ch13.ID] {
|
|
t.Errorf("user1 IDs = %v, want {%d, %d}", ids, ch12.ID, ch13.ID)
|
|
}
|
|
|
|
// user2 only participates in one DM.
|
|
ids2, err := database.GetUserDMChannelIDs(context.Background(), user2)
|
|
if err != nil {
|
|
t.Fatalf("GetUserDMChannelIDs(user2): %v", err)
|
|
}
|
|
if len(ids2) != 1 || ids2[0] != ch12.ID {
|
|
t.Errorf("user2 IDs = %v, want [%d]", ids2, ch12.ID)
|
|
}
|
|
|
|
// Closing a DM removes it from the caller's set only.
|
|
if err := database.CloseDM(context.Background(), user1, ch12.ID); err != nil {
|
|
t.Fatalf("CloseDM: %v", err)
|
|
}
|
|
ids, err = database.GetUserDMChannelIDs(context.Background(), user1)
|
|
if err != nil {
|
|
t.Fatalf("GetUserDMChannelIDs after close: %v", err)
|
|
}
|
|
if len(ids) != 1 || ids[0] != ch13.ID {
|
|
t.Errorf("user1 IDs after close = %v, want [%d]", ids, ch13.ID)
|
|
}
|
|
ids2, _ = database.GetUserDMChannelIDs(context.Background(), user2)
|
|
if len(ids2) != 1 || ids2[0] != ch12.ID {
|
|
t.Errorf("user2 IDs after user1's close = %v, want [%d]", ids2, ch12.ID)
|
|
}
|
|
}
|
|
|
|
func TestGetOrCreateDMChannel_ReopensForCaller(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
|
|
ch, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel: %v", err)
|
|
}
|
|
|
|
// Close the DM for user1.
|
|
if err := database.CloseDM(context.Background(), user1, ch.ID); err != nil {
|
|
t.Fatalf("CloseDM: %v", err)
|
|
}
|
|
|
|
// Verify user1 no longer sees it.
|
|
dms, err := database.GetUserDMChannels(context.Background(), user1)
|
|
if err != nil {
|
|
t.Fatalf("GetUserDMChannels: %v", err)
|
|
}
|
|
if len(dms) != 0 {
|
|
t.Errorf("expected 0 open DMs after close, got %d", len(dms))
|
|
}
|
|
|
|
// Call GetOrCreateDMChannel again — should re-open for user1.
|
|
ch2, created, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel after close: %v", err)
|
|
}
|
|
if created {
|
|
t.Error("expected created=false (reuse existing channel)")
|
|
}
|
|
if ch2.ID != ch.ID {
|
|
t.Errorf("expected same channel ID %d, got %d", ch.ID, ch2.ID)
|
|
}
|
|
|
|
// User1 should now see the DM again.
|
|
dms, err = database.GetUserDMChannels(context.Background(), user1)
|
|
if err != nil {
|
|
t.Fatalf("GetUserDMChannels after reopen: %v", err)
|
|
}
|
|
if len(dms) != 1 {
|
|
t.Errorf("expected 1 open DM after reopen, got %d", len(dms))
|
|
}
|
|
}
|
|
|
|
// ─── GetUserDMChannels ──────────────────────────────────────────────────────
|
|
|
|
func TestGetUserDMChannels_EmptyList(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
|
|
dms, err := database.GetUserDMChannels(context.Background(), user1)
|
|
if err != nil {
|
|
t.Fatalf("GetUserDMChannels: %v", err)
|
|
}
|
|
if len(dms) != 0 {
|
|
t.Errorf("expected 0 DMs, got %d", len(dms))
|
|
}
|
|
}
|
|
|
|
func TestGetUserDMChannels_ReturnsOpenDMs(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
user3 := seedUser(t, database, "charlie")
|
|
|
|
_, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel(u1,u2): %v", err)
|
|
}
|
|
_, _, err = database.GetOrCreateDMChannel(context.Background(), user1, user3)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel(u1,u3): %v", err)
|
|
}
|
|
|
|
dms, err := database.GetUserDMChannels(context.Background(), user1)
|
|
if err != nil {
|
|
t.Fatalf("GetUserDMChannels: %v", err)
|
|
}
|
|
if len(dms) != 2 {
|
|
t.Fatalf("expected 2 DMs, got %d", len(dms))
|
|
}
|
|
|
|
// Verify recipient info is correct (one should be bob, one charlie).
|
|
names := map[string]bool{}
|
|
for _, dm := range dms {
|
|
names[dm.Recipient.Username] = true
|
|
}
|
|
if !names["bob"] {
|
|
t.Error("expected recipient 'bob' in DMs")
|
|
}
|
|
if !names["charlie"] {
|
|
t.Error("expected recipient 'charlie' in DMs")
|
|
}
|
|
}
|
|
|
|
func TestGetUserDMChannels_ExcludesClosedDMs(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
|
|
ch, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel: %v", err)
|
|
}
|
|
|
|
if err := database.CloseDM(context.Background(), user1, ch.ID); err != nil {
|
|
t.Fatalf("CloseDM: %v", err)
|
|
}
|
|
|
|
dms, err := database.GetUserDMChannels(context.Background(), user1)
|
|
if err != nil {
|
|
t.Fatalf("GetUserDMChannels: %v", err)
|
|
}
|
|
if len(dms) != 0 {
|
|
t.Errorf("expected 0 DMs after close, got %d", len(dms))
|
|
}
|
|
|
|
// User2 should still see the DM (only user1 closed it).
|
|
dms2, err := database.GetUserDMChannels(context.Background(), user2)
|
|
if err != nil {
|
|
t.Fatalf("GetUserDMChannels(user2): %v", err)
|
|
}
|
|
if len(dms2) != 1 {
|
|
t.Errorf("expected 1 DM for user2, got %d", len(dms2))
|
|
}
|
|
}
|
|
|
|
func TestGetUserDMChannels_UnreadCount(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
|
|
ch, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel: %v", err)
|
|
}
|
|
|
|
// Send 3 messages from user2 in the DM channel.
|
|
msg1, err := database.CreateMessage(context.Background(), ch.ID, user2, "hello", nil)
|
|
if err != nil {
|
|
t.Fatalf("CreateMessage 1: %v", err)
|
|
}
|
|
_, err = database.CreateMessage(context.Background(), ch.ID, user2, "how are you", nil)
|
|
if err != nil {
|
|
t.Fatalf("CreateMessage 2: %v", err)
|
|
}
|
|
_, err = database.CreateMessage(context.Background(), ch.ID, user2, "anyone there?", nil)
|
|
if err != nil {
|
|
t.Fatalf("CreateMessage 3: %v", err)
|
|
}
|
|
|
|
// Mark user1 as having read only the first message.
|
|
if err := database.UpdateReadState(context.Background(), user1, ch.ID, msg1); err != nil {
|
|
t.Fatalf("UpdateReadState: %v", err)
|
|
}
|
|
|
|
dms, err := database.GetUserDMChannels(context.Background(), user1)
|
|
if err != nil {
|
|
t.Fatalf("GetUserDMChannels: %v", err)
|
|
}
|
|
if len(dms) != 1 {
|
|
t.Fatalf("expected 1 DM, got %d", len(dms))
|
|
}
|
|
if dms[0].UnreadCount != 2 {
|
|
t.Errorf("UnreadCount = %d, want 2", dms[0].UnreadCount)
|
|
}
|
|
}
|
|
|
|
func TestGetUserDMChannels_NoMessages(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
|
|
_, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel: %v", err)
|
|
}
|
|
|
|
dms, err := database.GetUserDMChannels(context.Background(), user1)
|
|
if err != nil {
|
|
t.Fatalf("GetUserDMChannels: %v", err)
|
|
}
|
|
if len(dms) != 1 {
|
|
t.Fatalf("expected 1 DM, got %d", len(dms))
|
|
}
|
|
if dms[0].LastMessageID != nil {
|
|
t.Errorf("expected nil LastMessageID, got %d", *dms[0].LastMessageID)
|
|
}
|
|
if dms[0].UnreadCount != 0 {
|
|
t.Errorf("UnreadCount = %d, want 0", dms[0].UnreadCount)
|
|
}
|
|
}
|
|
|
|
func TestGetUserDMChannels_LastMessagePreview(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
|
|
ch, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel: %v", err)
|
|
}
|
|
|
|
_, err = database.CreateMessage(context.Background(), ch.ID, user2, "first message", nil)
|
|
if err != nil {
|
|
t.Fatalf("CreateMessage 1: %v", err)
|
|
}
|
|
lastMsgID, err := database.CreateMessage(context.Background(), ch.ID, user2, "latest message", nil)
|
|
if err != nil {
|
|
t.Fatalf("CreateMessage 2: %v", err)
|
|
}
|
|
|
|
dms, err := database.GetUserDMChannels(context.Background(), user1)
|
|
if err != nil {
|
|
t.Fatalf("GetUserDMChannels: %v", err)
|
|
}
|
|
if len(dms) != 1 {
|
|
t.Fatalf("expected 1 DM, got %d", len(dms))
|
|
}
|
|
if dms[0].LastMessageID == nil {
|
|
t.Fatal("expected non-nil LastMessageID")
|
|
}
|
|
if *dms[0].LastMessageID != lastMsgID {
|
|
t.Errorf("LastMessageID = %d, want %d", *dms[0].LastMessageID, lastMsgID)
|
|
}
|
|
if dms[0].LastMessage != "latest message" {
|
|
t.Errorf("LastMessage = %q, want 'latest message'", dms[0].LastMessage)
|
|
}
|
|
}
|
|
|
|
// ─── IsDMParticipant ────────────────────────────────────────────────────────
|
|
|
|
func TestIsDMParticipant_ValidParticipant(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
|
|
ch, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel: %v", err)
|
|
}
|
|
|
|
ok, err := database.IsDMParticipant(context.Background(), user1, ch.ID)
|
|
if err != nil {
|
|
t.Fatalf("IsDMParticipant(user1): %v", err)
|
|
}
|
|
if !ok {
|
|
t.Error("expected true for user1")
|
|
}
|
|
|
|
ok, err = database.IsDMParticipant(context.Background(), user2, ch.ID)
|
|
if err != nil {
|
|
t.Fatalf("IsDMParticipant(user2): %v", err)
|
|
}
|
|
if !ok {
|
|
t.Error("expected true for user2")
|
|
}
|
|
}
|
|
|
|
func TestIsDMParticipant_NonParticipant(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
user3 := seedUser(t, database, "charlie")
|
|
|
|
ch, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel: %v", err)
|
|
}
|
|
|
|
ok, err := database.IsDMParticipant(context.Background(), user3, ch.ID)
|
|
if err != nil {
|
|
t.Fatalf("IsDMParticipant(user3): %v", err)
|
|
}
|
|
if ok {
|
|
t.Error("expected false for non-participant user3")
|
|
}
|
|
}
|
|
|
|
func TestIsDMParticipant_NonExistentChannel(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
|
|
ok, err := database.IsDMParticipant(context.Background(), user1, 99999)
|
|
if err != nil {
|
|
t.Fatalf("IsDMParticipant: %v", err)
|
|
}
|
|
if ok {
|
|
t.Error("expected false for non-existent channel")
|
|
}
|
|
}
|
|
|
|
// ─── OpenDM / CloseDM ──────────────────────────────────────────────────────
|
|
|
|
func TestOpenDM_Idempotent(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
|
|
ch, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel: %v", err)
|
|
}
|
|
|
|
// Already open from creation — opening again should not error, and must
|
|
// report false: the row already existed, so this call is a no-op.
|
|
if opened, err := database.OpenDM(context.Background(), user1, ch.ID); err != nil {
|
|
t.Errorf("OpenDM (idempotent) error: %v", err)
|
|
} else if opened {
|
|
t.Error("OpenDM (idempotent) reported opened=true for an already-open DM")
|
|
}
|
|
|
|
// Should still have exactly 1 DM.
|
|
dms, err := database.GetUserDMChannels(context.Background(), user1)
|
|
if err != nil {
|
|
t.Fatalf("GetUserDMChannels: %v", err)
|
|
}
|
|
if len(dms) != 1 {
|
|
t.Errorf("expected 1 DM after idempotent open, got %d", len(dms))
|
|
}
|
|
}
|
|
|
|
func TestCloseDM_RemovesFromOpenList(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
|
|
ch, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel: %v", err)
|
|
}
|
|
|
|
if err := database.CloseDM(context.Background(), user1, ch.ID); err != nil {
|
|
t.Fatalf("CloseDM: %v", err)
|
|
}
|
|
|
|
dms, err := database.GetUserDMChannels(context.Background(), user1)
|
|
if err != nil {
|
|
t.Fatalf("GetUserDMChannels: %v", err)
|
|
}
|
|
if len(dms) != 0 {
|
|
t.Errorf("expected 0 DMs after close, got %d", len(dms))
|
|
}
|
|
}
|
|
|
|
func TestCloseDM_Idempotent(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
|
|
ch, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel: %v", err)
|
|
}
|
|
|
|
// Close twice — should not error.
|
|
if err := database.CloseDM(context.Background(), user1, ch.ID); err != nil {
|
|
t.Errorf("first CloseDM error: %v", err)
|
|
}
|
|
if err := database.CloseDM(context.Background(), user1, ch.ID); err != nil {
|
|
t.Errorf("second CloseDM (idempotent) error: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestOpenDM_AfterClose(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
|
|
ch, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel: %v", err)
|
|
}
|
|
|
|
if err := database.CloseDM(context.Background(), user1, ch.ID); err != nil {
|
|
t.Fatalf("CloseDM: %v", err)
|
|
}
|
|
|
|
if opened, err := database.OpenDM(context.Background(), user1, ch.ID); err != nil {
|
|
t.Fatalf("OpenDM after close: %v", err)
|
|
} else if !opened {
|
|
t.Error("OpenDM after close reported opened=false — a genuine reopen must report true")
|
|
}
|
|
|
|
dms, err := database.GetUserDMChannels(context.Background(), user1)
|
|
if err != nil {
|
|
t.Fatalf("GetUserDMChannels: %v", err)
|
|
}
|
|
if len(dms) != 1 {
|
|
t.Errorf("expected 1 DM after reopen, got %d", len(dms))
|
|
}
|
|
}
|
|
|
|
// ─── GetDMParticipantIDs ────────────────────────────────────────────────────
|
|
|
|
func TestGetDMParticipantIDs_ReturnsBoth(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
|
|
ch, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel: %v", err)
|
|
}
|
|
|
|
ids, err := database.GetDMParticipantIDs(context.Background(), ch.ID)
|
|
if err != nil {
|
|
t.Fatalf("GetDMParticipantIDs: %v", err)
|
|
}
|
|
if len(ids) != 2 {
|
|
t.Fatalf("expected 2 participant IDs, got %d", len(ids))
|
|
}
|
|
|
|
idSet := map[int64]bool{ids[0]: true, ids[1]: true}
|
|
if !idSet[user1] {
|
|
t.Errorf("expected user1 ID %d in participants", user1)
|
|
}
|
|
if !idSet[user2] {
|
|
t.Errorf("expected user2 ID %d in participants", user2)
|
|
}
|
|
}
|
|
|
|
func TestGetDMParticipantIDs_NonExistentChannel(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
|
|
ids, err := database.GetDMParticipantIDs(context.Background(), 99999)
|
|
if err != nil {
|
|
t.Fatalf("GetDMParticipantIDs: %v", err)
|
|
}
|
|
if len(ids) != 0 {
|
|
t.Errorf("expected 0 IDs for non-existent channel, got %d", len(ids))
|
|
}
|
|
}
|
|
|
|
// ─── GetDMRecipient ─────────────────────────────────────────────────────────
|
|
|
|
func TestGetDMRecipient_ReturnsOtherUser(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
user2 := seedUser(t, database, "bob")
|
|
|
|
ch, _, err := database.GetOrCreateDMChannel(context.Background(), user1, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetOrCreateDMChannel: %v", err)
|
|
}
|
|
|
|
// From user1's perspective, recipient should be user2.
|
|
recipient, err := database.GetDMRecipient(context.Background(), ch.ID, user1)
|
|
if err != nil {
|
|
t.Fatalf("GetDMRecipient(user1): %v", err)
|
|
}
|
|
if recipient == nil {
|
|
t.Fatal("expected recipient, got nil")
|
|
}
|
|
if recipient.ID != user2 {
|
|
t.Errorf("recipient ID = %d, want %d", recipient.ID, user2)
|
|
}
|
|
if recipient.Username != "bob" {
|
|
t.Errorf("recipient Username = %q, want 'bob'", recipient.Username)
|
|
}
|
|
|
|
// From user2's perspective, recipient should be user1.
|
|
recipient2, err := database.GetDMRecipient(context.Background(), ch.ID, user2)
|
|
if err != nil {
|
|
t.Fatalf("GetDMRecipient(user2): %v", err)
|
|
}
|
|
if recipient2 == nil {
|
|
t.Fatal("expected recipient, got nil")
|
|
}
|
|
if recipient2.ID != user1 {
|
|
t.Errorf("recipient ID = %d, want %d", recipient2.ID, user1)
|
|
}
|
|
if recipient2.Username != "alice" {
|
|
t.Errorf("recipient Username = %q, want 'alice'", recipient2.Username)
|
|
}
|
|
}
|
|
|
|
func TestGetDMRecipient_NonExistentChannel(t *testing.T) {
|
|
database := openMigratedMemory(t)
|
|
user1 := seedUser(t, database, "alice")
|
|
|
|
recipient, err := database.GetDMRecipient(context.Background(), 99999, user1)
|
|
if err != nil {
|
|
t.Fatalf("GetDMRecipient: %v", err)
|
|
}
|
|
if recipient != nil {
|
|
t.Errorf("expected nil for non-existent channel, got user ID %d", recipient.ID)
|
|
}
|
|
}
|