Files
OwnCord/Server/db/db.go
T
J3vbandClaude Fable 5 6afa9e974c refactor(server): thread context.Context through the db layer and all callers
Fixes all 109 golangci-lint findings (106 contextcheck, 1 gocritic,
2 gosec) that accumulated after D2 wired dbgen (whose queries take ctx)
under ctx-less db.DB wrappers while CI lint was quota-dead. No nolint
comments added; every finding fixed by genuinely threading context.

- db: all 138 hand-written db.DB methods take ctx first; the dbCtx()
  Background shim is deleted; raw Query/QueryRow/Exec/Begin use their
  Context variants; the four redundant ctx-less passthroughs removed.
  db.Auditor/WriteAudit gain ctx.
- Seams: permissions.Checker (DB iface, HasChannelPerm,
  RequireChannelAccess) and the service.Store interface mirror the new
  signatures (ws.EventStore and plugin.PluginStore already did).
- Callers: api/admin handlers use r.Context(); ws per-message paths use
  the connection ctx via DispatchV2; hub loops and startup wiring use
  context.Background(); service methods thread ctx where they have one
  and Background where no ctx exists. Public service surface reached by
  ctx-holding chains (PermissionService.HasChannelPerm/GetRoleForUser/
  RequireChannelAccess, message/dm/block/invite/profile methods) is now
  ctx-first.
- Detached (context.WithoutCancel) where cancellation would break an
  invariant, found by a 3-lens adversarial review of the diff:
  * voice-leave background retries (a dead webhook/connection ctx killed
    retry 2 before it ran, leaving ghost capacity-holding voice rows)
  * rollbackVoiceJoin's compensating delete (its trigger IS the cancel)
  * post-2FA-change DeleteOtherSessions and logout DeleteSession (the
    security tail of a committed change must not die with the request)
  * all api/ws audit writes (a banned user could suppress their own
    login_blocked_banned row by aborting the request mid-bcrypt)
  * admin backup VACUUM INTO (an interrupt left a truncated .db that
    the backup list presented as restorable)
  * post-commit message/edit refetches (a committed message must still
    fan out when the sender disconnects)
  * hub settings-cache refresh (one dead connection could pin stale
    values for the 30s TTL)
- gocritic rangeValCopy fixed (index iteration); gosec G306 excluded in
  config with justification (generated source must stay world-readable)
  instead of flipping genprotocol output to 0o600.

Verified: gofmt/vet, all four build-tag variants, full suite, deadlock
pass, full -race pass, golangci-lint 0 issues uncapped.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-23 17:03:52 +02:00

126 lines
4.4 KiB
Go

// Package db provides database access for the OwnCord server.
// It uses modernc.org/sqlite — a pure-Go SQLite driver requiring no CGO.
package db
import (
"context"
"database/sql"
"fmt"
"github.com/owncord/server/db/dbgen"
"github.com/owncord/server/migrations"
_ "modernc.org/sqlite" // register the sqlite3 driver
)
// DB wraps *sql.DB and exposes the subset of methods needed by the server.
//
// q is the sqlc-generated query layer (db/dbgen). Query method bodies delegate
// to it — sqlc is the source of truth for the SQL text and parameter binding
// (verified in CI by `make sqlc-verify`), while this package keeps the stable
// public API and the domain model types the rest of the server consumes.
// Migration is incremental (decision D2); methods not yet delegated still run
// their raw SQL directly against sqlDB.
type DB struct {
sqlDB *sql.DB
q *dbgen.Queries
}
// Open opens (or creates) a SQLite database at path, enables WAL mode and
// foreign key enforcement, and returns a ready-to-use DB.
func Open(path string) (*DB, error) {
sqlDB, err := sql.Open("sqlite", path)
if err != nil {
return nil, fmt.Errorf("opening sqlite db: %w", err)
}
// Verify the connection is actually usable.
if err := sqlDB.Ping(); err != nil {
_ = sqlDB.Close()
return nil, fmt.Errorf("pinging sqlite db: %w", err)
}
// SQLite only allows one writer at a time. Pin to a single connection
// so concurrent goroutines queue on the Go side rather than getting
// SQLITE_BUSY. For :memory: databases this also ensures all callers
// share the same in-memory state.
sqlDB.SetMaxOpenConns(1)
// Enable WAL mode for better concurrent read performance.
if _, err := sqlDB.Exec("PRAGMA journal_mode=WAL;"); err != nil {
_ = sqlDB.Close()
return nil, fmt.Errorf("enabling WAL mode: %w", err)
}
// Wait up to 5 seconds for the write lock instead of failing instantly.
if _, err := sqlDB.Exec("PRAGMA busy_timeout=5000;"); err != nil {
_ = sqlDB.Close()
return nil, fmt.Errorf("setting busy_timeout: %w", err)
}
// Enforce foreign key constraints.
if _, err := sqlDB.Exec("PRAGMA foreign_keys=ON;"); err != nil {
_ = sqlDB.Close()
return nil, fmt.Errorf("enabling foreign keys: %w", err)
}
// Performance tuning (safe with WAL mode).
if _, err := sqlDB.Exec("PRAGMA synchronous=NORMAL;"); err != nil {
_ = sqlDB.Close()
return nil, fmt.Errorf("setting synchronous mode: %w", err)
}
if _, err := sqlDB.Exec("PRAGMA temp_store=MEMORY;"); err != nil {
_ = sqlDB.Close()
return nil, fmt.Errorf("setting temp_store: %w", err)
}
if _, err := sqlDB.Exec("PRAGMA mmap_size=268435456;"); err != nil {
_ = sqlDB.Close()
return nil, fmt.Errorf("setting mmap_size: %w", err)
}
if _, err := sqlDB.Exec("PRAGMA cache_size=-64000;"); err != nil {
_ = sqlDB.Close()
return nil, fmt.Errorf("setting cache_size: %w", err)
}
return &DB{sqlDB: sqlDB, q: dbgen.New(sqlDB)}, nil
}
// Migrate runs all SQL migration files from the embedded migrations FS in
// lexicographic order, applying each file exactly once. It delegates to
// MigrateFS (defined in migrate.go) which maintains the schema_versions
// tracking table.
func Migrate(database *DB) error {
return MigrateFS(database, migrations.FS)
}
// Close releases the underlying database connection.
func (d *DB) Close() error {
// Run PRAGMA optimize to analyze and update query planner statistics.
_, _ = d.sqlDB.Exec("PRAGMA optimize;")
return d.sqlDB.Close()
}
// QueryRowContext executes a query that returns at most one row, with context.
func (d *DB) QueryRowContext(ctx context.Context, query string, args ...any) *sql.Row {
return d.sqlDB.QueryRowContext(ctx, query, args...)
}
// ExecContext executes a query that doesn't return rows, with context.
func (d *DB) ExecContext(ctx context.Context, query string, args ...any) (sql.Result, error) {
return d.sqlDB.ExecContext(ctx, query, args...)
}
// QueryContext executes a query that returns multiple rows, with context.
func (d *DB) QueryContext(ctx context.Context, query string, args ...any) (*sql.Rows, error) {
return d.sqlDB.QueryContext(ctx, query, args...)
}
// BeginTx starts a database transaction with context and options.
func (d *DB) BeginTx(ctx context.Context, opts *sql.TxOptions) (*sql.Tx, error) {
return d.sqlDB.BeginTx(ctx, opts)
}
// SQLDb returns the underlying *sql.DB for cases requiring direct access.
func (d *DB) SQLDb() *sql.DB {
return d.sqlDB
}