mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
Server: - Fix YAML injection in LiveKit config generation (quote values) - Revert token TTL to 4h (no server-side JWT revocation) - Derive LiveKit publish permissions from user role (prevent SFU bypass) - Add CAS guard for webhook/voice_leave race condition - Add voice_leave broadcast to rollbackVoiceJoin (prevent ghost state) - Limit webhook body to 64KB (prevent memory abuse) - Add rate limit to voice_token_refresh handler (1/60s) - Add LiveKit health check endpoint (GET /api/v1/livekit/health, 503 on degraded) - Add voice_token_refresh WS handler for client-initiated token refresh - Consolidate voice quality constants (single source of truth) - Fix video limit TOCTOU race (count from DB instead of LiveKit API) - Raise default voice_max_video from 10 to 25 (Discord parity) - Add CountActiveCameras DB query - Non-blocking broadcast send, circuit breaker, exponential backoff - Close send channel before context cancel in serve.go - Guard voice mute/deafen for active channel - Delete orphaned message on attachment link failure - Redact query string from proxy logs (prevent token leak) - Use instance-level HTTP client for health checks (no redirect following) - Set cmd.WaitDelay to prevent goroutine leak on Windows - Log buildJSON marshal errors Client: - Refactor livekitSession.ts from singleton module to LiveKitSession class - Share single AudioContext for all analysers (was 1 per participant) - Extract createRoom() helper (DRY) - Add token refresh timer (3.5h interval, re-arms on failure) - Skip setSpeakers if unchanged (sort in-place, no allocations) - Distinguish user-initiated leave from connection error in retry - Add YouTube videoId validation (prevent iframe src injection) - Add try/finally to disableCamera - Wrap store subscription callbacks in try/catch - Track and cancel initial scroll RAF on cleanup - Add 5s timeout + encodeURIComponent to YouTube oEmbed fetch - Clean raw mic stream on RNNoise suppressor failure - Full voice cleanup on logout via cleanupAll() Tests: - Add 7 new server tests (webhook parsing, voice guards, quality fallback) - Fix 2 pre-existing test failures (mute/deafen invalid payload)
336 lines
11 KiB
Go
336 lines
11 KiB
Go
package ws
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"log/slog"
|
|
"net/http"
|
|
"strings"
|
|
"time"
|
|
|
|
"nhooyr.io/websocket"
|
|
|
|
"github.com/owncord/server/auth"
|
|
"github.com/owncord/server/db"
|
|
)
|
|
|
|
const authDeadline = 10 * time.Second
|
|
const writeTimeout = 10 * time.Second
|
|
const settingsCacheTTL = 30 * time.Second
|
|
|
|
// ServeWS upgrades an HTTP connection to WebSocket, performs in-band auth,
|
|
// then drives the client's read/write loops.
|
|
// Do not wrap with AuthMiddleware — WS does its own auth.
|
|
//
|
|
// allowedOrigins controls which HTTP origins may open a WebSocket connection.
|
|
// Pass nil or []string{"*"} to allow all origins (insecure, for development).
|
|
// Pass explicit origins such as []string{"https://example.com"} to restrict access.
|
|
func ServeWS(hub *Hub, database *db.DB, allowedOrigins []string) http.HandlerFunc {
|
|
acceptOpts := OriginAcceptOptions(allowedOrigins)
|
|
return func(w http.ResponseWriter, r *http.Request) {
|
|
conn, err := websocket.Accept(w, r, acceptOpts)
|
|
if err != nil {
|
|
slog.Warn("ws upgrade failed", "err", err)
|
|
return
|
|
}
|
|
conn.SetReadLimit(1 << 20) // 1 MB — match client-side limit
|
|
|
|
user, tokenHash, lastSeq, err := authenticateConn(conn, database)
|
|
if err != nil {
|
|
slog.Warn("ws auth failed", "err", err, "remote", r.RemoteAddr)
|
|
_ = conn.Close(websocket.StatusPolicyViolation, "authentication failed")
|
|
return
|
|
}
|
|
|
|
// Reject duplicate connections — prevent ping-pong reconnect loops.
|
|
if hub.IsUserConnected(user.ID) {
|
|
slog.Warn("ws duplicate login rejected", "user_id", user.ID, "remote", r.RemoteAddr)
|
|
ctx := r.Context()
|
|
_ = conn.Write(ctx, websocket.MessageText, buildAuthError("already connected from another client"))
|
|
_ = conn.Close(websocket.StatusPolicyViolation, "already connected")
|
|
return
|
|
}
|
|
|
|
c := newClient(hub, conn, user, tokenHash)
|
|
hub.Register(c)
|
|
|
|
// Look up role name for protocol-compliant payloads and cache on client.
|
|
roleName := "member"
|
|
if role, roleErr := database.GetRoleByID(user.RoleID); roleErr == nil && role != nil {
|
|
roleName = strings.ToLower(role.Name)
|
|
}
|
|
c.roleName = roleName
|
|
|
|
slog.Info("websocket connected", "username", user.Username, "user_id", user.ID, "remote", r.RemoteAddr)
|
|
_ = database.LogAudit(user.ID, "ws_connect", "user", user.ID,
|
|
"WebSocket connected from "+r.RemoteAddr)
|
|
|
|
ctx := r.Context()
|
|
|
|
// Reconnection with state recovery: if the client sent a last_seq,
|
|
// try to replay missed events from the ring buffer instead of
|
|
// sending a full ready payload.
|
|
if lastSeq > 0 {
|
|
events := hub.ReplayBuffer().EventsSince(lastSeq)
|
|
if events != nil {
|
|
// Replay succeeded — send auth_ok then missed events.
|
|
slog.Info("ws sending auth_ok (reconnect)", "user_id", user.ID, "username", user.Username, "role", roleName)
|
|
_ = conn.Write(ctx, websocket.MessageText, hub.buildAuthOK(user, roleName))
|
|
for _, evt := range events {
|
|
_ = conn.Write(ctx, websocket.MessageText, evt)
|
|
}
|
|
slog.Info("ws replay completed", "user_id", user.ID, "events_replayed", len(events), "from_seq", lastSeq)
|
|
|
|
// Update presence but skip member_join — user was already known.
|
|
if updateErr := database.UpdateUserStatus(user.ID, "online"); updateErr != nil {
|
|
slog.Warn("ws UpdateUserStatus", "err", updateErr)
|
|
}
|
|
hub.BroadcastToAll(buildPresenceMsg(user.ID, "online"))
|
|
|
|
// Start pumps.
|
|
writeCtx, writeCancel := context.WithCancel(ctx)
|
|
go writePump(writeCtx, conn, c)
|
|
readPump(ctx, conn, hub, c)
|
|
c.closeSend()
|
|
writeCancel()
|
|
return
|
|
}
|
|
// Replay failed (seq too old) — fall through to full ready payload.
|
|
slog.Info("ws replay failed (seq too old), sending full ready", "user_id", user.ID, "last_seq", lastSeq)
|
|
}
|
|
|
|
// Fresh connection or replay fallback: full auth_ok + ready flow.
|
|
if updateErr := database.UpdateUserStatus(user.ID, "online"); updateErr != nil {
|
|
slog.Warn("ws UpdateUserStatus", "err", updateErr)
|
|
}
|
|
|
|
slog.Info("ws sending auth_ok", "user_id", user.ID, "username", user.Username, "role", roleName)
|
|
_ = conn.Write(ctx, websocket.MessageText, hub.buildAuthOK(user, roleName))
|
|
if ready, readyErr := hub.buildReady(database, user.ID); readyErr == nil {
|
|
slog.Info("ws sending ready payload", "user_id", user.ID, "payload_bytes", len(ready))
|
|
_ = conn.Write(ctx, websocket.MessageText, ready)
|
|
} else {
|
|
slog.Error("buildReady failed", "user_id", user.ID, "err", readyErr)
|
|
_ = conn.Write(ctx, websocket.MessageText,
|
|
buildErrorMsg(ErrCodeInternal, "failed to build ready payload"))
|
|
}
|
|
|
|
slog.Info("ws broadcasting member_join and presence", "user_id", user.ID, "username", user.Username)
|
|
hub.BroadcastToAll(buildMemberJoin(user, roleName))
|
|
hub.BroadcastToAll(buildPresenceMsg(user.ID, "online"))
|
|
|
|
// writePump runs in background; readPump blocks.
|
|
// When readPump returns (disconnect), close the send channel first
|
|
// so writePump drains any remaining messages, then cancel its context.
|
|
writeCtx, writeCancel := context.WithCancel(ctx)
|
|
go writePump(writeCtx, conn, c)
|
|
readPump(ctx, conn, hub, c)
|
|
c.closeSend()
|
|
writeCancel()
|
|
}
|
|
}
|
|
|
|
// writePump drains the client's send channel and writes to the WebSocket.
|
|
func writePump(ctx context.Context, conn *websocket.Conn, c *Client) {
|
|
for {
|
|
select {
|
|
case msg, ok := <-c.send:
|
|
if !ok {
|
|
_ = conn.Close(websocket.StatusNormalClosure, "")
|
|
return
|
|
}
|
|
wCtx, cancel := context.WithTimeout(ctx, writeTimeout)
|
|
err := conn.Write(wCtx, websocket.MessageText, msg)
|
|
cancel()
|
|
if err != nil {
|
|
slog.Warn("ws writePump error", "user_id", c.userID, "err", err)
|
|
return
|
|
}
|
|
case <-ctx.Done():
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
// readPump reads from the WebSocket and dispatches messages. Blocks until disconnect.
|
|
func readPump(ctx context.Context, conn *websocket.Conn, hub *Hub, c *Client) {
|
|
defer func() {
|
|
hub.Unregister(c)
|
|
hub.handleVoiceLeave(c)
|
|
if c.user != nil {
|
|
slog.Info("websocket disconnected", "username", c.user.Username, "user_id", c.userID)
|
|
_ = hub.db.UpdateUserStatus(c.userID, "offline")
|
|
hub.BroadcastToAll(buildPresenceMsg(c.userID, "offline"))
|
|
}
|
|
}()
|
|
|
|
for {
|
|
_, msg, err := conn.Read(ctx)
|
|
if err != nil {
|
|
return
|
|
}
|
|
c.touch()
|
|
hub.handleMessage(c, msg)
|
|
}
|
|
}
|
|
|
|
// authenticateConn reads the first WebSocket message and validates the session
|
|
// token. Returns the authenticated user and the token hash (for later
|
|
// periodic session revalidation).
|
|
func authenticateConn(conn *websocket.Conn, database *db.DB) (*db.User, string, uint64, error) {
|
|
ctx, cancel := context.WithTimeout(context.Background(), authDeadline)
|
|
defer cancel()
|
|
|
|
_, raw, err := conn.Read(ctx)
|
|
if err != nil {
|
|
return nil, "", 0, err
|
|
}
|
|
|
|
var env envelope
|
|
if err := json.Unmarshal(raw, &env); err != nil {
|
|
_ = conn.Write(ctx, websocket.MessageText, buildAuthError( "invalid message"))
|
|
return nil, "", 0, fmt.Errorf("auth: invalid JSON: %w", err)
|
|
}
|
|
if env.Type != "auth" {
|
|
_ = conn.Write(ctx, websocket.MessageText, buildAuthError( "first message must be auth"))
|
|
return nil, "", 0, fmt.Errorf("auth: unexpected type %q", env.Type)
|
|
}
|
|
|
|
var p struct {
|
|
Token string `json:"token"`
|
|
LastSeq uint64 `json:"last_seq"`
|
|
}
|
|
if err := json.Unmarshal(env.Payload, &p); err != nil || p.Token == "" {
|
|
_ = conn.Write(ctx, websocket.MessageText, buildAuthError( "missing token"))
|
|
return nil, "", 0, fmt.Errorf("auth: missing token")
|
|
}
|
|
|
|
hash := auth.HashToken(p.Token)
|
|
sess, err := database.GetSessionByTokenHash(hash)
|
|
if err != nil || sess == nil {
|
|
_ = conn.Write(ctx, websocket.MessageText, buildAuthError( "invalid token"))
|
|
return nil, "", 0, fmt.Errorf("auth: invalid session")
|
|
}
|
|
|
|
if auth.IsSessionExpired(sess.ExpiresAt) {
|
|
_ = conn.Write(ctx, websocket.MessageText, buildAuthError( "session expired"))
|
|
return nil, "", 0, fmt.Errorf("auth: session expired")
|
|
}
|
|
|
|
user, err := database.GetUserByID(sess.UserID)
|
|
if err != nil || user == nil {
|
|
_ = conn.Write(ctx, websocket.MessageText, buildAuthError( "user not found"))
|
|
return nil, "", 0, fmt.Errorf("auth: user not found")
|
|
}
|
|
|
|
if auth.IsEffectivelyBanned(user) {
|
|
_ = conn.Write(ctx, websocket.MessageText, buildErrorMsg(ErrCodeBanned, "you are banned"))
|
|
return nil, "", 0, fmt.Errorf("auth: banned user %d", user.ID)
|
|
}
|
|
|
|
return user, hash, p.LastSeq, nil
|
|
}
|
|
|
|
// buildAuthOK constructs the auth_ok server→client message.
|
|
// Per PROTOCOL.md, user object contains only id, username, avatar, role (no status).
|
|
func (h *Hub) buildAuthOK(user *db.User, roleName string) []byte {
|
|
var avatarVal any
|
|
if user.Avatar != nil {
|
|
avatarVal = *user.Avatar
|
|
}
|
|
|
|
serverName, motd := h.getCachedSettings()
|
|
|
|
return buildJSON(map[string]any{
|
|
"type": "auth_ok",
|
|
"payload": map[string]any{
|
|
"user": map[string]any{
|
|
"id": user.ID,
|
|
"username": user.Username,
|
|
"avatar": avatarVal,
|
|
"role": roleName,
|
|
},
|
|
"server_name": serverName,
|
|
"motd": motd,
|
|
},
|
|
})
|
|
}
|
|
|
|
// buildReady constructs the ready server→client message.
|
|
// Per PROTOCOL.md, channels include unread_count and last_message_id per user,
|
|
// and only protocol-specified fields (no slow_mode, archived, voice_* extras).
|
|
func (h *Hub) buildReady(database *db.DB, userID int64) ([]byte, error) {
|
|
channels, err := database.ListChannels()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("buildReady ListChannels: %w", err)
|
|
}
|
|
roles, err := database.ListRoles()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("buildReady ListRoles: %w", err)
|
|
}
|
|
|
|
members, err := database.ListMembers()
|
|
if err != nil {
|
|
slog.Warn("buildReady ListMembers", "err", err)
|
|
members = []db.MemberSummary{}
|
|
}
|
|
|
|
// Per-user unread counts.
|
|
unreadMap, err := database.GetChannelUnreadCounts(userID)
|
|
if err != nil {
|
|
slog.Warn("buildReady GetChannelUnreadCounts", "err", err)
|
|
unreadMap = map[int64]db.ChannelUnread{}
|
|
}
|
|
|
|
// Build protocol-compliant channel objects (strip extra fields).
|
|
channelPayloads := make([]map[string]any, 0, len(channels))
|
|
for _, ch := range channels {
|
|
entry := map[string]any{
|
|
"id": ch.ID,
|
|
"name": ch.Name,
|
|
"type": ch.Type,
|
|
"category": ch.Category,
|
|
"position": ch.Position,
|
|
}
|
|
if ch.Type == "text" {
|
|
if u, ok := unreadMap[ch.ID]; ok {
|
|
entry["unread_count"] = u.UnreadCount
|
|
entry["last_message_id"] = u.LastMessageID
|
|
} else {
|
|
entry["unread_count"] = 0
|
|
entry["last_message_id"] = 0
|
|
}
|
|
}
|
|
channelPayloads = append(channelPayloads, entry)
|
|
}
|
|
|
|
// Collect all active voice states across every voice channel.
|
|
voiceStates, err := collectAllVoiceStates(database, channels)
|
|
if err != nil {
|
|
// Non-fatal: send empty list rather than failing the whole ready payload.
|
|
slog.Warn("buildReady collectAllVoiceStates", "err", err)
|
|
voiceStates = []db.VoiceState{}
|
|
}
|
|
|
|
serverName, motd := h.getCachedSettings()
|
|
|
|
return buildJSON(map[string]any{
|
|
"type": "ready",
|
|
"payload": map[string]any{
|
|
"channels": channelPayloads,
|
|
"members": members,
|
|
"voice_states": voiceStates,
|
|
"roles": roles,
|
|
"server_name": serverName,
|
|
"motd": motd,
|
|
},
|
|
}), nil
|
|
}
|
|
|
|
// collectAllVoiceStates gathers voice states across all channels in a single
|
|
// query, replacing the previous N+1 per-channel pattern.
|
|
func collectAllVoiceStates(database *db.DB, _ []db.Channel) ([]db.VoiceState, error) {
|
|
return database.GetAllVoiceStates()
|
|
}
|