From 0600154d3db260b3cef0bba0e0b5cc83adbae526 Mon Sep 17 00:00:00 2001 From: Connor Yoh Date: Wed, 2 Sep 2026 13:43:40 +0100 Subject: [PATCH] fix(portal): state the reason in the story comments, not the change comment-lint CMT004: both new stories narrated what the code used to do. devGuide/CODE_COMMENTS.md asks for the reason instead, and git already holds the history. --- .../infrastructure/EncryptionPanel.stories.tsx | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/frontend/editor/src/portal/components/infrastructure/EncryptionPanel.stories.tsx b/frontend/editor/src/portal/components/infrastructure/EncryptionPanel.stories.tsx index fa119b9278..752e06dacb 100644 --- a/frontend/editor/src/portal/components/infrastructure/EncryptionPanel.stories.tsx +++ b/frontend/editor/src/portal/components/infrastructure/EncryptionPanel.stories.tsx @@ -285,8 +285,9 @@ export const MigrationFailed: Story = { }; /** - * A revoke that fails. The error belongs to the key card: one shared error - * string previously rendered it under "Encrypt existing files" instead. + * A revoke that fails. Asserts the message lands inside the key card rather + * than merely existing somewhere on the panel, which is the part that makes + * this a regression test rather than a smoke test. */ export const KeyActionFailed: Story = { globals: { tier: "enterprise" }, @@ -322,9 +323,9 @@ export const KeyActionFailed: Story = { }; /** - * Decrypt-only on S3. The backend still streams downloads through the app once - * any key exists, so the bandwidth note has to show here too — it used to be - * tied to the write flag and vanished in exactly this state. + * Decrypt-only on S3. The backend suppresses presigned URLs once any key row + * exists, not only while writes are encrypted, so the bandwidth note belongs + * in this state too. */ export const DecryptOnlyOnS3: Story = { globals: { tier: "enterprise" },