From cd49daf5c691dc1e115301c751b06181f0a5d93d Mon Sep 17 00:00:00 2001
From: brios <127139797+balazs-szucs@users.noreply.github.com>
Date: Thu, 13 Aug 2026 11:16:09 +0000
Subject: [PATCH] refactor(api): move DeletingRandomAccessFile to
 CustomPDFDocumentFactory as a private static class (#7344)

# Description of Changes

It was in a seperate dir
(app/common/src/main/java/org/apache/pdfbox/examples/util/) which i felt
out of place for it.



<!--
Please provide a summary of the changes, including:

- What was changed
- Why the change was made
- Any challenges encountered

Closes #(issue_number)
-->

---

## Checklist

### General

- [X] I have read the [Contribution
Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md)
- [X] I have read the [Stirling-PDF Developer
Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md)
(if applicable)
- [ ] I have read the [How to add new languages to
Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md)
(if applicable)
- [X] I have performed a self-review of my own code
- [X] My changes generate no new warnings

### Documentation

- [ ] I have updated relevant docs on [Stirling-PDF's doc
repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/)
(if functionality has heavily changed)
- [ ] I have read the section [Add New Translation
Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags)
(for new translation tags only)

### Translations (if applicable)

- [ ] I ran
[`scripts/counter_translation.py`](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/docs/counter_translation.md)

### UI Changes (if applicable)

- [ ] Screenshots or videos demonstrating the UI changes are attached
(e.g., as comments or direct attachments in the PR)

### Testing (if applicable)

- [X] I have run `task check` to verify linters, typechecks, and tests
pass
- [X] I have tested my changes locally. Refer to the [Testing
Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#7-testing)
for more details.
---
 .../service/CustomPDFDocumentFactory.java     | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/app/common/src/main/java/stirling/software/common/service/CustomPDFDocumentFactory.java b/app/common/src/main/java/stirling/software/common/service/CustomPDFDocumentFactory.java
index 178052ebf6..9a7caefc7d 100644
--- a/app/common/src/main/java/stirling/software/common/service/CustomPDFDocumentFactory.java
+++ b/app/common/src/main/java/stirling/software/common/service/CustomPDFDocumentFactory.java
@@ -729,4 +729,32 @@ public class CustomPDFDocumentFactory {
         p.toFile().deleteOnExit();
         return p;
     }
+
+    /** A custom RandomAccessRead implementation that deletes the file when closed */
+    private static class DeletingRandomAccessFile extends RandomAccessReadBufferedFile {
+        private final Path tempFilePath;
+
+        public DeletingRandomAccessFile(File file) throws IOException {
+            super(file);
+            this.tempFilePath = file.toPath();
+        }
+
+        @Override
+        public void close() throws IOException {
+            try {
+                super.close();
+            } finally {
+                try {
+                    boolean deleted = Files.deleteIfExists(tempFilePath);
+                    if (deleted) {
+                        log.info("Successfully deleted temp file: {}", tempFilePath);
+                    } else {
+                        log.warn("Failed to delete temp file (may not exist): {}", tempFilePath);
+                    }
+                } catch (IOException e) {
+                    log.error("Error deleting temp file: {}", tempFilePath, e);
+                }
+            }
+        }
+    }
 }