mirror of
https://github.com/Stirling-Tools/Stirling-PDF.git
synced 2026-09-03 05:10:16 +03:00
Connor Yoh
f5a1c7b235
A linked self-hosted instance was still shown the connect prompt, the sidebar
button and the feature gates.
linkState has three values and none of them is "unknown", so LinkProvider opens
at "unlinked" and a separate status call corrects it. The gate read !isLinked
and its loading flag covered only the app-config query, so between app-config
landing and the status arriving a linked instance looked unlinked: the prompt
fired, the gates closed, and markPrompted() burned the once-a-session marker on
a prompt that should never have opened.
Worse, the status call swallows its failures into { linked: false }. A 401 from
a lapsed admin session, a 5xx, a dropped connection, and nothing retries: the
instance then looked unlinked for the rest of the session. That is the version
users hit, because it does not correct itself.
So the context now carries whether the status has actually been read back.
Anything that blocks waits for it; the gate holds open until then and stays
open if the call never succeeds. A gate that cannot read its own precondition
should not be the thing standing in the way, and the real enforcement for these
features belongs on the server regardless.
The prop defaults to true so a pinned state in a story or test is still
believed as given. Only the app passes false, because only the app has to go
and ask.
Tests cover the three answers that were being conflated: not yet known, never
knowable, and genuinely unlinked, that last one so this cannot quietly become
"never gate".