mirror of
https://github.com/Stirling-Tools/Stirling-PDF.git
synced 2026-09-02 21:03:34 +03:00
# Description of Changes This PR modernizes the project's Python tooling across GitHub Actions by migrating CI workflows from pip-based dependency management to `uv` and aligning Python execution with the engine project's managed environment. ### What was changed - Replaced `actions/setup-python` and ad-hoc `pip install` steps with `astral-sh/setup-uv` across CI workflows. - Configured shared `uv` dependency caching using `engine/pyproject.toml` and `engine/uv.lock`. - Updated Python script execution to use `uv run --project engine --locked` for a consistent runtime environment. - Replaced package installation steps with `uv sync` for the required dependency groups (e.g. `tools` and `cucumber`). - Added Docker image build validation for both production and development AI engine images. - Updated workflow cache configuration and Docker build context where required. - Removed obsolete Python requirements files that are no longer needed after the migration. - Applied minor Python code modernizations, including import cleanup, modern built-in generic type annotations (`list[...]`, `tuple[...]`, `float | None`), and small style improvements. - Removed unnecessary Python formatter/linter extensions from the development container configuration. ### Why the change was made - Standardize Python dependency management across the repository. - Reduce duplicated dependency installation logic in CI. - Improve workflow performance through shared dependency caching. - Ensure all Python utilities execute against the same locked dependency set managed by the engine project. - Simplify long-term maintenance by eliminating legacy requirements files and pip-specific workflow steps. --- ## Checklist ### General - [ ] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [ ] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [ ] I have performed a self-review of my own code - [ ] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### Translations (if applicable) - [ ] I ran [`scripts/counter_translation.py`](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/docs/counter_translation.md) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have run `task check` to verify linters, typechecks, and tests pass - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#7-testing) for more details. --------- Signed-off-by: Carsten Drewes <c.drewes@stud.uni-hannover.de> Co-authored-by: albanobattistella <34811668+albanobattistella@users.noreply.github.com> Co-authored-by: kastenherri <116314318+kastenherri@users.noreply.github.com> Co-authored-by: Anthony Stirling <77850077+Frooodle@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: James Brunton <jbrunton96@gmail.com>
183 lines
5.6 KiB
Python
183 lines
5.6 KiB
Python
#!/usr/bin/env python3
|
|
"""
|
|
Validate that translation files have the same placeholders as en-US (source of truth).
|
|
|
|
Usage:
|
|
python scripts/translations/validate_placeholders.py [--language LANG] [--fix]
|
|
|
|
--language: Validate specific language (e.g., es-ES, de-DE)
|
|
--fix: Automatically remove extra placeholders (use with caution)
|
|
"""
|
|
|
|
import argparse
|
|
import json
|
|
import re
|
|
import sys
|
|
import tomllib # Python 3.11+ (stdlib)
|
|
from pathlib import Path
|
|
|
|
|
|
def find_placeholders(text: str) -> set[str]:
|
|
"""Find all placeholders in text like {n}, {{var}}, {0}, etc."""
|
|
if not isinstance(text, str):
|
|
return set()
|
|
return set(re.findall(r"\{\{?[^}]+\}\}?", text))
|
|
|
|
|
|
def flatten_dict(d: dict, parent_key: str = "", sep: str = ".") -> dict[str, str]:
|
|
"""Flatten nested dict to dot-notation keys."""
|
|
items = []
|
|
for k, v in d.items():
|
|
new_key = f"{parent_key}{sep}{k}" if parent_key else k
|
|
if isinstance(v, dict):
|
|
items.extend(flatten_dict(v, new_key, sep=sep).items())
|
|
else:
|
|
items.append((new_key, v))
|
|
return dict(items)
|
|
|
|
|
|
def validate_language(en_us_flat: dict[str, str], lang_flat: dict[str, str], lang_code: str) -> list[dict]:
|
|
"""Validate placeholders for a language against en-US."""
|
|
issues = []
|
|
|
|
for key in en_us_flat:
|
|
if key not in lang_flat:
|
|
continue
|
|
|
|
en_placeholders = find_placeholders(en_us_flat[key])
|
|
lang_placeholders = find_placeholders(lang_flat[key])
|
|
|
|
if en_placeholders != lang_placeholders:
|
|
missing = en_placeholders - lang_placeholders
|
|
extra = lang_placeholders - en_placeholders
|
|
|
|
issue = {
|
|
"language": lang_code,
|
|
"key": key,
|
|
"missing": missing,
|
|
"extra": extra,
|
|
"en_text": en_us_flat[key],
|
|
"lang_text": lang_flat[key],
|
|
}
|
|
issues.append(issue)
|
|
|
|
return issues
|
|
|
|
|
|
def print_issues(issues: list[dict], verbose: bool = False):
|
|
"""Print validation issues in a readable format."""
|
|
if not issues:
|
|
print("✅ No placeholder validation issues found!")
|
|
return
|
|
|
|
print(f"❌ Found {len(issues)} placeholder validation issue(s):\n")
|
|
print("=" * 100)
|
|
|
|
for i, issue in enumerate(issues, 1):
|
|
print(f"\n{i}. Language: {issue['language']}")
|
|
print(f" Key: {issue['key']}")
|
|
|
|
if issue["missing"]:
|
|
print(f" ⚠️ MISSING placeholders: {issue['missing']}")
|
|
if issue["extra"]:
|
|
print(f" ⚠️ EXTRA placeholders: {issue['extra']}")
|
|
|
|
if verbose:
|
|
print(f" EN-GB: {issue['en_text'][:150]}")
|
|
print(f" {issue['language']}: {issue['lang_text'][:150]}")
|
|
|
|
print("-" * 100)
|
|
|
|
|
|
def main():
|
|
parser = argparse.ArgumentParser(description="Validate translation placeholder consistency")
|
|
parser.add_argument(
|
|
"--language",
|
|
help="Specific language code to validate (e.g., es-ES)",
|
|
default=None,
|
|
)
|
|
parser.add_argument(
|
|
"--verbose",
|
|
"-v",
|
|
action="store_true",
|
|
help="Show full text samples for each issue",
|
|
)
|
|
parser.add_argument("--json", action="store_true", help="Output results as JSON")
|
|
|
|
args = parser.parse_args()
|
|
|
|
# Define paths
|
|
locales_dir = Path("frontend/editor/public/locales")
|
|
en_us_path = locales_dir / "en-US" / "translation.toml"
|
|
|
|
if not en_us_path.exists():
|
|
print(f"❌ Error: en-US translation file not found at {en_us_path}")
|
|
sys.exit(1)
|
|
|
|
# Load en-US (source of truth)
|
|
with open(en_us_path, "rb") as f:
|
|
en_us = tomllib.load(f)
|
|
|
|
en_us_flat = flatten_dict(en_us)
|
|
|
|
# Get list of languages to validate
|
|
if args.language:
|
|
languages = [args.language]
|
|
else:
|
|
# Validate all languages except en-US
|
|
languages = []
|
|
for d in locales_dir.iterdir():
|
|
if d.is_dir() and d.name != "en-US":
|
|
if (d / "translation.toml").exists():
|
|
languages.append(d.name)
|
|
|
|
all_issues = []
|
|
|
|
# Validate each language
|
|
for lang_code in sorted(languages):
|
|
lang_path = locales_dir / lang_code / "translation.toml"
|
|
|
|
if not lang_path.exists():
|
|
print(f"⚠️ Warning: {lang_code}/translation.toml not found, skipping")
|
|
continue
|
|
|
|
# Load language file
|
|
with open(lang_path, "rb") as f:
|
|
lang_data = tomllib.load(f)
|
|
|
|
lang_flat = flatten_dict(lang_data)
|
|
issues = validate_language(en_us_flat, lang_flat, lang_code)
|
|
all_issues.extend(issues)
|
|
|
|
# Output results
|
|
if args.json:
|
|
print(json.dumps(all_issues, indent=2, ensure_ascii=False))
|
|
else:
|
|
if all_issues:
|
|
# Group by language
|
|
by_language = {}
|
|
for issue in all_issues:
|
|
lang = issue["language"]
|
|
if lang not in by_language:
|
|
by_language[lang] = []
|
|
by_language[lang].append(issue)
|
|
|
|
print("📊 Validation Summary:")
|
|
print(f" Total issues: {len(all_issues)}")
|
|
print(f" Languages with issues: {len(by_language)}\n")
|
|
|
|
for lang in sorted(by_language.keys()):
|
|
print(f"\n{'=' * 100}")
|
|
print(f"Language: {lang} ({len(by_language[lang])} issue(s))")
|
|
print(f"{'=' * 100}")
|
|
print_issues(by_language[lang], verbose=args.verbose)
|
|
else:
|
|
print("✅ All translations have correct placeholders!")
|
|
|
|
# Exit with error code if issues found
|
|
sys.exit(1 if all_issues else 0)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|