ConnorYohandJames Brunton
50c0f2bcb5
## What was wrong Opening the procurement **Schedule a call** modal had two problems: 1. **Blank the first time, works the second time.** The first open showed nothing; closing and reopening eventually loaded Calendly. 2. **Slow to load** even when it did work. ## Why 1. Our script loader treated a script as "ready" the moment its `<script>` tag was added to the page — not when it had actually finished downloading. On the first open, two loads overlap (React re-runs the effect in dev), and the second one returned "ready" too early, before Calendly's code existed, so nothing rendered. Reopening worked because by then the script had finished. 2. Nothing was loaded until you clicked, so the first open waited on a cold download of Calendly's script and then its booking page. ## The fix - Make the script loader wait for the script to **actually finish loading**, and have overlapping loads share the same wait. This fixes the blank-first-open (and helps every other lazy-loaded script too). - **Warm up Calendly early**: open the connection and start fetching its script as soon as the "Schedule a call" button appears, so the modal opens quickly instead of downloading everything on click. - If Calendly still can't load (e.g. blocked by an extension), show the existing "open in a new tab" link instead of an empty modal. ## Testing Added a unit test proving the loader only reports "ready" after the script truly loads. Type-check, lint, and formatting all pass. Note: I couldn't click through the live modal here (needs a linked procurement deal running locally) — happy to do a manual open/close/open pass before merge if you'd like. --------- Co-authored-by: James Brunton <jbrunton96@gmail.com>
Frontend
All frontend commands are run from the repository root using Task:
task frontend:dev— start Vite dev server (localhost:5173)task frontend:build— production buildtask frontend:test— run teststask frontend:test:watch— run tests in watch modetask frontend:lint— run ESLint + cycle detectiontask frontend:typecheck— run TypeScript type checkingtask frontend:check— run typecheck + lint + testtask frontend:install— install npm dependencies
For desktop app development, see the Tauri section below.
Layout
frontend/ is a workspace containing one or more apps. Today it holds the
PDF editor under frontend/editor/; new apps (the developer portal, etc.)
will sit alongside it as siblings. Shared tooling — package.json, node_modules,
.storybook/, ESLint, Prettier — lives at frontend/ so every app installs
once and lints with the same config.
Environment Variables
The editor's environment variables live in committed .env files at
frontend/editor/:
.env— used by all builds (core, proprietary, and as the base for desktop/SaaS).env.desktop— additional vars loaded in desktop (Tauri) mode.env.saas— additional vars loaded in SaaS mode
These files contain non-secret defaults and are checked into Git, so most dev work needs no further setup.
To override values locally (API keys, machine-specific settings), create an uncommitted sibling editor/.env.local / editor/.env.desktop.local / editor/.env.saas.local. Vite automatically layers these on top of the committed files.
Docker Setup
For Docker deployments and configuration, see the Docker README.
Tauri
All desktop tasks are available via Task. From the root of the repo:
Dev
task desktop:dev
This ensures the JLink runtime and backend JAR exist (skipping if already built), then starts Tauri in dev mode.
Build
task desktop:build
This does a full clean rebuild of the backend JAR and JLink runtime, then builds the Tauri app for production.
Platform-specific dev builds are also available:
task desktop:build:dev # No bundling
task desktop:build:dev:mac # macOS .app bundle
task desktop:build:dev:windows # Windows NSIS installer
task desktop:build:dev:linux # Linux AppImage
JLink Tasks
You can also run JLink steps individually:
task desktop:jlink # Build JAR + create JLink runtime
task desktop:jlink:jar # Build backend JAR only
task desktop:jlink:runtime # Create JLink custom JRE only
task desktop:jlink:clean # Remove JLink artifacts
Clean
task desktop:clean
Removes all desktop build artifacts including JLink runtime, bundled JARs, Cargo build, and dist/build directories.