perf(ready): stop sending read state twice per session (#2223)

packages/schema/src/domains/channel/ChannelRequestSchemas.ts

@@ -249,9 +249,6 @@ export type ReadStateAckRequest = z.infer<typeof ReadStateAckRequest>;
 
 export const ReadStateAckResponse = z.object({
 	read_states: z.array(ReadStateResponse).describe('Authoritative read states after applying the acknowledgement'),
-	read_state_proto: z
-		.string()
-		.describe('Authoritative read states after applying the acknowledgement, encoded as a base64 protobuf bundle'),
 });
 
 export type ReadStateAckResponse = z.infer<typeof ReadStateAckResponse>;

packages/schema/src/domains/read_state/ReadStateProtoCodec.ts

@@ -13,14 +13,6 @@ interface ReadStateProtoEntryInput {
 	version?: string | null;
 }
 
-interface ReadStateProtoNativeEntryInput {
-	channelId: bigint | string;
-	mentionCount?: number | null;
-	lastMessageId?: bigint | string | null;
-	lastPinTimestamp?: Date | string | null;
-	version?: bigint | string | null;
-}
-
 interface ReadStateProtoEntry {
 	id: string;
 	mention_count: number;
@@ -34,24 +26,12 @@ const MAX_UINT32 = 0xffffffff;
 const MAX_UINT64 = 0xffffffffffffffffn;
 
 export function encodeReadStateProto(readStates: ReadonlyArray<ReadStateProtoEntryInput>): string {
-	return encodeReadStateProtoNative(
-		readStates.map((readState) => ({
-			channelId: readState.id,
-			lastMessageId: readState.last_message_id,
-			mentionCount: readState.mention_count,
-			lastPinTimestamp: readState.last_pin_timestamp,
-			version: readState.version,
-		})),
-	);
-}
-
-export function encodeReadStateProtoNative(readStates: ReadonlyArray<ReadStateProtoNativeEntryInput>): string {
 	const bundle = create(ReadStateBundleSchema, {
 		readStates: readStates.map((readState) => ({
-			channelId: parseUint64(readState.channelId, 'id'),
-			lastMessageId: optionalUint64(readState.lastMessageId, 'last_message_id'),
-			mentionCount: normalizeMentionCount(readState.mentionCount),
-			lastPinTimestamp: optionalTimestamp(readState.lastPinTimestamp),
+			channelId: parseUint64(readState.id, 'id'),
+			lastMessageId: optionalUint64(readState.last_message_id, 'last_message_id'),
+			mentionCount: normalizeMentionCount(readState.mention_count),
+			lastPinTimestamp: optionalTimestamp(readState.last_pin_timestamp),
 			version: optionalUint64(readState.version, 'version'),
 		})),
 	});
@@ -101,13 +81,13 @@ class ReadStateProtoEncodeError extends Error {
 	}
 }
 
-function optionalUint64(value: bigint | string | null | undefined, field: string): bigint | undefined {
+function optionalUint64(value: string | null | undefined, field: string): bigint | undefined {
 	return value == null ? undefined : parseUint64(value, field);
 }
 
-function parseUint64(value: bigint | string, field: string): bigint {
+function parseUint64(value: string, field: string): bigint {
 	try {
-		const parsed = typeof value === 'bigint' ? value : BigInt(value);
+		const parsed = BigInt(value);
 		if (parsed < 0n || parsed > MAX_UINT64) {
 			throw new Error('out of uint64 range');
 		}
@@ -119,9 +99,9 @@ function parseUint64(value: bigint | string, field: string): bigint {
 	}
 }
 
-function optionalTimestamp(value: Date | string | null | undefined) {
+function optionalTimestamp(value: string | null | undefined) {
 	if (value == null) return undefined;
-	const date = value instanceof Date ? value : new Date(value);
+	const date = new Date(value);
 	if (Number.isNaN(date.getTime())) {
 		throw new ReadStateProtoEncodeError('last_pin_timestamp: invalid timestamp');
 	}

packages/schema/src/domains/rpc/RpcSchemas.ts

@@ -288,7 +288,6 @@ export const RpcResponseSessionData = z.object({
 	user_guild_settings: z.array(UserGuildSettingsResponse).describe('Per-guild settings for the user'),
 	notes: z.record(SnowflakeStringType, z.string()).describe('User notes keyed by user ID'),
 	read_states: z.array(ReadStateResponse).describe('Read state for each channel'),
-	read_state_proto: z.string().describe('Read state for each channel, encoded as a base64 protobuf bundle'),
 	private_channels: z.array(ChannelResponse).describe('List of DM and group DM channels'),
 	relationships: z.array(RelationshipResponse).describe('User relationships (friends, blocked, etc.)'),
 	favorite_memes: z.array(FavoriteMemeResponse).describe('List of user favorite memes'),