From e7f68c2e2088e3aea0c8f7c8458e023d14ba5195 Mon Sep 17 00:00:00 2001 From: Hampus Date: Sun, 30 Aug 2026 23:25:47 +0200 Subject: [PATCH] test(message): count permission fetches instead of view checks (#2193) --- .../channel/tests/MessageSendPermissions.test.ts | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/fluxer_api/src/api/channel/tests/MessageSendPermissions.test.ts b/fluxer_api/src/api/channel/tests/MessageSendPermissions.test.ts index 05998a4a5..04bcf97c5 100644 --- a/fluxer_api/src/api/channel/tests/MessageSendPermissions.test.ts +++ b/fluxer_api/src/api/channel/tests/MessageSendPermissions.test.ts @@ -106,9 +106,7 @@ describe('Message send permissions', () => { const gatewayService = getGatewayService(); const getGuildData = vi.spyOn(gatewayService, 'getGuildData'); const getGuildMember = vi.spyOn(gatewayService, 'getGuildMember'); - const checkPermission = vi.spyOn(gatewayService, 'checkPermission'); - const countViewChannelChecks = () => - checkPermission.mock.calls.filter((call) => call[0].permission === Permissions.VIEW_CHANNEL).length; + const getUserPermissions = vi.spyOn(gatewayService, 'getUserPermissions'); try { const sentMessage = await createBuilder(harness, member.token) @@ -118,11 +116,11 @@ describe('Message send permissions', () => { const sendCounts = { guildData: getGuildData.mock.calls.length, guildMember: getGuildMember.mock.calls.length, - viewChannel: countViewChannelChecks(), + userPermissions: getUserPermissions.mock.calls.length, }; getGuildData.mockClear(); getGuildMember.mockClear(); - checkPermission.mockClear(); + getUserPermissions.mockClear(); await createBuilder(harness, member.token) .patch(`/channels/${systemChannel.id}/messages/${sentMessage.id}`) .body({content: 'authenticate me once again'}) @@ -130,15 +128,15 @@ describe('Message send permissions', () => { const editCounts = { guildData: getGuildData.mock.calls.length, guildMember: getGuildMember.mock.calls.length, - viewChannel: countViewChannelChecks(), + userPermissions: getUserPermissions.mock.calls.length, }; - expect(sendCounts).toEqual({guildData: 1, guildMember: 1, viewChannel: 1}); - expect(editCounts).toEqual({guildData: 1, guildMember: 1, viewChannel: 1}); + expect(sendCounts).toEqual({guildData: 1, guildMember: 1, userPermissions: 1}); + expect(editCounts).toEqual({guildData: 1, guildMember: 1, userPermissions: 1}); } finally { getGuildData.mockRestore(); getGuildMember.mockRestore(); - checkPermission.mockRestore(); + getUserPermissions.mockRestore(); } });