From 1d950fa24d21a32cf79b5faed6788ef5d8bdb583 Mon Sep 17 00:00:00 2001 From: Shadowghost Date: Thu, 3 Sep 2020 18:13:14 +0000 Subject: [PATCH] fix(devcontainer): move to suggested extensions, switch default shell to zsh --- .devcontainer/Dockerfile | 4 +-- .devcontainer/devcontainer.json | 60 ++++++++++++++------------------- 2 files changed, 28 insertions(+), 36 deletions(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index d38f1030..43047a6e 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -14,5 +14,5 @@ FROM mcr.microsoft.com/vscode/devcontainers/typescript-node:0-${VARIANT} # RUN sudo -u node npm install -g # [Optional] Persist bash history -RUN SNIPPET="export PROMPT_COMMAND='history -a' && export HISTFILE=/commandhistory/.bash_history" \ - && echo $SNIPPET >> "/root/.bashrc" \ No newline at end of file +RUN SNIPPET="export PROMPT_COMMAND='history -a' && export HISTFILE=/commandhistory/.zsh_history" \ + && echo $SNIPPET >> "/root/.zshrc" \ No newline at end of file diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 570b0a46..05ae9952 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,37 +1,29 @@ // For format details, see https://aka.ms/vscode-remote/devcontainer.json or this file's README at: // https://github.com/microsoft/vscode-dev-containers/tree/v0.134.1/containers/typescript-node { - "name": "Node.js & TypeScript", - "build": { - "dockerfile": "Dockerfile", - // Update 'VARIANT' to pick a Node version: 10, 12, 14 - "args": { - "VARIANT": "12" - } - }, - // Set *default* container specific settings.json values on container create. - "settings": { - "terminal.integrated.shell.linux": "/bin/bash" - }, - // Add the IDs of extensions you want installed when the container is created. - "extensions": [ - "dbaeumer.vscode-eslint", - "ms-vscode.vscode-typescript-tslint-plugin", - "jcbuisson.vue", - "sdras.vue-vscode-snippets", - "dariofuzinato.vue-peek", - "peakchen90.vue-beautify", - "gamunu.vscode-yarn" - ], - // Use 'forwardPorts' to make a list of ports inside the container available locally. - "forwardPorts": [ - 3000 - ], - // Use 'postCreateCommand' to run commands after the container is created. - "postCreateCommand": "yarn install", - // Uncomment to connect as a non-root user. See https://aka.ms/vscode-remote/containers/non-root. - // "remoteUser": "node" - "mounts": [ - "source=jellyfin-vue-history,target=/commandhistory,type=volume" - ] -} \ No newline at end of file + "name": "Node.js & TypeScript", + "build": { + "dockerfile": "Dockerfile", + // Update 'VARIANT' to pick a Node version: 10, 12, 14 + "args": { + "VARIANT": "12" + } + }, + // Set *default* container specific settings.json values on container create. + "settings": { + "terminal.integrated.shell.linux": "/usr/bin/zsh" + }, + // Add the IDs of extensions you want installed when the container is created. + "extensions": [ + "dbaeumer.vscode-eslint", + "octref.vetur", + "esbenp.prettier-vscode" + ], + // Use 'forwardPorts' to make a list of ports inside the container available locally. + "forwardPorts": [3000], + // Use 'postCreateCommand' to run commands after the container is created. + "postCreateCommand": "yarn install", + // Uncomment to connect as a non-root user. See https://aka.ms/vscode-remote/containers/non-root. + // "remoteUser": "node" + "mounts": ["source=jellyfin-vue-history,target=/commandhistory,type=volume"] +}