Files
OwnCord/Server/api/dm_handler.go
T

487 lines
18 KiB
Go
Raw Normal View History

package api
import (
2026-08-01 22:06:14 +02:00
"context"
"encoding/json"
"fmt"
"log/slog"
"net/http"
"github.com/J3vb/OwnCord/Server/db"
"github.com/J3vb/OwnCord/Server/service"
"github.com/J3vb/OwnCord/Server/ws"
"github.com/go-chi/chi/v5"
)
// DMBroadcaster is the interface needed to send WebSocket events from REST
// handlers. Satisfied by *ws.Hub.
type DMBroadcaster interface {
SendToUser(userID int64, msg []byte) bool
}
// dmVisibilityMarker is an optional DMBroadcaster capability: bump the hub's
// visibility watermark after an unsequenced, targeted event so a client that
// warm-reconnects across the gap takes the full-ready path instead of a
// sequenced-only replay that can never redeliver it. Reached by type
// assertion rather than being added to DMBroadcaster directly so the
// SendToUser-only test doubles in this package keep working. Satisfied in
// production by ws.Hub.MarkVisibilityChanged, which forwards to the same
// bumpVisibilityWatermark the WS-side dm_channel_open emitter uses
// (ws/emit.go).
type dmVisibilityMarker interface {
MarkVisibilityChanged()
}
// The production broadcaster must keep satisfying it: a type assertion that
// silently stops matching would turn the watermark bump back into the no-op
// this fixed, with nothing failing to say so — mirrors the dmVoiceEvictor
// assertion below for its sibling capability.
var _ dmVisibilityMarker = (*ws.Hub)(nil)
// markDMVisibilityChanged bumps the visibility watermark if broadcaster
// supports it. dm_channel_open/close are unsequenced and targeted, so a
// client that misses one via a dropped connection and then warm-reconnects
// never gets it redelivered by the ordinary seq-replay path — mirroring why
// the WS emitter of the same event (ws/emit.go DMChannelOpenEvent) forces
// this bump unconditionally, regardless of whether the send itself
// succeeded.
func markDMVisibilityChanged(broadcaster DMBroadcaster) {
if vm, ok := broadcaster.(dmVisibilityMarker); ok {
vm.MarkVisibilityChanged()
}
}
// dmVoiceEvictor is the DMBroadcaster capability used to evict a user's
// voice-call connection for one specific channel, leaving an unrelated call
// they may currently be in untouched (which the unconditional
// DisconnectFromVoice would not). It is kept out of DMBroadcaster itself and
// reached by type assertion so the handler stays usable with the
// SendToUser-only test doubles the package already has.
type dmVoiceEvictor interface {
DisconnectFromVoiceInChannel(ctx context.Context, userID, channelID int64) bool
}
// The production broadcaster must keep satisfying it: a type assertion that
// silently stops matching would turn the eviction back into the no-op this
// fixed, with nothing failing to say so.
var _ dmVoiceEvictor = (*ws.Hub)(nil)
// MountDMRoutes registers DM-related routes onto r.
// All routes require authentication.
// hub is used to send real-time WebSocket events on DM close.
func MountDMRoutes(r chi.Router, database *db.DB, svc *service.Services, broadcaster DMBroadcaster) {
r.Route("/api/v1/dms", func(r chi.Router) {
r.Use(AuthMiddleware(database))
r.Post("/", handleCreateDM(svc, broadcaster))
2026-08-01 22:06:14 +02:00
r.Post("/group", handleCreateGroupDM(svc, broadcaster))
r.Get("/", handleListDMs(svc))
2026-08-01 22:06:14 +02:00
r.Patch("/{channelId}", handleRenameGroupDM(svc, broadcaster))
r.Delete("/{channelId}", handleCloseDM(svc, broadcaster))
})
// User blocking routes — prevent DM creation and messaging.
r.Route("/api/v1/blocks", func(r chi.Router) {
r.Use(AuthMiddleware(database))
r.Get("/", handleListBlocks(svc))
r.Put("/{userId}", handleBlockUser(svc, broadcaster))
r.Delete("/{userId}", handleUnblockUser(svc))
})
}
// createDMRequest is the JSON body for POST /api/v1/dms.
type createDMRequest struct {
RecipientID int64 `json:"recipient_id"`
}
// createDMResponse is the JSON response for POST /api/v1/dms.
type createDMResponse struct {
ChannelID int64 `json:"channel_id"`
Recipient db.DMUser `json:"recipient"`
Created bool `json:"created"`
}
2026-08-01 22:06:14 +02:00
// createGroupDMRequest is the JSON body for POST /api/v1/dms/group.
type createGroupDMRequest struct {
RecipientIDs []int64 `json:"recipient_ids"`
Name string `json:"name"`
}
// renameDMRequest is the JSON body for PATCH /api/v1/dms/{channelId}.
type renameDMRequest struct {
Name string `json:"name"`
}
// listDMsResponse is the JSON response for GET /api/v1/dms.
type listDMsResponse struct {
DMChannels []db.DMChannelInfo `json:"dm_channels"`
}
// handleCreateDM creates or retrieves a DM channel with a recipient.
func handleCreateDM(svc *service.Services, broadcaster DMBroadcaster) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
user, ok := r.Context().Value(UserKey).(*db.User)
if !ok || user == nil {
writeJSON(w, http.StatusUnauthorized, errorResponse{
Error: "UNAUTHORIZED", Message: "authentication required",
})
return
}
var req createDMRequest
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
writeJSON(w, http.StatusBadRequest, errorResponse{
Error: "BAD_REQUEST", Message: "invalid request body",
})
return
}
result, err := svc.DMs.CreateDM(r.Context(), user.ID, req.RecipientID)
if err != nil {
writeServiceError(r.Context(), w, err)
return
}
// A brand-new 1:1 DM has dm_open_state pre-seeded for BOTH users by
// GetOrCreateDMChannel (db/dm_queries.go), so the recipient's first
// OpenDM call — fired later from the sender's first message — finds
// the row already present and reports opened=false. Without this,
// nothing ever tells the recipient the DM exists: no live event, and
// no visibility-watermark bump for a warm reconnect either. Only the
// creation path needs this — CreateDM re-opening an existing DM for
// the caller only touches the caller's own dm_open_state row, which
// the caller obviously already knows about.
if result.Created {
broadcastDMOpen(r.Context(), svc, broadcaster, result.Channel.ID, []int64{result.Recipient.ID})
}
avatarStr := ""
if result.Recipient.Avatar != nil {
avatarStr = *result.Recipient.Avatar
}
2026-08-01 22:06:14 +02:00
displayName := ""
if result.Recipient.DisplayName != nil {
displayName = *result.Recipient.DisplayName
}
// PresentableStatus applies the "no live connection is offline,
// whatever the row says" half of the rule ws/serve_ready.go's
// presentableMembers documents — StatusForViewer alone only
// collapses invisible to offline and would otherwise ship a
// disconnected recipient's saved idle/dnd verbatim (OC-0304).
dmUser := db.DMUser{
2026-08-01 22:06:14 +02:00
ID: result.Recipient.ID,
Username: result.Recipient.Username,
Avatar: avatarStr,
Status: svc.DMs.PresentableStatus(result.Recipient.ID, db.StatusForViewer(result.Recipient.Status, result.Recipient.ID, user.ID)),
2026-08-01 22:06:14 +02:00
DisplayName: displayName,
}
status := http.StatusOK
if result.Created {
status = http.StatusCreated
}
writeJSON(w, status, createDMResponse{
ChannelID: result.Channel.ID,
Recipient: dmUser,
Created: result.Created,
})
}
}
// handleListDMs returns all open DM channels for the authenticated user.
func handleListDMs(svc *service.Services) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
user, ok := r.Context().Value(UserKey).(*db.User)
if !ok || user == nil {
writeJSON(w, http.StatusUnauthorized, errorResponse{
Error: "UNAUTHORIZED", Message: "authentication required",
})
return
}
channels, err := svc.DMs.ListDMs(r.Context(), user.ID)
if err != nil {
writeServiceError(r.Context(), w, err)
return
}
writeJSON(w, http.StatusOK, listDMsResponse{DMChannels: channels})
}
}
// handleCloseDM removes a DM channel from the authenticated user's open list.
func handleCloseDM(svc *service.Services, broadcaster DMBroadcaster) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
user, ok := r.Context().Value(UserKey).(*db.User)
if !ok || user == nil {
writeJSON(w, http.StatusUnauthorized, errorResponse{
Error: "UNAUTHORIZED", Message: "authentication required",
})
return
}
channelID, ok := parseIDParam(w, r, "channelId")
if !ok {
return
}
2026-08-01 22:06:14 +02:00
result, err := svc.DMs.CloseDM(r.Context(), user.ID, channelID)
if err != nil {
writeServiceError(r.Context(), w, err)
return
}
// Notify via WebSocket so sidebar updates immediately.
if broadcaster != nil {
closeMsg := fmt.Appendf(nil, `{"type":%q,"payload":{"channel_id":%d}}`, ws.MsgTypeDMChannelClose, channelID)
if ok := broadcaster.SendToUser(user.ID, closeMsg); !ok {
slog.Debug("handleCloseDM: user not connected", "user_id", user.ID, "channel_id", channelID)
}
// dm_channel_close is unsequenced and targeted like
// dm_channel_open — see markDMVisibilityChanged.
markDMVisibilityChanged(broadcaster)
2026-08-01 22:06:14 +02:00
// A group leave changes the membership everyone else renders, so
// the survivors get a refreshed dm_channel_open rather than being
// left showing a member who has gone.
if result.Left && !result.ChannelDeleted {
broadcastDMOpen(r.Context(), svc, broadcaster, channelID, result.RemainingParticipantIDs)
}
// Leaving a group DM removes the caller from its membership but,
// without this, leaves them connected to its live voice call —
// they keep hearing and speaking to a room they are no longer a
// member of. Scoped to this channel so a leaver currently on an
// unrelated voice call is untouched. This also covers the
// last-participant case (ChannelDeleted): the row is already gone
// by now, so CleanupVoiceForChannel would read an FK-cascaded
// empty voice_states and do nothing, while the leaver — the only
// participant left — is evicted here.
if result.Left {
if ve, ok := broadcaster.(dmVoiceEvictor); ok {
ve.DisconnectFromVoiceInChannel(context.WithoutCancel(r.Context()), user.ID, channelID)
}
}
}
w.WriteHeader(http.StatusNoContent)
}
}
2026-08-01 22:06:14 +02:00
// broadcastDMOpen sends a per-viewer dm_channel_open for channelID to each of
// targetIDs. The payload differs per addressee (`recipient`/`recipients` are
// relative to who is reading), so it is rebuilt inside the loop.
//
// Failures are logged and skipped, never surfaced: the mutation that prompted
// this has already committed, and a client that misses the event re-derives
// the same state from its next `ready`.
func broadcastDMOpen(ctx context.Context, svc *service.Services, broadcaster DMBroadcaster, channelID int64, targetIDs []int64) {
if broadcaster == nil || len(targetIDs) == 0 {
return
}
// The mutation that led here has already committed, so this fan-out must
// survive the caller's request context being cancelled after that point
// (client disconnect mid-handler) — otherwise every DMSummaryFor lookup
// below fails with context.Canceled and no participant, including ones
// otherwise unaffected by the cancellation, ever receives the open.
ctx = context.WithoutCancel(ctx)
// dm_channel_open is unsequenced and targeted — a recipient who is
// offline or drops the connection right now can never have it replayed
// to them by the ordinary seq-based resume path, so a warm reconnect must
// be forced onto the full-ready path instead. Bumped once per call,
// unconditionally (not per-recipient SendToUser result): the ws emitter
// of this same event does the same (ws/emit.go), and this covers every
// caller — group create, rename refresh, and the group-leave refresh.
markDMVisibilityChanged(broadcaster)
2026-08-01 22:06:14 +02:00
for _, pid := range targetIDs {
summary, pErr := svc.DMs.DMSummaryFor(ctx, pid, channelID)
if pErr != nil {
slog.Debug("broadcastDMOpen: summary unavailable", "user_id", pid, "channel_id", channelID, "err", pErr)
continue
}
msg, mErr := json.Marshal(map[string]any{
"type": "dm_channel_open",
"payload": summary,
})
if mErr != nil {
slog.Warn("broadcastDMOpen: marshal failed", "err", mErr, "channel_id", channelID)
continue
}
if ok := broadcaster.SendToUser(pid, msg); !ok {
slog.Debug("broadcastDMOpen: user not connected", "user_id", pid, "channel_id", channelID)
}
}
}
// handleCreateGroupDM creates a group DM between the caller and 2..8 others.
func handleCreateGroupDM(svc *service.Services, broadcaster DMBroadcaster) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
user, ok := r.Context().Value(UserKey).(*db.User)
if !ok || user == nil {
writeJSON(w, http.StatusUnauthorized, errorResponse{
Error: "UNAUTHORIZED", Message: "authentication required",
})
return
}
var req createGroupDMRequest
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
writeJSON(w, http.StatusBadRequest, errorResponse{
Error: "BAD_REQUEST", Message: "invalid request body",
})
return
}
result, err := svc.DMs.CreateGroupDM(r.Context(), user.ID, req.RecipientIDs, req.Name)
if err != nil {
writeServiceError(r.Context(), w, err)
return
}
// Everyone gets the DM in their sidebar immediately, the creator
// included — the REST response is only the creator's copy, and a
// second window of theirs needs the event just as much as the others.
broadcastDMOpen(r.Context(), svc, broadcaster, result.Channel.ID, result.ParticipantIDs)
writeJSON(w, http.StatusCreated,
db.NewDMChannelInfo(result.Channel.ID, result.Channel.Name, true, result.Participants, user.ID))
}
}
// handleRenameGroupDM sets or clears a group DM's name. Participants only —
// there is no owner, so every member holds the same authority over it.
func handleRenameGroupDM(svc *service.Services, broadcaster DMBroadcaster) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
user, ok := r.Context().Value(UserKey).(*db.User)
if !ok || user == nil {
writeJSON(w, http.StatusUnauthorized, errorResponse{
Error: "UNAUTHORIZED", Message: "authentication required",
})
return
}
channelID, ok := parseIDParam(w, r, "channelId")
if !ok {
return
}
var req renameDMRequest
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
writeJSON(w, http.StatusBadRequest, errorResponse{
Error: "BAD_REQUEST", Message: "invalid request body",
})
return
}
if _, err := svc.DMs.RenameGroupDM(r.Context(), user.ID, channelID, req.Name); err != nil {
writeServiceError(r.Context(), w, err)
return
}
// The rename has already committed at this point, so this lookup must
// survive the caller's request context being cancelled right after
// that commit (client disconnect mid-handler) — same reasoning as
// broadcastDMOpen's own context.WithoutCancel, and the failure must be
// logged rather than silently dropping the fan-out (participants would
// keep rendering the stale name with no compensating resync, since
// dm_channel_open is unsequenced/targeted and can't be replayed).
bgCtx := context.WithoutCancel(r.Context())
participantIDs, pErr := svc.Channels.GetDMParticipantIDs(bgCtx, channelID)
if pErr != nil {
slog.Error("handleRenameGroupDM: participant lookup failed", "err", pErr, "channel_id", channelID)
} else {
broadcastDMOpen(bgCtx, svc, broadcaster, channelID, participantIDs)
2026-08-01 22:06:14 +02:00
}
summary, sErr := svc.DMs.DMSummaryFor(r.Context(), user.ID, channelID)
if sErr != nil {
writeServiceError(r.Context(), w, sErr)
return
}
writeJSON(w, http.StatusOK, summary)
}
}
// handleBlockUser blocks a user.
func handleBlockUser(svc *service.Services, broadcaster DMBroadcaster) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
user, _ := r.Context().Value(UserKey).(*db.User)
if user == nil {
writeJSON(w, http.StatusUnauthorized, errorResponse{Error: "UNAUTHORIZED", Message: "authentication required"})
return
}
targetID, ok := parseIDParam(w, r, "userId")
if !ok {
return
}
if err := svc.Blocks.BlockUser(r.Context(), user.ID, targetID); err != nil {
writeServiceError(r.Context(), w, err)
return
}
// The block has already committed at this point, so the rest of this
// handler must survive the caller's request context being cancelled
// right after that commit (client disconnect mid-handler) — same
// reasoning as handleRenameGroupDM's own bgCtx. Without this, a
// canceled request context makes the shared-DM lookup below fail and
// get skipped, silently defeating the eviction it gates.
bgCtx := context.WithoutCancel(r.Context())
// Revocation must evict a live session, not merely block the next
// join (the same invariant the voice sweep states): without this, a
// blocked user already in the pair's 1:1 DM voice call stays in it
// indefinitely — the block gate otherwise runs only on voice_join and
// voluntary voice_token_refresh, both of which the blocked client
// controls. Group DM calls are deliberately untouched, matching
// requireDMNotBlocked's group exemption.
if ve, evictable := broadcaster.(dmVoiceEvictor); evictable {
if chID, exists, err := svc.DMs.SharedOneToOneDM(bgCtx, user.ID, targetID); err != nil {
slog.Warn("block: shared-DM lookup for voice eviction failed",
"blocker_id", user.ID, "target_id", targetID, "err", err)
} else if exists {
ve.DisconnectFromVoiceInChannel(bgCtx, targetID, chID)
}
}
writeJSON(w, http.StatusOK, map[string]string{"message": "user blocked"})
}
}
// handleUnblockUser unblocks a user.
func handleUnblockUser(svc *service.Services) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
user, _ := r.Context().Value(UserKey).(*db.User)
if user == nil {
writeJSON(w, http.StatusUnauthorized, errorResponse{Error: "UNAUTHORIZED", Message: "authentication required"})
return
}
targetID, ok := parseIDParam(w, r, "userId")
if !ok {
return
}
if err := svc.Blocks.UnblockUser(r.Context(), user.ID, targetID); err != nil {
writeServiceError(r.Context(), w, err)
return
}
writeJSON(w, http.StatusOK, map[string]string{"message": "user unblocked"})
}
}
// handleListBlocks returns all blocked user IDs.
func handleListBlocks(svc *service.Services) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
user, _ := r.Context().Value(UserKey).(*db.User)
if user == nil {
writeJSON(w, http.StatusUnauthorized, errorResponse{Error: "UNAUTHORIZED", Message: "authentication required"})
return
}
ids, err := svc.Blocks.ListBlocked(r.Context(), user.ID)
if err != nil {
writeServiceError(r.Context(), w, err)
return
}
writeJSON(w, http.StatusOK, map[string]any{"blocked_user_ids": ids})
}
}