J3vb/OwnCord
1
0
Fork 0
mirror of https://github.com/J3vb/OwnCord.git synced 2026-09-03 03:50:00 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: video grid auto-opens only for local camera/screenshare (BUG-105)

Browse Source 
Refine auto-open to match Discord behavior: grid opens automatically
when the local user enables camera or screenshare, but NOT when remote
users do. Remote video requires clicking the user row to open.
This commit is contained in:
J3vb
2026-04-02 13:42:00 +02:00
parent 1622e04cee
commit e9543ce6d6
2 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Client/tauri-client/src/pages/main-page/VideoModeController.ts
+4 -2
View File
@@ -107,8 +107,10 @@ export function createVideoModeController(opts: VideoModeControllerOptions): Vid
if (!anyVideoOn && videoMode) {
showChat();
}
// BUG-105: Auto-open video grid when any video stream becomes active.
if (anyVideoOn && !videoMode) {
// BUG-105: Auto-open video grid only for LOCAL camera/screenshare.
// Remote streams require manual click (Discord-style behavior).
const localVideoOn = voice.localCamera || voice.localScreenshare;
if (localVideoOn && !videoMode) {
showVideoGrid();
}
Client/tauri-client/tests/unit/video-mode-controller.test.ts
+6 -4
View File
@@ -104,7 +104,7 @@ describe("createVideoModeController", () => {
expect(ctrl.isVideoMode()).toBe(false);
});
it("checkVideoMode auto-opens video grid when remote has camera (BUG-105)", () => {
it("checkVideoMode does NOT auto-open for remote camera (BUG-105)", () => {
const users = new Map([[2, { userId: 2, camera: true, screenshare: false, username: "bob" }]]);
mockVoiceStoreGetState.mockReturnValue(
makeVoiceState({ currentChannelId: 10, voiceUsers: new Map([[10, users]]) }),
@@ -118,7 +118,8 @@ describe("createVideoModeController", () => {
});
ctrl.checkVideoMode();
expect(ctrl.isVideoMode()).toBe(true);
// Remote streams require manual click — no auto-open
expect(ctrl.isVideoMode()).toBe(false);
});
it("checkVideoMode auto-closes video grid when no streams remain", () => {
@@ -359,7 +360,7 @@ describe("createVideoModeController", () => {
expect(vg.removeStream).toHaveBeenCalledWith(1_000_001);
});
it("checkVideoMode auto-opens when remote has screenshare on (BUG-105)", () => {
it("checkVideoMode does NOT auto-open for remote screenshare (BUG-105)", () => {
const users = new Map([
[1, { userId: 1, camera: false, screenshare: false, username: "me" }],
[2, { userId: 2, camera: false, screenshare: true, username: "bob" }],
@@ -375,7 +376,8 @@ describe("createVideoModeController", () => {
});
ctrl.checkVideoMode();
expect(ctrl.isVideoMode()).toBe(true);
// Remote streams require manual click — no auto-open
expect(ctrl.isVideoMode()).toBe(false);
});
// -----------------------------------------------------------------------