mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
* docs: record the desktop/browser platform contract map (B1-8, RL-02/L-02) Client/src/platform/ does not exist — no commits, no files, zero importers. RL-02 asked for the boundary to be *recorded* in B1 so that B7 executes a decided plan rather than rediscovering the surface. This is that record, and nothing more: no directory, no interface, no code. Measured against dev @eb873fe7, not estimated: 20 files under Client/src/ import @tauri-apps, using 26 distinct invoke command names against 30 #[tauri::command] handlers, with zero dangling calls and zero uses of the window.__TAURI__ global. Every native dependency is an import, so a static check can find all of them — which is what BPR-025 will eventually enforce. The count is 26 and not 22 because Client/src/lib/ws.ts binds core.invoke to a local tauriInvoke before calling it; a regex matching only invoke("…") misses ws_connect, ws_send, ws_disconnect and accept_cert_fingerprint. Any future lint rule enforcing the seam has to match the binding, not the call site. The 20 files collapse into 13 capability clusters, three of which have no browser equivalent and are flagged as product decisions rather than shims: certificate TOFU in ws.ts, the OS keychain behind credentials.ts/identity.ts, and out-of-focus push-to-talk in ptt.ts. Ownership is recorded by phase (B7/B8/B2). No human owners exist for these folders anywhere in the repository; the document says so rather than leaving the absence to read as an oversight. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs: perform the HP-1 structural review and measure the B1 exit gate HP-1 asks whether B1's migrations were mechanical. It had never been run, and it cannot be run against dev: dev is squash-merge only, so #1411 landed as one commit and the pure-move/path-rewrite separation the hold point exists to review survives only on refs/pull/1411/head. The scorecard records the pre-squash SHAs so the review is reproducible. Four proofs, all passing: - Pure move (4befe699): 473 renames, all R100, zero non-rename entries, zero line changes, and every renamed blob byte-identical. The blob-OID comparison is what actually covers the six binaries — --numstat prints "-" for them, so the obvious line-count filter reports false positives. - Path rewrite (38ddca73): 983 added / 983 removed, and after normalising the substitution, six unpaired pairs remain — all relative-path depth arithmetic from losing one directory level. Each was resolved against HEAD. The release signer is among them and runs only on a tag, so no CI run on any branch executes it; it is correct (working-directory: Client, artifacts at the root) and guarded by a downstream verify step that fails closed. - Go module rename (7a4e5dc3): 350 files, 728/728, zero unpaired lines. The largest change in B1 is provably a pure substitution. - Active path inventory: 11 files still name tauri-client, all historical — ledger lens labels, dated audits, and plans that describe the move. Zero in code, workflows, scripts, hooks or the Dockerfile. The seed move (93ee14d5) does change behaviour — init() deleted, os.MkdirAll moved into main(). That was authorised by the plan and is isolated in its own commit, which is what HP-1 asks for. Exit gate: seven of eight conditions evidenced. Condition 6 is recorded as PARTIALLY MET and is a real gap — dev has 11 required checks pinned but strict:false, so when dev advances after a PR goes green that PR can still merge without re-testing, and the squash commit that lands was never itself tested. Deliberately not changed here: flipping strict forces a rebase on every open PR whenever another lands, and enforce_admins is on. Owner's call. ENV-01 is closed. Every B0 number was measured on Node 26 while CI pins 24. The client suite now re-runs on Node 24 from a fresh clone in a node:24 container: 192 files, 5257 tests — identical to B0, and the clone doubles as the exit gate's Linux setup smoke. ENV-02 also reproduces at 50.1 MB booting on :8443. Corrects the plan's stale Docker command along the way: the script moved to Server/scripts/ and now takes the image as an argument, and the build context is Server/ rather than the repository root — building from the root streams the whole working tree and then fails on the missing go.mod. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs: record the applied repository settings in the HP-1 scorecard Both checked-in settings scripts were run on 2026-08-27 — they had landed in #1418 and #1419 but were deliberately never executed, because repo-settings writes need a person. b0-dev-branch-protection.sh pinned the twelfth required check on dev, "Docs & Ledger Consistency". Until that run the FINDINGS.md drift gate reported but could not block a merge. Condition 6 now reads 12 pinned checks; it stays PARTIALLY MET because strict is still false, which the script itself encodes as a deliberate choice. b1-release-tag-protection.sh created the "Release tags" ruleset (active, target tag, refs/tags/v*, blocks update and deletion, zero bypass actors) and the release environment with one required reviewer. Checked for a pre-existing ruleset of that name first — the POST half is not idempotent and a second run would have created a duplicate. Three rulesets existed, all targeting branches, none named "Release tags". Condition 7 closes: B1-7 merged, and the Discussions slugs its issue-template config hardcodes — q-a and ideas — both exist, so the contact links resolve rather than silently dropping the user on the category picker. Two things the read-back surfaced, both recorded as open, neither blocking: - The release environment has can_admins_bypass: true, GitHub's default. The ruleset has zero bypass actors, but the reviewer gate does not. Moot while the sole admin is also the sole reviewer. - claude.yml passes secrets.CLAUDE_CODE_OAUTH_TOKEN and the repository has no such secret. Nothing is failing, because all five issue_comment runs are skipped at the B1-7 guard before the missing secret would matter — but the paid-automation surface RL-22 hardens is inert today. environment: release is still absent from release.yml, deliberately. The environment now exists, so that is a separate two-line change. Gate re-run after rebasing ontoc0c87366so condition 8 is measured over the final tree, B1-7 included: green, 5257 client tests, exit 0. B1-7's check-workflow-guards.mjs runs locally; its sibling verify-gate-evidence.mjs does not — CI runs the selftest, and the assert form needs a token and a real SHA. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
49 lines
2.7 KiB
Markdown
49 lines
2.7 KiB
Markdown
# OwnCord Client (Tauri v2)
|
|
|
|
TypeScript frontend (Vite, vanilla TS — no React/Vue) plus a deliberately thin
|
|
Rust backend in `src-tauri/` for native APIs only. LiveKit handles voice/video.
|
|
|
|
## Layout
|
|
|
|
- `src/stores/` observable stores · `src/lib/` protocol, WS, voice, E2EE ·
|
|
`src/pages/`, `src/components/` UI
|
|
- `src/lib/protocolTypes.ts` and `src/generated/` are generated — see the root
|
|
CLAUDE.md
|
|
- `tests/unit`, `tests/integration`, `tests/contract` (vitest, jsdom) ·
|
|
`tests/e2e`, `tests/e2e/admin`, `tests/e2e/native` (Playwright) ·
|
|
`tests/browser` (vitest browser mode)
|
|
- A test whose assertions read, import or execute a **`Server/`-owned**
|
|
artifact belongs in `tests/contract`, not `tests/unit` — `src-tauri/` is
|
|
part of this component, so reading it is an ordinary unit test. The rule
|
|
is in [docs/contributing.md](../docs/contributing.md#testing)
|
|
- `src/platform/` does **not** exist yet. Where the desktop/browser seam will
|
|
go, and which 20 files hold the native imports that must move behind it, is
|
|
recorded in
|
|
[docs/architecture/platform-contracts.md](../docs/architecture/platform-contracts.md).
|
|
Building it is B7 — do not start it as a side effect of another change.
|
|
|
|
## Gotchas
|
|
|
|
- Node's native Web Storage (Node 22+) shadows jsdom's `localStorage`;
|
|
`tests/setup.ts` replaces it with an in-memory shim, so the suite runs on
|
|
modern Node without `--no-experimental-webstorage`. If storage tests fail
|
|
en masse, suspect that shim before your change. CI pins Node 24.
|
|
- `src/lib/dispatcher.ts` is the single WS-event entry point **into the
|
|
stores**: server events reach domain stores only through a `ws.on(...)`
|
|
subscription registered there. Other modules do register their own
|
|
`ws.on(...)` handlers for page-local UI (`main.ts`, `MainPage.ts`,
|
|
`ChannelController.ts` — ringing, overlays, slow-mode timers); that is fine
|
|
as long as they only _read_ store state. Writing a store from one of those
|
|
handlers is the violation, and `local/no-store-write-in-ws-on` now fails the
|
|
build on it.
|
|
- Voice sessions are superseded, not cancelled. `LiveKitSession` re-entry
|
|
points check whether a newer attempt owns the shared state before tearing
|
|
anything down, so cleanup in an aborted path must be scoped to that attempt's
|
|
own room — a global `leaveVoice()` there kills the live session.
|
|
- Voice E2EE is key-holder based with TOFU identity pinning. Anything touching
|
|
`livekitE2EE.ts` or `identity.ts` must preserve the epoch/keypair staleness
|
|
guards and must never report an unverified peer as verified.
|
|
- Do not run `npm run tauri build` locally; the desktop build is CI-only.
|
|
- Formatting is prettier-enforced; match the surrounding code rather than
|
|
reasoning about style.
|