mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
- Document single-instance requirement for in-memory rate stores (L2) - Add IsOwnerRole() helper for explicit owner guards (L4) - WS auth deadline uses request context, not context.Background (L5) - Double-check voice state before clearing in webhook handler (L8) - Upload stores measured write size instead of client header.Size (L11) - Startup warning when config upload size exceeds HTTP body limit (L12) - Update check endpoint now requires owner role (L13) - Backup paths resolved to absolute at init time (L14)
252 lines
6.6 KiB
Go
252 lines
6.6 KiB
Go
package auth
|
|
|
|
import (
|
|
"time"
|
|
|
|
"github.com/owncord/server/syncutil"
|
|
)
|
|
|
|
// entry records individual request timestamps for sliding-window limiting.
|
|
type entry struct {
|
|
timestamps []time.Time
|
|
}
|
|
|
|
// lockoutEntry records when a lockout expires.
|
|
type lockoutEntry struct {
|
|
expiresAt time.Time
|
|
}
|
|
|
|
// LockoutPersister is an optional persistence backend for lockout entries.
|
|
// When provided, lockouts survive server restarts. The interface uses only
|
|
// stdlib types to avoid circular dependencies between packages.
|
|
type LockoutPersister interface {
|
|
UpsertLockout(key string, expiresAt time.Time) error
|
|
DeleteLockout(key string) error
|
|
CleanupExpiredLockouts() error
|
|
// LoadActiveLockouts returns (keys, expiresAt) slices of equal length.
|
|
LoadActiveLockouts() (keys []string, expiresAt []time.Time, err error)
|
|
}
|
|
|
|
// RateLimiter is an in-memory, thread-safe sliding-window rate limiter with
|
|
// optional IP lockout support. When a LockoutStore is provided, lockout
|
|
// entries are persisted so they survive server restarts.
|
|
//
|
|
// NOTE (L2): The sliding-window counters and the PartialAuthStore /
|
|
// UsedTOTPCodeStore (in totp.go) are process-local. The server must run
|
|
// as a single instance. Horizontal scaling requires migrating these
|
|
// stores to a shared backend (e.g. Redis).
|
|
type RateLimiter struct {
|
|
mu syncutil.Mutex
|
|
windows map[string]*entry
|
|
lockouts map[string]*lockoutEntry
|
|
store LockoutPersister // nil = pure in-memory (tests, non-login limiters)
|
|
}
|
|
|
|
// NewRateLimiter returns an initialised RateLimiter with no persistence.
|
|
func NewRateLimiter() *RateLimiter {
|
|
return &RateLimiter{
|
|
windows: make(map[string]*entry),
|
|
lockouts: make(map[string]*lockoutEntry),
|
|
}
|
|
}
|
|
|
|
// NewPersistentRateLimiter returns a RateLimiter that persists lockouts via
|
|
// the provided store. It loads any active lockouts from the store on creation.
|
|
func NewPersistentRateLimiter(store LockoutPersister) *RateLimiter {
|
|
rl := &RateLimiter{
|
|
windows: make(map[string]*entry),
|
|
lockouts: make(map[string]*lockoutEntry),
|
|
store: store,
|
|
}
|
|
// Load surviving lockouts from the store.
|
|
if keys, expiresAt, err := store.LoadActiveLockouts(); err == nil {
|
|
for i, key := range keys {
|
|
rl.lockouts[key] = &lockoutEntry{expiresAt: expiresAt[i]}
|
|
}
|
|
}
|
|
return rl
|
|
}
|
|
|
|
// Allow reports whether a request from key is permitted given the limit and
|
|
// window. It records the current request timestamp only when the request is
|
|
// permitted. Returns false when key is locked out or has exceeded limit within
|
|
// window.
|
|
func (r *RateLimiter) Allow(key string, limit int, window time.Duration) bool {
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
|
|
// Lockout takes priority.
|
|
if lo, ok := r.lockouts[key]; ok {
|
|
if time.Now().Before(lo.expiresAt) {
|
|
return false
|
|
}
|
|
delete(r.lockouts, key)
|
|
}
|
|
|
|
now := time.Now()
|
|
cutoff := now.Add(-window)
|
|
|
|
e, ok := r.windows[key]
|
|
if !ok {
|
|
e = &entry{}
|
|
r.windows[key] = e
|
|
}
|
|
|
|
// Prune timestamps outside the current window.
|
|
valid := e.timestamps[:0]
|
|
for _, ts := range e.timestamps {
|
|
if ts.After(cutoff) {
|
|
valid = append(valid, ts)
|
|
}
|
|
}
|
|
e.timestamps = valid
|
|
|
|
if len(e.timestamps) >= limit {
|
|
return false
|
|
}
|
|
|
|
e.timestamps = append(e.timestamps, now)
|
|
return true
|
|
}
|
|
|
|
// Lockout prevents any requests from key for duration regardless of the
|
|
// sliding-window counter. When a LockoutStore is configured, the lockout
|
|
// is persisted so it survives server restarts.
|
|
func (r *RateLimiter) Lockout(key string, duration time.Duration) {
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
expiresAt := time.Now().Add(duration)
|
|
r.lockouts[key] = &lockoutEntry{expiresAt: expiresAt}
|
|
if r.store != nil {
|
|
_ = r.store.UpsertLockout(key, expiresAt)
|
|
}
|
|
}
|
|
|
|
// IsLockedOut reports whether key is currently under a lockout.
|
|
func (r *RateLimiter) IsLockedOut(key string) bool {
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
lo, ok := r.lockouts[key]
|
|
if !ok {
|
|
return false
|
|
}
|
|
if time.Now().Before(lo.expiresAt) {
|
|
return true
|
|
}
|
|
delete(r.lockouts, key)
|
|
return false
|
|
}
|
|
|
|
// Check reports whether a request from key would be permitted given the limit
|
|
// and window, WITHOUT recording a new timestamp. Use this for read-only
|
|
// rate-limit checks where the caller wants to record (via Allow) only on
|
|
// specific outcomes such as verification failures.
|
|
func (r *RateLimiter) Check(key string, limit int, window time.Duration) bool {
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
|
|
if lo, ok := r.lockouts[key]; ok {
|
|
if time.Now().Before(lo.expiresAt) {
|
|
return false
|
|
}
|
|
delete(r.lockouts, key)
|
|
}
|
|
|
|
cutoff := time.Now().Add(-window)
|
|
|
|
e, ok := r.windows[key]
|
|
if !ok {
|
|
return true
|
|
}
|
|
|
|
count := 0
|
|
for _, ts := range e.timestamps {
|
|
if ts.After(cutoff) {
|
|
count++
|
|
}
|
|
}
|
|
|
|
return count < limit
|
|
}
|
|
|
|
// Reset clears all rate-limit state (timestamps and lockout) for key.
|
|
func (r *RateLimiter) Reset(key string) {
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
delete(r.windows, key)
|
|
delete(r.lockouts, key)
|
|
if r.store != nil {
|
|
_ = r.store.DeleteLockout(key)
|
|
}
|
|
}
|
|
|
|
// Cleanup evicts stale map entries to prevent unbounded memory growth.
|
|
//
|
|
// A windows entry is removed when every recorded timestamp is older than
|
|
// maxWindow — meaning the entry could not affect any future Allow call that
|
|
// uses a window equal to or shorter than maxWindow.
|
|
//
|
|
// A lockouts entry is removed when its expiry has passed.
|
|
//
|
|
// Pass defaultCleanupMaxWindow (15 minutes) for normal server operation, or
|
|
// a shorter duration in tests.
|
|
func (r *RateLimiter) Cleanup(maxWindow time.Duration) {
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
|
|
cutoff := time.Now().Add(-maxWindow)
|
|
|
|
for key, e := range r.windows {
|
|
allStale := true
|
|
for _, ts := range e.timestamps {
|
|
if ts.After(cutoff) {
|
|
allStale = false
|
|
break
|
|
}
|
|
}
|
|
if allStale {
|
|
delete(r.windows, key)
|
|
}
|
|
}
|
|
|
|
now := time.Now()
|
|
for key, lo := range r.lockouts {
|
|
if now.After(lo.expiresAt) {
|
|
delete(r.lockouts, key)
|
|
}
|
|
}
|
|
|
|
if r.store != nil {
|
|
_ = r.store.CleanupExpiredLockouts()
|
|
}
|
|
}
|
|
|
|
// StartCleanup runs Cleanup on a ticker with the given interval until the
|
|
// stop channel is closed. It is intended to be called in a goroutine:
|
|
//
|
|
// stop := make(chan struct{})
|
|
// go rl.StartCleanup(5*time.Minute, 15*time.Minute, stop)
|
|
//
|
|
// Closing stop causes the goroutine to exit promptly.
|
|
func (r *RateLimiter) StartCleanup(interval, maxWindow time.Duration, stop <-chan struct{}) {
|
|
ticker := time.NewTicker(interval)
|
|
defer ticker.Stop()
|
|
|
|
for {
|
|
select {
|
|
case <-ticker.C:
|
|
r.Cleanup(maxWindow)
|
|
case <-stop:
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
// Len returns the number of entries currently stored in the windows and
|
|
// lockouts maps. It is primarily useful for testing and monitoring.
|
|
func (r *RateLimiter) Len() (windows, lockouts int) {
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
return len(r.windows), len(r.lockouts)
|
|
}
|