mirror of
https://github.com/J3vb/OwnCord.git
synced 2026-09-03 03:50:00 +03:00
Audit writes stay best-effort — a LogAudit failure must never fail or abort the request — but a failed write must no longer be silently discarded. Add db.WriteAudit(auditor, actor, action, targetType, targetID, detail), which logs a failed write with actor/action/target context (never the detail string, which may be sensitive) and never propagates the error. The Auditor interface is satisfied structurally by both *db.DB and the service-layer Store, so api/admin/ws/service all reach the helper without an import cycle. Converts all ~26 call sites from `_ = LogAudit(...)` (and the two backup handlers' inline `if err` blocks) to db.WriteAudit. Pinned by db/audit_test.go: failure logged and not propagated, success logs nothing, detail never leaks. Resolves the repo-wide LogAudit policy question flagged by the D8 note. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
178 lines
5.9 KiB
Go
178 lines
5.9 KiB
Go
package admin
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"log/slog"
|
|
"net"
|
|
"net/http"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/microcosm-cc/bluemonday"
|
|
"github.com/owncord/server/auth"
|
|
"github.com/owncord/server/db"
|
|
)
|
|
|
|
// setupSanitizer strips all HTML from user input during setup.
|
|
var setupSanitizer = bluemonday.StrictPolicy()
|
|
|
|
// ownerRoleID is the role ID assigned to the first user (Owner).
|
|
const ownerRoleID = 1
|
|
|
|
// setupStatusResponse is the JSON shape returned by GET /api/setup/status.
|
|
type setupStatusResponse struct {
|
|
NeedsSetup bool `json:"needs_setup"`
|
|
}
|
|
|
|
// setupRequest is the JSON body for POST /api/setup.
|
|
type setupRequest struct {
|
|
Username string `json:"username"`
|
|
Password string `json:"password"`
|
|
}
|
|
|
|
// setupResponse is the JSON shape returned on successful setup.
|
|
type setupResponse struct {
|
|
Token string `json:"token"`
|
|
UserID int64 `json:"user_id"`
|
|
Username string `json:"username"`
|
|
InviteCode string `json:"invite_code"`
|
|
}
|
|
|
|
// handleSetupStatus returns whether initial setup is needed (no users exist).
|
|
func handleSetupStatus(database *db.DB) http.HandlerFunc {
|
|
return func(w http.ResponseWriter, r *http.Request) {
|
|
count, err := database.UserCount()
|
|
if err != nil {
|
|
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to check user count")
|
|
return
|
|
}
|
|
writeJSON(w, http.StatusOK, setupStatusResponse{NeedsSetup: count == 0})
|
|
}
|
|
}
|
|
|
|
// handleSetup creates the first owner account. It only works when no users
|
|
// exist in the database, preventing abuse after initial setup.
|
|
func handleSetup(database *db.DB, limiter *auth.RateLimiter, allowedOrigins []string) http.HandlerFunc {
|
|
return func(w http.ResponseWriter, r *http.Request) {
|
|
// CSRF protection: reject cross-origin requests (BUG-097).
|
|
// If Origin is present and doesn't match allowed origins, deny.
|
|
// No Origin header = same-origin or non-browser client (allow).
|
|
if origin := r.Header.Get("Origin"); origin != "" {
|
|
if !isSetupOriginAllowed(origin, allowedOrigins) {
|
|
writeErr(w, http.StatusForbidden, "FORBIDDEN", "cross-origin setup request blocked")
|
|
return
|
|
}
|
|
}
|
|
|
|
// Rate limit: 5 attempts per minute per IP.
|
|
// Strip the port so that different source ports from the same IP
|
|
// are correctly grouped under a single rate-limit bucket.
|
|
host, _, err := net.SplitHostPort(r.RemoteAddr)
|
|
if err != nil {
|
|
host = r.RemoteAddr
|
|
}
|
|
setupKey := "setup:" + host
|
|
if !limiter.Allow(setupKey, 5, time.Minute) {
|
|
writeErr(w, http.StatusTooManyRequests, "RATE_LIMITED", "too many setup attempts, try again later")
|
|
return
|
|
}
|
|
|
|
var req setupRequest
|
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
|
writeErr(w, http.StatusBadRequest, "BAD_REQUEST", "invalid request body")
|
|
return
|
|
}
|
|
|
|
req.Username = strings.TrimSpace(setupSanitizer.Sanitize(req.Username))
|
|
if req.Username == "" || req.Password == "" {
|
|
writeErr(w, http.StatusBadRequest, "BAD_REQUEST", "username and password are required")
|
|
return
|
|
}
|
|
|
|
// Validate username format (length, no control/invisible chars).
|
|
if err := auth.ValidateUsername(req.Username); err != nil {
|
|
writeErr(w, http.StatusBadRequest, "BAD_REQUEST", err.Error())
|
|
return
|
|
}
|
|
|
|
if err := auth.ValidatePasswordStrength(req.Password); err != nil {
|
|
writeErr(w, http.StatusBadRequest, "BAD_REQUEST", err.Error())
|
|
return
|
|
}
|
|
|
|
// Hash the password.
|
|
hash, err := auth.HashPassword(req.Password)
|
|
if err != nil {
|
|
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to hash password")
|
|
return
|
|
}
|
|
|
|
// Atomically check no users exist and create the owner (BUG-119).
|
|
// This closes the TOCTOU race between UserCount() and CreateUser().
|
|
uid, err := database.CreateOwnerIfEmpty(req.Username, hash, ownerRoleID)
|
|
if errors.Is(err, db.ErrConflict) {
|
|
writeErr(w, http.StatusForbidden, "FORBIDDEN", "setup has already been completed")
|
|
return
|
|
}
|
|
if err != nil {
|
|
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to create user")
|
|
return
|
|
}
|
|
|
|
// Issue a session token so the user is immediately logged in.
|
|
token, err := auth.GenerateToken()
|
|
if err != nil {
|
|
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to generate session token")
|
|
return
|
|
}
|
|
|
|
device := r.Header.Get("User-Agent")
|
|
const maxDeviceLen = 512
|
|
if len(device) > maxDeviceLen {
|
|
device = device[:maxDeviceLen]
|
|
}
|
|
if _, err := database.CreateSession(uid, auth.HashToken(token), device, host); err != nil {
|
|
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to create session")
|
|
return
|
|
}
|
|
|
|
// Create default channels under canonical categories.
|
|
_, _ = database.CreateChannel("general", "text", "Text Channels", "Welcome to the server!", 0)
|
|
_, _ = database.CreateChannel("General", "voice", "Voice Channels", "", 0)
|
|
|
|
// Generate a bootstrap invite code so the owner can invite others.
|
|
// Bound it (5 uses / 24h) rather than minting an unlimited, non-expiring
|
|
// invite — the owner can create fresh invites once logged in.
|
|
bootstrapInviteExpiry := time.Now().Add(24 * time.Hour)
|
|
inviteCode, err := database.CreateInvite(uid, 5, &bootstrapInviteExpiry)
|
|
if err != nil {
|
|
writeErr(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to generate invite code")
|
|
return
|
|
}
|
|
|
|
slog.Info("server setup completed", "owner", req.Username, "user_id", uid)
|
|
db.WriteAudit(database, uid, "server_setup", "server", 0,
|
|
"initial setup: owner account created, default channel and invite generated")
|
|
|
|
writeJSON(w, http.StatusCreated, setupResponse{
|
|
Token: token,
|
|
UserID: uid,
|
|
Username: req.Username,
|
|
InviteCode: inviteCode,
|
|
})
|
|
}
|
|
}
|
|
|
|
// isSetupOriginAllowed checks if the given origin is permitted by the
|
|
// configured allowed_origins list. Wildcard "*" allows any origin.
|
|
// An empty list denies all cross-origin requests (safe default).
|
|
func isSetupOriginAllowed(origin string, allowed []string) bool {
|
|
for _, a := range allowed {
|
|
if a == "*" || strings.EqualFold(a, origin) {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|