Stirling-Tools/Stirling-PDF
1
0
Fork 0
mirror of https://github.com/Stirling-Tools/Stirling-PDF.git synced 2026-09-03 05:10:16 +03:00
Code Issues Packages Projects Releases Wiki Activity

Remove '&& false' guards from build workflow

Browse Source 
Remove leftover '&& false' sentinels from .github/workflows/build.yml so jobs are gated directly by needs.files-changed outputs. This re-enables conditional execution for build, project, openapi, frontend-validation, frontend-a11y, playwright-e2e, playwright-e2e-live, playwright-e2e-enterprise, check-licence, docker-compose-tests, ai-engine and generated-models, and unwraps a combined-condition that previously contained a final && false. Effect: CI jobs will run when their corresponding files-changed outputs are true instead of being force-skipped.
This commit is contained in:
Ludy87
2026-08-25 08:59:04 +02:00
parent bd38117279
commit 6ee59f1288
1 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/build.yml
+13 -13
View File
@@ -68,7 +68,7 @@ jobs:
secrets: inherit
build:
if: needs.files-changed.outputs.backend == 'true' && false
if: needs.files-changed.outputs.backend == 'true'
needs: [files-changed, gradle-cache-prime]
permissions:
actions: read
@@ -83,7 +83,7 @@ jobs:
# releases (v2.0.0 / v2.5.0 / v2.10.0) and verifies admin login still
# works after Hibernate's ddl-auto=update migrates the schema. Gated on
# the `project` filter so doc-only PRs skip this ~5-minute job.
if: needs.files-changed.outputs.project == 'true' && false
if: needs.files-changed.outputs.project == 'true'
needs: [files-changed, gradle-cache-prime]
permissions:
contents: read
@@ -91,7 +91,7 @@ jobs:
secrets: inherit
check-generateOpenApiDocs:
if: needs.files-changed.outputs.openapi == 'true' && false
if: needs.files-changed.outputs.openapi == 'true'
needs: [files-changed, gradle-cache-prime]
permissions:
contents: read
@@ -99,7 +99,7 @@ jobs:
secrets: inherit
frontend-validation:
if: needs.files-changed.outputs.frontend == 'true' && false
if: needs.files-changed.outputs.frontend == 'true'
needs: [files-changed]
permissions:
contents: read
@@ -112,7 +112,7 @@ jobs:
# whole-suite sweep (nightly.yml) still covers stories a change affects without
# touching them directly.
frontend-a11y:
if: needs.files-changed.outputs.frontend == 'true' && false
if: needs.files-changed.outputs.frontend == 'true'
needs: [files-changed]
permissions:
contents: read
@@ -120,7 +120,7 @@ jobs:
secrets: inherit
playwright-e2e:
if: needs.files-changed.outputs.frontend == 'true' && false
if: needs.files-changed.outputs.frontend == 'true'
needs: [files-changed]
permissions:
contents: read
@@ -128,7 +128,7 @@ jobs:
secrets: inherit
playwright-e2e-live:
if: needs.files-changed.outputs.frontend == 'true' && false
if: needs.files-changed.outputs.frontend == 'true'
needs: [files-changed, gradle-cache-prime]
permissions:
contents: read
@@ -136,7 +136,7 @@ jobs:
secrets: inherit
playwright-e2e-enterprise:
if: needs.files-changed.outputs.proprietary == 'true' && false
if: needs.files-changed.outputs.proprietary == 'true'
needs: [files-changed, gradle-cache-prime]
permissions:
contents: read
@@ -146,7 +146,7 @@ jobs:
use_shared_cache: true
check-licence:
if: needs.files-changed.outputs.build == 'true' && false
if: needs.files-changed.outputs.build == 'true'
needs: [files-changed, gradle-cache-prime]
permissions:
contents: read
@@ -154,7 +154,7 @@ jobs:
secrets: inherit
docker-compose-tests:
if: needs.files-changed.outputs.project == 'true' && false
if: needs.files-changed.outputs.project == 'true'
needs: [files-changed, gradle-cache-prime]
permissions:
actions: write
@@ -173,7 +173,7 @@ jobs:
contains(fromJSON('["success", "skipped"]'), needs.gradle-cache-prime.result) &&
contains(fromJSON('["success", "skipped"]'), needs.build.result) &&
contains(fromJSON('["success", "skipped"]'), needs.check-generateOpenApiDocs.result) &&
contains(fromJSON('["success", "skipped"]'), needs.check-licence.result) && false
contains(fromJSON('["success", "skipped"]'), needs.check-licence.result)
needs:
[
files-changed,
@@ -210,7 +210,7 @@ jobs:
use_shared_cache: true
ai-engine:
if: needs.files-changed.outputs.engine == 'true' && false
if: needs.files-changed.outputs.engine == 'true'
needs: [files-changed]
permissions:
contents: read
@@ -224,7 +224,7 @@ jobs:
# generators, generated files, generation tasks) rather than the broad
# frontend filter, so a CSS-only PR does not pay for a backend build.
generated-models:
if: needs.files-changed.outputs.generated-models == 'true' && false
if: needs.files-changed.outputs.generated-models == 'true'
needs: [files-changed, gradle-cache-prime]
permissions:
contents: read