mirror of
https://github.com/Stirling-Tools/Stirling-PDF.git
synced 2026-09-03 05:10:16 +03:00
# Description of Changes This PR modernizes the project's Python tooling across GitHub Actions by migrating CI workflows from pip-based dependency management to `uv` and aligning Python execution with the engine project's managed environment. ### What was changed - Replaced `actions/setup-python` and ad-hoc `pip install` steps with `astral-sh/setup-uv` across CI workflows. - Configured shared `uv` dependency caching using `engine/pyproject.toml` and `engine/uv.lock`. - Updated Python script execution to use `uv run --project engine --locked` for a consistent runtime environment. - Replaced package installation steps with `uv sync` for the required dependency groups (e.g. `tools` and `cucumber`). - Added Docker image build validation for both production and development AI engine images. - Updated workflow cache configuration and Docker build context where required. - Removed obsolete Python requirements files that are no longer needed after the migration. - Applied minor Python code modernizations, including import cleanup, modern built-in generic type annotations (`list[...]`, `tuple[...]`, `float | None`), and small style improvements. - Removed unnecessary Python formatter/linter extensions from the development container configuration. ### Why the change was made - Standardize Python dependency management across the repository. - Reduce duplicated dependency installation logic in CI. - Improve workflow performance through shared dependency caching. - Ensure all Python utilities execute against the same locked dependency set managed by the engine project. - Simplify long-term maintenance by eliminating legacy requirements files and pip-specific workflow steps. --- ## Checklist ### General - [ ] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [ ] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [ ] I have performed a self-review of my own code - [ ] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### Translations (if applicable) - [ ] I ran [`scripts/counter_translation.py`](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/docs/counter_translation.md) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have run `task check` to verify linters, typechecks, and tests pass - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#7-testing) for more details. --------- Signed-off-by: Carsten Drewes <c.drewes@stud.uni-hannover.de> Co-authored-by: albanobattistella <34811668+albanobattistella@users.noreply.github.com> Co-authored-by: kastenherri <116314318+kastenherri@users.noreply.github.com> Co-authored-by: Anthony Stirling <77850077+Frooodle@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: James Brunton <jbrunton96@gmail.com>
83 lines
3.0 KiB
Python
83 lines
3.0 KiB
Python
#!/usr/bin/env python3
|
|
"""Verify Tauri updater .sig files against plugins.updater.pubkey in tauri.conf.json.
|
|
|
|
Usage: verify-updater-signatures.py <dir-to-scan> [tauri.conf.json]
|
|
"""
|
|
|
|
import base64
|
|
import binascii
|
|
import hashlib
|
|
import json
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
from cryptography.exceptions import InvalidSignature
|
|
from cryptography.hazmat.primitives.asymmetric.ed25519 import Ed25519PublicKey
|
|
|
|
ART_ROOT = Path(sys.argv[1])
|
|
CONF = Path(sys.argv[2] if len(sys.argv) > 2 else "frontend/editor/src-tauri/tauri.conf.json")
|
|
|
|
|
|
def load_pubkey():
|
|
# tauri pubkey = base64 of a minisign .pub file; last line is base64 of
|
|
# [2 algo][8 key-id][32 ed25519 public key].
|
|
raw = json.loads(CONF.read_text())["plugins"]["updater"]["pubkey"]
|
|
blob = base64.b64decode(base64.b64decode(raw).decode().splitlines()[-1])
|
|
return blob[2:10], Ed25519PublicKey.from_public_bytes(blob[10:])
|
|
|
|
|
|
def hash_file(path: Path) -> bytes:
|
|
h = hashlib.blake2b(digest_size=64)
|
|
with path.open("rb") as f:
|
|
for chunk in iter(lambda: f.read(1 << 16), b""):
|
|
h.update(chunk)
|
|
return h.digest()
|
|
|
|
|
|
def verify(artifact: Path, sig_file: Path, keyid_pub, pub) -> str:
|
|
# tauri .sig = base64 of a minisign signature file (4 lines).
|
|
try:
|
|
lines = base64.b64decode(sig_file.read_text()).decode().splitlines()
|
|
sig_blob = base64.b64decode(lines[1])
|
|
except (binascii.Error, IndexError, UnicodeDecodeError) as e:
|
|
return f"FAIL malformed sig ({type(e).__name__})"
|
|
algo, keyid, sig = sig_blob[:2], sig_blob[2:10], sig_blob[10:74]
|
|
if keyid != keyid_pub:
|
|
return f"FAIL key-id mismatch (sig {keyid.hex()} vs pub {keyid_pub.hex()})"
|
|
# 'ED' = prehashed (BLAKE2b-512), 'Ed' = legacy (raw message).
|
|
msg = hash_file(artifact) if algo == b"ED" else artifact.read_bytes()
|
|
try:
|
|
pub.verify(sig, msg)
|
|
except InvalidSignature:
|
|
return f"FAIL signature invalid (algo={algo.decode()})"
|
|
# Global signature covers sig + trusted_comment.
|
|
gc = "global-sig FAIL"
|
|
try:
|
|
tc = lines[2].split("trusted comment: ", 1)[1]
|
|
pub.verify(base64.b64decode(lines[3]), sig + tc.encode())
|
|
gc = "global-sig OK"
|
|
except (InvalidSignature, IndexError, binascii.Error):
|
|
pass
|
|
return f"VALID (algo={algo.decode()}, keyid={keyid.hex()}, {gc})"
|
|
|
|
|
|
keyid_pub, pub = load_pubkey()
|
|
print(f"updater pubkey keyid={keyid_pub.hex()}\n")
|
|
sigs = sorted(ART_ROOT.rglob("*.sig"))
|
|
if not sigs:
|
|
print(f"WARN: no .sig files under {ART_ROOT} - nothing to verify")
|
|
sys.exit(0)
|
|
bad = 0
|
|
for sig_file in sigs:
|
|
artifact = sig_file.with_suffix("")
|
|
if not artifact.exists():
|
|
print(f" ? {sig_file.name}: artifact missing")
|
|
bad += 1
|
|
continue
|
|
res = verify(artifact, sig_file, keyid_pub, pub)
|
|
print(f" {artifact.name}: {res}")
|
|
if not res.startswith("VALID") or "global-sig FAIL" in res:
|
|
bad += 1
|
|
print(f"\n{'ALL SIGNATURES VALID' if bad == 0 else f'{bad} SIGNATURE(S) FAILED'}")
|
|
sys.exit(1 if bad else 0)
|