fluxerapp/fluxer
1
0
Fork 0
mirror of https://github.com/fluxerapp/fluxer.git synced 2026-09-02 21:04:06 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(common): stop advertising static assets as immutable (#1836)

Browse Source
This commit is contained in:
Hampus
2026-08-24 12:28:10 +02:00
committed by GitHub
parent 8cfac127f5
commit 208632e648
4 changed files with 31 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fluxer_static/Caddyfile
+4 -2
View File
@@ -24,8 +24,10 @@
-Server
}
@hashed path /assets/*
header @hashed Cache-Control "public, max-age=31536000, immutable"
header @health {
defer
Cache-Control "no-store"
}
file_server
}
packages/hono/src/middleware/CacheHeaders.ts
+1 -1
View File
@@ -22,7 +22,7 @@ export interface CacheHeadersOptions {
}
export function cacheHeaders(options: CacheHeadersOptions = {}): MiddlewareHandler {
const {staticCacheControl = 'public, max-age=31536000, immutable', defaultCacheControl = 'no-cache'} = options;
const {staticCacheControl = 'public, max-age=31536000', defaultCacheControl = 'no-cache'} = options;
return async (c, next) => {
await next();
const existingCacheControl = c.res.headers.get('Cache-Control');
packages/hono/src/middleware/tests/CacheHeaders.test.ts
+18 -18
View File
@@ -6,7 +6,7 @@ import {describe, expect, test} from 'vitest';
describe('CacheHeaders Middleware', () => {
describe('static content caching', () => {
test('sets immutable cache for CSS files', async () => {
test('sets long-lived cache for CSS files', async () => {
const app = new Hono();
app.use('*', cacheHeaders());
app.get('/styles.css', () => {
@@ -15,9 +15,9 @@ describe('CacheHeaders Middleware', () => {
});
});
const response = await app.request('/styles.css');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000, immutable');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000');
});
test('sets immutable cache for JavaScript files', async () => {
test('sets long-lived cache for JavaScript files', async () => {
const app = new Hono();
app.use('*', cacheHeaders());
app.get('/app.js', () => {
@@ -26,9 +26,9 @@ describe('CacheHeaders Middleware', () => {
});
});
const response = await app.request('/app.js');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000, immutable');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000');
});
test('sets immutable cache for images', async () => {
test('sets long-lived cache for images', async () => {
const app = new Hono();
app.use('*', cacheHeaders());
app.get('/logo.png', (c) => {
@@ -36,9 +36,9 @@ describe('CacheHeaders Middleware', () => {
return c.body(new Uint8Array([1, 2, 3]));
});
const response = await app.request('/logo.png');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000, immutable');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000');
});
test('sets immutable cache for fonts', async () => {
test('sets long-lived cache for fonts', async () => {
const app = new Hono();
app.use('*', cacheHeaders());
app.get('/font.woff2', (c) => {
@@ -46,9 +46,9 @@ describe('CacheHeaders Middleware', () => {
return c.body(new Uint8Array([1, 2, 3]));
});
const response = await app.request('/font.woff2');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000, immutable');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000');
});
test('sets immutable cache for application/font-woff2', async () => {
test('sets long-lived cache for application/font-woff2', async () => {
const app = new Hono();
app.use('*', cacheHeaders());
app.get('/font.woff2', (c) => {
@@ -56,9 +56,9 @@ describe('CacheHeaders Middleware', () => {
return c.body(new Uint8Array([1, 2, 3]));
});
const response = await app.request('/font.woff2');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000, immutable');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000');
});
test('sets immutable cache for video files', async () => {
test('sets long-lived cache for video files', async () => {
const app = new Hono();
app.use('*', cacheHeaders());
app.get('/video.mp4', (c) => {
@@ -66,9 +66,9 @@ describe('CacheHeaders Middleware', () => {
return c.body(new Uint8Array([1, 2, 3]));
});
const response = await app.request('/video.mp4');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000, immutable');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000');
});
test('sets immutable cache for audio files', async () => {
test('sets long-lived cache for audio files', async () => {
const app = new Hono();
app.use('*', cacheHeaders());
app.get('/audio.mp3', (c) => {
@@ -76,7 +76,7 @@ describe('CacheHeaders Middleware', () => {
return c.body(new Uint8Array([1, 2, 3]));
});
const response = await app.request('/audio.mp3');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000, immutable');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000');
});
});
describe('default caching', () => {
@@ -183,7 +183,7 @@ describe('CacheHeaders Middleware', () => {
return c.body(new Uint8Array([1, 2, 3]));
});
const response = await app.request('/photo.jpg');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000, immutable');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000');
});
test('handles image/gif', async () => {
const app = new Hono();
@@ -193,7 +193,7 @@ describe('CacheHeaders Middleware', () => {
return c.body(new Uint8Array([1, 2, 3]));
});
const response = await app.request('/animation.gif');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000, immutable');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000');
});
test('handles image/svg+xml', async () => {
const app = new Hono();
@@ -204,7 +204,7 @@ describe('CacheHeaders Middleware', () => {
});
});
const response = await app.request('/icon.svg');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000, immutable');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000');
});
test('handles video/webm', async () => {
const app = new Hono();
@@ -214,7 +214,7 @@ describe('CacheHeaders Middleware', () => {
return c.body(new Uint8Array([1, 2, 3]));
});
const response = await app.request('/video.webm');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000, immutable');
expect(response.headers.get('Cache-Control')).toBe('public, max-age=31536000');
});
});
});
tools/ci/src/app_proxy.rs
+8
View File
@@ -515,6 +515,14 @@ mod tests {
assert!(plan[0].repair_existing_metadata);
}
#[test]
fn uploaded_assets_carry_the_same_policy_the_app_proxy_serves() {
assert_eq!(
IMMUTABLE_ASSET_CACHE_CONTROL,
"public, max-age=31536000, immutable"
);
}
#[test]
fn asset_upload_plan_rejects_manifest_entries_missing_on_disk() {
let temp = tempfile::tempdir().unwrap();