ci(pnpm): run a check for monorepo dependency cycles, switch to pnpm i

pnpm i is an alias to pnpm install, so the shorter version is desired

Signed-off-by: Fernando Fernández <ferferga@hotmail.com>

.devcontainer/devcontainer.json

@@ -23,7 +23,7 @@
   },
   "postCreateCommand": {
     "tauri-deps": "install_packages $(cat packaging/tauri/apt_packages)",
-    "pnpm": "corepack pnpm install --frozen-lockfile",
+    "pnpm": "corepack pnpm i --frozen-lockfile",
     "unshallow": "git fetch --unshallow || true"
   },
   "postAttachCommand": {

.github/workflows/__package.yml

@@ -75,7 +75,7 @@ jobs:
           cache-workspaces: ${{ env.WORKING_DIR }}
 
       - name: Install npm dependencies 📦
-        run: corepack pnpm install --frozen-lockfile
+        run: corepack pnpm i --frozen-lockfile
 
       - name: Install Linux dependencies 📦🐧
         if: ${{ matrix.platform == 'ubuntu' }}

.github/workflows/__quality_checks.yml

@@ -35,7 +35,9 @@ jobs:
           - lint
           - test
           - check:types
+          # Checks for dependency cycles in the bundle and in the monorepo setup
           - analyze:cycles
+          - 'pnpm i --lockfile-only --config.disallow-workspace-cycles=true'
 
     steps:
       - name: Checkout ⬇️
@@ -51,7 +53,7 @@ jobs:
           check-latest: true
 
       - name: Install dependencies 📦
-        run: corepack pnpm install --frozen-lockfile
+        run: corepack pnpm i --frozen-lockfile
 
       - name: Run ${{ matrix.command }} ⚙️
         run: corepack pnpm ${{ matrix.command }}

packages/configs/src/utils.ts

@@ -9,8 +9,8 @@ const monorepoRoot = workspaceManifest ? dirname(workspaceManifest) : process.cw
 
 /**
  * Gets the workspace packages directly from pnpm configuration
- * @param workspaceManifestPath 
- * @returns 
+ * @param workspaceManifestPath
+ * @returns
  */
 function getWorkspacePackagePatterns(workspaceManifestPath: string): string[] {
   const workspace = parse(readFileSync(workspaceManifestPath, 'utf8')) as { packages?: unknown };

packaging/deb/debian/rules

@@ -12,7 +12,7 @@ override_dh_clistrip:
 
 override_dh_auto_build:
 	cp -ra root/{package.json,pnpm-workspace.yaml,pnpm-lock.yaml,packages} $(CURDIR)/
-	corepack pnpm install --frozen-lockfile
+	corepack pnpm i --frozen-lockfile
 	cd packages/frontend && corepack pnpm build
 	mv $(CURDIR)/packages/frontend/dist $(CURDIR)/dist
 	rm -rf $(CURDIR)/packages $(CURDIR)/node_modules $(CURDIR)/package.json $(CURDIR)/pnpm-lock.yaml $(CURDIR)/pnpm-workspace.yaml

packaging/docker/Dockerfile

@@ -15,7 +15,7 @@ COPY packages /app/packages
 WORKDIR /app/packages/frontend
 
 # Build client
-RUN corepack pnpm install --frozen-lockfile && corepack pnpm build
+RUN corepack pnpm i --frozen-lockfile && corepack pnpm build
 
 # Deploy built distribution to nginx
 FROM ghcr.io/nginxinc/nginx-unprivileged:stable-alpine-slim