multi-scrobbler/multi-scrobbler
1
0
Fork 0
mirror of https://github.com/FoxxMD/multi-scrobbler.git synced 2026-09-02 21:03:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: Add full coverage for cached queue updating during client lifecycle

Browse Source
This commit is contained in:
FoxxMD
2025-09-11 19:14:01 +00:00
parent c1e1de2255
commit fd316a8e84
1 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/backend/scrobblers/AbstractScrobbleClient.ts
+18 -4
View File
@@ -804,12 +804,14 @@ ${closestMatch.breakdowns.join('\n')}`, {leaf: ['Dupe Check']});
this.logger.warn(new Error(`Could not scrobble ${buildTrackString(transformedScrobble)} from Source '${currQueuedPlay.source}' but error was not show stopping. Adding scrobble to Dead Letter Queue and will retry on next heartbeat.`, {cause: e}));
} else {
this.queuedScrobbles.unshift(currQueuedPlay);
this.updateQueuedScrobblesCache();
throw new Error('Error occurred while trying to scrobble', {cause: e});
}
}
} else if (!timeFrameValid) {
this.logger.debug(`Will not scrobble ${buildTrackString(currQueuedPlay.play)} from Source '${currQueuedPlay.source}' because it ${timeFrameValidLog}`);
}
this.updateQueuedScrobblesCache();
this.emitEvent('scrobbleDequeued', {queuedScrobble: currQueuedPlay})
}
await sleep(this.scrobbleSleep);
@@ -908,12 +910,12 @@ ${closestMatch.breakdowns.join('\n')}`, {leaf: ['Dupe Check']});
}
this.logger.info(`Removed scrobble ${buildTrackString(this.deadLetterScrobbles[index].play)} from queue`, {leaf: 'Dead Letter'});
this.deadLetterScrobbles.splice(index, 1);
this.cache.cacheScrobble.set(`${this.getMachineId()}-dead`, this.deadLetterScrobbles);
this.updateDeadLetterCache();
}
removeDeadLetterScrobbles = () => {
this.deadLetterScrobbles = [];
this.cache.cacheScrobble.set(`${this.getMachineId()}-dead`, []);
this.updateDeadLetterCache();
this.logger.info('Removed all scrobbles from queue', {leaf: 'Dead Letter'});
}
@@ -933,7 +935,7 @@ ${closestMatch.breakdowns.join('\n')}`, {leaf: ['Dupe Check']});
this.queuedScrobbles.push(queuedPlay);
}
this.queuedScrobbles.sort((a, b) => sortByOldestPlayDate(a.play, b.play));
this.cache.cacheScrobble.set(`${this.getMachineId()}-queue`, this.queuedScrobbles);
this.updateQueuedScrobblesCache();
}
protected addDeadLetterScrobble = (data: QueuedScrobble<PlayObject>, error: (Error | string) = 'Unspecified error') => {
@@ -947,7 +949,7 @@ ${closestMatch.breakdowns.join('\n')}`, {leaf: ['Dupe Check']});
this.deadLetterScrobbles.push(deadData);
this.deadLetterScrobbles.sort((a, b) => sortByOldestPlayDate(a.play, b.play));
this.emitEvent('deadLetter', {dead: deadData});
this.cache.cacheScrobble.set(`${this.getMachineId()}-dead`, this.deadLetterScrobbles);
this.updateDeadLetterCache();
}
queuePlayingNow = (data: PlayObject, source: SourceIdentifier) => {
@@ -1027,4 +1029,16 @@ ${closestMatch.breakdowns.join('\n')}`, {leaf: ['Dupe Check']});
from: 'client'
});
}
protected updateDeadLetterCache = () => {
this.cache.cacheScrobble.set(`${this.getMachineId()}-dead`, this.deadLetterScrobbles)
.then(() => isDebugMode() ? this.logger.debug('Updated dead letter cache') : null)
.catch((e) => this.logger.warn(new Error('Error while updating dead letter cache', {cause: e})));
}
protected updateQueuedScrobblesCache = () => {
this.cache.cacheScrobble.set(`${this.getMachineId()}-queue`, this.queuedScrobbles)
.then(() => isDebugMode() ? this.logger.debug('Updated queued scrobble cache') : null)
.catch((e) => this.logger.warn(new Error('Error while updating queued scrobble cache', {cause: e})));
}
}